[PATCH core-updates] gnu: mesa: Update to 21.1.4.

I can confirm this builds for me on different computers as well, and would be great to have updated in guix. This is a bigger version jump since the current version is more than 6 months old and upstream continues with frequent bug fix releases.

libepoxy doesn't build (patch paths?). On #guix there was discussion of fixing these problems, could an updated patch be sent here for testing?

??????? Original Message ???????

On Monday, July 5th, 2021 at 11:35 AM:

This was easy to solve: I switched where libepoxy was looking for EGL and GL libraries to use libglvnd rather than mesa, as well as adding libglvnd as an input. Also added libglvnd as an input into xorg-server.

Looking at other packages that depend on e.g. libepoxy/mesa/etc. seems like many will need libglvnd as an input now? Is that what we want to move to (I take it is optional, but perhaps a move in the right direction)?

In either case, I'd love to see this in core-updates so we can make fixes to dependent packages as needed, since there are many that depend on mesa, libepoxy, xorg-server, and so on.

??????? Original Message ???????

On Wednesday, July 7th, 2021 at 9:35 PM:

As a followup, looks like libglvnd is optional for building mesa, and without that change I think it is just a drop in version bump. I'm not sure about dependents generally, but libepoxy and xorg-server needed no changes.

So, shall we reduce this patch to just a Mesa update, and then libglvnd as a separate issue? I think that one would require changing/adding inputs to all GL packages, as they should link to libglvnd rather than any vendor's GL directly, if I understand correctly.

With just a version change I think this should be easily merged, can anyone else weigh in on that?

Hello,

Here is a patch for just the minimal Mesa version bump. I reverted option changes to match the previous version (and wasn't sure with there being a mesa-opencl package already).

All Mesa tests pass for me too (on x86_64), so mesa-skip-tests.patch is not applied, as per original patch here. src/compiler/glsl/tests/cache_test.c has moved to src/util/tests/cache and has changed. However, the test works for me (compiling on foreign distro). The i686 part of the patch can still be applied, but will need someone to test.

This is just the Mesa change, it relies on libdrm update in https://issues.guix.gnu.org/49412

I think other than the tests patch, should be good to go, can someone review and check the i686 patch so we can move ahead with this?

Thanks,

John

John Kehayias via Guix-patches via schreef op do 08-07-2021 om 01:35 [+0000]:

If with this update of mesa, (almost) every package using mesa also needs libglvnd,

then why not add 'libglvnd' to the propagated-inputs mesa, for about the same reasons

that 'atk' has 'glib' in 'propagated-inputs'?

Not sure if the comparison applies though.

Greetings,

Maxime

??????? Original Message ???????

On Thursday, July 8th, 2021 at 4:55 PM, Maxime Devos wrote:

Hi Maxime,

That sounds like a good idea, but I think there may be some kinks to work out. Adding libglvnd to propagated-inputs of Mesa does lead to the successful building of dependents (tested on libepoxy and virtualgl, for example). However, libepoxy fails on a test because it doesn't find libGL. That is no longer in Mesa's lib but from libglvnd if I'm understanding correctly. May just be a problem with the test since building works (which checks for GL).

Anyway, perhaps we want to tackle libglvnd separately? I don't think it is specific to the Mesa version change, but more of how we want to handle gl across packages. Still, it will involve changes to how we build Mesa as well as possibly other packages. I'm not sure that the Mesa version change will require other changes in dependent packages (I can only test a few on my own).

How do you think we should proceed?

John

John Kehayias schreef op vr 09-07-2021 om 02:41 [+0000]:

[...]

Warning: I've no idea how building mesa and libglvnd works,

how linking against mesa and libglvnd works, and how mesa and libglvnd

work, besides ‘you can use the GL_... functions to do GL stuff’.

That said, it appears some package definitions expect "libGL.so" to be in mesa.

(Search for "/lib/libGL" and "lib/libEGL" with 'git grep -F"').

I've found about twenty such occurences, including libepoxy.

So it appears that adding libglvnd to the propagated-inputs and fixing

these twenty package definitions should be doable.

Looking at libepoxy in particular:

(let ((python (assoc-ref inputs "python"))

(mesa (assoc-ref inputs "mesa")))

(substitute* "src/gen_dispatch.py"

(("/usr/bin/env python") python))

(substitute* (find-files "." "\\.[ch]$")

(("libGL.so.1") (string-append mesa "/lib/libGL.so.1"))

(("libEGL.so.1") (string-append mesa "/lib/libEGL.so.1")))

#t))))))

it seems like the test failure isn't a false positive, as libGL.so.1 is searched

for in the wrong location.

I'd suggest adding libglvnd to propagated-inputs

and adjusting the twenty package definitions to refer

to libglvnd, and testing some graphical applications.

"mesa-utils" has "glxdemo" and "glxheads" and has few dependencies,

maybe start with that?

Greetings,

Maxime.

??????? Original Message ???????

On Friday, July 9th, 2021 at 8:48 AM, Maxime Devos wrote:

No worries, I also know very little here (just learning about libglvnd), so I'm no expert. However, I think it will be a little more complicated because libglvnd is meant to dispatch to a vendor's GL libraries at runtime. Meaning it will need to know where these libraries exist, which may require some changes for Guix.

While I think getting builds and tests to pass is not so bad, I don't know that it will actually work the way it is supposed to (see above). I'm also a bit limited in what I can test directly. (For one thing, I'm on a foreign distro right now, which complicates GL testing. For example, Nix has https://github.com/guibou/nixGLfor the "OpenGL problem" which may be something we should look at for this as well.)

The more I think about it, the more I think we should tackle a change to Guix's GL system separately. The original patch enabled libglvnd in Mesa, but that has been around for a while and is not new to 21.1.x. I worry doing them at the same time would introduce two sources for anything breaking, though I hope the move to 21.1.x doesn't require any big changes elsewhere.

Personally, I'd like to see Mesa 21.1.x updated and make sure dependents are okay. We can then have a separate patch series that enables libglvnd in Mesa and adjusts all packages. We would need some people who can test that actually use different GL vendors to see that libglvnd does what it is supposed to. Perhaps Irfan can weigh in, since in their original patch they did have libglvnd and may have tested that it works.

Any experts on Mesa/libglvnd here to chime in? Is the minimal Mesa version update patch okay if we want to libglvnd separately?

Thanks,

John

I did test building some dependents of mesa with libglvnd.

libepoxy, in particular, needed the change that Maxime points out

will affect some 20 or so other packages as well. With that made,

I was able to build and boot into a functioning graphical

environment on xorg-server. I can work on patching all packages

that look for libgl.so/libegl.so from mesa to use libglvnd

instead, as Maxime suggested. But I agree with John that getting

an updated mesa, with or without libglvnd, into core-updates now

would be preferable than being delayed to the next freeze cycle.

If that is a concern, then maybe this patch can be pushed as is.

Cheers,

Irfan

Hi everyone,

Final update, we still need the mesa-skip-tests.patch, but only for the i686 part (second half). The other part of the patch is not needed as the test passes.

Here is the final version of the patch to just update Mesa to 21.1.4. Note this depends on the libdrm update of https://issues.guix.gnu.org/49412Mesa builds as well as descendants I've tried (like xorg and friends).

Shall we get this merged and set the libglvnd updates after (in case we run into the core-updates freeze)? That would work well for me at least.

Thanks everyone,

John

??????? Original Message ???????

On Tuesday, July 13th, 2021 at 11:42 AM, John Kehayias <john.kehayias@protonmail.com> wrote:

I forgot the copyright line, though I think this should be for Irfan. Here is mine, just in case:

Apologies, the full patch was missing before. It is attached as v2 with changes noted previously (would be great to give Irfan credit here as well). Still depends on libdrm being updated, see https://issues.guix.gnu.org/49412

Thanks!

John

Hi,

As a bit of bug-tracking reference, this patch supersedes the 20.3.4 update submitted back in Feb (that judging from the comments didn't land because of a core-updates freeze at the time): https://issues.guix.gnu.org/46672

There are also several older mesa update tickets that are still open but can probably be closed since the main branch has 20.2.4 built against LLVM 11:

* https://issues.guix.gnu.org/44558"Mesa isn't update to date"

* https://issues.guix.gnu.org/44584"[PATCH] Update mesa to 20.2.2"

* https://issues.guix.gnu.org/44585"[PATCH] Update mesa to use LLVM 11"

* https://issues.guix.gnu.org/44586"[PATCH] Mesa updated to 20.2.2 (staging)"

Cheers,

Kaelyn

Noticed that Mesa has had a few quick bug fix releases, here is v3 of the patch now to update Mesa to 21.1.6. I've tested that it builds, and since these are bug fix releases there should be no major changes.

Thanks!

John

Hi John,

John Kehayias <john.kehayias@protonmail.com> skribis:

Applied, thanks!

[...]

Is this expected to change anything feature-wise?

BTW, please generate the patch with ‘git format-patch’ next time; that

makes it easier to apply with ‘git am’.

Ludo’.

Hi Ludo’,

On Saturday, July 31st, 2021 at 6:33 AM, Ludovic Courtès <ludo@gnu.org> wrote:

Great, thank you!

Mesa at v21 removed the software OSMesa driver (see https://www.phoronix.com/scan.php?page=news_item&px=Classic-OSMesa-Retires). We were already using the gallium driver so I think there is no change for us, but the compile flag changed to a boolean: true for what was before gallium, based on my reading of the change https://cgit.freedesktop.org/mesa/mesa/commit/?id=ee802372180a2b4460cc7abb53438e45c6b6f1e4

Will do, sorry about that (I think I did do that but may have manually altered the header).

By the way, I'm looking now and see mesa-opencl failing, I'll take a look (perhaps an option change or library location?).

John

Hi,

John Kehayias <john.kehayias@protonmail.com> skribis:

[...]

Makes sense, thanks for explaining!

Ludo’.