[PATCH 31/41] gnu: Add go-github-com-google-shlex.

(
(address . guix-patches@gnu.org)(name . (unmatched-parenthesis)(address . paren@disroot.org)
20220803120439.5108-31-paren@disroot.org
From: "(unmatched-parenthesis" <paren@disroot.org>

* gnu/packages/golang.scm (go-github-com-google-shlex): New variable.
---
gnu/packages/golang.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)

Toggle diff (33 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index fd2335b61a..9959dd118c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzysearch
"A speedy fuzzy matching package for Go inspired by the JavaScript
library bevacqua/fuzzysearch.")
(license license:expat)))
+
+(define-public go-github-com-google-shlex
+ (package
+ (name "go-github-com-google-shlex")
+ (version "0.0.0-20191202100458-e7afc7fbc510")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/google/shlex")
+ (commit (go-version->git-ref version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "14z8hqyik910wk2qwnzgz8mjsmiamxa0pj55ahbv0jx6j3dgvzfm"))))
+ (build-system go-build-system)
+ (arguments
+ (list #:import-path "github.com/google/shlex"))
+ (home-page "https://github.com/google/shlex")
+ (synopsis "Simple lexer for Go")
+ (description
+ "Shlex is a simple lexer for Go that supports shell-style quoting,
+commenting, and escaping.")
+ (license license:asl2.0)))
--
2.37.1
(
(address . control@debbugs.gnu.org)
CLWDYGGQDWDZ.EQ4EERCSNS2U@guix-aspire
merge 55903 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 56933 56936 56935 56932 56941 56938 56939 56937 56942 56940 56943 56944 56945 56946 56947 56948 56949
thanks

-- (
(
(address . control@debbugs.gnu.org)
CLWE95B9PDVA.ZLM2DBCU1L9V@guix-aspire
close 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 56933 56936 56935 56932 56941 56938 56939 56937 56942 56940 56943 56944 56945 56946 56947 56948 56949
thanks

-- (
(
(address . control@debbugs.gnu.org)
CLWEDCUIBCHE.GM9WA0YNQXVR@guix-aspire
unmerge 55903
thanks

-- (
(
(address . control@debbugs.gnu.org)
CLWEDQR118FS.2LE0145ASDQR9@guix-aspire
close 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 56933 56936 56935 56932 56941 56938 56939 56937 56942 56940 56943 56944 56945 56946 56947 56948 56949
thanks

-- (
M
M
Maxime Devos wrote on 3 Aug 2022 17:38
402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be
On 03-08-2022 14:04, ( via Guix-patches via wrote:
Toggle quote (6 lines)
> + (arguments
> + (list #:import-path "github.com/zenhack/go.notmuch"
> + ;; XXX: Tests require you to download fixtures from the Internet.
> + ;; See<https://github.com/zenhack/go.notmuch/blob/master/Makefile>.
> + #:tests? #f))
> + (propagated-inputs (list notmuch))
Can we just substitute* in the appropriate library reference or whatever
is the Go equivalent instead of propagating?  Maybe in in configList.go,
we can replace -lnotmuch by -l/gnu/store/.../libnotmuch.so or add a
-L/gnu/store/... there?
Toggle quote (20 lines)
> From: "(unmatched-parenthesis"<paren@disroot.org>
>
> * gnu/packages/golang.scm (go-github-com-google-shlex): New variable.
> ---
> gnu/packages/golang.scm | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index fd2335b61a..9959dd118c 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzysearch
> "A speedy fuzzy matching package for Go inspired by the JavaScript
> library bevacqua/fuzzysearch.")
> (license license:expat)))
> +
> +(define-public go-github-com-google-shlex
> + (package
> + (name "go-github-com-google-shlex")
> + (version "0.0.0-20191202100458-e7afc7fbc510")
Why has the commit and description been changed since
https://issues.guix.gnu.org/37444? The change in synopsis seems good
to me though.
Also, there are multiple patches adding go-github-com-google-shlex now
-- as I've asked in the past, can we stop doing that, or at least add a
pointer to the previous version to avoid double work for reviewers?
Likewise for:
* [...]
Like, if I would properly review (including checking the source code)
this patch series and didn't know some of those were reviewed
previously, then I would have to do the review again even though that's
double work better spent elsewhere and if I later discover these were
actually reviewed previously, that doesn't sound good for motivation to me.
And even though I know some of those have been submitted and reviewed
previously, I don't remember which ones exactly and to which degree
(only superficial checks like checking synopsis, description and
#:tests?, or also source code checks, ...), so if I were to review this
(*), I would have to look up the old patches and reviews, see which ones
were reviewed previously and to what degree, look if changes have been
made (e.g. changing which commit to use) that invalidated the review,
..., which is not motivating to me.
(*) To be clear, I consider it unlikely for me to seriously review Go
stuff in the future, as the Go world is full of forks that make no
attempt to contribute back to upstream, or many independent
implementations (see e.g. terminfo and shlex) where a single or maybe
two implementations would suffice, often there's a lack of attempting
backwards compatibility and version numbers are often just 0.0.0, ...
Greetings,
Maxime.
Attachment: file
Attachment: OpenPGP_signature
(
CLWM0UPGDRH5.DJ700HGB2F3G@guix-aspire
On Wed Aug 3, 2022 at 4:38 PM BST, Maxime Devos wrote:
Toggle quote (4 lines)
> Can we just substitute* in the appropriate library reference or whatever
> is the Go equivalent instead of propagating?  Maybe in in configList.go,
> we can replace -lnotmuch by -l/gnu/store/.../libnotmuch.so or add a
> -L/gnu/store/... there?
Good point! I'll try that.

Toggle quote (22 lines)
> > * gnu/packages/golang.scm (go-github-com-google-shlex): New variable.
> > ---
> > gnu/packages/golang.scm | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> > index fd2335b61a..9959dd118c 100644
> > --- a/gnu/packages/golang.scm
> > +++ b/gnu/packages/golang.scm
> > @@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzysearch
> > "A speedy fuzzy matching package for Go inspired by the JavaScript
> > library bevacqua/fuzzysearch.")
> > (license license:expat)))
> > +
> > +(define-public go-github-com-google-shlex
> > + (package
> > + (name "go-github-com-google-shlex")
> > + (version "0.0.0-20191202100458-e7afc7fbc510")
>
> Why has the commit and description been changed since
> <https://issues.guix.gnu.org/37444>? The change in synopsis seems good
> to me though.
I never referenced that issue in the making of this patchset :) I'll
change its description to that issue's version if you wish.

Toggle quote (10 lines)
> Also, there are multiple patches adding go-github-com-google-shlex now
> -- as I've asked in the past, can we stop doing that, or at least add a
> pointer to the previous version to avoid double work for reviewers?
> Likewise for:
>
> * https://issues.guix.gnu.org/search?query=go-google-golang-org-protobuf
> * https://issues.guix.gnu.org/search?query=go-github-com-xo-terminfo
> * https://issues.guix.gnu.org/search?query=go-github-com-go-ini-ini
> * https://issues.guix.gnu.org/search?query=go-github-com-emersion-go-pgpmail
> * [...]
Maybe we could merge the patches adding those duplicate packages
standalone, without merging the other parts of the patchsets, so there
would be no need for anyone to write them again in the future.

Toggle quote (6 lines)
> (*) To be clear, I consider it unlikely for me to seriously review Go
> stuff in the future, as the Go world is full of forks that make no
> attempt to contribute back to upstream, or many independent
> implementations (see e.g. terminfo and shlex) where a single or maybe
> two implementations would suffice, often there's a lack of attempting
> backwards compatibility and version numbers are often just 0.0.0, ...
I know what you mean. It's a huge pain.

-- (
?