[PATCH] adds `ack' package and it's perl module dependency File::Next

Done

Details

4 participants

Gabriel Wicki
Maxime Devos
Xinglu Chen
Ricardo Wurmus

Owner: unassigned

Submitted by: Gabriel Wicki

Severity: normal

Gabriel Wicki wrote on 24 May 2021 21:10

Recipients:(address . guix-patches@gnu.org)

Message-ID:20210524191054.7wtb4wopstgx2c77@silver

modified: gnu/packages/perl.scm

- adds package `perl-file-next' (module File::Next)

modified: gnu/packages/textutils.scm

- adds package `ack' with disabled tests

---

gnu/packages/perl.scm | 20 ++++++++++++++++++++

gnu/packages/textutils.scm | 26 ++++++++++++++++++++++++++

2 files changed, 46 insertions(+)

Toggle diff (74 lines)diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d35508112f..87d541783e 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4578,6 +4578,26 @@ that arise trying to find them consistently across a wide variety of
 platforms.")
     (license (package-license perl))))
 
+(define-public perl-file-next
+  (package
+   (name "perl-file-next")
+   (version "1.18")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/petdance/file-next")
+                  (commit version)))
+            (file-name "perl-next-file")
+            (sha256
+             (base32
+              "0zdrxk409qxkbbv4fl4wi285kfzyrpaja9wfl00vrxc078rs4afm"))))
+   (build-system perl-build-system)
+   (synopsis "File::Next is a lightweight, taint-safe file-finding Perl module")
+   (description "A Perl CPAN module for finding files.  It has no non-core
+prerequisites")
+   (home-page "https://metacpan.org/pod/File::Next")
+   (license license:artistic2.0)))
+
 (define-public perl-file-path
   (package
     (name "perl-file-path")
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index ab34373705..7dd7ee80e2 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -45,6 +45,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system go)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
   #:use-module (guix utils)
   #:use-module (gnu packages)
@@ -1304,3 +1305,28 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public ack
+  (package
+   (name "ack")
+   (version "3.5.0")
+   (source (origin
+            (method git-fetch)
+            (uri
+             (git-reference
+              (url "https://github.com/beyondgrep/ack3")
+              (commit (format #nil "v~a" version))))
+            (file-name "ack")
+            (sha256
+             (base32 "00131vqjbzcn6w22m0h3j6x9kp59dimfnnqhpmi78vbcj0jws1dv"))))
+   (build-system perl-build-system)
+   (arguments '(#:tests? #f))
+   (propagated-inputs `(("perl-file-next" ,perl-file-next)))
+   (synopsis "Code-searching tool optimized for programmers with large trees
+of source code")
+   (description "ack is a tool for finding text inside files. it is designed for
+hackers and programmers by being fast, ignoring VCS directories, letting a user
+easily specify file types, match highlighting, Perl-Compatible Regular
+Expressions, and being faster to type than `grep '")
+   (home-page "https://beyondgrep.com/")
+   (license license:artistic2.0)))
-- 
2.30.2

Maxime Devos wrote on 24 May 2021 23:01

Recipients:

Message-ID:b8dbcd484944232e2da0a9e9d9e32317ff487dbc.camel@telenet.be

Gabriel Wicki schreef op ma 24-05-2021 om 21:10 [+0200]:

Toggle quote (12 lines)> [...]
> +(define-public ack
> +  (package
> +   (name "ack")
> +   (version "3.5.0")
> +   (source (origin
> +            (method git-fetch)
> +            (uri
> +             (git-reference
> +              (url "https://github.com/beyondgrep/ack3")
> +              (commit (format #nil "v~a" version))))

#f is an elisp compatibility hack in Guile.

Use (format #f "v~a" version) instead, or simpler

(string-append "v" version).

Looking at the patch only and (I didn't test it, didn't do

licensing checks, etc.) I only see one other problem:

Toggle quote (2 lines)

> + (arguments '(#:tests? #f))

Why are the tests disabled? (Are there none, do they need

additional packages not in Guix, ...) Maybe add a line like

Toggle quote (3 lines)

> + ;; There is no test suite.

> + (arguments '(#:tests? #f))

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYKwUHxccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iWXAQDWOpjbcIknk/MN8PUtmO28a2Ab

mJoir5bh4D53h0eW9wD+NrdV2T56fCmuDKo3OskSi6CUxHokvlWeO+LkDyXoBg8=

=Lo63

-----END PGP SIGNATURE-----

Xinglu Chen wrote on 24 May 2021 23:26

Recipients:

Message-ID:87mtsj962p.fsf@yoctocell.xyz

On Mon, May 24 2021, Gabriel Wicki wrote:

Toggle quote (6 lines)

> modified: gnu/packages/perl.scm

> - adds package `perl-file-next' (module File::Next)

> modified: gnu/packages/textutils.scm

> - adds package `ack' with disabled tests

Commit messages should be written in ChangeLog format[1], you can look

at previous commits for examples.

This commit should also be split into two separate commits, one adding

‘perl-file-next’, and the other adding ‘ack’.

Toggle quote (11 lines)> +(define-public perl-file-next
> +  (package
> +   (name "perl-file-next")
> +   (version "1.18")
> +   (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                  (url "https://github.com/petdance/file-next")
> +                  (commit version)))
> +            (file-name "perl-next-file")

Use ‘(file-name (git-file-name name version))’.

Toggle quote (6 lines)

> + (sha256

> + (base32

> + "0zdrxk409qxkbbv4fl4wi285kfzyrpaja9wfl00vrxc078rs4afm"))))

> + (build-system perl-build-system)

> + (synopsis "File::Next is a lightweight, taint-safe file-finding Perl module")

Try to make the synopsis as concise as possible, just “Lightweight,

taint-safe file-finding Perl module” should do. See the ‘Synopses and

Descriptions’ section of the manual.

Toggle quote (3 lines)

> + (description "A Perl CPAN module for finding files. It has no non-core

> +prerequisites")

The description should contain one or more complete sentences.

Toggle quote (11 lines)> +(define-public ack
> +  (package
> +   (name "ack")
> +   (version "3.5.0")
> +   (source (origin
> +            (method git-fetch)
> +            (uri
> +             (git-reference
> +              (url "https://github.com/beyondgrep/ack3")
> +              (commit (format #nil "v~a" version))))

We usually use ‘(string-append "v" version)’ instead of ‘format’.

Toggle quote (2 lines)

> + (file-name "ack")

Use ‘(file-name (git-file-name name version))’ (same as above).

Toggle quote (5 lines)

> + (sha256

> + (base32 "00131vqjbzcn6w22m0h3j6x9kp59dimfnnqhpmi78vbcj0jws1dv"))))

> + (build-system perl-build-system)

> + (arguments '(#:tests? #f))

What’s the reason for disabling the tests?

Toggle quote (4 lines)

> + (propagated-inputs `(("perl-file-next" ,perl-file-next)))

> + (synopsis "Code-searching tool optimized for programmers with large trees

> +of source code")

> + (description "ack is a tool for finding text inside files. it is designed for

Please use double spacing, and capitalize.

Toggle quote (3 lines)

> +hackers and programmers by being fast, ignoring VCS directories, letting a user

> +easily specify file types, match highlighting, Perl-Compatible Regular

> +Expressions, and being faster to type than `grep '")

Unecessary whitespace, and missing period.

Could you send an updated series?

[1]: https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs

Gabriel Wicki wrote on 25 May 2021 21:12

Re: bug#48630: Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next)

Recipients:(address . 48630@debbugs.gnu.org)

Message-ID:20210525191259.23awunfcwdr6p3cg@silver

thanks for the advice, i'll update and split the patch into a small

series soon!

the tests are deactivated because 3 of 841 fail. they seem to check

some kind of shebang #! paths. see this excerpt from the build log:

# Failed test 'Util::sets_match( TEST_TYPE with -t perl )'

# at t/ack-type.t line 43.

# actual[

# 't/swamp/0:1:#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl -w',

...

# ]

# expected[

# 't/swamp/0:1:#!/usr/bin/perl -w',

...

# ]

these lines are being ignored by the patch-generated-file-shebangs

phase, maybe because the #! aren't at the beginning of the line?

i'm a total novice in Perl, so i'm not sure what exactly is happening

there or why this is even tested.

should i try and add my own version of a patch-shebang after the

patch-generated-file-shebangs phase?

Xinglu Chen wrote on 25 May 2021 23:34

Re: [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next)

Recipients:

Message-ID:875yz67b19.fsf@yoctocell.xyz

On Tue, May 25 2021, Gabriel Wicki wrote:

Toggle quote (3 lines)

> thanks for the advice, i'll update and split the patch into a small

> series soon!

Great! :)

Toggle quote (24 lines)> the tests are deactivated because 3 of 841 fail. they seem to check
> some kind of shebang #! paths. see this excerpt from the build log:
>
> #   Failed test 'Util::sets_match( TEST_TYPE with -t perl )'
> #   at t/ack-type.t line 43.
>
> 	# actual[
> 	#   't/swamp/0:1:#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl -w',
> ...
> 	# ]
> 	# expected[
> 	#   't/swamp/0:1:#!/usr/bin/perl -w',
> ...
> 	# ]
>
> these lines are being ignored by the patch-generated-file-shebangs
> phase, maybe because the #! aren't at the beginning of the line?
>
> i'm a total novice in Perl, so i'm not sure what exactly is happening
> there or why this is even tested.
>
> should i try and add my own version of a patch-shebang after the
> patch-generated-file-shebangs phase?

Yes, you could add add a phase after the ‘patch-generated-file-shebangs’
phase that replaces #!/usr/bin/perl with #!/gnu/store/...-perl/bin/perl.
Something like this should work (untested):

#+begin_src scheme
(add-after 'patch-generated-file-shebangs 'patch-more-shebangs
  (lambda (#:key inputs #:allow-other-keys)
    (substitute* '("t/ack-type.t" ...)
      (let ((perl (assoc-ref inputs "perl")))
        (("/usr/bin/perl")
         (string-append perl "/bin/perl"))))))
#+end_src

Gabriel Wicki wrote on 26 May 2021 00:03

[PATCH] adds `ack' package and it's perl module dependency File::Next

Recipients:(address . 48630@debbugs.gnu.org)

Message-ID:20210525220311.oicyl2ofgtdgvzrz@silver

From 65c6ef5af4ac8207b6d8905bdc381fc51075367b Mon Sep 17 00:00:00 2001
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Tue, 25 May 2021 23:52:59 +0200
Subject: [PATCH] add package perl-find-next

modified:   gnu/packages/perl.scm
 - add package definition `perl-file-next' for File::Next Perl module
---
 gnu/packages/perl.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Toggle diff (32 lines)diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d35508112f..4f36fc3e44 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4654,6 +4654,25 @@ provided base directory and can return files (and/or directories if desired)
 matching a regular expression.")
     (home-page "https://metacpan.org/release/File-List")))
 
+(define-public perl-file-next
+  (package
+   (name "perl-file-next")
+   (version "1.18")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/petdance/file-next")
+                  (commit version)))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32
+              "0zdrxk409qxkbbv4fl4wi285kfzyrpaja9wfl00vrxc078rs4afm"))))
+   (build-system perl-build-system)
+   (synopsis "Lightweight, taint-safe file-finding Perl module")
+   (description "File::Next is a Perl CPAN module for finding files.")
+   (home-page "https://metacpan.org/pod/File::Next")
+   (license license:artistic2.0)))
+
 (define-public perl-file-readbackwards
   (package
     (name "perl-file-readbackwards")
-- 
2.30.2

Gabriel Wicki wrote on 26 May 2021 00:13

Recipients:(address . 48630@debbugs.gnu.org)

Message-ID:20210525221326.tadqgibhes4bbyyl@silver

From 2c708fcb56bdb7549a9de7535a0aaf936a18e8a0 Mon Sep 17 00:00:00 2001
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Wed, 26 May 2021 00:08:09 +0200
Subject: [PATCH] add package ack to (gnu packages textutils)

modified:   gnu/packages/textutils.scm
 - add package ack
 - add (guix build-system perl) and (gnu packages perl) to imports
---
 gnu/packages/textutils.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

Toggle diff (63 lines)diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index ab34373705..1df5050f30 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -45,6 +45,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system go)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
   #:use-module (guix utils)
   #:use-module (gnu packages)
@@ -59,6 +60,7 @@
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages perl)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-xyz)
@@ -1304,3 +1306,40 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public ack
+  (package
+   (name "ack")
+   (version "3.5.0")
+   (source (origin
+            (method git-fetch)
+            (uri
+             (git-reference
+              (url "https://github.com/beyondgrep/ack3")
+              (commit (string-append "v" version))))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32 "00131vqjbzcn6w22m0h3j6x9kp59dimfnnqhpmi78vbcj0jws1dv"))))
+   (build-system perl-build-system)
+   (arguments '(#:tests? #t
+                #:phases (modify-phases
+                          %standard-phases
+                          (add-after 'patch-generated-file-shebangs 'patch-more-shebangs
+                                     (lambda* (#:key inputs #:allow-other-keys)
+                                       (let ((perl (string-append
+                                                    (assoc-ref inputs "perl")
+                                                    "/bin/perl")))
+                                         (substitute* "t/ack-type.t"
+                                                      (("/usr/bin/perl")
+                                                       perl)
+                                                      (("/usr/bin/env perl")
+                                                       perl))))))))
+   (propagated-inputs `(("perl-file-next" ,perl-file-next)))
+   (synopsis "Code-searching tool optimized for programmers with large trees
+of source code")
+   (description "ack is a tool for finding text inside files.  It is designed for
+hackers and programmers by being fast, ignoring VCS directories, letting a user
+easily specify file types, match highlighting, Perl-Compatible Regular
+Expressions, and being faster to type than grep.")
+   (home-page "https://beyondgrep.com/")
+   (license license:artistic2.0)))
-- 
2.30.2

Xinglu Chen wrote on 27 May 2021 08:45

Recipients:

Message-ID:875yz43ca3.fsf@yoctocell.xyz

On Wed, May 26 2021, Gabriel Wicki wrote:

Toggle quote (12 lines)> From 2c708fcb56bdb7549a9de7535a0aaf936a18e8a0 Mon Sep 17 00:00:00 2001
> From: Gabriel Wicki <gabriel@erlikon.ch>
> Date: Wed, 26 May 2021 00:08:09 +0200
> Subject: [PATCH] add package ack to (gnu packages textutils)
>
> modified:   gnu/packages/textutils.scm
>  - add package ack
>  - add (guix build-system perl) and (gnu packages perl) to imports
> ---
>  gnu/packages/textutils.scm | 39 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)

Apart from the commit message not conforming to the ChangeLog format[1],

looks good to me.

[1]: https://www.gnu.org/prep/standards/html_node/Change-Logs.html

Gabriel Wicki wrote on 27 May 2021 18:45

Recipients:(name . Xinglu Chen)(address . public@yoctocell.xyz)(address . 48630@debbugs.gnu.org)

Message-ID:20210527164555.vg2xqiaafkii4x4o@silver

On Thu, May 27, 2021 at 08:45:40AM +0200, Xinglu Chen wrote:

Toggle quote (3 lines)

> Apart from the commit message not conforming to the ChangeLog format[1],

> looks good to me.

Sorry for that! I hope i got it right, now :)

From 6bd756812bfc684ca92c4aa9c9d3d573b6bb5717 Mon Sep 17 00:00:00 2001

* gnu/packages/perl.scm (perl-file-next): New variable.

---

gnu/packages/perl.scm | 19 +++++++++++++++++++

1 file changed, 19 insertions(+)

Toggle diff (108 lines)diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d35508112f..4f36fc3e44 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -4654,6 +4654,25 @@ provided base directory and can return files (and/or directories if desired)
 matching a regular expression.")
     (home-page "https://metacpan.org/release/File-List")))
 
+(define-public perl-file-next
+  (package
+   (name "perl-file-next")
+   (version "1.18")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/petdance/file-next")
+                  (commit version)))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32
+              "0zdrxk409qxkbbv4fl4wi285kfzyrpaja9wfl00vrxc078rs4afm"))))
+   (build-system perl-build-system)
+   (synopsis "Lightweight, taint-safe file-finding Perl module")
+   (description "File::Next is a Perl CPAN module for finding files.")
+   (home-page "https://metacpan.org/pod/File::Next")
+   (license license:artistic2.0)))
+
 (define-public perl-file-readbackwards
   (package
     (name "perl-file-readbackwards")
-- 
2.30.2



From 499cf536648320a628cc7aef2606b8817220f27d Mon Sep 17 00:00:00 2001
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Thu, 27 May 2021 18:40:56 +0200
Subject: [PATCH] add package ack

* gnu/packages/textutils.scm (ack): New variable.
---
 gnu/packages/textutils.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index ab34373705..1df5050f30 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -45,6 +45,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system go)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
   #:use-module (guix utils)
   #:use-module (gnu packages)
@@ -59,6 +60,7 @@
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages perl)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-xyz)
@@ -1304,3 +1306,40 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public ack
+  (package
+   (name "ack")
+   (version "3.5.0")
+   (source (origin
+            (method git-fetch)
+            (uri
+             (git-reference
+              (url "https://github.com/beyondgrep/ack3")
+              (commit (string-append "v" version))))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32 "00131vqjbzcn6w22m0h3j6x9kp59dimfnnqhpmi78vbcj0jws1dv"))))
+   (build-system perl-build-system)
+   (arguments '(#:tests? #t
+                #:phases (modify-phases
+                          %standard-phases
+                          (add-after 'patch-generated-file-shebangs 'patch-more-shebangs
+                                     (lambda* (#:key inputs #:allow-other-keys)
+                                       (let ((perl (string-append
+                                                    (assoc-ref inputs "perl")
+                                                    "/bin/perl")))
+                                         (substitute* "t/ack-type.t"
+                                                      (("/usr/bin/perl")
+                                                       perl)
+                                                      (("/usr/bin/env perl")
+                                                       perl))))))))
+   (propagated-inputs `(("perl-file-next" ,perl-file-next)))
+   (synopsis "Code-searching tool optimized for programmers with large trees
+of source code")
+   (description "ack is a tool for finding text inside files.  It is designed for
+hackers and programmers by being fast, ignoring VCS directories, letting a user
+easily specify file types, match highlighting, Perl-Compatible Regular
+Expressions, and being faster to type than grep.")
+   (home-page "https://beyondgrep.com/")
+   (license license:artistic2.0)))
-- 
2.30.2

Xinglu Chen wrote on 28 May 2021 22:13

Recipients:(name . Gabriel Wicki)(address . gabriel@erlikon.ch)(address . 48630@debbugs.gnu.org)

Message-ID:87v972pqgc.fsf@yoctocell.xyz

On Thu, May 27 2021, Gabriel Wicki wrote:

Toggle quote (6 lines)

> On Thu, May 27, 2021 at 08:45:40AM +0200, Xinglu Chen wrote:

>> Apart from the commit message not conforming to the ChangeLog format[1],

>> looks good to me.

> Sorry for that! I hope i got it right, now :)

I forgot to mention that this applies to the ‘ack’ package as well[1],

sorry for the inconvenience!

Also, I don’t have commit access, so you will have to wait for someone

else to merge the patches.

[1]: https://issues.guix.gnu.org/48630#6

Gabriel Wicki wrote on 6 Jul 2021 20:52

Recipients:(name . Xinglu Chen)(address . public@yoctocell.xyz)(address . 48630@debbugs.gnu.org)

Message-ID:20210706185219.xu2ehxph2iaf5nbp@knurd

On Fri, May 28, 2021 at 10:13:07PM +0200, Xinglu Chen wrote:

Toggle quote (2 lines)

> I forgot to mention that this applies to the ‘ack’ package as well[1],

> sorry for the inconvenience!

Now I'm confused... Both patches are included in my last email[1].

Or am I missing something?

[1] https://issues.guix.gnu.org/48630#8

Gabriel Wicki wrote on 26 Jul 2021 16:33

Re: bug#48630: Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next)

Recipients:(address . 48630@debbugs.gnu.org)

Message-ID:20210726143303.xljnaiuh3mghzyx3@silvi

Attachment: file

Ricardo Wurmus wrote on 8 Jul 2022 18:44

[PATCH] adds `ack' package and it's perl module dependency File::Next

Recipients:(address . 48630-done@debbugs.gnu.org)

Message-ID:877d4nzh5n.fsf@elephly.net

Commit 1051db25267a9bbc0ad38be2f3ec92af40f18e18 adds ack. I’ve

reformatted your patch a little, but nothing fundamental has been

changed.

Thank you for your patience! Let’s hope your next patch gets noticed

sooner. Feel free to ping us on IRC if you think we may have forgotten

about your contributions.

Thanks again!

Ricardo

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 48630@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 48630

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date