From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 17:01:25 2021 Received: (at 48630) by debbugs.gnu.org; 24 May 2021 21:01:25 +0000 Received: from localhost ([127.0.0.1]:44020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llHhV-0000HN-F4 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:01:25 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:49682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llHhU-0000HF-1T for 48630@debbugs.gnu.org; Mon, 24 May 2021 17:01:24 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by andre.telenet-ops.be with bizsmtp id 8l1M2500T0mfAB401l1Nli; Mon, 24 May 2021 23:01:22 +0200 Message-ID: Subject: Re: [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next From: Maxime Devos To: Gabriel Wicki , 48630@debbugs.gnu.org Date: Mon, 24 May 2021 23:01:09 +0200 In-Reply-To: <20210524191054.7wtb4wopstgx2c77@silver> References: <20210524191054.7wtb4wopstgx2c77@silver> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-oqUmi9nuvCo+8bggsUiK" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1621890082; bh=IvsgGFmMp8KwYGPDPvHWfOe2Kv4ay8GJ42vIqw0pLqo=; h=Subject:From:To:Date:In-Reply-To:References; b=vCKHOjA/f/ZsHB2JjkFO6xBcJsqaUhT3n5QC4F/vVDcqwEUdGuQ+zmALr4tgtfoeU Dn4Vy+m97Vim5fdLdAlWUkx6rKwbqT5kjnMaHZ5WuW2xhoaSgy0HijB6s+Np8aTAWX aB++85Ytoo12r0KTOG0mvs1GQasJKZO7yN7HL+XzumBjdHi//xWR97ExnfyBe/O2CC iIYmXrp5wiQBunqFzFRmR1PeK0TYxCRqMBGuAMKPC/iFqGOC/f14rmg+gGRBX+idnG AG1RkTacTF8cgtEgPQOVcm9ZEPEzRogdxwNUuHpJdIytb/AzpZVs0odayoU2bK/FD/ 5OHLDHSdUlD6g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48630 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-oqUmi9nuvCo+8bggsUiK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gabriel Wicki schreef op ma 24-05-2021 om 21:10 [+0200]: > [...] > +(define-public ack > + (package > + (name "ack") > + (version "3.5.0") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/beyondgrep/ack3") > + (commit (format #nil "v~a" version)))) #f is an elisp compatibility hack in Guile. Use (format #f "v~a" version) instead, or simpler (string-append "v" version). Looking at the patch only and (I didn't test it, didn't do licensing checks, etc.) I only see one other problem: > + (arguments '(#:tests? #f)) Why are the tests disabled? (Are there none, do they need additional packages not in Guix, ...) Maybe add a line like > + ;; There is no test suite. > + (arguments '(#:tests? #f)) Greetings, Maxime. --=-oqUmi9nuvCo+8bggsUiK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYKwUHxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iWXAQDWOpjbcIknk/MN8PUtmO28a2Ab mJoir5bh4D53h0eW9wD+NrdV2T56fCmuDKo3OskSi6CUxHokvlWeO+LkDyXoBg8= =Lo63 -----END PGP SIGNATURE----- --=-oqUmi9nuvCo+8bggsUiK--