From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 17:26:33 2021 Received: (at 48630) by debbugs.gnu.org; 24 May 2021 21:26:33 +0000 Received: from localhost ([127.0.0.1]:44037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI5o-0000sD-S9 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:26:33 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:60090 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI5m-0000rz-R7 for 48630@debbugs.gnu.org; Mon, 24 May 2021 17:26:31 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1621891583; bh=CttyecTjS7GAmMHmjgk9lC2v56FRHnnVjWlAmGxSKwg=; h=From:To:Subject:In-Reply-To:References:Date; b=RKj7A+LIgmy0aj4AQU+CqYjAoNLClCkyVx4uQSGFnrRE33yz2PEej9kNbLWeyjYFC 9EgUiZfN78+wbLtLsxnAscxaGgiu5HchOpXkI/ea1iEJs4tG0qqznMm2oYhRn4trSR zNcNwdvOh6ISm0ERMcw5yrGS1RSDY2o/0ol0/CHw= To: Gabriel Wicki , 48630@debbugs.gnu.org Subject: Re: [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next In-Reply-To: <20210524191054.7wtb4wopstgx2c77@silver> References: <20210524191054.7wtb4wopstgx2c77@silver> Date: Mon, 24 May 2021 23:26:22 +0200 Message-ID: <87mtsj962p.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, May 24 2021, Gabriel Wicki wrote: > modified: gnu/packages/perl.scm > - adds package `perl-file-next' (module File::Next) > > modified: gnu/packages/textutils.scm > - adds package `ack' with disabled tests Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS X-Debbugs-Envelope-To: 48630 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, May 24 2021, Gabriel Wicki wrote: > modified: gnu/packages/perl.scm > - adds package `perl-file-next' (module File::Next) > > modified: gnu/packages/textutils.scm > - adds package `ack' with disabled tests Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, May 24 2021, Gabriel Wicki wrote: > modified: gnu/packages/perl.scm > - adds package `perl-file-next' (module File::Next) > > modified: gnu/packages/textutils.scm > - adds package `ack' with disabled tests Commit messages should be written in ChangeLog format[1], you can look at previous commits for examples. This commit should also be split into two separate commits, one adding =E2=80=98perl-file-next=E2=80=99, and the other adding =E2=80=98ack=E2=80= =99. > +(define-public perl-file-next > + (package > + (name "perl-file-next") > + (version "1.18") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/petdance/file-next") > + (commit version))) > + (file-name "perl-next-file") Use =E2=80=98(file-name (git-file-name name version))=E2=80=99. > + (sha256 > + (base32 > + "0zdrxk409qxkbbv4fl4wi285kfzyrpaja9wfl00vrxc078rs4afm")))) > + (build-system perl-build-system) > + (synopsis "File::Next is a lightweight, taint-safe file-finding Perl = module") Try to make the synopsis as concise as possible, just =E2=80=9CLightweight, taint-safe file-finding Perl module=E2=80=9D should do. See the =E2=80=98S= ynopses and Descriptions=E2=80=99 section of the manual. > + (description "A Perl CPAN module for finding files. It has no non-co= re > +prerequisites") The description should contain one or more complete sentences. > +(define-public ack > + (package > + (name "ack") > + (version "3.5.0") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/beyondgrep/ack3") > + (commit (format #nil "v~a" version)))) We usually use =E2=80=98(string-append "v" version)=E2=80=99 instead of =E2= =80=98format=E2=80=99. > + (file-name "ack") Use =E2=80=98(file-name (git-file-name name version))=E2=80=99 (same as abo= ve). > + (sha256 > + (base32 "00131vqjbzcn6w22m0h3j6x9kp59dimfnnqhpmi78vbcj0jws1= dv")))) > + (build-system perl-build-system) > + (arguments '(#:tests? #f)) What=E2=80=99s the reason for disabling the tests? > + (propagated-inputs `(("perl-file-next" ,perl-file-next))) > + (synopsis "Code-searching tool optimized for programmers with large t= rees > +of source code") > + (description "ack is a tool for finding text inside files. it is desi= gned for ^^ Please use double spacing, and capitalize. > +hackers and programmers by being fast, ignoring VCS directories, letting= a user > +easily specify file types, match highlighting, Perl-Compatible Regular > +Expressions, and being faster to type than `grep '") ^^ Unecessary whitespace, and missing period. Could you send an updated series? [1]: https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-L= ogs --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmCsGf4VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5aQ8QAIxabUMnGFQoYw1oOf8ojuow1Eqn A7uCsWBdxOKoeFEQzHhyvQgQHtgtVTld+pSngpElgSuBeD+HE/j4H477rMiFoj8Q hVFNDbH2BKDq9GJ7EaBMZA6ZAKTisqhqcbsoR7i78ir6pyFwlV24EA2AJ0H237gK NAA+9bVo991B4E0pe+nHgTQY9vsN1HstGhKFujTqdGHy++JWZCGNQSSPQmsSYyyT 1aLz7dfYkT+v24CMogIq/Fg5TscZE6Cy1YWtrb87v9rE4kVx9Wbw1WYtGaMtVItc LEXHNa5nIai2Xfo0VkgsaYmgm2JA7EP9WMGF4QL4h2s+huNkR/9dmpXEVzyEiHaM oIQIO5k+E77ZnMNqwMnDPc+4GowoDjS1ESyXwtPIK8lB9u0HJCdLDvf98iHJ2f33 mvDMOYuKY+FUDasOCNXZ/swF4OA8HjTT8gyEZ7SPfdcNAWyDxaVYSQclRCHAgwqx NwELoPRdu1Tm3N0szt55+zgj9uE4H9uFNUMA2VYf96I8ztr71vBa9GyQdti8hNIV PBu7Ce3gPQDUtvmL+0OzBfW6OOWCZpIdeHBcDL3y5b58OubcMm+wuju3nxyLplom gkKUqdUYNijBWzDbW+QuirBASZlOll7AdduoCL6ulW/k5bjAiTzRASRY7I1zW53z 5N2LHO9fBvxqgvN+ =Eoj3 -----END PGP SIGNATURE----- --=-=-=--