[PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

  • Done
  • quality assurance status badge
Details
4 participants
  • Cayetano Santos
  • Maxim Cournoyer
  • Rostislav Svoboda
  • Steve George
Owner
unassigned
Submitted by
Rostislav Svoboda
Severity
normal
Merged with
R
R
Rostislav Svoboda wrote on 15 Oct 2023 00:04
(address . guix-patches@gnu.org)(name . Rostislav Svoboda)(address . Rostislav.Svoboda@gmail.com)
98829ade4c0e01410c35f295b073ecd001eb9e5c.1697320831.git.Rostislav.Svoboda@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-solarized): New variable.
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

Toggle diff (40 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5fd851b38..26ea9dd84b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11081,6 +11081,30 @@ (define-public emacs-color-theme-sanityinc-tomorrow
extensive face definitions than the \"official\" Emacs variant.")
(license license:gpl3+))))
+(define-public emacs-color-theme-sanityinc-solarized
+ (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")
+ (revision "0"))
+ (package
+ (name "emacs-color-theme-sanityinc-solarized")
+ (version (git-version "0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/purcell/color-theme-sanityinc-solarized")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "10vfbl9dry03dw264w7b4grmzcv78x3p7r86bsyhyl74hwwvx1hp"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/purcell/color-theme-sanityinc-solarized")
+ (synopsis
+ "Emacs color themes based on Ethan Schoonover's 'solarized' theme")
+ (description
+ "An alternate Emacs color-theme version of Ethan Schoonover's \"Solarized\"
+theme pair.")
+ (license license:gpl3+))))
+
(define-public emacs-solarized-theme
(package
(name "emacs-solarized-theme")

base-commit: 3d0cdf963820da665d71987c15cae6e503efc701
prerequisite-patch-id: 0d0169efa833e9dd39a2b5c7ff264f733f212e5b
--
2.41.0
R
R
Rostislav Svoboda wrote on 15 Oct 2023 00:09
Re: bug#66550: Acknowledgement ([PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.)
(address . 66550@debbugs.gnu.org)
CAEtmmew18cbXh6AmSVW0dM-a8jW8ioqWV5uXVzmkzQsNZbv5ew@mail.gmail.com
Please consider reviewing the following two patches together:

[PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.

[PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

Le dim. 15 oct. 2023 à 00:05, GNU bug Tracking System
<help-debbugs@gnu.org> a écrit :
Toggle quote (26 lines)
>
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> As you requested using X-Debbugs-CC, your message was also forwarded to
> Andrew Tropin <andrew@trop.in>, Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>, Liliana Marie Prikler <liliana.prikler@gmail.com>
> (after having been given a bug report number, if it did not have one).
>
> Your message has been sent to the package maintainer(s):
> guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 66550@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 66550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66550
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
S
S
Steve George wrote on 5 Mar 12:52 +0100
merging 66545 66550
(address . control@debbugs.gnu.org)
1709639527-3638-bts-steve@futurile.net
merge 66545 66550
thanks
C
C
Cayetano Santos wrote on 7 Nov 11:52 +0100
Re: [bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.
(address . rostislav.svoboda@gmail.com)(address . 66550@debbugs.gnu.org)
87iksz2u5l.fsf@inventati.org
+ (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")

It could be great to include latest commits from 2024

+ (license license:gpl3+))))

I see no license whatsoever in upstream repository, is that correct ?
R
R
Rostislav Svoboda wrote on 7 Nov 13:32 +0100
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 66550@debbugs.gnu.org)
CAEtmmewdOHsqR9naLWeOqE0f0hsbrSVdzaLCLgsjWvBa81Y6TA@mail.gmail.com
Hello

Toggle quote (4 lines)
> + (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")
>
> It could be great to include latest commits from 2024

Uff, that's been more than a year since I sent the patch!
Anyway, I updated it and also slightly tweaked the synopsis. See attachment.

Toggle quote (4 lines)
> + (license license:gpl3+))))
>
> I see no license whatsoever in upstream repository, is that correct ?

The color-theme-sanityinc-solarized repository does not include an
explicit license file. However, the main source file,
color-theme-sanityinc-solarized.el, contains the following header:

;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.

Cheers Bost
From fb2d6a3541d425edd2b17eed1bb185752a0adadb Mon Sep 17 00:00:00 2001
Message-ID: <fb2d6a3541d425edd2b17eed1bb185752a0adadb.1730982465.git.Rostislav.Svoboda@gmail.com>
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Thu, 7 Nov 2024 13:24:37 +0100
Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

* gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-solarized): New variable.

Change-Id: Ic989e64cc532529772cda51e1f49b53d6aa4c073
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

Toggle diff (39 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 88e1ab89a9..63b6a6da1a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11096,6 +11096,30 @@ (define-public emacs-slime
for compilation, debugging, documentation lookup, and so on.")
(license (list license:gpl2+ license:public-domain))))
+(define-public emacs-color-theme-sanityinc-solarized
+ (let ((commit "9c62a49fe0a5ff456bcf3984ba825e75861534b9")
+ (revision "0"))
+ (package
+ (name "emacs-color-theme-sanityinc-solarized")
+ (version (git-version "0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url
+ "https://github.com/purcell/color-theme-sanityinc-solarized")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0vakjdm5xf7ahxf39j4bc38irkwyv8xkp45akqfc7z252vpxi44k"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/purcell/color-theme-sanityinc-solarized")
+ (synopsis "Solarized color themes for Emacs")
+ (description
+ "An alternate Emacs color-theme version of Ethan Schoonover's \"Solarized\"
+theme pair.")
+ (license license:gpl3+))))
+
(define-public emacs-popup
(package
(name "emacs-popup")

base-commit: 2a6d96425eea57dc6dd48a2bec16743046e32e06
--
2.46.0
C
C
Cayetano Santos wrote on 7 Nov 13:55 +0100
QA review for 66550
871pzndx01.fsf@inventati.org
user guix
usertag 66550 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked:

- Commit messages
- Package builds
- Lint warnings
- Package tests
- Package style
- List dependent packages build

- New package licenses
- New package tests
- New package synopsis and descriptions
M
M
Maxim Cournoyer wrote on 12 Nov 12:52 +0100
Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
(name . Rostislav Svoboda)(address . rostislav.svoboda@gmail.com)
87o72k4ql3.fsf@gmail.com
Hi,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

Toggle quote (11 lines)
>> The tests should not be byte compilation. In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)

I've applied it.

Thank you!

--
Maxim
Closed
M
M
Maxim Cournoyer wrote on 12 Nov 15:12 +0100
(name . Rostislav Svoboda)(address . rostislav.svoboda@gmail.com)
87ed3g1qy9.fsf@gmail.com
Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

Toggle quote (32 lines)
>> The tests should not be byte compilation. In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)
>
> From 1ab65dedbca8d38cf9291e93265cf48c0e473a58 Mon Sep 17 00:00:00 2001
> Message-ID: <1ab65dedbca8d38cf9291e93265cf48c0e473a58.1697312893.git.Rostislav.Svoboda@gmail.com>
> From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
> Date: Sat, 14 Oct 2023 19:17:22 +0200
> Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
>
> * gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow): New variable.
> ---
> gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..b5fd851b38 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -11057,6 +11057,30 @@ (define-public emacs-moe-theme-el
> variants.")
> (license license:gpl3+)))
>
> +(define-public emacs-color-theme-sanityinc-tomorrow

I've added this comment here:

;; Use the latest commit as there are no release/tag.

We always justify why using a made-up version or random commit, to help
the next person who'll update the package.

--
Thanks,
Maxim
R
R
Rostislav Svoboda wrote on 14 Nov 12:56 +0100
Re: [bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 66550@debbugs.gnu.org)
CAEtmmey-kGUvtTw+o73ihwvbS88Ac3BA99+xQFDM7HYWmL-DmA@mail.gmail.com
Hello Cayetano,

It would be great if you could merge my patch. It’s not particularly
important - just a trivial piece of code - but it has been lingering
for quite some time now. Specifically, for 1 year and 1 month, minus 1
day ;-)

Cheers,
Bost
C
C
Cayetano Santos wrote on 14 Nov 14:17 +0100
(name . Rostislav Svoboda)(address . rostislav.svoboda@gmail.com)(address . 66550@debbugs.gnu.org)
87o72i9cpo.fsf@inventati.org
Toggle quote (9 lines)
>jeu. 14 nov. 2024 at 12:56, Rostislav Svoboda <rostislav.svoboda@gmail.com> wrote:

> Hello Cayetano,
>
> It would be great if you could merge my patch. It’s not particularly
> important - just a trivial piece of code - but it has been lingering
> for quite some time now. Specifically, for 1 year and 1 month, minus 1
> day ;-)

I’m not a guix committer, I’m just reviewing patches, and yours was fine to me.

I think I understand the tweak here. You have ask to merge 66545
(solarized) and 66550 (tomorrow). The later was merged a couple of days
ago, so both are considered as done now.


If I’m right, you’ll better ask Maxim (the committer) to consider the
situation.

C.
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 66550@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 66550
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch