[PATCH 2/2] gnu: emacs-explain-pause-mode: Fix failing tests.

  • Done
  • quality assurance status badge
Details
3 participants
  • luishgh
  • Nicolas Goaziou
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
luishgh
Severity
normal
Merged with
L
L
luishgh wrote on 17 May 2022 01:45
(address . guix-patches@gnu.org)(name . luishgh)(address . 51053603+luishgh@users.noreply.github.com)
20220516234553.24531-3-luishenriquegh2701@gmail.com
From: luishgh <51053603+luishgh@users.noreply.github.com>

* gnu/packages/emacs-xyz.scm (emacs-explain-pause-mode): Fix failing tests.
---
gnu/packages/emacs-xyz.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 590330ac4f..8fc1d38193 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4709,7 +4709,7 @@ (define-public emacs-explain-pause-mode
(revision "0"))
(package
(name "emacs-explain-pause-mode")
- (version (git-version "0.1" revision commit))
+ (version (git-version "0.2" revision commit))
(source
(origin
(method git-fetch)
@@ -4724,6 +4724,13 @@ (define-public emacs-explain-pause-mode
(list emacs-buttercup))
(arguments
'(#:tests? #t
+ #:phases
+ (modify-phases %standard-phases
+ ;; This causes the byte-compilation before unit-tests to fail
+ (add-after 'unpack 'remove-error-on-warn
+ (lambda _
+ (substitute* "Makefile"
+ (("--eval '\\(setq byte-compile-error-on-warn t\\)'") "")))))
;; Don't run case-tests as they will fail to create sockets because
;; the path is too long
#:test-command '("make" "byte-compile" "unit-tests")
--
2.36.0
L
L
Luis Henrique Gomes Higino wrote on 17 May 2022 01:50
Apologies
(address . 55467@debbugs.gnu.org)(address . 55468@debbugs.gnu.org)
87r14tqbjy.fsf@gmail.com
Hi guix,

sent the patches as separate issues :/. The right one is
https://issues.guix.gnu.org/55466.Sorry for the inconvenience.

Regards,
--
Luis H. Higino
T
T
Tobias Geerinckx-Rice wrote on 17 May 2022 01:59
(address . control@debbugs.gnu.org)(name . Luis Henrique Gomes Higino)(address . luishenriquegh2701@gmail.com)
1A8465C6-B903-480F-BF15-21999AFC5A51@tobias.gr
merge 55466 55467 55468
thanks

No problem; easily fixed!

Kind regards,

T G-R

Sent on the go. Excuse or enjoy my brevity.
N
N
Nicolas Goaziou wrote on 17 May 2022 09:19
Re: [bug#55468] [PATCH 2/2] gnu: emacs-explain-pause-mode: Fix failing tests.
(name . luishgh)(address . luishenriquegh2701@gmail.com)
87a6bglj6x.fsf@nicolasgoaziou.fr
luishgh <luishenriquegh2701@gmail.com> writes:

Toggle quote (5 lines)
> From: luishgh <51053603+luishgh@users.noreply.github.com>
>
> * gnu/packages/emacs-xyz.scm (emacs-explain-pause-mode): Fix failing
> tests.

Closing, as a duplicate of bug#55466.
?
Your comment

This issue is archived.

To comment on this conversation send an email to 55468@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 55468
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch