nginx-rtmp-module not compatible with nginx

X-Debbugs-CC: mail@cbaines.net

Hi Guix,

nginx currently (Guix commit b80ca672de936a76368de6e6ea0b28505e74d420)

fails to load the nginx-rtmp-module build from the same Guix commit with

the following message:

[emerg] 3823#0: module "/gnu/store/qnk6k7wa25w0bk5v8fb6iv524imlm58s-nginx-rtmp-module-1.2.2/etc/nginx/modules/ngx_rtmp_module.so" is not binary compatible in /gnu/store/mz0bck7ha0iqgi1bv4k14b36ycs3bz6k-nginx.conf:1

I wonder if this problem was introduced with the recent nginx changes

(e.g. a14c6352662bfa6715ec70b3d280a6d1d599ad0c)

Best,

Jack

On Wed, 4 May 2022, Jack Hill wrote:

The problem seems to actually have been introduced with

c9ce02ecff769449bb79f9f0db33c69e2c7564f0 "nginx: Respect

#:configure-flags". I suspect that now that the #:configure-flags are

being respected they've gotten out of sync with nginx-rtmp-module (which

probably only worked by change before). The likely solution is to find a

way to re-use the #:configure-flags from the nginx package.

Best,

Jack

reassign 55253 guix-patches

tags 55253 patch

These patches buils the nginx-rtmp-module with the same #:configure-flags

as the nginx package, which fixes the incompatible module problem, and

update the #:phases to use gexps instead of `assoc-ref`

Jack Hill (2):

gnu: nginx-rtmp-module: Use #:configure-flags from nginx.

gnu: nginx-rtmp-module: Use gexps in phases.

gnu/packages/web.scm | 23 +++++++++--------------

1 file changed, 9 insertions(+), 14 deletions(-)

--

2.36.1

of arguments from nginx and augment #:configure-flags from nginx

rather than overwriting.

---

gnu/packages/web.scm | 9 +++------

1 file changed, 3 insertions(+), 6 deletions(-)

remove trailing #t.

---

gnu/packages/web.scm | 14 ++++++--------

1 file changed, 6 insertions(+), 8 deletions(-)

Hi Jack,

Jack Hill <jackhill@jackhill.us> skribis:

If I’m not mistaken, #:make-flags and #:modules are lost here, no?

Or were they unnecessary in the first place?

Thanks,

Ludo’.

On Mon, 23 May 2022, Ludovic Courtès wrote:

You are not mistaken, they are lost. They do seem to be unnecessary

though. nginx is able to load and make use of the module without them.

Best,

Jack

On Mon, 23 May 2022, Jack Hill wrote:

I realized the value of the make-flags. It saves effort when building, as

only the module is build not all of nginx again. The output is identical.

I'll send a v2 with those added back. I still don't see the value of the

modules.

Best,

Jack

of arguments from nginx and augment #:configure-flags from nginx

rather than overwriting.

---

gnu/packages/web.scm | 9 ++++-----

1 file changed, 4 insertions(+), 5 deletions(-)

remove trailing #t.

---

gnu/packages/web.scm | 14 ++++++--------

1 file changed, 6 insertions(+), 8 deletions(-)

I've pushed these two patches as

0e953f3332cc862b08ecb2342bdac9976dd6d08c and

0e953f3332cc862b08ecb2342bdac9976dd6d08c now.

Thanks,

Chris

On Fri, 27 May 2022, Christopher Baines wrote:

Thanks, and closing!

Jack