From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 10:11:38 2022 Received: (at 55253) by debbugs.gnu.org; 23 May 2022 14:11:38 +0000 Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt8mY-0000gK-6j for submit@debbugs.gnu.org; Mon, 23 May 2022 10:11:38 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:58318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt8mU-0000g2-1X for 55253@debbugs.gnu.org; Mon, 23 May 2022 10:11:36 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt8mO-0004sh-Sq; Mon, 23 May 2022 10:11:28 -0400 Date: Mon, 23 May 2022 10:11:28 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: =?ISO-8859-15?Q?Ludovic_Court=E8s?= Subject: Re: [bug#55253] nginx-rtmp-module not compatible with nginx In-Reply-To: <871qwk8kyx.fsf_-_@gnu.org> Message-ID: References: <20220522055157.31807-1-jackhill@jackhill.us> <871qwk8kyx.fsf_-_@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-1670597693-1653315088=:11587" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55253 Cc: 55253@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1670597693-1653315088=:11587 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 23 May 2022, Ludovic Courtès wrote: > Jack Hill skribis: >> >> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm >> index 600ef0c895..50401c07e1 100644 >> --- a/gnu/packages/web.scm >> +++ b/gnu/packages/web.scm >> @@ -785,12 +785,9 @@ (define-public nginx-rtmp-module >> `(("nginx-sources" ,(package-source nginx)) >> ,@(package-inputs nginx))) >> (arguments >> - (substitute-keyword-arguments >> - `(#:make-flags '("modules") >> - #:modules ((guix build utils) >> - (guix build gnu-build-system)) >> - ,@(package-arguments nginx) >> - #:configure-flags '("--add-dynamic-module=.")) >> + (substitute-keyword-arguments (package-arguments nginx) >> + ((#:configure-flags flags) >> + #~(cons "--add-dynamic-module=." #$flags)) > > If I’m not mistaken, #:make-flags and #:modules are lost here, no? > Or were they unnecessary in the first place? You are not mistaken, they are lost. They do seem to be unnecessary though. nginx is able to load and make use of the module without them. Best, Jack --925712948-1670597693-1653315088=:11587--