From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 08:58:12 2022 Received: (at 55253) by debbugs.gnu.org; 23 May 2022 12:58:12 +0000 Received: from localhost ([127.0.0.1]:47604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt7dT-0006VI-QE for submit@debbugs.gnu.org; Mon, 23 May 2022 08:58:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt7dP-0006Ur-4O for 55253@debbugs.gnu.org; Mon, 23 May 2022 08:58:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt7dJ-0001r5-Ad; Mon, 23 May 2022 08:58:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rrndyFTLhy5kjv+SVydN4447unOGI9HR5MBySBsw7IQ=; b=DUBDuO3r0PjMYdRyNdKt bPlVUju1SjYjEL9qVhLcXG/z08RopGz3Jm916q3HavINNaKvH7SG6h+01poMY0KZxf9/RByBoYzMe 8o/looHiDekZWO82eO/xzPEk4TRb2jNC4iZPyGDxEX7tEwkqk160hZwKu0kjpzd2nSgl+meEjyNPO oHMZvdR60tPEAdhroSQBQl4BywbzvnT/SFAnxXMmpKxCd+mHIFOiyIpY1jffhIHtZF6qZbCIa35ly XnwiKOq8LoATg4SbEbtyEet5BW1K5IeO6/3JvIbvYJoewLqGPWMVAth1NJdW9fGwYT1+9QoDAgZmR POjrCDiNCNljuQ==; Received: from [193.50.110.143] (port=58878 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt7dI-0001RI-ST; Mon, 23 May 2022 08:58:01 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jack Hill Subject: Re: bug#55253: nginx-rtmp-module not compatible with nginx References: <20220522055157.31807-1-jackhill@jackhill.us> Date: Mon, 23 May 2022 14:57:58 +0200 In-Reply-To: <20220522055157.31807-1-jackhill@jackhill.us> (Jack Hill's message of "Sun, 22 May 2022 01:51:56 -0400") Message-ID: <871qwk8kyx.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55253 Cc: 55253@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Jack, Jack Hill skribis: > * gnu/packages/web.scm (nginx-rtmp-module)[arguments]: Simplify copying > of arguments from nginx and augment #:configure-flags from nginx > rather than overwriting. > --- > gnu/packages/web.scm | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index 600ef0c895..50401c07e1 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -785,12 +785,9 @@ (define-public nginx-rtmp-module > `(("nginx-sources" ,(package-source nginx)) > ,@(package-inputs nginx))) > (arguments > - (substitute-keyword-arguments > - `(#:make-flags '("modules") > - #:modules ((guix build utils) > - (guix build gnu-build-system)) > - ,@(package-arguments nginx) > - #:configure-flags '("--add-dynamic-module=3D.")) > + (substitute-keyword-arguments (package-arguments nginx) > + ((#:configure-flags flags) > + #~(cons "--add-dynamic-module=3D." #$flags)) If I=E2=80=99m not mistaken, #:make-flags and #:modules are lost here, no? Or were they unnecessary in the first place? Thanks, Ludo=E2=80=99.