[PATCH] gnu: Add qbe.

  • Done
  • quality assurance status badge
Details
4 participants
  • Jon Eskin
  • Liliana Marie Prikler
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Jon Eskin
Severity
normal
Merged with
J
J
Jon Eskin wrote on 27 Apr 2022 14:03
(address . guix-patches@gnu.org)
645F64B5-672D-48DB-B3CB-6B621E56AA49@gmail.com
Hello,

I’ve packaged the qbe compiler backend. I’m new to GUIX, so let me know if I messed anything up!

I sent this about patch about a half hour ago and it shows as sent on my end but isn’t showing up on the archive… apologies if it comes through twice.

Jon
Attachment: file
Attachment: file
T
T
Tobias Geerinckx-Rice wrote on 27 Apr 2022 17:07
(address . control@debbugs.gnu.org)
EDF060AA-AA28-4B5F-954B-F55333E4017E@tobias.gr
merge 55150 55151
thanks


Kind regards,

T G-R

Sent on the go. Excuse or enjoy my brevity.
L
L
Ludovic Courtès wrote on 1 May 2022 15:16
(name . Liliana Marie Prikler)(address . liliana.prikler@ist.tugraz.at)
87h7694cma.fsf@gnu.org
Hi,

Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:

Toggle quote (11 lines)
> Am Montag, dem 25.04.2022 um 20:05 +0000 schrieb paren@disroot.org:
>> QBE is now being used in one reasonably mature project:
>> https://harelang.org
>>
>> While it's not at 1.0 yet, it's been in development for ~2 (i think)
>> years now.
> I'm not asking for a 1.0, I'd be fine with a 0.1 or even a 0.0.1. As
> it stands, every place I look at says "this is experimental" rather
> than "you can use this and it ought to work as intended at least for
> these sample programs".

But that’s fine: having a web page at all, or one that doesn’t read
“experimental”, has never been a criterion for getting a package in
Guix.

There’s now a second patch for qbe:


I propose to go ahead and apply it, adding anything missing from paren’s
initial patch.

Thanks,
Ludo’.
L
L
Liliana Marie Prikler wrote on 2 May 2022 08:33
(name . Ludovic Courtès)(address . ludo@gnu.org)
23ff4ecaf07b3cec38d452d69785f1dd450581d7.camel@ist.tugraz.at
Hi Ludo,

Am Sonntag, dem 01.05.2022 um 15:16 +0200 schrieb Ludovic Courtès:
Toggle quote (19 lines)
> Hi,
>
> Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:
>
> > Am Montag, dem 25.04.2022 um 20:05 +0000 schrieb paren@disroot.org:
> >
> > > QBE is now being used in one reasonably mature project:
> > > https://harelang.org
> > >
> > > While it's not at 1.0 yet, it's been in development for ~2 (i
> > > think) years now.
> > I'm not asking for a 1.0, I'd be fine with a 0.1 or even a 0.0.1. 
> > As it stands, every place I look at says "this is experimental"
> > rather than "you can use this and it ought to work as intended at
> > least for these sample programs".
>
> But that’s fine: having a web page at all, or one that doesn’t read
> “experimental”, has never been a criterion for getting a package in
> Guix.
That's not my criterion either. My critierion is more or less "Will we
have to revision-bump this package daily/every few days because people
want to play with the latest stuff?" With upstream having seen no
commit for three weeks at this point, I guess it might be fine.

Toggle quote (6 lines)
> There’s now a second patch for qbe:
>
>   https://issues.guix.gnu.org/55151
>
> I propose to go ahead and apply it, adding anything missing from
> paren’s initial patch.
IMHO, paren's initial patch is slightly better in quality than 55151,
but there are two (three) things lacking. First, the synopsis and
description are subpar. 55151 has a slightly better synopsis, don't
feel too sure about the description though. Second, the "fix-cc" phase
from 55151 should be added after unpack ("patch-test-script" sounds
like a better phase name). It might be better to use (cc-for-target)
in the substitution rather than gcc, but note that this substitution
only applies for native compilation anyway.

cproc too seems to grow at a slower pace now. Might be worth moving
stuff over from guixrus now. Note that the cproc package has #:tests
#f without an explanation, though, so it needs some polishing.

Cheers
L
L
Liliana Marie Prikler wrote on 24 May 2022 08:43
(address . control@debbugs.gnu.org)
8fdea3aaa79939d25f1fbe1a7b92b7f73ae20cc1.camel@ist.tugraz.at
merge 53833 55151 55605
merge 55187 55606
block 55187 by 53833
block 53834 by 53833
thanks
?
Your comment

This issue is archived.

To comment on this conversation send an email to 55151@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 55151
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch