[PATCH] gnu: Add libtree

Done

Details

5 participants

Julien Lepiller
Ludovic Courtès
Maxime Devos
Mathieu Othacehe
Artyom V. Poptsov

Owner: unassigned

Submitted by: Artyom V. Poptsov

Severity: normal

Artyom V. Poptsov wrote on 13 Dec 2021 21:42

Recipients:(address . guix-patches@gnu.org)

Message-ID:87fsqw5j9h.fsf@gmail.com

Hello Guixers,

this patch adds libtree[1] v3.0.0-rc6.

- avp

References:

1: https://github.com/haampie/libtree

From 98428689a669def9499cce2883ac33202fa3ac84 Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++

1 file changed, 37 insertions(+)

Toggle diff (54 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 1e51dd8d83..84e7042604 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -53,6 +53,7 @@
 ;;; Copyright © 2021 B. Wilson <elaexuotee@wilsonb.com>
 ;;; Copyright © 2021 Ivan Gankevich <i.gankevich@spbu.ru>
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
+;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8690,3 +8691,39 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.0-rc6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1i2v70n0pn7aqa4k2pr049zwp1sf8m975pgpgmnr3d53806zchgs"))))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (delete 'check)
+         (delete 'configure)
+         (add-before 'build 'patch
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* "Makefile"
+               (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
+                (format #f "~a/bin/" (assoc-ref outputs "out"))))))
+         (replace 'build
+           (lambda _
+             (setenv "CC" "gcc")
+             (setenv "LDFLAGS" "-static")
+             (invoke "make"))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "@command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Artyom V. Poptsov wrote on 18 Dec 2021 09:02

Recipients:(address . guix-patches@gnu.org)

Message-ID:87pmpu5oi8.fsf@gmail.com

I've updated libtree to v3.0.1.

- Artyom

From 4deebbcc8be0352121b7cf42e6a39949601faa0f Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 40 ++++++++++++++++++++++++++++++++++++++++

1 file changed, 40 insertions(+)

Toggle diff (57 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 055a37cb79..7503b10800 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -59,6 +59,8 @@
 ;;; Copyright © 2021 Josselin Poiret <josselin.poiret@protonmail.ch>
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
+;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8754,3 +8756,41 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1j56j1k4rlm0wi6jvdmk7j7nf4wrmc5gyhgp6vjf180hpgwlqz92"))))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (delete 'check)
+         (delete 'configure)
+         (add-before 'build 'patch
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* "Makefile"
+               (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
+                (format #f "~a/bin/" (assoc-ref outputs "out")))
+               (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
+                (format #f "~a/share/" (assoc-ref outputs "out"))))))
+         (replace 'build
+           (lambda _
+             (setenv "CC" "gcc")
+             (setenv "LDFLAGS" "-static")
+             (invoke "make"))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "@command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Mathieu Othacehe wrote on 19 Dec 2021 10:48

Re: bug#52472: [PATCH] gnu: Add libtree

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)(address . 52472@debbugs.gnu.org)

Message-ID:87bl1dsz6b.fsf_-_@gnu.org

Hey Artyom,

Toggle quote (4 lines)

> +

No need for an extra new-line here.

Toggle quote (7 lines)

> + (lambda* (#:key outputs #:allow-other-keys)

> + (substitute* "Makefile"

> + (("\\$\$DESTDIR\$\\$\$BINDIR\$")

> + (format #f "~a/bin/" (assoc-ref outputs "out")))

> + (("\\$\$DESTDIR\$\\$\$SHAREDIR\$")

> + (format #f "~a/share/" (assoc-ref outputs "out"))))))

You can now write:

Toggle snippet (12 lines)       ,#~(modify-phases %standard-phases
            (delete 'check)
            (delete 'configure)
            (add-before 'build 'patch
              (lambda* (#:key outputs #:allow-other-keys)
                (substitute* "Makefile"
                  (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
                   (string-append #$output "/bin/"))
                  (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
                   (string-append #$output "/share/")))))

Toggle quote (4 lines)

> + (replace 'build

> + (lambda _

> + (setenv "CC" "gcc")

That would break cross-compilation. You should use something like:

Toggle snippet (3 lines)

(string-append "CC=" ,(cc-for-target)).

Toggle quote (2 lines)

> + (setenv "LDFLAGS" "-static")

Why are we building a static version of the program?

There's also this linter warning:

gnu/packages/linux.scm:8649:14: libtree@3.0.1: synopsis should start with an upper-case letter or digit

Thanks,

Mathieu

Julien Lepiller wrote on 19 Dec 2021 13:50

Re: [bug#52472] [PATCH] gnu: Add libtree

Recipients:(address . 52472@debbugs.gnu.org)

Message-ID:61183D53-CE3D-4A00-AC7D-294C0C98FC00@lepiller.eu

Sorry if this is overwhelming, but also:

Le 19 décembre 2021 04:48:28 GMT-05:00, Mathieu Othacehe <othacehe@gnu.org> a écrit�:

Toggle quote (32 lines)>
>Hey Artyom,
>
>>  ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
>> +;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
>> +
>
>No need for an extra new-line here.
>
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (substitute* "Makefile"
>> +               (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
>> +                (format #f "~a/bin/" (assoc-ref outputs "out")))
>> +               (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
>> +                (format #f "~a/share/" (assoc-ref outputs "out"))))))
>
>You can now write:
>
>--8<---------------cut here---------------start------------->8---
>       ,#~(modify-phases %standard-phases
>            (delete 'check)
>            (delete 'configure)
>            (add-before 'build 'patch
>              (lambda* (#:key outputs #:allow-other-keys)
>                (substitute* "Makefile"
>                  (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
>                   (string-append #$output "/bin/"))
>                  (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
>                   (string-append #$output "/share/")))))
>--8<---------------cut here---------------end--------------->8---
>

Don't remove the check phase. Use #:tests? #f instead and add a comment explaining why. If the tests fail, we should fix them, not put them under the rug ;)

Maybe it would be easier to pass BINDIR, SHAREDIR and CC with #:make-flags?

Toggle quote (23 lines)>> +         (replace 'build
>> +           (lambda _
>> +             (setenv "CC" "gcc")
>
>That would break cross-compilation. You should use something like:
>
>--8<---------------cut here---------------start------------->8---
>(string-append "CC=" ,(cc-for-target)).
>--8<---------------cut here---------------end--------------->8---
>
>> +             (setenv "LDFLAGS" "-static")
>
>Why are we building a static version of the program?
>
>There's also this linter warning:
>
>gnu/packages/linux.scm:8649:14: libtree@3.0.1: synopsis should start with an upper-case letter or digit
>
>Thanks,
>
>Mathieu
>

Could you send a new patch with these changes? Don't hesitate to ask if you're a bit lost or need help on some points :)

Artyom V. Poptsov wrote on 13 Jan 2022 04:30

Recipients:(name . Julien Lepiller)(address . julien@lepiller.eu)

Message-ID:87zgo0jori.fsf@gmail.com

Hello,

this is the updated version of the patch with changes suggested by

Mathieu Othacehe and Julien Lepiller.

A note for Mathieu: I used to build libtree with "-static" flag as it is

recommended by the official documentation. But libtree builds fine

without the flag so I removed it.

Thanks,

- Artyom

From 4ce9098e6fe8525e1e68d97458cb246ddc901266 Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++

1 file changed, 37 insertions(+)

Toggle diff (54 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index da2ce602a7..f73e235a3c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -60,6 +60,8 @@
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8789,3 +8791,38 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1j56j1k4rlm0wi6jvdmk7j7nf4wrmc5gyhgp6vjf180hpgwlqz92"))))
+    (arguments
+     (list #:tests? #f
+           #:make-flags
+           ;; NOTE: Official documentation recommends to build libtree with
+           ;; "-static" flag.
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   "PREFIX=/"
+                   (string-append "DESTDIR=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (delete 'configure)
+               (replace 'build
+                 (lambda* (#:key make-flags #:allow-other-keys)
+                   (apply invoke "make" make-flags))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "Show output of @command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 13 Jan 2022 08:38

Recipients:

Message-ID:2cabbfdeec3e063747dc8f852ec119ffe0cef1f6.camel@telenet.be

Hi,

Artyom V. Poptsov schreef op do 13-01-2022 om 06:30 [+0300]:

Toggle quote (2 lines)

> +�� (list #:tests? #f

There's a check target in
https://github.com/haampie/libtree/blob/master/Makefile
and a bunch of tests in
https://github.com/haampie/libtree/tree/master/tests.

Greetings,
Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYd/W+hccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qxyAP0UNEh/KHFV2ZLQ627j1YIo3cxE

9c914yVbbWQzLffKmQD9FLLWMuI3smwpi2Tu6d9tqMqWfT93aUxe01yoU+D9Wg0=

=XDVQ

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 13 Jan 2022 18:18

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87v8ynk0zp.fsf@gmail.com

Hello Maxime,

to my understanding some libtree tests (namely 07 and 08) are made in

such way that they finish with a non-zero code when they pass, that

makes Guix stop during the build with an error. For example, the test

"07_origin_is_relative_to_symlink_location_not_realpath" expects that

libtree will fail. I checked a compiled "exe" file from a failed build

and got this:

Toggle snippet (27 lines)$ libtree /tmp/guix-build-libtree-3.0.1.drv-0/source/tests/07_origin_is_relative_to_symlink_location_not_realpath/exe 
exe 
??? libg.so [runpath]
    ??? libf.so not found
        ? Paths considered in this order:
        ? 1. rpath is skipped because runpath was set
        ? 2. LD_LIBRARY_PATH was not set
        ? 3. runpath:
        ?    /tmp/guix-build-libtree-3.0.1.drv-0/source/tests/07_origin_is_relative_to_symlink_location_not_realpath/b
        ? 4. ld config files:
        ?    /usr/lib/x86_64-linux-gnu/libfakeroot
        ?    /usr/local/lib
        ?    /usr/local/lib/x86_64-linux-gnu
        ?    /lib/x86_64-linux-gnu
        ?    /usr/lib/x86_64-linux-gnu
        ?    /lib32
        ?    /usr/lib32
        ? 5. Standard paths:
        ?    /lib
        ?    /lib64
        ?    /usr/lib
        ?    /usr/lib64
Error [/tmp/guix-build-libtree-3.0.1.drv-0/source/tests/07_origin_is_relative_to_symlink_location_not_realpath/exe]: Not all dependencies were found
$ echo $?
28

Yet libtree itself seems to work fine after installation from Guix.

Here's an example of the output for a correct binary:

Toggle snippet (9 lines)

$ libtree guix-daemon

guix-daemon

??? libz.so.1 [runpath]

??? libbz2.so.1.0 [runpath]

??? libgcrypt.so.20 [runpath]

? ??? libgpg-error.so.0 [runpath]

??? libsqlite3.so.0 [runpath]

I suggest that we keep "#f" for tests unless the libtree author fix this

behavior.

For now I opened an issue for libtree:

https://github.com/haampie/libtree/issues/65

Thanks!

- Artyom

Artyom "avp" Poptsov <poptsov.artyom@gmail.com>

Home page: https://memory-heap.org/~avp/

CADR Hackerspace co-founder: https://cadrspace.ru/

GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 13 Jan 2022 18:37

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:f9ba4042840bed63c059b39057f18dcae3155899.camel@telenet.be

Artyom V. Poptsov schreef op do 13-01-2022 om 20:18 [+0300]:

Toggle quote (8 lines)

> [...]

> I suggest that we keep "#f" for tests unless the libtree author fix this

> behavior.

> For now I opened an issue for libtree:

> ��https://github.com/haampie/libtree/issues/65

Seems reasonable to me, though I would add a comment

;; See https://github.com/haampie/libtree/issues/65

next to the #:tests? #false such that the reasons won't be lost to

time.

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeBjSxccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7naeAQDSewgufeSRcEoMWHKP78/zDStd

ZWr+hEggQUFQaKzlQgD9G+CembadJ4rpRgtbFUxH85kIYvF49zNqzxiiRZa/6wg=

=ePWc

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 13 Jan 2022 18:51

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87r19bjzi1.fsf@gmail.com

Hello,

Toggle quote (7 lines)

> Seems reasonable to me, though I would add a comment

> ;; See <https://github.com/haampie/libtree/issues/65>

> next to the #:tests? #false such that the reasons won't be lost to

> time.

I added the comment.

- Artyom

From 8367850d181a221cdf71911022c767d466009c5d Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++

1 file changed, 37 insertions(+)

Toggle diff (54 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index da2ce602a7..07a64da679 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -60,6 +60,8 @@
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8789,3 +8791,38 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1j56j1k4rlm0wi6jvdmk7j7nf4wrmc5gyhgp6vjf180hpgwlqz92"))))
+    (arguments
+     (list #:tests? #f  ; See <https://github.com/haampie/libtree/issues/65>
+           #:make-flags
+           ;; NOTE: Official documentation recommends to build libtree with
+           ;; "-static" flag.
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   "PREFIX=/"
+                   (string-append "DESTDIR=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (delete 'configure)
+               (replace 'build
+                 (lambda* (#:key make-flags #:allow-other-keys)
+                   (apply invoke "make" make-flags))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "Show output of @command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Artyom V. Poptsov wrote on 17 Jan 2022 19:09

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87mtjujkt9.fsf@gmail.com

Hello,

meanwhile the libtree author fixed the tests in 3.0.2:

https://github.com/haampie/libtree/issues/65

So I've updated the patch to add libtree 3.0.2.

Thanks,

- Artyom

From 6a21b02af62ce27cedd1f3f02d47362b434616f7 Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++

1 file changed, 37 insertions(+)

Toggle diff (54 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 5f471beaaf..0a1e0d829b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -60,6 +60,8 @@
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8761,3 +8763,38 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb"))))
+    (arguments
+     (list #:tests? #t
+           #:make-flags
+           ;; NOTE: Official documentation recommends to build libtree with
+           ;; "-static" flag.
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   "PREFIX=/"
+                   (string-append "DESTDIR=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (delete 'configure)
+               (replace 'build
+                 (lambda* (#:key make-flags #:allow-other-keys)
+                   (apply invoke "make" make-flags))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "Show output of @command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 17 Jan 2022 20:02

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:b4910fd9166b93d64831b68536e7884a8d99673e.camel@telenet.be

Hi,

Artyom V. Poptsov schreef op ma 17-01-2022 om 21:09 [+0300]:

Toggle quote (2 lines)

> +�� (list #:tests? #t

Tests can almost never be run when cross-compiling,

so this needs to be #false when cross-compiling. �This should

be detected by the 'tests-true' linter. �I suggest removing '#:tests?

#t’.

Toggle quote (4 lines)

> +�� #~(list (string-append "CC=" #$(cc-for-target))

> +�� "PREFIX=/"

> +�� (string-append "DESTDIR=" #$output))

Guix doesn't do staged installation
(https://www.gnu.org/software/automake/manual/html_node/DESTDIR.html).
Doing (string-append "PREFIX=" $output) and dropping DESTDIR=... should
suffice.

Greetings,
Maxime

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeW9NRccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kXfAQDvj51ptZjsvYLqYZlnNlr6SPGk

Vdq5HDueVB5vbgClqwD/aYMae62Ps4PLwI8+bQbbjAHcFGDVpJCGyiIybjIJSAE=

=znuF

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 17 Jan 2022 20:14

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87iluijhtr.fsf@gmail.com

Hello,

Toggle quote (2 lines)

> I suggest removing '#:tests?

Okay, done.

Toggle quote (2 lines)

> Guix doesn't do staged installation

Unfortunately it seems to me that libtree fails when I remove

'(string-append "DESTDIR=" #$output)' from the make flags.

The reason is this code from libtree Makefile:

Toggle snippet (7 lines)

install: all

mkdir -p $(DESTDIR)$(BINDIR)

cp -p libtree $(DESTDIR)$(BINDIR)

mkdir -p $(DESTDIR)$(SHAREDIR)/man/man1

cp -p doc/libtree.1 $(DESTDIR)$(SHAREDIR)/man/man1

As you can see it's using 'DESTDIR' as prefix for the installation.

- Artyom

From 1808690c43044fdd9340c75c6d726a5f71dd8c64 Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

Toggle diff (53 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 5f471beaaf..a68f35ebf0 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -60,6 +60,8 @@
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8761,3 +8763,37 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb"))))
+    (arguments
+     (list #:make-flags
+           ;; NOTE: Official documentation recommends to build libtree with
+           ;; "-static" flag.
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   "PREFIX=/"
+                   (string-append "DESTDIR=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (delete 'configure)
+               (replace 'build
+                 (lambda* (#:key make-flags #:allow-other-keys)
+                   (apply invoke "make" make-flags))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "Show output of @command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 17 Jan 2022 20:22

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:b9ed068a0dbfb3c9798e2846473bfc27dda0b710.camel@telenet.be

Hi,

Artyom V. Poptsov schreef op ma 17-01-2022 om 22:14 [+0300]:

Toggle quote (18 lines)> [...]
> > Guix doesn't do staged installation
> 
> Unfortunately it seems to me that libtree fails when I remove
> '(string-append "DESTDIR=" #$output)' from the make flags.
> 
> The reason is this code from libtree Makefile:
> 
> --8<---------------cut here---------------start------------->8---
> install: all
> 	mkdir -p $(DESTDIR)$(BINDIR)
> 	cp -p libtree $(DESTDIR)$(BINDIR)
> 	mkdir -p $(DESTDIR)$(SHAREDIR)/man/man1
> 	cp -p doc/libtree.1 $(DESTDIR)$(SHAREDIR)/man/man1
> --8<---------------cut here---------------end--------------->8---
> 
> As you can see it's using 'DESTDIR' as prefix for the installation.

SHAREDIR is set to $(PREFIX)/share in the Makefile.

It seems to work for me, the attached package definition builds

and the store item has a man page and a binary.

Greetings,

Maxime.

(use-modules (guix packages) (guix) (guix git-download) (guix build-system gnu) ((guix licenses) #:prefix license:)) (define-public libtree (package (name "libtree") (version "3.0.2") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/haampie/libtree") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb")))) (arguments (list #:make-flags ;; NOTE: Official documentation recommends to build libtree with ;; "-static" flag. #~(list (string-append "CC=" #$(cc-for-target)) (string-append "PREFIX=" #$output)) #:phases #~(modify-phases %standard-phases (delete 'configure) (replace 'build (lambda* (#:key make-flags #:allow-other-keys) (apply invoke "make" make-flags)))))) (build-system gnu-build-system) (home-page "https://github.com/haampie/libtree") (synopsis "Show output of @command{ldd} as a tree") (description "This tool turns @command{ldd} into a tree and explains how shared libraries are found or why they cannot be located.") (license license:expat))) libtree

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeXCExccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hxRAP4jExD4FAtUPpQTAeAsnFg8PHWF

RWkWycZKd2JfEiXbbgEA0I59TSt/rUKqxgargwwVsdqiB5a8luqVeKc/d+o1kgs=

=YBWU

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 28 Jan 2022 19:30

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87zgnfg1c2.fsf@gmail.com

Hello,

sorry for bugging you but are there any problems left with the package

that I should solve? As far as I understand now the package is fine and

can be merged to Guix. Am I mistaken?

Thanks!

- Artyom

Artyom "avp" Poptsov <poptsov.artyom@gmail.com>

Home page: https://memory-heap.org/~avp/

CADR Hackerspace co-founder: https://cadrspace.ru/

GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 28 Jan 2022 19:54

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:3c3cc605d110d977d10b0e7ed7d6f17d3af89f29.camel@telenet.be

Artyom V. Poptsov schreef op vr 28-01-2022 om 21:30 [+0300]:

Toggle quote (6 lines)

> Hello,

> sorry for bugging you but are there any problems left with the package

> that I should solve? As far as I understand now the package is fine and

> can be merged to Guix. Am I mistaken?

As I wrote in https://issues.guix.gnu.org/52472#12, setting DESTDIR
is unnecessary. �I haven't seen a revised patch not setting DESTDIR.
Aside from that, the patch looks reasonable.  However, I didn't look at
all the source code (for hash mismatches etc.).

Greetings,
Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYfQ72BccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jt9AP9FRp6cPcnwxWMHK8xZ4ALGSHRp

g8ym2vTXEEdL/RLRVQD/b81UuN5WF1WnlLKdwQokwR3RQHt89DE0kaNrGVqizAU=

=K4mF

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 4 Feb 2022 19:25

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87v8xufq0x.fsf@gmail.com

Hello Maxime!

I think I figured out how to properly remove DESTDIR setting in my

libtree patch.

Please find the updated patch attached.

- Artyom

From d481bf6df007e75df0fec118eadc448ac3f4af5a Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++

1 file changed, 35 insertions(+)

Toggle diff (52 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7df64bbdae..eea2fea59b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -60,6 +60,8 @@
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8830,3 +8832,36 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb"))))
+    (arguments
+     (list #:make-flags
+           ;; NOTE: Official documentation recommends to build libtree with
+           ;; "-static" flag.
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (delete 'configure)
+               (replace 'build
+                 (lambda* (#:key make-flags #:allow-other-keys)
+                   (apply invoke "make" make-flags))))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "Show output of @command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 4 Feb 2022 20:19

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:1d4a8ba63e8a9a6c76fc8c4b3999e6695644da48.camel@telenet.be

Artyom V. Poptsov schreef op vr 04-02-2022 om 21:25 [+0300]:

Toggle quote (7 lines)

> Hello Maxime!

> I think I figured out how to properly remove DESTDIR setting in my

> libtree patch.

> Please find the updated patch attached.

Unless libtree's Makefile doesn't support parallel compilation,

replacing the build phase has now become unnecessary, right?

The attached simplified package definition builds succesfully for me.

The patch seems to be ready now, I believe?

Greetings,

Maxime (not a committer)

(use-modules (guix packages) (guix build-system gnu) (guix utils) (guix git-download) ((guix licenses) #:prefix license:)(guix gexp)) (define-public libtree (package (name "libtree") (version "3.0.2") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/haampie/libtree") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb")))) (arguments (list #:make-flags ;; NOTE: Official documentation recommends to build libtree with ;; "-static" flag. #~(list (string-append "CC=" #$(cc-for-target)) (string-append "PREFIX=" #$output)) #:phases #~(modify-phases %standard-phases (delete 'configure)))) (build-system gnu-build-system) (home-page "https://github.com/haampie/libtree") (synopsis "Show output of @command{ldd} as a tree") (description "This tool turns @command{ldd} into a tree and explains how shared libraries are found or why they cannot be located.") (license license:expat))) libtree

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYf18KhccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uUtAPwOE2qQJDZMran4ONyOfcVjFEeg

y2SYKdbn+EsKeAvSOAD/YE2bARPrfue/swdXkh0SABfCL/BxtKqtVilL9gu6OgA=

=frt+

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 5 Feb 2022 06:50

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87r18hg8v1.fsf@gmail.com

Hello Maxime,

sorry but libtree refuses to build when I use your patch instead of mine:

Toggle snippet (8 lines)

$ ./pre-inst-env guix build libtree --check --no-offload

;;; note: source file /home/avp/src/dist/guix/gnu/packages/linux.scm

;;; newer than compiled /home/avp/src/dist/guix/gnu/packages/linux.go

The following derivation will be built:

/gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv

guix build: error: some outputs of `/gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv' are not valid, so checking is not possible

Toggle quote (2 lines)

> The patch seems to be ready now, I believe?

Are you asking me or the Guix community? If you're asking me, I think

that since libtree builds and runs OK with my last patch it is ready for

the merge.

But I'd love to hear feedback from the community as well; if someone

find another flaw in the patch I'll try to fix it.

Thanks,

- Artyom

Artyom "avp" Poptsov <poptsov.artyom@gmail.com>

Home page: https://memory-heap.org/~avp/

CADR Hackerspace co-founder: https://cadrspace.ru/

GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F

Maxime Devos wrote on 5 Feb 2022 11:56

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:abe48feccca50344ed43396100d3108b474cb24f.camel@telenet.be

Artyom V. Poptsov schreef op za 05-02-2022 om 08:50 [+0300]:

Toggle quote (15 lines)> sorry but libtree refuses to build when I use your patch instead of
> mine:
> 
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build libtree --check --no-offload
> ;;; note: source file /home/avp/src/dist/guix/gnu/packages/linux.scm
> ;;;������ newer than compiled
> /home/avp/src/dist/guix/gnu/packages/linux.go
> The following derivation will be built:
> �� /gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv
> guix build: error: some outputs of
> `/gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv' are
> not valid, so checking is not possible
> --8<---------------cut here---------------end--------------->8---

I've seen this before (for something non-libtree), IIUC you can only
run '--check' after it has been built (or substituted) for the first
time.

Greetings,
Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYf5X5hccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nFsAP4xcrsDKRBsnsFvxfgXeWRRRKWX

KCexNBJBE3j6SVSIwQD/cxjLHREyYhg4O5UaWRabcr6l3A0+LTdgAq8IMvCPDgM=

=+D0G

-----END PGP SIGNATURE-----

Artyom V. Poptsov wrote on 5 Feb 2022 12:34

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)

Message-ID:87mtj5fsx7.fsf@gmail.com

Hello Maxime!

Toggle quote (4 lines)

> I've seen this before (for something non-libtree), IIUC you can only

> run '--check' after it has been built (or substituted) for the first

> time.

Thanks for pointing that out, I overlooked this little detail somehow.

When I removed '--check' from Guix options it built libtree without

errors with your version of the patch.

Please find the updated patch attached.

- Artyom

From 44971155b6b7d05e4d9b052b5ffc02022f3a97e9 Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (libtree): New variable.

---

gnu/packages/linux.scm | 32 ++++++++++++++++++++++++++++++++

1 file changed, 32 insertions(+)

Toggle diff (49 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7df64bbdae..da3ee63e12 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -60,6 +60,8 @@
 ;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
 ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8830,3 +8832,33 @@ older system-wide @file{/sys} interface.")
     (license (list license:lgpl2.1+   ;; libgpiod
                    license:gpl2+      ;; gpio-tools
                    license:lgpl3+)))) ;; C++ bindings
+
+(define-public libtree
+  (package
+    (name "libtree")
+    (version "3.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/haampie/libtree")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb"))))
+    (arguments
+     (list #:make-flags
+           ;; NOTE: Official documentation recommends to build libtree with
+           ;; "-static" flag.
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (delete 'configure))))
+    (build-system gnu-build-system)
+    (home-page "https://github.com/haampie/libtree")
+    (synopsis "Show output of @command{ldd} as a tree")
+    (description
+     "This tool turns @command{ldd} into a tree and explains how shared
+libraries are found or why they cannot be located.")
+    (license license:expat)))
-- 
2.25.1

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Ludovic Courtès wrote on 9 Mar 2022 23:06

Re: bug#52472: [PATCH] gnu: Add libtree

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:87a6dy3hms.fsf_-_@gnu.org

Hi Artyom and all,

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

Toggle quote (2 lines)

> * gnu/packages/linux.scm (libtree): New variable.

Finally applied.

Thanks you and thanks everyone for reviewing!

Ludo’.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 52472@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 52472

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date