Shell: error when -m manifest is removed

Hi guix,

Using latest guix, and considering a local manifest.scm file

with only

(specifications->manifest (list "python"))

Following command works

guix shell --container -m manifest.scm -- python3

But

guix shell --container -- python3

gives an error. However,

guix shell --container

followed by

python3

works.

So, by just removing the ’-m manifest.scm’ flag, I get an error.

Regards,

Cayetano Santos

Hi,

On Tue, 7 Dec 2021 at 09:41, Cayetano Santos via Bug reports for GNU

Guix <bug-guix@gnu.org> wrote:

It works correctly for me. With Guix f43a783:

Cheers,

simon

Problem is

guix shell -C -- python3

Tried after ’guix pull’ and problem remains.

C.

Hi,

On Tue, 7 Dec 2021 at 11:10, Cayetano Santos

<cayetano.santos@inventati.org> wrote:

Which revision do you use? Because using f43a783, it fails as expected. :-)

Are you running Guix on foreign distro or Guix System?

Cheers,

simon

I’m using guix 05deb26.

Is it expected to fail when I remove the ’-m manifest’ flag and I

just run ’guix shell -C -- python3’ ?

Foreign, on top of ArchLinux.

C.

Hi,

On Tue, 7 Dec 2021 at 11:25, Cayetano Santos

<cayetano.santos@inventati.org> wrote:

The command "guix shell -C -- python3" fails. It cannot work, because

the environment (new shell) is empty. You need to provide what this

shell has to contain, via command line package list or via manifest.

Cheers,

simon

To my understanding, in this blog entry

https://guix.gnu.org/en/blog/2021/from-guix-environment-to-guix-shell/

they claim that "guix shell automatically loads guix.scm or

manifest.scm, from the current directory"

No need to "-m manifest.scm", then.

C.

Cayetano Santos via Bug reports for GNU Guix schreef op di 07-12-2021

om 09:33 [+0100]:

What's the error message?

Greetings,

Maxime

Hi,

On Tue, 7 Dec 2021 at 11:44, Cayetano Santos

<cayetano.santos@inventati.org> wrote:

Ah yes, sorry. Since I personally find implicit a bad thing, I have

forgotten about it. :-)

Anyway!

Indeed, there is a bug. It comes from 'stat:uid' vs 'getuid' in

'find-file-in-parent-directories'. On my machine, this

(= (stat:uid stat) (getuid))

compares 0 against 1001.

Cheers,

simon

Hi,

I am experiencing a similar situation without the container. At work,

I need some special Emacs packages, that I don't need/want in my normal

setup, so I do `guix shell -m manifest.scm -- emacs'. Even with the

directory added to the good noodles list, `guix shell -- emacs' fails,

probably because Guix assumes it has arguments when those really are

just the command to run. IOW the check for "when is implicit okay"

might be too narrow for this use case.

Cheers

On Tue, 7 Dec 2021 at 14:33, Liliana Marie Prikler

<liliana.prikler@ist.tugraz.at> wrote:

Similar root, I guess, described by https://issues.guix.gnu.org/52347#8:-)

Cheers,

simon

Am Dienstag, den 07.12.2021, 14:41 +0100 schrieb zimoun:

I am pretty sure all files are owned by the same user in my case. Can

stat:uid really return 0 then?

Hi,

On Tue, 7 Dec 2021 at 14:48, Liliana Marie Prikler

<liliana.prikler@ist.tugraz.at> wrote:

Maybe I am doing wrong but I just 'pk' in find-file-in-parent-directories. :-)

Cheers,

simon

Am Dienstag, den 07.12.2021, 15:27 +0100 schrieb zimoun:

You are doing wrong:

(if (or (not interactive?) ; true if giving -- COMMAND

disallow-implicit-load?

(options-contain-payload? opts))

So the pk in find-file-in-parent-directories should not even fire. I'm

pretty sure the interactive constraint has a reasoning that was

explained back then, so we should investigate carefully whether we want

to overthrow that. Warning, that noninteractive use of `guix shell'

requires an explicit manifest is also an option imo.

By the way, if we do search for a file, but find none, the warning

(warning (G_ "no packages specified; creating an empty environment~%"))

is displayed twice; once by auto-detect-manifest and once by guix-

environment*. We should probably change that string to something that

indicates that we've attempted to auto-load a manifest.

Cheers

Hi,

On Tue, 7 Dec 2021 at 17:23, Liliana Marie Prikler

<liliana.prikler@gmail.com> wrote:

Yes, indeed. I simply grepped "manifest" and looked at

'find-file-in-parent-directories', because if it is not called, the

"manifest" file cannot be loaded. :-) Then I incorrectly used the

wrong command line invokation. Bad day with a lot of inattentive

today. :-/

I am in favour to keep it explicit. (Personally, I already find that

"guix shell" is wrong ;-))

I agree.

Cheers,

simon

Output to ’guix shell --container -- python3’ gives

guix shell: avertissement : aucun paquet spécifié ; création d'un

environnement vide

guix shell: erreur : python3: command not found

Backtrace:

16 (primitive-load "/usr/local/bin/guix")

In guix/ui.scm:

2206:7 15 (run-guix . _)

2169:10 14 (run-guix-command _ . _)

In ice-9/boot-9.scm:

1752:10 13 (with-exception-handler _ _ #:unwind? _ # _)

1752:10 12 (with-exception-handler _ _ #:unwind? _ # _)

In guix/store.scm:

658:37 11 (thunk)

1320:8 10 (call-with-build-handler _ _)

1320:8 9 (call-with-build-handler #<procedure 7fbb1d6516f0 at

g…> …)

In guix/status.scm:

800:4 8 (call-with-status-report _ _)

In guix/scripts/environment.scm:

951:12 7 (_)

In guix/store.scm:

2119:24 6 (run-with-store #<store-connection 256.99

7fbb2132ccd0> …)

In guix/scripts/environment.scm:

627:17 5 (_ _)

576:23 4 (validate-exit-status _ _ 32512)

In guix/utils.scm:

954:4 3 (string-closest _ _ #:threshold _)

In guix/combinators.scm:

46:32 2 (fold2 #<procedure 7fbb10e14380 at

guix/utils.scm:954:…> …)

In ice-9/boot-9.scm:

1685:16 1 (raise-exception _ #:continuable? _)

1685:16 0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:

In procedure car: Wrong type argument in position 1 (expecting

pair): #f

Cayetano Santos schreef op di 07-12-2021 om 19:11 [+0100]:

Seems like suggest-command-name is passing #f to string-closest instead

of a list (a bug!).

Hi,

Cayetano Santos <cayetano.santos@inventati.org> skribis:

This particular issue was fixed in

16e9e538386bf30da690502c65b8053ff266e8cb.

Thanks,

Ludo’.

Hi Cayetano,

Cayetano Santos <cayetano.santos@inventati.org> skribis:

As Liliana noted, this is the intended behavior: auto-loading of

‘manifest.scm’ happens only for interactive use. This is to keep

non-interactive use context-independent and thereby avoid bad surprises.

Note that when ‘manifest.scm’ is auto-loaded, a message is printed; when

it’s not considered, no message is printed. Likewise, when creating an

empty environment, a warning is printed (twice even :-)).

Any suggestions on things we might improve to avoid confusion?

Thanks,

Ludo’.

merge 52347 53892

thanks

Hello Josselin!

Josselin Poiret <dev@jpoiret.xyz> writes:

Oh, I had missed it; thanks for pointing it out. I've merged the two

issues.

Thank you!

Maxim