[PATCH 1/2] gnu: register notcurses.scm in local.mk

  • Done
  • quality assurance status badge
Details
2 participants
  • Blake Shaw
  • Leo Famulari
Owner
unassigned
Submitted by
Blake Shaw
Severity
normal
Merged with
B
B
Blake Shaw wrote on 6 Dec 2021 20:00
(address . guix-patches@gnu.org)(name . Blake Shaw)(address . blake@nonconstructivism.com)
5ccbd4e534f4f6fcfb3f8c8814ad59e51377cb7a.1638817174.git.blake@nonconstructivism.com
---
gnu/local.mk | 1 +
1 file changed, 1 insertion(+)

Toggle diff (14 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index b91d6eaa62..54e6dd422d 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -422,6 +422,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/ninja.scm \
%D%/packages/node.scm \
%D%/packages/node-xyz.scm \
+ %D%/packages/notcurses.scm \
%D%/packages/noweb.scm \
%D%/packages/nss.scm \
%D%/packages/ntp.scm \
--
2.33.1
L
L
Leo Famulari wrote on 6 Dec 2021 20:24
(name . Blake Shaw via Guix-patches via)(address . guix-patches@gnu.org)
Ya5jW1UHFYVWcSmc@jasmine.lan
On Tue, Dec 07, 2021 at 02:00:01AM +0700, Blake Shaw via Guix-patches via wrote:
Toggle quote (14 lines)
> ---
> gnu/local.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index b91d6eaa62..54e6dd422d 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -422,6 +422,7 @@ GNU_SYSTEM_MODULES = \
> %D%/packages/ninja.scm \
> %D%/packages/node.scm \
> %D%/packages/node-xyz.scm \
> + %D%/packages/notcurses.scm \

Thanks! Remember, this should be done in the same commit as adding the
new file itself. Otherwise, the build of Guix would be broken in between
the two commits.
B
B
Blake Shaw wrote on 21 Dec 2021 21:37
(name . Leo Famulari)(address . leo@famulari.name)
87v8zhpudl.fsf@nonconstructivism.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (4 lines)
> Thanks! Remember, this should be done in the same commit as adding the
> new file itself. Otherwise, the build of Guix would be broken in between
> the two commits.

sorry Leo did you need me to rebase these commits before the package can
be merged?

--
“In girum imus nocte et consumimur igni”
L
L
Leo Famulari wrote on 21 Dec 2021 21:51
(name . Blake Shaw)(address . blake@nonconstructivism.com)
YcI+Vm54seBjzySY@jasmine.lan
On Wed, Dec 22, 2021 at 03:37:10AM +0700, Blake Shaw wrote:
Toggle quote (3 lines)
> sorry Leo did you need me to rebase these commits before the package can
> be merged?

Can you clarify what this patch is for?

It looks like ticket #52336 only registers a package module in
'gnu/local.mk', but the actual patch adding the module is missing:


I sent my earlier message assuming that there would also be a commit
adding notcurses.scm itself.
L
L
Leo Famulari wrote on 22 Dec 2021 00:23
(name . Blake Shaw)(address . blake@nonconstructivism.com)
YcJh5uEAqORWqLXT@jasmine.lan
On Tue, Dec 21, 2021 at 03:51:34PM -0500, Leo Famulari wrote:
Toggle quote (5 lines)
> It looks like ticket #52336 only registers a package module in
> 'gnu/local.mk', but the actual patch adding the module is missing:
>
> https://issues.guix.gnu.org/52336

Oh, I see. The other patch is #52335. I've merged the two tickets now.
L
L
Leo Famulari wrote on 22 Dec 2021 00:22
(no subject)
(address . control@debbugs.gnu.org)
YcJh0QvP4a/JssjY@jasmine.lan
merge 52335 52336
?