Rebased wip-pinebook-pro branch

  • Open
  • quality assurance status badge
Details
3 participants
  • Efraim Flashner
  • phodina
  • Vagrant Cascadian
Owner
unassigned
Submitted by
phodina
Severity
normal
P
P
phodina wrote on 11 Nov 2021 22:02
bOGpoTUJVqKP3U95E5b3BWzge1uPCA2M7df8JZR5Pe3JIxf060qsd3GmdZHGx7KLrk7NmSkvTIH_iFdpfUOgUfObqgHxBATE-niaCGxGaMw=@protonmail.com
Hi,

Thanks for the amazing work on Pinebook Pro!

Here are the patches rebased on linux-libre-5.10 on Guix master.

I also saw another issue regarding HW graphics support. [1]

Should I also rebase the changes from there?
Kind regards
Petr

Attachment: file
From 3d95877f01f4a31b07322ab81c4f89023a13fe10 Mon Sep 17 00:00:00 2001
From: Petr Hodina <phodina@protonmail.com>
Date: Thu, 11 Nov 2021 21:51:50 +0100
Subject: [PATCH 2/2] gnu: Add linux-libre-arm-pinebook-pro-5.10.

* gnu/packages/linux.scm (linux-libre-arm-pinebook-pro-5.10): New variable.

Toggle diff (34 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index d91d1fe4b6..2697b25b7e 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -53,6 +53,7 @@
;;; Copyright © 2021 B. Wilson <elaexuotee@wilsonb.com>
;;; Copyright © 2021 Ivan Gankevich <i.gankevich@spbu.ru>
;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1087,6 +1088,19 @@ (define-public linux-libre-arm-omap2plus-4.14
#:defconfig "omap2plus_defconfig"
#:extra-version "arm-omap2plus"))
+(define-public linux-libre-arm-pinebook-pro-5.10
+ (make-linux-libre* linux-libre-5.10-version
+ linux-libre-5.10-gnu-revision
+ (source-with-patches linux-libre-5.10-pristine-source
+ (append
+ %pinebook-pro-patches
+ (list
+ %boot-logo-patch
+ %linux-libre-arm-export-__sync_icache_dcache-patch)))
+ '("aarch64-linux")
+ #:defconfig "pinebook_pro_defconfig"
+ #:extra-version "pinebook-pro"))
+
(define-public linux-libre-arm64-generic
(make-linux-libre* linux-libre-version
linux-libre-gnu-revision
--
2.33.1
Attachment: 0001-gnu-Add-patches-for-pinebook-pro.patch
V
V
Vagrant Cascadian wrote on 12 Nov 2021 06:30
(address . phodina@protonmail.com)
874k8ic55q.fsf@ponder
On 2021-11-11, phodina@protonmail.com wrote:
Toggle quote (3 lines)
> Thanks for the amazing work on Pinebook Pro!
>
> Here are the patches rebased on linux-libre-5.10 on Guix master.
...
Toggle quote (2 lines)
> Should I also rebase the changes from there?

I stopped working on the wip-pinebook-pro branch in May 2021:

Pinebook Pro no longer WIP

All the features that seemed important were merged into guix's master
branch at that time, with only very small and minor patches to
linux-libre. I've since tested several other features, such as
NVMe. Some of the quirks seem to have gotten less bad over time, as
support has improved upstream.

I'm not sure it's worth adding a large patchset to support a 5.10.x
linux-libre kernel at this point... What features are missing from the
default kernel?

What guix master branch does lack is decent documentation for the
pinebook-pro; there is a system image configuration but I have not tried
it out so cannot speak to how well it works.


live well,
vagrant
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYY375AAKCRDcUY/If5cW
qmQnAQDIuX3hTVVdoMVbvc0+UdE6DYyccpuq6//LIXSrwwAmgAEA57x0JcWieTeQ
gKmX6+B33B11tlDtlGVkV1I4l7sMJAI=
=Donw
-----END PGP SIGNATURE-----

E
E
Efraim Flashner wrote on 16 Nov 2021 20:20
Re: [bug#51775] Rebased wip-pinebook-pro branch
(name . Vagrant Cascadian)(address . vagrant@debian.org)
YZQEYApxBkDBOU8V@3900XT
On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
Toggle quote (30 lines)
> On 2021-11-11, phodina@protonmail.com wrote:
> > Thanks for the amazing work on Pinebook Pro!
> >
> > Here are the patches rebased on linux-libre-5.10 on Guix master.
> ...
> > Should I also rebase the changes from there?
>
> I stopped working on the wip-pinebook-pro branch in May 2021:
>
> Pinebook Pro no longer WIP
> https://lists.gnu.org/archive/html/guix-devel/2021-05/msg00032.html
>
> All the features that seemed important were merged into guix's master
> branch at that time, with only very small and minor patches to
> linux-libre. I've since tested several other features, such as
> NVMe. Some of the quirks seem to have gotten less bad over time, as
> support has improved upstream.
>
> I'm not sure it's worth adding a large patchset to support a 5.10.x
> linux-libre kernel at this point... What features are missing from the
> default kernel?
>
> What guix master branch does lack is decent documentation for the
> pinebook-pro; there is a system image configuration but I have not tried
> it out so cannot speak to how well it works.
>
>
> live well,
> vagrant

The pinebook pro boots from the SD card first if it's present, right? I
have one sitting next to me, I can take some time and build an image and
test it out.


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmGUBGAACgkQQarn3Mo9
g1GwEA//UUFR5ZZ9oRXSJ+QhcrAceJI0N8bN4YrubfjFECEsKGBDSoRjQ3uVTZ18
BlWCcDob+KVHXEn+1FSRDCHgxAFi7tL6zU/9ePN7UIMmO5vTVkfrtK435oDm7/iR
HbP9Z7qXHX0WWEIB9J1On+i0Zyl32m0Wu47u3diFrhCQwc/oibpo3m3UDFZtfiPh
4Pt8Ob44SL07T6CHrxiePjNVkMx8bIgKF9BgaY2SBzWyGV9DWtMJiNgTOgLbihw2
SC/td6SS/8hh558/6hl4hKd8mVLh2whaOg2SKBqu6noNSKsUmh48TfO4YajXr34Z
xZh15cnSz//jOfGcr8lWhwN9tYCVOoaHPO2tctfoV5oWfenjiBfA1O+56aNk0bSx
9nDTjHmlrkUaXmxoQYNeGEvI5U3yyxHhJm1Sdxl6QeLFc0Dgiefw4jAAhqgtVJAZ
0n+5vHphlp9K1YdXNJ3l78q5G+B53XmQc2Ttjku/wNXHKs6UtZ0KfFnaZZvtSckD
uN6ej60evoed1E+aknO4aJnC37/n9EPz6t8IbEM4Sg5EOvUHNLAdM2qaMpLo/6nX
ZoBHhPxblPua9wrtdhkfaRMCXRwsDWQrcARHVw0t4Uo8W2y1uz0b3hh8lJywCRMb
hVivHYlKkEzmctireE/1MdIM250Zm/B/4oJEkT65KR84AnoVS08=
=SZpC
-----END PGP SIGNATURE-----


V
V
Vagrant Cascadian wrote on 17 Nov 2021 00:22
(name . Efraim Flashner)(address . efraim@flashner.co.il)
87wnl7u1nc.fsf@ponder
On 2021-11-16, Efraim Flashner wrote:
Toggle quote (9 lines)
> On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
>> What guix master branch does lack is decent documentation for the
>> pinebook-pro; there is a system image configuration but I have not tried
>> it out so cannot speak to how well it works.

> The pinebook pro boots from the SD card first if it's present, right? I
> have one sitting next to me, I can take some time and build an image and
> test it out.

Pretty sure the hard-coded bootrom boot order is SPI -> eMMC -> microSD
-> ... other stuff

So it depends on what else you have installed. I've never installed
u-boot to SPI and yanked the eMMC to keep updates easier to fix when
regressions happen; the u-boot loaded from microSD boots off of NVMe
nicely...


live well,
vagrant
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZQ9KwAKCRDcUY/If5cW
qotsAQDhX/vA1scph9d7bkrDtxJg8DRJdHnWIRbb6H6kNizKXgEAl7jtwpd6KAKK
HsMK4O4SchwyUEuZAcNGlCzIorJryAE=
=KsKC
-----END PGP SIGNATURE-----

P
P
phodina wrote on 17 Nov 2021 11:38
(name . Vagrant Cascadian)(address . vagrant@debian.org)
ebtdae8w7C8V3JlhiSwMsenmkHojSGhFpkM0MhU-PtligCTVgy0-Dvza7V7j1kqE263UX_27Mfw79FcqjfEEFi9gVha4snMYECxmu2F9Rq4=@protonmail.com
Hi,

On Wednesday, November 17th, 2021 at 12:22 AM, Vagrant Cascadian <vagrant@debian.org> wrote:

Toggle quote (10 lines)
> On 2021-11-16, Efraim Flashner wrote:
>
> > On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
> >
> > > What guix master branch does lack is decent documentation for the
> > >
> > > pinebook-pro; there is a system image configuration but I have not tried
> > >
> > > it out so cannot speak to how well it works.

I've used the system image configuration the build image for my Pinebook Pro.

It works, though I experience issue when I reboot the system the output on the screen is just some garbage. It has to be turned off completely. Then after cold boot it displays everything properly.

So I started to investigate which patch I'm missing and found this wip-pinebook-pro branch.
Toggle quote (11 lines)
>
> > The pinebook pro boots from the SD card first if it's present, right? I
> >
> > have one sitting next to me, I can take some time and build an image and
> >
> > test it out.
>
> Pretty sure the hard-coded bootrom boot order is SPI -> eMMC -> microSD
>
> -> ... other stuff
>
Yes there is bootrom which launches the u-boot. I've updated mine to latest version and it let's me select, though boots first eMMC.

Toggle quote (12 lines)
> So it depends on what else you have installed. I've never installed
>
> u-boot to SPI and yanked the eMMC to keep updates easier to fix when
>
> regressions happen; the u-boot loaded from microSD boots off of NVMe
>
> nicely...
>
> live well,
>
> vagrant

So the way forward would be to check with mainline which patches are already accepted, right?

Also I agree it makes no sense to support 5.10 version of the kernel.

Petr
V
V
Vagrant Cascadian wrote on 17 Nov 2021 17:53
(name . phodina)(address . phodina@protonmail.com)
87ilwq9116.fsf@ponder
On 2021-11-17, phodina@protonmail.com wrote:
Toggle quote (16 lines)
> On Wednesday, November 17th, 2021 at 12:22 AM, Vagrant Cascadian <vagrant@debian.org> wrote:
>> On 2021-11-16, Efraim Flashner wrote:
>> > On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
>> > > What guix master branch does lack is decent documentation for the
>> > > pinebook-pro; there is a system image configuration but I have not tried
>> > > it out so cannot speak to how well it works.
>
> I've used the system image configuration the build image for my Pinebook Pro.
>
> It works, though I experience issue when I reboot the system the
> output on the screen is just some garbage. It has to be turned off
> completely. Then after cold boot it displays everything properly.
>
> So I started to investigate which patch I'm missing and found this
> wip-pinebook-pro branch.

I also experienced that behavior using wip-pinebook-pro back in the
day... so I don't think you'll find a solution there.


Toggle quote (5 lines)
> So the way forward would be to check with mainline which patches are
> already accepted, right?
>
> Also I agree it makes no sense to support 5.10 version of the kernel.

Sure, though I don't see any newer branches on:


Which is where the patches on wip-pinebook-pro came from...

So my guess is there hasn't been much activity unless someone else is
doing the upstreaming work.


live well,
vagrant

p.s. no need to encrypt messages to me when also sending the same
messages to the public bug tracker! :)
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZUzjAAKCRDcUY/If5cW
qt8bAP9lxzHio01JzjSUJusuZG87as0rWEIeb+/oNLxJxzRvYwD+IfoHN4PPx0JB
tHaZ3L91VmSL2EAw20e/aAvEmsnplgc=
=RsRg
-----END PGP SIGNATURE-----

V
V
Vagrant Cascadian wrote on 20 Nov 2021 06:21
Re: default tar format for "make dist" and patch file length
87tug7jtba.fsf@ponder
On 2021-11-19, Philip McGrath wrote:
Toggle quote (10 lines)
> On 11/19/21 09:54, Ludovic Courtès wrote:
>> Vagrant Cascadian <vagrant@debian.org> skribis:
>>> So, I guess I'm leaning towards making the guix lint check a little more
>>> lenient.
>>>
>>> Thoughts?
>>
>> That sounds even better, I’m all for it (changing (guix lint) + fixing
>> the two remaining issues)!

Submitted the guix lint change as https://issues.guix.gnu.org/51775


Toggle quote (8 lines)
> It might also help to change the warning given by the check.
>
> When a program called "lint" tells me that something is too long, I
> understand that to mean that what I've done is generally considered bad
> style, but there might be a very good reason to do it in some specific
> case. For example, I might exceed a line length guideline to avoid
> inserting linebreaks into a URL.

That's a good point!


Toggle quote (3 lines)
> If instead `guix lint` is telling us about a hard limit that will break
> things, I think it should say so clearly.

Not sure how to convey succinctly, but here's an attempt at a patch
(which ironically also probably makes the line a bit too long in the
code):

Toggle diff (31 lines)
diff --git a/guix/lint.scm b/guix/lint.scm
index ac2e7b3841..6464fb751a 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name)
max)
(make-warning
package
- (G_ "~a: file name is too long")
+ (G_ "~a: file name is too long and may break release tarball generation")
(list (basename patch))
#:field 'patch-file-names)
#f))
diff --git a/tests/lint.scm b/tests/lint.scm
index 9a91dd5426..d4c3d62aaf 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs
"hsab")
(test-equal "patches: file name too long"
(string-append "x-"
(make-string 100 #\a)
- ".patch: file name is too long")
+ ".patch: file name is too long and may break release tarball generation")
(single-lint-warning-message
(let ((pkg (dummy-package
"x"


live well,
vagrant
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZiF4AAKCRDcUY/If5cW
qn9WAP92Cl6vJuHzku/IkYq6KFUWRpy1SbqOCwjA14+9mGd75gD/R6K8y0aCBhMU
xLDWCkEfHluYfOyHwtVDl6SM1Ep//g4=
=aTkp
-----END PGP SIGNATURE-----

?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 51775@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 51775
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch