From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 20 00:21:52 2021 Received: (at 51775) by debbugs.gnu.org; 20 Nov 2021 05:21:52 +0000 Received: from localhost ([127.0.0.1]:41328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moIoy-0000vs-6C for submit@debbugs.gnu.org; Sat, 20 Nov 2021 00:21:52 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:48810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moIow-0000ve-87 for 51775@debbugs.gnu.org; Sat, 20 Nov 2021 00:21:50 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 06C051AA41; Fri, 19 Nov 2021 21:21:43 -0800 (PST) From: Vagrant Cascadian To: Philip McGrath , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: default tar format for "make dist" and patch file length In-Reply-To: <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87czmy8hr6.fsf@ponder> <87y25kjiwa.fsf@gnu.org> <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> Date: Fri, 19 Nov 2021 21:21:29 -0800 Message-ID: <87tug7jtba.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51775 Cc: guix-devel@gnu.org, 51775@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-19, Philip McGrath wrote: > On 11/19/21 09:54, Ludovic Court=C3=A8s wrote: >> Vagrant Cascadian skribis: >>> So, I guess I'm leaning towards making the guix lint check a little more >>> lenient. >>> >>> Thoughts? >>=20 >> That sounds even better, I=E2=80=99m all for it (changing (guix lint) + = fixing >> the two remaining issues)! Submitted the guix lint change as https://issues.guix.gnu.org/51775 > It might also help to change the warning given by the check. > > When a program called "lint" tells me that something is too long, I=20 > understand that to mean that what I've done is generally considered bad=20 > style, but there might be a very good reason to do it in some specific=20 > case. For example, I might exceed a line length guideline to avoid=20 > inserting linebreaks into a URL. That's a good point! > If instead `guix lint` is telling us about a hard limit that will break=20 > things, I think it should say so clearly. Not sure how to convey succinctly, but here's an attempt at a patch (which ironically also probably makes the line a bit too long in the code): diff --git a/guix/lint.scm b/guix/lint.scm index ac2e7b3841..6464fb751a 100644 =2D-- a/guix/lint.scm +++ b/guix/lint.scm @@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name) max) (make-warning package =2D (G_ "~a: file name is too long") + (G_ "~a: file name is too long and may break re= lease tarball generation") (list (basename patch)) #:field 'patch-file-names) #f)) diff --git a/tests/lint.scm b/tests/lint.scm index 9a91dd5426..d4c3d62aaf 100644 =2D-- a/tests/lint.scm +++ b/tests/lint.scm @@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs "hsab") (test-equal "patches: file name too long" (string-append "x-" (make-string 100 #\a) =2D ".patch: file name is too long") + ".patch: file name is too long and may break release tarb= all generation") (single-lint-warning-message (let ((pkg (dummy-package "x" live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZiF4AAKCRDcUY/If5cW qn9WAP92Cl6vJuHzku/IkYq6KFUWRpy1SbqOCwjA14+9mGd75gD/R6K8y0aCBhMU xLDWCkEfHluYfOyHwtVDl6SM1Ep//g4= =aTkp -----END PGP SIGNATURE----- --=-=-=--