[PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4.

---

While I was updating this, I renamed it to match the proper import path (so

the Go importer sees this package), and fixed those pesky D-Bus tests.

--

Sarah

gnu/packages/golang.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

The proper module name now includes "-v5" (see project's go.mod). Change

the variable/package name to help the Go importer find it.

(go-github-com-godbus-dbus-v5): ...this.

(go-github-com-zalando-go-keyring)[native-inputs]: Adjust accordingly.

---

gnu/packages/configuration-management.scm | 2 +-

gnu/packages/golang.scm | 6 +++---

2 files changed, 4 insertions(+), 4 deletions(-)

Disable system D-Bus tests. Fix session D-Bus tests by running them

within our own session.

snippet to disable system D-Bus tests.

[arguments]: Enable tests, override 'check phase to run tests within a

dbus session.

---

gnu/packages/golang.scm | 18 ++++++++++++++++--

1 file changed, 16 insertions(+), 2 deletions(-)

I was just working on another package that needs the current version of godbus-dbus, so thanks for this patch. I haven't yet built your version, but previously I had to disable tests that it looks like you fixed, great!

Hello,

I recently built this with these changes and updating to version 5.0.6 with hash 0d7740bjprd6mhs1wmhd53fb3kf61dz0hp1a0dda3dc28w2z84pp Builds successfully and works for a package I'm working on.

I'm not sure how much of a "review" this counts for exactly, but would be great to have this revived and pushed.

Thanks!

John

Hi Ludo’ and Nguy?n (and cc'ing Sarah from earlier patches),

On Fri, Oct 13, 2023 at 01:16 AM, Nguy?n Gia Phong wrote:

I haven't checked but this might need some fixing as based on an earlier

patch for updating godbus (I can't help but read this as "god bus") the

import name has changed. Though as an example chezmoi seems to have been

broken for some time anyway. Maybe the import-name doesn't need the v5?

See

and

https://issues.guix.gnu.org/50037.

The earlier patch also has fixes for the tests which would be good to

include now.

My apologies to Sarah as my original replies way back when only went to

the bug number (we should document this, easy beginner mistake!) and

once I became a committer this was on my list to update and push but I

didn't get around to it.

Nguy?n and/or Sarah would you like to submit a patch to change the

import path if needed, enable tests, and make any other changes? I could

also take a look if no one gets to it quickly.

Thanks to all on this updates!

John

PS: Looks like one extra signed-off-by tag made it through on a commit.

Oh well, glad I'm not the only one who's not perfect at these things!

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:

IIUC go-github-com-godbus-dbus is just a name for human consumption,

on the other hand I don't understand how it works without

the import-path matching the one in the go.mod file:

On 2021-08-13 at 20:49-07:00, Sarah Morgensen wrote in patchset 50037:

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:

As stated above, I don't quite understand how go packages work

(when they don't seem to be supposed to), so you two please go ahead.

(BTW you can call me by my given name Phong.)

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:

Yea DBus is short for Dieu Bus anyway.

Hi,

This patch series was used as base for:

- fa7de86cfc * gnu: go-github-com-zalando-go-keyring: Enable tests.

- 669dc9d906 * gnu: go-github-com-zalando-go-keyring: Update to 0.2.5.

- 7573464ede * gnu: go-github-com-gsterjov-go-libsecret: Improve package style.

- c32ae37272 * gnu: go-github-com-gsterjov-go-libsecret: Update to 0.0.0-20161001094733-a6f4afe4910c.

- d567987426 * gnu: go-github-com-godbus-dbus: Enable tests.

- 5bb0d4b0d6 * gnu: Add go-github-com-godbus-dbus-v5.

--

Oleg