Reverse my commits on GNOME meta-package

Raghav Gururajan wrote on 17 Feb 19:41 +0100

Recipients:(address . bug-guix@gnu.org)(address . dannym@scratchpost.org)

Message-ID:6bad163b0ed969c5c1117f9fa7446631060a8d4d.camel@disroot.org

Hello Guix!
@Danny
Could you please reverse my following commits:
1) d36fa50fbf8169018193774782fd21f1b13b9c0e
2) 7922b6f795eb575084546ec9bfb9d40508a9378e
3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
I will re-test throughly and re-commit them later. I also apologize forthe mishap.
Thank you!
Regards,RG.

Tobias Geerinckx-Rice wrote on 17 Feb 20:02 +0100

Recipients:(address . 39648@debbugs.gnu.org)

Message-ID:875zg56nq4.fsf@nckx

Raghav Gururajan 写道：

Toggle quote (10 lines)> Could you please reverse my following commits:>> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e>> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e>> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f>> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

Copy-pasted from #guix:
Whoa there, that's drastic, let's put that on hold.
The first two only add packages (did they break anything? what?), the third has no effect on packages if your commit message is accurate.
The fourth is the only one that removes packages, and even that might be better tweaked (this time: with comments noting what each non-core package brings to the GNOME table) than flat-out reverted.
What do you think?
Kind regards,
T G-R

Raghav Gururajan wrote on 17 Feb 20:09 +0100

Recipients:(name . Danny Milosavljevic)(address . dannym@scratchpost.org)

Message-ID:9f88fe4148c57c48b87206387daf8a7b9af84544.camel@disroot.org

Toggle quote (15 lines)> Copy-pasted from #guix:> > Whoa there, that's drastic, let's put that on hold.> > The first two only add packages (did they break anything? what?), > the third has no effect on packages if your commit message is > accurate.> > The fourth is the only one that removes packages, and even that > might be better tweaked (this time: with comments noting what each > non-core package brings to the GNOME table) than flat-out > reverted.> > What do you think?

I made a mistake of not reading comments of previous commits that weredone to gnome meta-package. Since we got lot of feedbacks regardinggnome experience, I will re-conyemplate my plans for gnome, make thechanges, test it throughly and then re-commit later.
Also, this reverse should be smooth and does not break anything. Itjust takes the GNOME meta-package back to the time before I startedmaking my commits to it.
Regards,RG.

Gábor Boskovits wrote on 17 Feb 20:19 +0100

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)

Message-ID:CAE4v=pjBVmuAawDHMJizh7nuBcXB72RcEdsS9mdnsMSsB4WgQA@mail.gmail.com

Hello Tobias,
Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>ezt írta (időpont: 2020. febr. 17., H, 20:03):

Toggle quote (16 lines)>> Raghav Gururajan 写道：> > Could you please reverse my following commits:> >> > 1) d36fa50fbf8169018193774782fd21f1b13b9c0e> >> > 2) 7922b6f795eb575084546ec9bfb9d40508a9378e> >> > 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f> >> > 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b>> Copy-pasted from #guix:>> Whoa there, that's drastic, let's put that on hold.

I agree.

Toggle quote (5 lines)

>> The first two only add packages (did they break anything? what?),> the third has no effect on packages if your commit message is> accurate.

These findings are accurate. I checked the diff of the third, it's ok.

Toggle quote (7 lines)

>> The fourth is the only one that removes packages, and even that> might be better tweaked (this time: with comments noting what each> non-core package brings to the GNOME table) than flat-out> reverted.>

I believe the fourth can be reverted if needed.

Toggle quote (7 lines)

> What do you think?>> Kind regards,>> T G-R

Best regards,g_bor-- OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

Raghav Gururajan wrote on 17 Feb 20:25 +0100

Recipients:

Message-ID:23882c4119d10b0ca3e41bc525c93683c8b47b97.camel@disroot.org

Toggle quote (2 lines)

> I believe the fourth can be reverted if needed.

Some packages that were removed, I made a mistake of not reading thecomments of why it were added in the first place. Some of them werenon-core and some were core but depracated. It gonna take some time forme to read and understand their exact role and effect on GNOMEexperience. Since I am planning+working on new changes anyway, I willstudy and test them throughly all together to see how the experience isand then commit them. :-)
Regards,RG.

Ludovic Courtès wrote on 22 Feb 17:52 +0100

control message for bug #39648

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87o8tqy36o.fsf@gnu.org

severity 39648 importantquit

Ludovic Courtès wrote on 22 Feb 17:52 +0100

control message for bug #39646

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87mu9ay36i.fsf@gnu.org

merge 39646 39648quit

Ludovic Courtès wrote on 22 Feb 18:08 +0100

Re: bug#39648: Reverse my commits on GNOME meta-package

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)

Message-ID:87ftf2y2gj.fsf@gnu.org

Hi Tobias & all!
Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (24 lines)> Raghav Gururajan 写道：>> Could you please reverse my following commits:>>>> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e>>>> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e>>>> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f>>>> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b>> Copy-pasted from #guix:>> Whoa there, that's drastic, let's put that on hold.>> The first two only add packages (did they break anything? what?), the> third has no effect on packages if your commit message is accurate.>> The fourth is the only one that removes packages, and even that might> be better tweaked (this time: with comments noting what each non-core> package brings to the GNOME table) than flat-out reverted.>> What do you think?

I agree. As a stop-gap measure, I propose to commit the followingchange real soon. I’ve tested it in a VM; it addresses the points Andyraised by re-adding the important bits mentioned inhttps://issues.guix.gnu.org/issue/39648.
Raghav, don’t worry, we all make mistakes! We can refine this calmlylater on.
Thanks,Ludo’.

Toggle diff (35 lines)diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scmindex 3c63ab283d..c64b182869 100644--- a/gnu/packages/gnome.scm+++ b/gnu/packages/gnome.scm@@ -7906,7 +7906,29 @@ world.")        ("yelp" ,yelp)      ;; Others        ("hicolor-icon-theme" ,hicolor-icon-theme)-       ("gnome-online-accounts" ,gnome-online-accounts)))+       ("gnome-online-accounts" ,gnome-online-accounts)++       ;; Packages not part of GNOME proper but that are needed for a good+       ;; experience.  See <https://bugs.gnu.org/39646>.+       ;; XXX: Find out exactly which ones are needed and why.+       ("font-cantarell"            ,font-cantarell)+       ("font-dejavu"               ,font-dejavu)+       ("at-spi2-core"              ,at-spi2-core)+       ("dbus"                      ,dbus)+       ("dconf"                     ,dconf)+       ("desktop-file-utils"        ,desktop-file-utils)+       ("gnome-default-applications" ,gnome-default-applications)+       ("gnome-themes-standard"     ,gnome-themes-standard)+       ("gst-plugins-base"          ,gst-plugins-base)+       ("gst-plugins-good"          ,gst-plugins-good)+       ("gucharmap"                 ,gucharmap)+       ("pinentry-gnome3"           ,pinentry-gnome3)+       ("pulseaudio"                ,pulseaudio)+       ("shared-mime-info"          ,shared-mime-info)+       ("system-config-printer"     ,system-config-printer)+       ("xdg-user-dirs"             ,xdg-user-dirs)+       ("yelp"                      ,yelp)+       ("zenity"                    ,zenity)))     (synopsis "The GNU desktop environment")     (home-page "https://www.gnome.org/")     (description

Raghav Gururajan wrote on 23 Feb 02:19 +0100

Recipients:

Message-ID:eda28ad9e1351279e8b9f916a070573a@disroot.org

Hi Ludo!

Toggle quote (5 lines)

> I agree. As a stop-gap measure, I propose to commit the following> change real soon. I’ve tested it in a VM; it addresses the points Andy> raised by re-adding the important bits mentioned in> <https://issues.guix.gnu.org/issue/39648>.

Sure, I can do that.

Toggle quote (3 lines)

> Raghav, don’t worry, we all make mistakes! We can refine this calmly> later on.

Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)
Regards,RG.

Ludovic Courtès wrote on 23 Feb 12:48 +0100

Recipients:(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)

Message-ID:87d0a5tthk.fsf@gnu.org

Hi,
"Raghav Gururajan" <raghavgururajan@disroot.org> skribis:

Toggle quote (12 lines)>> I agree. As a stop-gap measure, I propose to commit the following>> change real soon. I’ve tested it in a VM; it addresses the points Andy>> raised by re-adding the important bits mentioned in>> <https://issues.guix.gnu.org/issue/39648>.>> Sure, I can do that.>>> Raghav, don’t worry, we all make mistakes! We can refine this calmly>> later on.>> Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

OK, pushed as 9f2fef4fb164df81034c2b114292d836a9f6d4f8.
Thanks,Ludo’.

Closed

Your comment

This issue is archived.

To comment on this conversation send email to 39648@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date