Reverse my commits on GNOME meta-package

DoneSubmitted by Raghav Gururajan.
Details
4 participants
  • Gábor Boskovits
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
  • Raghav Gururajan
Owner
unassigned
Severity
important
Merged with
R
R
Raghav Gururajan wrote on 17 Feb 2020 19:41
(address . bug-guix@gnu.org)(address . dannym@scratchpost.org)
6bad163b0ed969c5c1117f9fa7446631060a8d4d.camel@disroot.org
Hello Guix!

@Danny

Could you please reverse my following commits:

1) d36fa50fbf8169018193774782fd21f1b13b9c0e

2) 7922b6f795eb575084546ec9bfb9d40508a9378e

3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f

4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

I will re-test throughly and re-commit them later. I also apologize for
the mishap.

Thank you!

Regards,
RG.
-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEamFiplxUWgy2NgJiorDiYAVcMdsFAl5K3lMACgkQorDiYAVc
MdtWlAf/fe54TgYjJE/t3SdcSQ8Iec4pB4Lp7YWgc2mInte7kdrP3bx+Hh7+PXZg
dJq4za6kUrQG3BeAyCeLKAUr6eOMGWzlcjHCN7LcDx5P1Z4hdoDzCqOURUCAasnZ
k83sUu/EjDlkQRxgZcafRsfEDT+j13B/sHDihsv4aXcWXLjjKQw+5PQVW4q27H4e
rnIpE/szAfh7POXSM/3scnoWVRywUhiqFRF7gUziuIuqF4/Xvn0EI/6yhjMOJkvm
crQxnLz6XDaE9He9pMmoG2wKsD8sKv7tKd964KNNbk1E1jnxmOPfnBNXxuQtUkdT
GG5GjNRVozn2sXqsjggbV1k4vG2xTQ==
=DrRB
-----END PGP SIGNATURE-----


T
T
Tobias Geerinckx-Rice wrote on 17 Feb 2020 20:02
(address . 39648@debbugs.gnu.org)
875zg56nq4.fsf@nckx
Raghav Gururajan 写道:
Toggle quote (10 lines)
> Could you please reverse my following commits:
>
> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
>
> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
>
> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
>
> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

Copy-pasted from #guix:

Whoa there, that's drastic, let's put that on hold.

The first two only add packages (did they break anything? what?),
the third has no effect on packages if your commit message is
accurate.

The fourth is the only one that removes packages, and even that
might be better tweaked (this time: with comments noting what each
non-core package brings to the GNOME table) than flat-out
reverted.

What do you think?

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5K42QACgkQ2Imw8BjF
STzfOg/+KE/zhM6mQuGcSYBebIGK/JoDBMbg5nYnAlFcTfy444OHu6OMsA5gp5HC
0QqkQytgIDdiPZWlBJAI2nfxFK+pP/JgWtkjA/QWas+tgHma+2hO7PMic9wwQ87K
nCVWlgXCeoc6Mn0l/K23tWReiWStzXDJlmBjLoxoDKdFpCDGbJNM27muLirRhSEL
HxJQ5+2BEM6x4gOVOGsLekb2fTuMlrAhwV80e4/iWkZ/Sn1kgBCbYElzMDDVKbfa
FHqSJ5aBcHIrGJXJCGsnr7YgdiDoqoiallzXLs7KVfWUphShBeMAx4wm1UgLZpDz
K0neRLsS4dzYhUIYCkurDYoDtbwrSwNBZa65svxLb5l2OvH0aJ7l2ASDh+1skrqO
a0MatlSmEMqdC7EYvI8aoPo//E9mc6NTA4GmVRoOvat2LZLX0ZJNCowdBE40oFM6
j4AOA1Zan5ZhT7u50s4nALZEslih5ol4NLMbcIWTTngnTPWVPD838dH7lxKMOtUo
xkMfme2z8Uk8Z/T/LG9/u7O/tRaZXu1GZTHqdOuh+YirWAg0PKIDjXIOanhE/jri
QBHnYCOTlWBkFdFu2cvSq8KqkeKbNREdNdoKpgToz/W8hukFgcf0XLAnlRbgOWNm
ITlVzCCHcu2U+6geqUGtGBj9cmmRnVS6SfOc/rzKhhmrz0jsGkI=
=RWjH
-----END PGP SIGNATURE-----

R
R
Raghav Gururajan wrote on 17 Feb 2020 20:09
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
9f88fe4148c57c48b87206387daf8a7b9af84544.camel@disroot.org
Toggle quote (15 lines)
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.
>
> The first two only add packages (did they break anything? what?),
> the third has no effect on packages if your commit message is
> accurate.
>
> The fourth is the only one that removes packages, and even that
> might be better tweaked (this time: with comments noting what each
> non-core package brings to the GNOME table) than flat-out
> reverted.
>
> What do you think?

I made a mistake of not reading comments of previous commits that were
done to gnome meta-package. Since we got lot of feedbacks regarding
gnome experience, I will re-conyemplate my plans for gnome, make the
changes, test it throughly and then re-commit later.

Also, this reverse should be smooth and does not break anything. It
just takes the GNOME meta-package back to the time before I started
making my commits to it.

Regards,
RG.
-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEamFiplxUWgy2NgJiorDiYAVcMdsFAl5K5NEACgkQorDiYAVc
Mdt0jwf/WtP/c8dfWDnZwlq4zxf6pOvHl+0vu3wTyUt8KCYIcx/NYXevT9j1ZlI8
WWPOnzq9A4vwFi2zZRiH+9MbLc08F9822kY2kShNuPU6dvTxyQ/OSHlJcJ1MwJ15
2shDXP3vu9vp20MFH4oPBiUTNZbDKOgCwrRhL50VAz0M0vLDwfil7aT4h5MM4Ju4
zgdp2AIc2VBr3AbE6gUdMHiBlHdydxf2jWZ3I5jKy+c27/8ljh1sbnet+8wMUpuI
c4QJjoKOPaiev/SwS7wC48GzDfPdzJ382I6EdzhgMylUeL8gebepUw6ZzkqO4+8S
q4nqi8K/9WajVOp9x9Ioi1PJ0JAfSg==
=HAAI
-----END PGP SIGNATURE-----


G
G
Gábor Boskovits wrote on 17 Feb 2020 20:19
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
CAE4v=pjBVmuAawDHMJizh7nuBcXB72RcEdsS9mdnsMSsB4WgQA@mail.gmail.com
Hello Tobias,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
ezt írta (időpont: 2020. febr. 17., H, 20:03):
Toggle quote (16 lines)
>
> Raghav Gururajan 写道:
> > Could you please reverse my following commits:
> >
> > 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
> >
> > 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
> >
> > 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
> >
> > 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.

I agree.

Toggle quote (5 lines)
>
> The first two only add packages (did they break anything? what?),
> the third has no effect on packages if your commit message is
> accurate.

These findings are accurate. I checked the diff of the third, it's ok.

Toggle quote (7 lines)
>
> The fourth is the only one that removes packages, and even that
> might be better tweaked (this time: with comments noting what each
> non-core package brings to the GNOME table) than flat-out
> reverted.
>

I believe the fourth can be reverted if needed.

Toggle quote (7 lines)
> What do you think?
>
> Kind regards,
>
> T G-R


Best regards,
g_bor
--
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21
R
R
Raghav Gururajan wrote on 17 Feb 2020 20:25
23882c4119d10b0ca3e41bc525c93683c8b47b97.camel@disroot.org
Toggle quote (2 lines)
> I believe the fourth can be reverted if needed.

Some packages that were removed, I made a mistake of not reading the
comments of why it were added in the first place. Some of them were
non-core and some were core but depracated. It gonna take some time for
me to read and understand their exact role and effect on GNOME
experience. Since I am planning+working on new changes anyway, I will
study and test them throughly all together to see how the experience is
and then commit them. :-)

Regards,
RG.
-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEamFiplxUWgy2NgJiorDiYAVcMdsFAl5K6LUACgkQorDiYAVc
MduPrAf/RhNBU1nxsvFZXYsTa0E4kBteBAKkG4g9TGTeZ2qXuT6hjyIF1OLr01z7
YviqIXccT6qndQQirWzF5J8/pugGZVijYHGhrPep3ZjkVTRpzS80dJo2ZSlpB6Vg
P5x+DNZvkdLqV0bn9tO0Fd4IbXtKRS4/dXL0oZaI5qpXg/DRxFhc2hmkEeaUapm1
6bTHr+4hcZwZnmS7RXb9CPC1sxdEHEoHsBShTuc8igQk1VJtVJIUkicfDT9sYvoP
7cMmkzy0BNyXuaee5GilI7Nxiq8qxL84gYGWGIkbWOopiRdxy9rrreqarizIJmE1
q9zxhX8kLi9OFcZ6Od792hReTX21uA==
=iwsV
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 22 Feb 2020 17:52
control message for bug #39648
(address . control@debbugs.gnu.org)
87o8tqy36o.fsf@gnu.org
severity 39648 important
quit
L
L
Ludovic Courtès wrote on 22 Feb 2020 17:52
control message for bug #39646
(address . control@debbugs.gnu.org)
87mu9ay36i.fsf@gnu.org
merge 39646 39648
quit
L
L
Ludovic Courtès wrote on 22 Feb 2020 18:08
Re: bug#39648: Reverse my commits on GNOME meta-package
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
87ftf2y2gj.fsf@gnu.org
Hi Tobias & all!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (24 lines)
> Raghav Gururajan 写道:
>> Could you please reverse my following commits:
>>
>> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
>>
>> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
>>
>> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
>>
>> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.
>
> The first two only add packages (did they break anything? what?), the
> third has no effect on packages if your commit message is accurate.
>
> The fourth is the only one that removes packages, and even that might
> be better tweaked (this time: with comments noting what each non-core
> package brings to the GNOME table) than flat-out reverted.
>
> What do you think?

I agree. As a stop-gap measure, I propose to commit the following
change real soon. I’ve tested it in a VM; it addresses the points Andy
raised by re-adding the important bits mentioned in

Raghav, don’t worry, we all make mistakes! We can refine this calmly
later on.

Thanks,
Ludo’.
Toggle diff (35 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3c63ab283d..c64b182869 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7906,7 +7906,29 @@ world.")
        ("yelp" ,yelp)
      ;; Others
        ("hicolor-icon-theme" ,hicolor-icon-theme)
-       ("gnome-online-accounts" ,gnome-online-accounts)))
+       ("gnome-online-accounts" ,gnome-online-accounts)
+
+       ;; Packages not part of GNOME proper but that are needed for a good
+       ;; experience.  See <https://bugs.gnu.org/39646>.
+       ;; XXX: Find out exactly which ones are needed and why.
+       ("font-cantarell"            ,font-cantarell)
+       ("font-dejavu"               ,font-dejavu)
+       ("at-spi2-core"              ,at-spi2-core)
+       ("dbus"                      ,dbus)
+       ("dconf"                     ,dconf)
+       ("desktop-file-utils"        ,desktop-file-utils)
+       ("gnome-default-applications" ,gnome-default-applications)
+       ("gnome-themes-standard"     ,gnome-themes-standard)
+       ("gst-plugins-base"          ,gst-plugins-base)
+       ("gst-plugins-good"          ,gst-plugins-good)
+       ("gucharmap"                 ,gucharmap)
+       ("pinentry-gnome3"           ,pinentry-gnome3)
+       ("pulseaudio"                ,pulseaudio)
+       ("shared-mime-info"          ,shared-mime-info)
+       ("system-config-printer"     ,system-config-printer)
+       ("xdg-user-dirs"             ,xdg-user-dirs)
+       ("yelp"                      ,yelp)
+       ("zenity"                    ,zenity)))
     (synopsis "The GNU desktop environment")
     (home-page "https://www.gnome.org/")
     (description
R
R
Raghav Gururajan wrote on 23 Feb 2020 02:19
eda28ad9e1351279e8b9f916a070573a@disroot.org
Hi Ludo!

Toggle quote (5 lines)
> I agree. As a stop-gap measure, I propose to commit the following
> change real soon. I’ve tested it in a VM; it addresses the points Andy
> raised by re-adding the important bits mentioned in
> <https://issues.guix.gnu.org/issue/39648>.

Sure, I can do that.

Toggle quote (3 lines)
> Raghav, don’t worry, we all make mistakes! We can refine this calmly
> later on.

Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

Regards,
RG.
L
L
Ludovic Courtès wrote on 23 Feb 2020 12:48
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
87d0a5tthk.fsf@gnu.org
Hi,

"Raghav Gururajan" <raghavgururajan@disroot.org> skribis:

Toggle quote (12 lines)
>> I agree. As a stop-gap measure, I propose to commit the following
>> change real soon. I’ve tested it in a VM; it addresses the points Andy
>> raised by re-adding the important bits mentioned in
>> <https://issues.guix.gnu.org/issue/39648>.
>
> Sure, I can do that.
>
>> Raghav, don’t worry, we all make mistakes! We can refine this calmly
>> later on.
>
> Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

OK, pushed as 9f2fef4fb164df81034c2b114292d836a9f6d4f8.

Thanks,
Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 39648@debbugs.gnu.org