[PATCH] system: Add btrfs-progs to %BASE-PACKAGES.

DoneSubmitted by Leo Famulari.
Details
3 participants
  • Brice Waegeneire
  • Jonathan Brielmaier
  • Leo Famulari
Owner
unassigned
Severity
normal
L
L
Leo Famulari wrote on 28 Jan 2020 23:26
(address . guix-patches@gnu.org)
1ca6544af3d10a72d2c6a6c7d7a12b67d887e104.1580250411.git.leo@famulari.name
* gnu/system.scm (%base-packages): Add btrfs-progs.
---
gnu/system.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/gnu/system.scm b/gnu/system.scm
index 01baa248a2..7cb6bef99d 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -586,7 +586,8 @@ of PROVENANCE-SERVICE-TYPE to its services."
          ;; already depends on it anyway.
          kmod eudev
 
-         e2fsprogs kbd
+         btrfs-progs e2fsprogs
+         kbd
 
          bash-completion
 
-- 
2.25.0
J
J
Jonathan Brielmaier wrote on 28 Jan 2020 23:42
(address . guix-patches@gnu.org)
47a29486-a557-b7f5-645b-382b39eee571@web.de
On 28.01.20 23:26, Leo Famulari wrote:
Toggle quote (2 lines)
> * gnu/system.scm (%base-packages): Add btrfs-progs.

This adds btrfs-progs, zstd and lzo to the closure with a total of
7.7MiB. So that doesn't seem to big. I'm just wondering if we need btrfs
support here at all, as I would call btrfs still kind of exotic apart
from *SUSE distros and Facebook's backend.
L
L
Leo Famulari wrote on 29 Jan 2020 00:14
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 39332@debbugs.gnu.org)
20200128231445.GA17331@jasmine.lan
On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
Toggle quote (5 lines)
> This adds btrfs-progs, zstd and lzo to the closure with a total of
> 7.7MiB. So that doesn't seem to big. I'm just wondering if we need btrfs
> support here at all, as I would call btrfs still kind of exotic apart
> from *SUSE distros and Facebook's backend.

Yeah, maybe it is too niche. I use it on all my machines but that's just
me. Let's wait to see if there are more comments before deciding.
B
B
Brice Waegeneire wrote on 29 Jan 2020 12:19
(name . Leo Famulari)(address . leo@famulari.name)
bb3bdaeccbfbb11aecd6a5ce124c9b7e@waegenei.re
On 2020-01-28 23:14, Leo Famulari wrote:
Toggle quote (11 lines)
> On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
>> This adds btrfs-progs, zstd and lzo to the closure with a total of
>> 7.7MiB. So that doesn't seem to big. I'm just wondering if we need
>> btrfs
>> support here at all, as I would call btrfs still kind of exotic apart
>> from *SUSE distros and Facebook's backend.
>
> Yeah, maybe it is too niche. I use it on all my machines but that's
> just
> me. Let's wait to see if there are more comments before deciding.

Maybe %base-packages is the wrong place to add it. But it should at
least be added to the system profile if a file-systems entry uses btrfs
which isn't the case as I recall.
L
L
Leo Famulari wrote on 8 Feb 2020 01:21
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 39332-done@debbugs.gnu.org)
20200208002145.GE12194@jasmine.lan
On Wed, Jan 29, 2020 at 11:19:18AM +0000, Brice Waegeneire wrote:
Toggle quote (15 lines)
> On 2020-01-28 23:14, Leo Famulari wrote:
> > On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
> > > This adds btrfs-progs, zstd and lzo to the closure with a total of
> > > 7.7MiB. So that doesn't seem to big. I'm just wondering if we need
> > > btrfs
> > > support here at all, as I would call btrfs still kind of exotic apart
> > > from *SUSE distros and Facebook's backend.
> >
> > Yeah, maybe it is too niche. I use it on all my machines but that's just
> > me. Let's wait to see if there are more comments before deciding.
>
> Maybe %base-packages is the wrong place to add it. But it should at least be
> added to the system profile if a file-systems entry uses btrfs which isn't
> the case as I recall.

You're right, that's a much better idea!
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 39332@debbugs.gnu.org