[PATCH] gnu: Add emacs-forge.

  • Done
  • quality assurance status badge
Details
4 participants
  • Brian Leung
  • Oleg Pykhalov
  • Kyle Meyer
  • Ludovic Courtès
Owner
unassigned
Submitted by
Oleg Pykhalov
Severity
normal
O
O
Oleg Pykhalov wrote on 10 Aug 2019 18:18
(address . guix-patches@gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20190810161809.4014-1-go.wigust@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-forge): New variable.
---
gnu/packages/emacs-xyz.scm | 79 ++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)

Toggle diff (92 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1681cecbcf..40618406b1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15789,6 +15789,85 @@ command\", but because it always involves at least two commands (a prefix and
a suffix) we prefer to call it just a \"transient\".")
(license license:gpl3+))))
+(define-public emacs-forge
+ (let ((commit "a60bd64056ec910fdbd1400dd8f583b8eec6145b"))
+ (package
+ (name "emacs-forge")
+ (version (git-version "0.1.0" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/magit/forge.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1dhpsnb82mxpv3krf3apsbcirlcizw3g9gac9sfn0fad20qjwpgj"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("texinfo" ,texinfo)
+ ("emacs" ,emacs-minimal)))
+ (propagated-inputs
+ `(("emacs-closql" ,emacs-closql)
+ ("emacs-dash" ,emacs-dash)
+ ("emacs-emacsql-sqlite" ,emacs-emacsql)
+ ("emacs-ghub" ,emacs-ghub)
+ ("emacs-let-alist" ,emacs-let-alist)
+ ("emacs-magit" ,emacs-magit)
+ ("emacs-markdown-mode" ,emacs-markdown-mode)
+ ("emacs-transient" ,emacs-transient)))
+ (arguments
+ `(#:tests? #f ;no tests
+ #:modules ((srfi srfi-26)
+ (guix build gnu-build-system)
+ ((guix build emacs-build-system) #:prefix emacs:)
+ (guix build utils)
+ (guix build emacs-utils))
+ #:imported-modules (,@%gnu-build-system-modules
+ (guix build emacs-build-system)
+ (guix build emacs-utils))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'install)
+ (add-after 'unpack 'delete-doc-targets
+ (lambda _
+ (substitute* "./Makefile"
+ (("lisp docs") "lisp"))))
+ (add-after 'delete-doc-targets 'emacs-set-emacs-load-path
+ (assoc-ref emacs:%standard-phases 'set-emacs-load-path))
+ (add-after 'emacs-set-emacs-load-path 'chdir-lisp
+ (lambda _
+ (chdir "lisp")))
+ (add-after 'chdir-lisp 'emacs-install
+ (assoc-ref emacs:%standard-phases 'install))
+ (add-after 'emacs-install 'emacs-make-autoloads
+ (assoc-ref emacs:%standard-phases 'make-autoloads))
+ (add-after 'build 'install-elc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (el-dir (string-append
+ out "/share/emacs/site-lisp/guix.d/forge-"
+ ,version)))
+ (for-each (cut install-file <> el-dir)
+ (find-files "." "\\.elc"))
+ #t)))
+ (add-after 'install-elc 'install-doc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (info (string-append out "/share/info")))
+ (with-directory-excursion "../docs"
+ (invoke "makeinfo" "forge.texi")
+ (install-file "forge.info" info)
+ #t)))))))
+ (home-page "https://github.com/magit/ghub/")
+ (synopsis "Access Git forges from Magit")
+ (description
+ "Work with Git forges, such as Github and Gitlab, from the comfort of
+Magit and the rest of Emacs.")
+ (license license:gpl3+))))
+
(define-public emacs-matcha
(let ((commit "c7df5cf5cdac9ae369e241342389ccda0205eab9"))
(package
--
2.22.0
B
B
Brian Leung wrote on 11 Aug 2019 19:39
CAAc=MExLy10n8RvUJ14bMU5qhTmgoJAsgoiNgy3x1J0iDi6diA@mail.gmail.com
Hi Oleg,

I notice that emacs-forge, in its forge-pkg.el file, mentions newer
dependencies than what we currently have: ghub version 20190319, which
apparently contains a fix for a relevant bug; and Magit version 20190408.
I'm not sure how important the update to Magit is, and this newer version
of Magit also happens to depend on an additional package, libegit2. It
might be nice to update our version of ghub.

Best,
Brian
Attachment: file
B
B
Brian Leung wrote on 14 Aug 2019 08:08
Re: [bug#36999] [PATCH] gnu: Add emacs-forge.
CAAc=MEyGTJ5rc1v_0rTXacx6ViXk6RUy-qVgwmj6b_pLarj8ng@mail.gmail.com
Hi Oleg,

I've made a patch off the latest master branch with a version of emacs-ghub
that should meet the requirements of emacs-forge.

Best,
Brian

On Sun, Aug 11, 2019 at 7:39 PM Brian Leung <bkleung89@gmail.com> wrote:

Toggle quote (12 lines)
> Hi Oleg,
>
> I notice that emacs-forge, in its forge-pkg.el file, mentions newer
> dependencies than what we currently have: ghub version 20190319, which
> apparently contains a fix for a relevant bug; and Magit version 20190408.
> I'm not sure how important the update to Magit is, and this newer version
> of Magit also happens to depend on an additional package, libegit2. It
> might be nice to update our version of ghub.
>
> Best,
> Brian
>
Attachment: file
From 8f7c7623743cf2b0bc06b9ae34bac7ac2b1e7994 Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Wed, 14 Aug 2019 08:04:20 +0200
Subject: [PATCH] gnu: emacs-ghub: Update to 3.2.0-1.7d59937.

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 3.2.0-1.7d59937.
---
gnu/packages/emacs-xyz.scm | 62 ++++++++++++++++++++------------------
1 file changed, 32 insertions(+), 30 deletions(-)

Toggle diff (78 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6e612cab56..23e5e09d2a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -521,39 +521,41 @@ deliver data to mobile and web apps.")
(license license:gpl3+)))
(define-public emacs-ghub
- (package
- (name "emacs-ghub")
- (version "3.2.0")
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/magit/ghub")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "0lp52qygyavddl1lrgsyb6mq7hcf9h89dy2pzya3mb2va49f0vvl"))))
- (build-system emacs-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'install 'make-info
- (lambda _
- (invoke "make" "info"))))))
- (native-inputs
- `(("texinfo" ,texinfo)))
- (propagated-inputs
- `(("dash" ,emacs-dash)
- ("graphql" ,emacs-graphql)
- ("treepy" ,emacs-treepy)))
- (home-page "https://github.com/magit/ghub")
- (synopsis "Emacs client libraries for the APIs of various Git forges")
- (description
- "Ghub provides basic support for using the APIs of various Git forges from
+ ;; We need a newer commit to avoid problems in emacs-forge.
+ (let ((commit "7d59937d7782d0062216130a4d059b45e8396f82")
+ (revision "1"))
+ (package
+ (name "emacs-ghub")
+ (version (git-version "3.2.0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/magit/ghub")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1ngb61nij9gznqplwg1fmr1vq1czry759hmdibzngl4wqhxpfsjq"))))
+ (build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'make-info
+ (lambda _
+ (invoke "make" "info"))))))
+ (native-inputs
+ `(("texinfo" ,texinfo)))
+ (propagated-inputs
+ `(("dash" ,emacs-dash)
+ ("treepy" ,emacs-treepy)))
+ (home-page "https://github.com/magit/ghub")
+ (synopsis "Emacs client libraries for the APIs of various Git forges")
+ (description
+ "Ghub provides basic support for using the APIs of various Git forges from
Emacs packages. It supports the REST APIs of Github, Github GraphQL, Gitlab,
Gitea, Gogs and Bitbucket. It abstracts access to API resources using only a
handful of functions that are not resource-specific.")
- (license license:gpl3+)))
+ (license license:gpl3+))))
(define-public emacs-scribble-mode
(let ((commit "34e9e5edb921813b6483e0fefa848efb6ee4b314")
--
2.22.0
O
O
Oleg Pyhalov wrote on 18 Aug 2019 11:26
(name . Brian Leung)(address . bkleung89@gmail.com)
874l2erfi6.fsf@majordomo.ru
Hi Brian,

Apologies for a delay with response.

Brian Leung <bkleung89@gmail.com> writes:

Toggle quote (5 lines)
> Hi Oleg,
>
> I've made a patch off the latest master branch with a version of emacs-ghub
> that should meet the requirements of emacs-forge.

Thank you!

[…]

Toggle quote (7 lines)
>> I notice that emacs-forge, in its forge-pkg.el file, mentions newer
>> dependencies than what we currently have: ghub version 20190319, which
>> apparently contains a fix for a relevant bug; and Magit version 20190408.
>> I'm not sure how important the update to Magit is, and this newer version
>> of Magit also happens to depend on an additional package, libegit2. It
>> might be nice to update our version of ghub.

Unfortunately Magit update is needed, because on a GitLab instance you
could list issues but not open them to take a look on a content.

New Magit requires https://github.com/magit/libegit2which I try to
build, but stuck. I succeeded to build ‘libgit2.so’ and load it in
Emacs, but ‘featurep’ procedure says that feature is not loaded.

I think we should not merge partially working emacs-forge.

Regards,
Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl1ZGcEACgkQFn+OpQAa
+pxotw/9EM40YMHKcYs23WSGyfiaBSuUobL6uXKdndUFSmcwXRhefATCGsIyCpTL
jO81E6uZZRPde5O2OTpha5AEHIElRqOpLqIkboRf5AAln9aSlSY+pQH60tDkST7j
KderilGuhek+W5Fcd5/oAR/9+65Bh3l/MtXFHl9PASD24XVKH22G96RCPtRPtHzw
CYsvbX7hLzhYlcl9fDQpTjkPcwckeFW6h3kLncn6wLJujxkBChWQjKQh7sUkzOhI
WQaw9KFo5wgWxfPd4nsB9Vwtowyxmvk8HejjpzN36QJY8CZsFsYIUu+B+NJjhbJ3
KHmUeIVsBenD2qH7oaQPu5f/mR+oUyZ5jrOHta7nFHEqeaURUocIWO9BiHg4r/4R
JUDf3XLgteYaXBhvCwjt94GjeUaZbb0OfwUUtfkEPd5tGhJwosEySuvgEuos5NQu
3C+lKLEuXZWAwoJ2490PNs2uUm5DO0EJtvKbGwMoX2ir6t70vtiEqlkRZuJFr37h
TNuNRpSXyzwnc6zdOavg9kUbsuXg+6YcvbBO5D9BF+6f9wIjtuThOX1jC/SWIR2n
GDbz/9NhMSLRT7AB8Pw9jH2HXsPHMKtZ/RLAT4YFXJP9hehfZ5ghi0YMAR74ntI0
6ChMuvMH/2fDr3Fu1RfNHBjNW83S9/JWvxqT6UzWN3SpGuuh248=
=pZW9
-----END PGP SIGNATURE-----

K
K
Kyle Meyer wrote on 18 Aug 2019 16:07
(address . 36999@debbugs.gnu.org)
87blwm4le3.fsf@kyleam.com
Hi Oleg,

Oleg Pyhalov <go.wigust@gmail.com> writes:

[...]

Toggle quote (4 lines)
> New Magit requires https://github.com/magit/libegit2which I try to
> build, but stuck. I succeeded to build ‘libgit2.so’ and load it in
> Emacs, but ‘featurep’ procedure says that feature is not loaded.

I haven't been following this thread closely, but in case it's useful:
Building Magit should work without libegit2 if you set
BUILD_MAGIT_LIBGIT to false.

--
Kyle
O
O
Oleg Pyhalov wrote on 18 Aug 2019 17:49
(name . Kyle Meyer)(address . kyle@kyleam.com)
87lfvqo4mu.fsf@majordomo.ru
Hi Kyle,

Kyle Meyer <kyle@kyleam.com> writes:

Toggle quote (10 lines)
> Hi Oleg,
>
> Oleg Pyhalov <go.wigust@gmail.com> writes:
>
> [...]
>
>> New Magit requires https://github.com/magit/libegit2 which I try to
>> build, but stuck. I succeeded to build ‘libgit2.so’ and load it in
>> Emacs, but ‘featurep’ procedure says that feature is not loaded.

I mean ‘libegit2.so’, apologies for a typo.

Toggle quote (4 lines)
> I haven't been following this thread closely, but in case it's useful:
> Building Magit should work without libegit2 if you set
> BUILD_MAGIT_LIBGIT to false.

Oh, nice. Apparently we could avoid libegit2 at all for now. I get a
working Forge by finding a commit in Magit which intoduced a procedure
required to open GitLab issue content.

I need a time to test Magit and Forge behavior for some days and could
merge it if no issues discovered. Latest patches attached here.
From 6f4ab7861321232c8786446904df4ffc53323bf9 Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Wed, 14 Aug 2019 08:04:20 +0200
Subject: [PATCH 1/3] gnu: emacs-ghub: Update to 3.2.0-1.7d59937.

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 3.2.0-1.7d59937.

Signed-off-by: Oleg Pykhalov <go.wigust@gmail.com>
---
gnu/packages/emacs-xyz.scm | 62 ++++++++++++++++++++------------------
1 file changed, 32 insertions(+), 30 deletions(-)

Toggle diff (78 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index adab7d87d2..82c811a2d6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -521,39 +521,41 @@ deliver data to mobile and web apps.")
(license license:gpl3+)))
(define-public emacs-ghub
- (package
- (name "emacs-ghub")
- (version "3.2.0")
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/magit/ghub")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "0lp52qygyavddl1lrgsyb6mq7hcf9h89dy2pzya3mb2va49f0vvl"))))
- (build-system emacs-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'install 'make-info
- (lambda _
- (invoke "make" "info"))))))
- (native-inputs
- `(("texinfo" ,texinfo)))
- (propagated-inputs
- `(("dash" ,emacs-dash)
- ("graphql" ,emacs-graphql)
- ("treepy" ,emacs-treepy)))
- (home-page "https://github.com/magit/ghub")
- (synopsis "Emacs client libraries for the APIs of various Git forges")
- (description
- "Ghub provides basic support for using the APIs of various Git forges from
+ ;; We need a newer commit to avoid problems in emacs-forge.
+ (let ((commit "7d59937d7782d0062216130a4d059b45e8396f82")
+ (revision "1"))
+ (package
+ (name "emacs-ghub")
+ (version (git-version "3.2.0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/magit/ghub")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1ngb61nij9gznqplwg1fmr1vq1czry759hmdibzngl4wqhxpfsjq"))))
+ (build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'make-info
+ (lambda _
+ (invoke "make" "info"))))))
+ (native-inputs
+ `(("texinfo" ,texinfo)))
+ (propagated-inputs
+ `(("dash" ,emacs-dash)
+ ("treepy" ,emacs-treepy)))
+ (home-page "https://github.com/magit/ghub")
+ (synopsis "Emacs client libraries for the APIs of various Git forges")
+ (description
+ "Ghub provides basic support for using the APIs of various Git forges from
Emacs packages. It supports the REST APIs of Github, Github GraphQL, Gitlab,
Gitea, Gogs and Bitbucket. It abstracts access to API resources using only a
handful of functions that are not resource-specific.")
- (license license:gpl3+)))
+ (license license:gpl3+))))
(define-public emacs-scribble-mode
(let ((commit "34e9e5edb921813b6483e0fefa848efb6ee4b314")
--
2.22.1
From 1fa9f804e62aadcd693aac2edf17ae65bc8f2544 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 14 Aug 2019 23:12:48 +0300
Subject: [PATCH 2/3] gnu: emacs-magit: Update to 2.90.1-1.c761d28.

* gnu/packages/emacs-xyz.scm (emacs-magit): Update to 2.90.1-1.c761d28.
---
gnu/packages/emacs-xyz.scm | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)

Toggle diff (40 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 82c811a2d6..b483f42032 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -262,21 +262,28 @@ on stdout instead of using a socket as the Emacsclient does.")
(license license:gpl3+)))
(define-public emacs-magit
- ;; Version 2.90.1 has trouble loading the transient library,
- ;; so we use a more recent commit that fixes it.
- (let ((commit "b4aec016b5577afa8d889f258b499814d1bb1d94"))
+ ;; `magit-setup-buffer' macro introduced in c761d28d and required in
+ ;; `emacs-forge'.
+ (let ((commit "c761d28d49e5238037512b898db0ec9b40d85770"))
(package
(name "emacs-magit")
(version (git-version "2.90.1" "1" commit))
(source (origin
(method git-fetch)
(uri (git-reference
- (url "https://github.com/magit/magit")
+ (url "https://github.com/magit/magit.git")
(commit commit)))
(file-name (git-file-name name version))
(sha256
(base32
- "0zl7v6z0y50pcgqsf2r8c1k3r5nwjad9ba7r6sgrnf4rc62br7jv"))))
+ "16qx0404l05q1m6w7y5j8ck1z5nfmpinm00w0p2yh1hn5zzwy6dd"))
+ (modules '((guix build utils)))
+ (snippet
+ '(begin
+ ;; Fix syntax error
+ (substitute* "lisp/magit-extras.el"
+ (("rev\\)\\)\\)\\)\\)\\)") "rev)))))"))
+ #t))))
(build-system gnu-build-system)
(native-inputs `(("texinfo" ,texinfo)
("emacs" ,emacs-minimal)))
--
2.22.1
From b3c501b00ba335ef9182ecfb1345b014feab9af3 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 10 Aug 2019 19:17:12 +0300
Subject: [PATCH 3/3] gnu: Add emacs-forge.

* gnu/packages/emacs-xyz.scm (emacs-forge): New variable.
---
gnu/packages/emacs-xyz.scm | 79 ++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)

Toggle diff (92 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b483f42032..d907ee5375 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15856,6 +15856,85 @@ command\", but because it always involves at least two commands (a prefix and
a suffix) we prefer to call it just a \"transient\".")
(license license:gpl3+))))
+(define-public emacs-forge
+ (let ((commit "a60bd64056ec910fdbd1400dd8f583b8eec6145b"))
+ (package
+ (name "emacs-forge")
+ (version (git-version "0.1.0" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/magit/forge.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1dhpsnb82mxpv3krf3apsbcirlcizw3g9gac9sfn0fad20qjwpgj"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("texinfo" ,texinfo)
+ ("emacs" ,emacs-minimal)))
+ (propagated-inputs
+ `(("emacs-closql" ,emacs-closql)
+ ("emacs-dash" ,emacs-dash)
+ ("emacs-emacsql-sqlite" ,emacs-emacsql)
+ ("emacs-ghub" ,emacs-ghub)
+ ("emacs-let-alist" ,emacs-let-alist)
+ ("emacs-magit" ,emacs-magit)
+ ("emacs-markdown-mode" ,emacs-markdown-mode)
+ ("emacs-transient" ,emacs-transient)))
+ (arguments
+ `(#:tests? #f ;no tests
+ #:modules ((srfi srfi-26)
+ (guix build gnu-build-system)
+ ((guix build emacs-build-system) #:prefix emacs:)
+ (guix build utils)
+ (guix build emacs-utils))
+ #:imported-modules (,@%gnu-build-system-modules
+ (guix build emacs-build-system)
+ (guix build emacs-utils))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'install)
+ (add-after 'unpack 'delete-doc-targets
+ (lambda _
+ (substitute* "./Makefile"
+ (("lisp docs") "lisp"))))
+ (add-after 'delete-doc-targets 'emacs-set-emacs-load-path
+ (assoc-ref emacs:%standard-phases 'set-emacs-load-path))
+ (add-after 'emacs-set-emacs-load-path 'chdir-lisp
+ (lambda _
+ (chdir "lisp")))
+ (add-after 'chdir-lisp 'emacs-install
+ (assoc-ref emacs:%standard-phases 'install))
+ (add-after 'emacs-install 'emacs-make-autoloads
+ (assoc-ref emacs:%standard-phases 'make-autoloads))
+ (add-after 'build 'install-elc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (el-dir (string-append
+ out "/share/emacs/site-lisp/guix.d/forge-"
+ ,version)))
+ (for-each (cut install-file <> el-dir)
+ (find-files "." "\\.elc"))
+ #t)))
+ (add-after 'install-elc 'install-doc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (info (string-append out "/share/info")))
+ (with-directory-excursion "../docs"
+ (invoke "makeinfo" "forge.texi")
+ (install-file "forge.info" info)
+ #t)))))))
+ (home-page "https://github.com/magit/ghub/")
+ (synopsis "Access Git forges from Magit")
+ (description
+ "Work with Git forges, such as Github and Gitlab, from the comfort of
+Magit and the rest of Emacs.")
+ (license license:gpl3+))))
+
(define-public emacs-matcha
(let ((commit "c7df5cf5cdac9ae369e241342389ccda0205eab9"))
(package
--
2.22.1
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl1Zc4kACgkQFn+OpQAa
+pw0gA/6A7+GEzNK8pdMa9YhxkhvLUAwDWn5kkRx7xnKhnxuJsUIZl8fdmvm/Si1
HKOaaUjynHuNYFkslx9k6LjBwK7d6IJ8qmVJ4JIEox/ZXeWo2fHknvsAimc9oiiM
NUTsns7XJdjLyjingbyy9G/avQDSvaiUFOQm8w9oA8xP5NhEClshVLwauevuLamz
k8g8dLPFNqwfP7I08cWei9oZScksuBsmX3GIldEVhTn4QwWp9o/YDihM8O1be4yt
NdbLQfsXORt0FvTNQ6XrNpt0JJzAzK8X8zbIe8LUagrxcXH6NIgbOj+0uTjeA8fA
ggf3vx/ca5Pz+G7gEhrXu1FIQQbxu47gyurL0oEMdv1ddeleUWZAaf2SquIDHoO1
1cCyCRLeXCqQZ2bBjiuQLFGeqgprO2Czk0TNJf8t8Ehdl83UebkaA5CJaCg+0Kdd
8fyytcw7EXkQFrxq1JIJJiw426IN3nAvsa2MaclAvveS8UzSXz3gwwvKhQdjB849
IsIQ0ogdLsGjlNfeeQHAeWGtONRkskMdmZY4V7vz//axy9rFTLrZaZ0aajLsBcSM
iIIQ8olHAS/53cTwKbA8WG01F28Nr2UDA2CwQwb/g/f4g2ftMsB+SBsO9LoiaIc9
p6QBlBO6kG3tSotoMhbCmQE7jN6i8pa1NduEXF8tEZnAJZU/Fu8=
=wT2i
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 10 Sep 2019 23:51
(name . Oleg Pyhalov)(address . go.wigust@gmail.com)
87ef0n252j.fsf@gnu.org
Hi Oleg,

Oleg Pyhalov <go.wigust@gmail.com> skribis:

Toggle quote (7 lines)
> Oh, nice. Apparently we could avoid libegit2 at all for now. I get a
> working Forge by finding a commit in Magit which intoduced a procedure
> required to open GitLab issue content.
>
> I need a time to test Magit and Forge behavior for some days and could
> merge it if no issues discovered. Latest patches attached here.

Did you have a chance to test them? Looks like you could probably push
these patches, no?


Thanks,
Ludo’.
O
O
Oleg Pykhalov wrote on 5 Oct 2019 21:19
[PATCH 0/4] More test and then merge to master
(address . 36999@debbugs.gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20191005191929.7356-1-go.wigust@gmail.com
Hi,

Apologies for a delay.

I have issue with a broken magit ‘magit-copy-buffer-revision’ procedure and
then the forge broked after Emacs upgrade to 26.3. I've fixed both issues and
need more time for test before pushing to master.

Oleg Pykhalov (4):
gnu: emacs-magit: Update to 2.90.1-1.c761d28.
gnu: emacs-ghub: Update to 3.2.0-1.cf0b13a.
gnu: emacs-closql: Update to 1.0.0-1.70b98db.
gnu: Add emacs-forge.

gnu/packages/emacs-xyz.scm | 235 ++++++++++++++++++++++++++++---------
1 file changed, 179 insertions(+), 56 deletions(-)

--
2.23.0
O
O
Oleg Pykhalov wrote on 5 Oct 2019 21:19
[PATCH 1/4] gnu: emacs-magit: Update to 2.90.1-1.c761d28.
(address . 36999@debbugs.gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20191005191929.7356-2-go.wigust@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-magit): Update to 2.90.1-1.c761d28.
[arguments]: Add patch phase.
---
gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++++++++++++++++++----
1 file changed, 45 insertions(+), 5 deletions(-)

Toggle diff (80 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index afa21ee19e..7044b92240 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -265,21 +265,28 @@ on stdout instead of using a socket as the Emacsclient does.")
(license license:gpl3+)))
(define-public emacs-magit
- ;; Version 2.90.1 has trouble loading the transient library,
- ;; so we use a more recent commit that fixes it.
- (let ((commit "b4aec016b5577afa8d889f258b499814d1bb1d94"))
+ ;; `magit-setup-buffer' macro introduced in c761d28d and required in
+ ;; `emacs-forge'.
+ (let ((commit "c761d28d49e5238037512b898db0ec9b40d85770"))
(package
(name "emacs-magit")
(version (git-version "2.90.1" "1" commit))
(source (origin
(method git-fetch)
(uri (git-reference
- (url "https://github.com/magit/magit")
+ (url "https://github.com/magit/magit.git")
(commit commit)))
(file-name (git-file-name name version))
(sha256
(base32
- "0zl7v6z0y50pcgqsf2r8c1k3r5nwjad9ba7r6sgrnf4rc62br7jv"))))
+ "16qx0404l05q1m6w7y5j8ck1z5nfmpinm00w0p2yh1hn5zzwy6dd"))
+ (modules '((guix build utils)))
+ (snippet
+ '(begin
+ ;; Fix syntax error
+ (substitute* "lisp/magit-extras.el"
+ (("rev\\)\\)\\)\\)\\)\\)") "rev)))))"))
+ #t))))
(build-system gnu-build-system)
(native-inputs `(("texinfo" ,texinfo)
("emacs" ,emacs-minimal)))
@@ -318,6 +325,39 @@ on stdout instead of using a socket as the Emacsclient does.")
#:phases
(modify-phases %standard-phases
+ (add-after 'unpack 'patch
+ (lambda _
+ (chmod "lisp/magit-extras.el" #o644)
+ (emacs-batch-edit-file "lisp/magit-extras.el"
+ `(progn (progn
+ (goto-char (point-min))
+ (re-search-forward "(defun magit-copy-buffer-revision ()")
+ (forward-sexp 2)
+ (kill-sexp)
+ (insert ,(format #f "~S"
+ '(if (use-region-p)
+ (copy-region-as-kill nil nil 'region)
+ (when-let ((rev (cl-case major-mode
+ ((magit-cherry-mode
+ magit-log-select-mode
+ magit-reflog-mode
+ magit-refs-mode
+ magit-revision-mode
+ magit-stash-mode
+ magit-stashes-mode)
+ (car magit-refresh-args))
+ ((magit-diff-mode magit-log-mode)
+ (let ((r (caar magit-refresh-args)))
+ (if (string-match "\\.\\.\\.?\\(.+\\)" r)
+ (match-string 1 r)
+ r)))
+ (magit-status-mode "HEAD"))))
+ (when (magit-commit-p rev)
+ (setq rev (magit-rev-parse rev))
+ (push (list rev default-directory) magit-revision-stack)
+ (kill-new (message "%s" rev))))))))
+ (basic-save-buffer)))
+ #t))
(delete 'configure)
(add-before
'build 'patch-exec-paths
--
2.23.0
O
O
Oleg Pykhalov wrote on 5 Oct 2019 21:19
[PATCH 2/4] gnu: emacs-ghub: Update to 3.2.0-1.cf0b13a.
(address . 36999@debbugs.gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20191005191929.7356-3-go.wigust@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 3.2.0-1.cf0b13a.
---
gnu/packages/emacs-xyz.scm | 62 ++++++++++++++++++++------------------
1 file changed, 32 insertions(+), 30 deletions(-)

Toggle diff (78 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7044b92240..807b0260cd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -564,39 +564,41 @@ deliver data to mobile and web apps.")
(license license:gpl3+)))
(define-public emacs-ghub
- (package
- (name "emacs-ghub")
- (version "3.2.0")
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/magit/ghub")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "0lp52qygyavddl1lrgsyb6mq7hcf9h89dy2pzya3mb2va49f0vvl"))))
- (build-system emacs-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'install 'make-info
- (lambda _
- (invoke "make" "info"))))))
- (native-inputs
- `(("texinfo" ,texinfo)))
- (propagated-inputs
- `(("dash" ,emacs-dash)
- ("graphql" ,emacs-graphql)
- ("treepy" ,emacs-treepy)))
- (home-page "https://github.com/magit/ghub")
- (synopsis "Emacs client libraries for the APIs of various Git forges")
- (description
- "Ghub provides basic support for using the APIs of various Git forges from
+ ;; We need a newer commit to avoid problems in emacs-forge.
+ (let ((commit "cf0b13aeba4df3798e49c205cac2d8fefd53a137")
+ (revision "1"))
+ (package
+ (name "emacs-ghub")
+ (version (git-version "3.2.0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/magit/ghub")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0fzayvcysk80vv4q332axcjf80x6gsnpcbl0svmpb017ii6wxhid"))))
+ (build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'make-info
+ (lambda _
+ (invoke "make" "info"))))))
+ (native-inputs
+ `(("texinfo" ,texinfo)))
+ (propagated-inputs
+ `(("dash" ,emacs-dash)
+ ("treepy" ,emacs-treepy)))
+ (home-page "https://github.com/magit/ghub")
+ (synopsis "Emacs client libraries for the APIs of various Git forges")
+ (description
+ "Ghub provides basic support for using the APIs of various Git forges from
Emacs packages. It supports the REST APIs of Github, Github GraphQL, Gitlab,
Gitea, Gogs and Bitbucket. It abstracts access to API resources using only a
handful of functions that are not resource-specific.")
- (license license:gpl3+)))
+ (license license:gpl3+))))
(define-public emacs-scribble-mode
(let ((commit "217945d54de5e4bb207033f2116baa28f5c5ecf2")
--
2.23.0
O
O
Oleg Pykhalov wrote on 5 Oct 2019 21:19
[PATCH 3/4] gnu: emacs-closql: Update to 1.0.0-1.70b98db.
(address . 36999@debbugs.gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20191005191929.7356-4-go.wigust@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-closql): Update to 1.0.0-1.70b98db.
---
gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++------------------
1 file changed, 23 insertions(+), 21 deletions(-)

Toggle diff (61 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 807b0260cd..c8f4af54ad 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11356,31 +11356,33 @@ object @code{nil} corresponds 1:1 with @code{NULL} in the database.")
(license license:gpl3+)))
(define-public emacs-closql
- (package
- (name "emacs-closql")
- (version "1.0.0")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/emacscollective/closql.git")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "1xhpfjjkjqfc1k2rj77cscclz5r7gpvv3hi202x178vdcpipjwar"))))
- (build-system emacs-build-system)
- (propagated-inputs
- `(("emacs-emacsql" ,emacs-emacsql)))
- (home-page "https://github.com/emacscollective/closql")
- (synopsis "Store EIEIO objects using EmacSQL")
- (description
- "This package allows to store uniform EIEIO objects in an EmacSQL
+ ;; Take a commit newer than 1.0.0 release because of Emacs upgrade to 26.3.
+ (let ((commit "70b98dbae53611d10a461d9b4a6f71086910dcef"))
+ (package
+ (name "emacs-closql")
+ (version (git-version "1.0.0" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacscollective/closql.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1wvhrihg663f61yzc7f0vha2abjdnlwbk0gjcwakdfk1bhwf5ikh"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-emacsql" ,emacs-emacsql)))
+ (home-page "https://github.com/emacscollective/closql")
+ (synopsis "Store EIEIO objects using EmacSQL")
+ (description
+ "This package allows to store uniform EIEIO objects in an EmacSQL
database. SQLite is used as backend. This library imposes some restrictions
on what kind of objects can be stored; it isn't intended to store arbitrary
objects. All objects have to share a common superclass and subclasses cannot
add any additional instance slots.")
- (license license:gpl3)))
+ (license license:gpl3))))
(define-public emacs-epkg
;; The release version is to old for the current database scheme.
--
2.23.0
O
O
Oleg Pykhalov wrote on 5 Oct 2019 21:19
[PATCH 4/4] gnu: Add emacs-forge.
(address . 36999@debbugs.gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20191005191929.7356-5-go.wigust@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-forge): New variable.
---
gnu/packages/emacs-xyz.scm | 79 ++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)

Toggle diff (92 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c8f4af54ad..455b448d9d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17061,6 +17061,85 @@ command\", but because it always involves at least two commands (a prefix and
a suffix) we prefer to call it just a \"transient\".")
(license license:gpl3+))))
+(define-public emacs-forge
+ (let ((commit "a6721c071226ae8da6852e9330f2bdcba92a4577"))
+ (package
+ (name "emacs-forge")
+ (version (git-version "0.1.0" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/magit/forge.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1gzr1di29a9szkzm6kjznq7c8md71cm5761pznf08nmmk63dl3zm"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("texinfo" ,texinfo)
+ ("emacs" ,emacs-minimal)))
+ (propagated-inputs
+ `(("emacs-closql" ,emacs-closql)
+ ("emacs-dash" ,emacs-dash)
+ ("emacs-emacsql-sqlite" ,emacs-emacsql)
+ ("emacs-ghub" ,emacs-ghub)
+ ("emacs-let-alist" ,emacs-let-alist)
+ ("emacs-magit" ,emacs-magit)
+ ("emacs-markdown-mode" ,emacs-markdown-mode)
+ ("emacs-transient" ,emacs-transient)))
+ (arguments
+ `(#:tests? #f ;no tests
+ #:modules ((srfi srfi-26)
+ (guix build gnu-build-system)
+ ((guix build emacs-build-system) #:prefix emacs:)
+ (guix build utils)
+ (guix build emacs-utils))
+ #:imported-modules (,@%gnu-build-system-modules
+ (guix build emacs-build-system)
+ (guix build emacs-utils))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'install)
+ (add-after 'unpack 'delete-doc-targets
+ (lambda _
+ (substitute* "./Makefile"
+ (("lisp docs") "lisp"))))
+ (add-after 'delete-doc-targets 'emacs-set-emacs-load-path
+ (assoc-ref emacs:%standard-phases 'set-emacs-load-path))
+ (add-after 'emacs-set-emacs-load-path 'chdir-lisp
+ (lambda _
+ (chdir "lisp")))
+ (add-after 'chdir-lisp 'emacs-install
+ (assoc-ref emacs:%standard-phases 'install))
+ (add-after 'emacs-install 'emacs-make-autoloads
+ (assoc-ref emacs:%standard-phases 'make-autoloads))
+ (add-after 'build 'install-elc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (el-dir (string-append
+ out "/share/emacs/site-lisp/guix.d/forge-"
+ ,version)))
+ (for-each (cut install-file <> el-dir)
+ (find-files "." "\\.elc"))
+ #t)))
+ (add-after 'install-elc 'install-doc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (info (string-append out "/share/info")))
+ (with-directory-excursion "../docs"
+ (invoke "makeinfo" "forge.texi")
+ (install-file "forge.info" info)
+ #t)))))))
+ (home-page "https://github.com/magit/ghub/")
+ (synopsis "Access Git forges from Magit")
+ (description
+ "Work with Git forges, such as Github and Gitlab, from the comfort of
+Magit and the rest of Emacs.")
+ (license license:gpl3+))))
+
(define-public emacs-matcha
(let ((commit "c7df5cf5cdac9ae369e241342389ccda0205eab9"))
(package
--
2.23.0
K
K
Kyle Meyer wrote on 7 Oct 2019 03:03
Re: [bug#36999] [PATCH 1/4] gnu: emacs-magit: Update to 2.90.1-1.c761d28.
(address . 36999@debbugs.gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
87r23p8iz2.fsf@kyleam.com
Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> writes:

Toggle quote (36 lines)
> #:phases
> (modify-phases %standard-phases
> + (add-after 'unpack 'patch
> + (lambda _
> + (chmod "lisp/magit-extras.el" #o644)
> + (emacs-batch-edit-file "lisp/magit-extras.el"
> + `(progn (progn
> + (goto-char (point-min))
> + (re-search-forward "(defun magit-copy-buffer-revision ()")
> + (forward-sexp 2)
> + (kill-sexp)
> + (insert ,(format #f "~S"
> + '(if (use-region-p)
> + (copy-region-as-kill nil nil 'region)
> + (when-let ((rev (cl-case major-mode
> + ((magit-cherry-mode
> + magit-log-select-mode
> + magit-reflog-mode
> + magit-refs-mode
> + magit-revision-mode
> + magit-stash-mode
> + magit-stashes-mode)
> + (car magit-refresh-args))
> + ((magit-diff-mode magit-log-mode)
> + (let ((r (caar magit-refresh-args)))
> + (if (string-match "\\.\\.\\.?\\(.+\\)" r)
> + (match-string 1 r)
> + r)))
> + (magit-status-mode "HEAD"))))
> + (when (magit-commit-p rev)
> + (setq rev (magit-rev-parse rev))
> + (push (list rev default-directory) magit-revision-stack)
> + (kill-new (message "%s" rev))))))))
> + (basic-save-buffer)))
> + #t))

I didn't spot an explanation in either the commit message or comments
about what problem this patch phase is addressing. If it's still an
issue with Magit's current master, would you please submit an issue
upstream? If it's not, why not just go with a newer Magit revision?

--
Kyle
O
O
Oleg Pyhalov wrote on 7 Oct 2019 10:01
(name . Kyle Meyer)(address . kyle@kyleam.com)(address . 36999@debbugs.gnu.org)
87tv8l0yry.fsf@majordomo.ru
Hi Kyle,

Kyle Meyer <kyle@kyleam.com> writes:

[…]

Toggle quote (4 lines)
> I didn't spot an explanation in either the commit message or comments
> about what problem this patch phase is addressing. If it's still an
> issue with Magit's current master

Wrong argument type while calling magit-copy-buffer-revision.

magit-copy-buffer-revision is different in master.

Toggle quote (2 lines)
> If it's not, why not just go with a newer Magit revision?

Sorry, what revision do you mean?

I tried stick closer to release v2.90.1 because of compatibility with
other packages which require Magit.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl2a8PEACgkQFn+OpQAa
+pxiEA//T/GNY89AHTP/VAs5JZQJENuhMvqjfNWDTgQFUdSl4HyFUxVpf4Fp03J7
L68cBH8i2qkieWvP8pZ3LAxhfLuf6KRcs9cGeKjzwH9vHsnG8j/rAbtAcqrq2TyB
Y7E9G8IDuNwTputGxXpfrROtHvCfK2OFq2HtmM1UNjYUKPRyTSZsrF+IwsQFZHJN
VhUx6FuX5FcwmoohpyWO+dNqqwbl7naJTU3DSj59F3FeHtvdp4jvcomEUUQPYz04
Bn9OrCKi1RA+mgtHy5vQcjGEz9ciHSlLuLcNU+VG0FPXW92RH/wH/r6SVaUhRG2g
wdnNQW4PvVRbcU0dXMCuY+BhV/+/PejgJG3AThiyniM9h8qzSh63FKBJTB6A5XzE
ox7KUcfLv891pfkLLEuIU8GF24gP8hB17dikdZKAC1ofSmO7GH3xARsoXUBCbjCO
fzWs7gVwsAEGV+kYboDlDZ88v0RWOCQWljv7IBOXm3hgf3x5M4Rp5lcomaTU17LL
EMC7YO3Njj5GR1EUmsOBw5/FpCl/Q3cIl1IUWGfpAkDW1TVw3wjI09gx+uOCp2XE
jPIkh/oWeJTJNJ4+iuOCfi0uUaItMJNwjEQQrhGp1hAAiDlggKkl8f1ELHD0Vxcl
yU2KWqx4ieQds5VpuuKLuYk1A/oKI0xSa3ySemuTftzeH88dqGw=
=yza4
-----END PGP SIGNATURE-----

K
K
Kyle Meyer wrote on 7 Oct 2019 15:21
(name . Oleg Pyhalov)(address . go.wigust@gmail.com)(address . 36999@debbugs.gnu.org)
8736g43d3q.fsf@kyleam.com
Oleg Pyhalov <go.wigust@gmail.com> writes:

Toggle quote (18 lines)
> Hi Kyle,
>
> Kyle Meyer <kyle@kyleam.com> writes:
>
> […]
>
>> I didn't spot an explanation in either the commit message or comments
>> about what problem this patch phase is addressing. If it's still an
>> issue with Magit's current master
>
> Wrong argument type while calling magit-copy-buffer-revision.
>
> magit-copy-buffer-revision is different in master.
>
>> If it's not, why not just go with a newer Magit revision?
>
> Sorry, what revision do you mean?

Sorry for not being clear. I meant why not build the package from a
later commit in Magit that doesn't show the issue. Anyway, you answered
that next. Thanks.

Toggle quote (3 lines)
> I tried stick closer to release v2.90.1 because of compatibility with
> other packages which require Magit.

I see.
O
O
Oleg Pykhalov wrote on 13 Oct 2019 21:45
emacs-forge pushed to master
(address . 36999@debbugs.gnu.org)(address . 36999-done@debbugs.gnu.org)
87y2xo2zv5.fsf@gmail.com
Hi.

I didn't notice any issue with Magit and Forge. Pushed to master.

Thank you for help to package them and your suggestions!

Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl2jfu4ACgkQFn+OpQAa
+pzumw/+Ndq+kprBJPsD01huQOJr8h6nK4j89UmOND99U44sMPWCnYNt1wiLW83p
kEjBsglYYWCa0xxHoYRBiQn8OtsNWgf9tXYLKAS3jME603D50Iu8giNpZTJXAC1w
fG00Ww8Q7WyJexJLJWTSzFzvV9m+YbIMS+Py4rF2RUSbH0oJhayqqj2o4xHieLc3
F8PADYMmfxC2unN68WVIE/AgoLBGzkIAE9HKYwmopt4twbqnBskb3yG14vA0vGRe
ZxsBCjrpKr7pCDvcmMMxe01LiX6igo1KTs6s8JGrVfhrFUrAIZusYnXEKFFke8wR
NYjVkPa7fJvILI0a/4UGGmYt0s2Lbr8EERWORV9bFP3fll43yEwxYJ59FmjL9f4+
yzHbs49X368c9YQDWg+w/XXr9GUp9GV+4Ow71x7KanfDVVgAn7LbgrGnOvK6TAqP
A/Ww91gUPcvUimbCeRgpwl28tqBsAbJHlSjXf9iMOcV721SdAL1FA5IskoYCrKCL
Lcow8F4PnTNxUy9GTtqfdBvZjcbMLKoWal4t5e4aNa8gCiaviwAktS90KshRqxDd
KrAg2UIp8Trb+TRXqtbJa1djvDcGp8SryOmpaVqlflJ8jrqMO40VKwC01wp+hLmb
ZgZYtzpVlDuOpXrauCuJGxX0zOqTBE14xLDoBLlIGuUL15kXPvk=
=HuLk
-----END PGP SIGNATURE-----

?