Request for merging "mesa-updates" branch

  • Done
  • quality assurance status badge
Details
3 participants
  • Efraim Flashner
  • John Kehayias
  • Ludovic Courtès
Owner
unassigned
Submitted by
John Kehayias
Severity
normal

Debbugs page

John Kehayias wrote 3 months ago
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
8734iubuk1.fsf@protonmail.com
Hi Guix,

Currently the mesa-updates branch just has a few updates which seem to have built fine (on x86_64 at least), see https://issues.guix.gnu.org/74779.

I don't know of other pending changes other than a libva update I'll see about. Perhaps we can do some ungrafting too?

John
John Kehayias wrote 3 months ago
(address . 74780@debbugs.gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
87a5cqxfik.fsf@protonmail.com
On Wed, Dec 11, 2024 at 06:30 AM, John Kehayias wrote:

Toggle quote (11 lines)
> Hi Guix,
>
> Currently the mesa-updates branch just has a few updates which seem to
> have built fine (on x86_64 at least), see
> <https://issues.guix.gnu.org/74779>.
>
> I don't know of other pending changes other than a libva update I'll
> see about. Perhaps we can do some ungrafting too?
>
> John

(CC-ing Efraim after the patch to build the asahi vulkan driver on
aarch64-linux)

I just rebased on master after further updating wayland-protocols and
mesa to their very freshest versions.

Not much else going on here, so maybe just let this build and then merge
to keep things current. Unfortunately the QA page hasn't shown a status
for this branch but I'll check later.

There are discussions about libglvnd support in Mesa I need to chime in
on, so we could tackle that, but not until the new year for me. That
will require a decent number of changes and lots more testing, so my
preference would be to merge this branch when substitutes are available
and then immediately work on libglvnd or whatever else is pending.

John
Efraim Flashner wrote 3 months ago
(name . John Kehayias)(address . john.kehayias@protonmail.com)(address . 74780@debbugs.gnu.org)
Z2bth9Q6dYQyrjrm@3900XT
On Fri, Dec 20, 2024 at 08:31:57PM +0000, John Kehayias wrote:
Toggle quote (16 lines)
> On Wed, Dec 11, 2024 at 06:30 AM, John Kehayias wrote:
>
> > Hi Guix,
> >
> > Currently the mesa-updates branch just has a few updates which seem to
> > have built fine (on x86_64 at least), see
> > <https://issues.guix.gnu.org/74779>.
> >
> > I don't know of other pending changes other than a libva update I'll
> > see about. Perhaps we can do some ungrafting too?
> >
> > John
>
> (CC-ing Efraim after the patch to build the asahi vulkan driver on
> aarch64-linux)

I didn't test it (I don't have the hardware), but it built just fine and
I assume the Asahi people know what they're doing.

Toggle quote (3 lines)
> I just rebased on master after further updating wayland-protocols and
> mesa to their very freshest versions.

I'll rebuild again on a couple of architectures but I don't expect any
issues.

Toggle quote (10 lines)
> Not much else going on here, so maybe just let this build and then merge
> to keep things current. Unfortunately the QA page hasn't shown a status
> for this branch but I'll check later.
>
> There are discussions about libglvnd support in Mesa I need to chime in
> on, so we could tackle that, but not until the new year for me. That
> will require a decent number of changes and lots more testing, so my
> preference would be to merge this branch when substitutes are available
> and then immediately work on libglvnd or whatever else is pending.

That makes sense. Regular smallish updates are one of the reasons for
the team/topic -based branches.

--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdm7YQACgkQQarn3Mo9
g1GHiRAAq3fcbPEbdpwbyNjtL+3ciUly8JqqDb3aQ+iczPRGf2XZPm/jRWMFRSf5
tjm3tiZRA+/nmxWaHOmfqhk408DhzYWICg12ibRdWEYRah7lfAOf+qcuzWUt0DO/
M31KAh8f5tOyA/+NhammCkoUsEDW8/BARdVzRFjQD37JUBJ2S3bMxwVmcSl5+rpv
wVu/NQt2dw4Fhm8vuFVh75ZAeSqmZLWTMrMcur7UxUCM1SmCOCg8/o7brG+BZYjI
uwI7QG2+Oln0N0Ptfq2adPOWsd3mbITra3VwSbbdjYqupHs8GwnTyz45lBGfNvog
COcWSDIoqfCWwoLtuNAvGzE5VVWX6JfppdCIWuX0v+2Fk22QUdUmKGGsYryzdb+A
ChQJUJ1sWHlNIrDTQfOAnFfrF4c0Z/MbR5/apm7prBeA7AVuFpbkGDs6ICdEKUyx
svaNs6qOfhwi5gfZAyxEGtYZUOunLp5daKWSYRyk2TZ2zmVp2ejbGwwD6r5XjRIh
rdC7bZLOyixuxOeyUd+/E1eomuq8A6AOiK1IOSqzjFmcLk1JcIRg0MUAm3rkikcU
cWSRmTrlJ1ewzJLQB7W8rYXx5wlabNtLGkYgyXUvizH/IV8pbPVb9VVr1B4fbGol
E4vf8qI6tEqqmmYGBYHgRvmOqlGAOHozG1iDhSRAYkIrmxXxDtc=
=CSnj
-----END PGP SIGNATURE-----


Efraim Flashner wrote 3 months ago
(name . John Kehayias)(address . john.kehayias@protonmail.com)(address . 74780@debbugs.gnu.org)
Z2fZqPxJlOLj1shD@3900XT
On Fri, Dec 20, 2024 at 08:31:57PM +0000, John Kehayias wrote:
Toggle quote (29 lines)
> On Wed, Dec 11, 2024 at 06:30 AM, John Kehayias wrote:
>
> > Hi Guix,
> >
> > Currently the mesa-updates branch just has a few updates which seem to
> > have built fine (on x86_64 at least), see
> > <https://issues.guix.gnu.org/74779>.
> >
> > I don't know of other pending changes other than a libva update I'll
> > see about. Perhaps we can do some ungrafting too?
> >
> > John
>
> (CC-ing Efraim after the patch to build the asahi vulkan driver on
> aarch64-linux)
>
> I just rebased on master after further updating wayland-protocols and
> mesa to their very freshest versions.
>
> Not much else going on here, so maybe just let this build and then merge
> to keep things current. Unfortunately the QA page hasn't shown a status
> for this branch but I'll check later.
>
> There are discussions about libglvnd support in Mesa I need to chime in
> on, so we could tackle that, but not until the new year for me. That
> will require a decent number of changes and lots more testing, so my
> preference would be to merge this branch when substitutes are available
> and then immediately work on libglvnd or whatever else is pending.

I built mesa for aarch64, armhf, riscv64 and powerpc64le. They all
built without any problems.

--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdn2aQACgkQQarn3Mo9
g1G95w//WSW464VH1XWJepEpjvt183Ns18EsiFMuiRzFBz7CTVtVJiMxPd5fEM5/
pWD1AExhrP+DTUEPDKZpF4PQQvfORTMEO3LQMw4nS4HVUguzKr/OwKgIBHDBs8OB
5dfHAj6zKeo7uMBRuuYwfHKi9Nhv+r0sNHDAI3XkUZZI4FVLVKJVCwwPxhkhgXug
scW8svo86UxNp1EGXDaVyaaUef5mtZHqqA2OJ3J1r7l3U7xS7C8d1N6jqod4KwHJ
9eLP/X9BvsYzPjGpTxvpaXaNVHbS7A98ACyag1E1/itCyIgJNf4sftN2Ht9kiTHV
FZrvs/ZGY9hPKQI7iqZrfQiM2rRHJrTmabkuxsuO3gwa7xwknY387lsx+TSr3Hss
uvK+wqnZY6vV7djsD1m1MPPk3S2AW/wDK6hIXUJ4YtAJUHjnj95xIM+1xFUpjkPP
T21wDfnNKbiyOZGW0Bct9STIdtlGxnRXZ/vGwlfGSG3lYugOU3My1XQkTaoRL+iN
5KVyWAdeDi0O1J0QmW/bljh/cMYzcyFJCL8eh2JJfivTk79WWyqDWmd6xRxEkvOj
DdYdp8ta2dUzsrg+aM/J/Bp74BIDsRVVyRDtr+Gz5eX3klyJZUAfvjG4476RHHte
4Qx82HeO25vRzl6V9HJGFnzKTUAe2A6ET91rKFyETA/9kwb84Ds=
=EnNL
-----END PGP SIGNATURE-----


Ludovic Courtès wrote 2 months ago
(name . Efraim Flashner)(address . efraim@flashner.co.il)(name . John Kehayias)(address . john.kehayias@protonmail.com)(address . 74780@debbugs.gnu.org)
877c7ir0y8.fsf_-_@gnu.org
Hey John and all,

It’s the turn of the “mesa-updates” branch to be merged:


:-)

Ludo’.
John Kehayias wrote 2 months ago
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 74780@debbugs.gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
87ed1pnb02.fsf@protonmail.com
Hi all,

On Sun, Dec 29, 2024 at 03:57 PM, Ludovic Courtès wrote:

Toggle quote (10 lines)
> Hey John and all,
>
> It’s the turn of the “mesa-updates” branch to be merged:
>
> <https://qa.guix.gnu.org/>
>
> :-)
>
> Ludo’.

Thanks for checking in.

I just rebased and pushed. I'll keep an eye on it but didn't notice
any big failures (plenty on earlier evaluations but mostly due to the
python merge from what I can tell).

The question is what the substitute coverage will be like on
non-x86_64-linux. It had already been about 9-10 days from the last
update and didn't seem like much progress. And with QA back up but
very behind, not sure if we expect that to tell us anything soon.

Should I give it a day or so to build the current rebase and then just
merge? From Efraim's local builds and given the nature of the commits,
I don't expect any big surprises.

(Side note: does i686-linux have priority on Berlin or something like
that? The last few weeks I notice many more active i686 builds after a
push with many pending builds. The current evaluation, for instance:
the vast majority of workers are idle, and then the vast majority of
active are i686 builds. Or is that from just generally being behind on
i686 so there's just more of that to do?)

Thanks!
John
John Kehayias wrote 2 months ago
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 74780@debbugs.gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
87y0zrdtwq.fsf@protonmail.com
On Sun, Dec 29, 2024 at 09:46 PM, John Kehayias wrote:

Toggle quote (39 lines)
> Hi all,
>
> On Sun, Dec 29, 2024 at 03:57 PM, Ludovic Courtès wrote:
>
>> Hey John and all,
>>
>> It’s the turn of the “mesa-updates” branch to be merged:
>>
>> <https://qa.guix.gnu.org/>
>>
>> :-)
>>
>> Ludo’.
>
> Thanks for checking in.
>
> I just rebased and pushed. I'll keep an eye on it but didn't notice
> any big failures (plenty on earlier evaluations but mostly due to the
> python merge from what I can tell).
>
> The question is what the substitute coverage will be like on
> non-x86_64-linux. It had already been about 9-10 days from the last
> update and didn't seem like much progress. And with QA back up but
> very behind, not sure if we expect that to tell us anything soon.
>
> Should I give it a day or so to build the current rebase and then just
> merge? From Efraim's local builds and given the nature of the commits,
> I don't expect any big surprises.
>
> (Side note: does i686-linux have priority on Berlin or something like
> that? The last few weeks I notice many more active i686 builds after a
> push with many pending builds. The current evaluation, for instance:
> the vast majority of workers are idle, and then the vast majority of
> active are i686 builds. Or is that from just generally being behind on
> i686 so there's just more of that to do?)
>
> Thanks!
> John

QA page still hasn't updated and it has been another 5 days from the
last message. Unless there are any objections I'll do a rebase and
merge later this weekend.

John
Ludovic Courtès wrote 2 months ago
(name . John Kehayias)(address . john.kehayias@protonmail.com)(address . 74780@debbugs.gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
87ed1iqy26.fsf@gnu.org
Hi John,

John Kehayias <john.kehayias@protonmail.com> skribis:

Toggle quote (4 lines)
> QA page still hasn't updated and it has been another 5 days from the
> last message. Unless there are any objections I'll do a rebase and
> merge later this weekend.

Sure. Please do check the situation at
‘master’.

You can check that direct dependents of packages that were upgraded
still build fine. For example, “guix build -P1 mesa --no-grafts -n -v1”
will indicate whether substitutes are available for all of the direct
dependents of ‘mesa’, meaning that they were successfully built.

Thanks for working on this!

Ludo’.
John Kehayias wrote 2 months ago
(name . Ludovic Courtès)(address . ludo@gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 74780-done@debbugs.gnu.org)
87sepw8zex.fsf@protonmail.com
Hi Ludo’!

On Sat, Jan 04, 2025 at 06:38 PM, Ludovic Courtès wrote:

Toggle quote (5 lines)
> Sure. Please do check the situation at
> <https://ci.guix.gnu.org/jobset/mesa-updates> and how it compares to
> ‘master’.
>

Yes, I've been keeping an eye on that and by overall percentage (from
the Cuirass homepage), the mesa-updates branch has been about equal to
master for a while. Though I know the missing stuff is for non-x86
which we get more of from Bordeaux, which is what I usually try to
wait for, unfortunately harder to tell without the handy QA page
comparison.

Toggle quote (6 lines)
> You can check that direct dependents of packages that were upgraded
> still build fine. For example, “guix build -P1 mesa --no-grafts -n -v1”
> will indicate whether substitutes are available for all of the direct
> dependents of ‘mesa’, meaning that they were successfully built.
>

Oh, the new dependents option for guix build, very nice! I hadn't
tried it before but this is great.

I didn't see something like this built-in (maybe I missed it?) but
seems pretty easy to do a comparison then to another branch. I just
did the same command on my 'master' worktree and compared, to see just
a few minor differences (so I restarted the builds since they didn't
have a clear error).

A little bash-fu could easily have a nice little comparison between
branches using substitute coverage, or maybe we want to add that as an
option directly? Maybe specifying two branches or commits to see what
package names differ (in hash or substitutes)?


Toggle quote (4 lines)
> Thanks for working on this!
>
> Ludo’.

Most welcome!

Merged just now: 23231c296fb2c2af8c1c0a6ead1dd6f0833f7c45 to
a65ebe5fad6921dddb165f417761886fc114ad29.

Thanks,
John
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74780@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74780
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help