Some broken Go packages (including Podman)

  • Done
  • quality assurance status badge
Details
5 participants
  • Jean-Pierre De Jesus Diaz
  • jgart
  • Nils Landt
  • Sharlatan Hellseher
  • woshilapin
Owner
unassigned
Submitted by
Nils Landt
Severity
normal

Debbugs page

Nils Landt wrote 8 months ago
(name . bug-guix@gnu.org)(address . bug-guix@gnu.org)
602050338.91939.1719819308299@office.mailbox.org
Building the new Podman package fails because building a depdency (gvisor-tap-vsock) fails:
The following derivation will be built:
/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv
building /gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv...
WARNING: (guile-user): imported module (guix build utils) overrides core binding `delete'
Backtrace:
16 (primitive-load "/gnu/store/2a9k7v2qhydivh63xv921gr6kp9?")
In ice-9/eval.scm:
214:21 15 (_ #f)
217:50 14 (lp (#<procedure 7ffff77ff680 at ice-9/eval.scm:282:?> ?))
217:50 13 (lp (#<procedure 7ffff77ff660 at ice-9/eval.scm:282:?> ?))
217:50 12 (lp (#<procedure 7ffff77ff640 at ice-9/eval.scm:282:?> ?))
217:50 11 (lp (#<procedure 7ffff77ff620 at ice-9/eval.scm:282:?> ?))
217:50 10 (lp (#<procedure 7ffff77ff5c0 at ice-9/eval.scm:649:?> ?))
217:50 9 (lp (#<procedure 7ffff77ff580 at ice-9/eval.scm:282:?> ?))
217:50 8 (lp (#<procedure 7ffff77ff520 at ice-9/eval.scm:649:?> ?))
217:50 7 (lp (#<procedure 7ffff77ff500 at ice-9/eval.scm:282:?> ?))
217:50 6 (lp (#<procedure 7ffff77ff4c0 at ice-9/eval.scm:282:?> ?))
217:50 5 (lp (#<procedure 7ffff77ff4a0 at ice-9/eval.scm:282:?> ?))
217:33 4 (lp (#<procedure 7ffff77ff0a0 at ice-9/eval.scm:649:?> ?))
293:34 3 (_ #(#(#(#(#(#<directory (guile-user) 7f?> ?) ?) ?) ?) ?))
173:55 2 (_ #(#(#(#(#(#<directory (guile-user) 7f?> ?) ?) ?) ?) ?))
223:20 1 (proc #(#(#(#(#(#<directory (guile-user)?> ?) ?) ?) ?) ?))
In unknown file:
0 (%resolve-variable (5 (guix build go-build-system) . #) #)
ERROR: In procedure %resolve-variable:
In procedure module-lookup: Unbound variable: remove-go-references
builder for `/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv' failed with exit code 1
build of /gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv failed
View build log at '/var/log/guix/drvs/4l/zcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv.gz'.
guix build: error: build of `/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv' failed
error: Recipe `guix` failed on line 13 with exit code 1
It looks to me like 0df957eecc536e1d0a5722b47dda1563439bbe04 removed remove-go-references, but it is still used by podman, gvisor-tap-vsock, and buildah.
--
Nils Landt
Attachment: file
jgart wrote 8 months ago
(address . 71870@debbugs.gnu.org)(name . Nils Landt)(address . nils@landt.email)
871q4dw56z.fsf@dismail.de
Toggle quote (3 lines)
> Building the new Podman package fails because building a depdency
> (gvisor-tap-vsock) fails:

Hi Nils,

Would you be interested in sending patches to fix these failures?
--
all the best,
jgart
Nils Landt wrote 8 months ago
1191618923.144212.1719845034655@office.mailbox.org
Toggle quote (10 lines)
> jgart <jgart@dismail.de> hat am 01.07.2024 16:35 CEST geschrieben:
>
>
> > Building the new Podman package fails because building a depdency
> > (gvisor-tap-vsock) fails:
>
> Hi Nils,
>
> Would you be interested in sending patches to fix these failures?

No, the patch submission process is too annoying for me.
jgart wrote 8 months ago
35d9a037be458b7f3e9b88ddbf9c7b877bfe9028@dismail.de
Toggle quote (3 lines)
> No, the patch submission process is too annoying for me.
>

Hi Nils,

Sorry to hear that. I can relate to that as I've also been annoyed by aspects of the process.

Can you share some of the pain points that you've experienced with the patch submission process?

This will help us potentially address that and open discussion around it.

How do you think that the patch submission process can be improved?

I'm going to give a talk in August at the Guix London meetup on patch review, the mumi CLI tool, and my current personal workflow.

TBA,

jgart
Nils Landt wrote 8 months ago
479449617.175721.1719901242517@office.mailbox.org
Toggle quote (15 lines)
> jgart <jgart@dismail.de> hat am 01.07.2024 19:04 CEST geschrieben:
>
>
> > No, the patch submission process is too annoying for me.
> >
>
> Hi Nils,
>
> Sorry to hear that. I can relate to that as I've also been annoyed by aspects of the process.
>
> Can you share some of the pain points that you've experienced with the patch submission process?
>
> This will help us potentially address that and open discussion around it.
>
> How do you think that the patch submission process can be improved?
Nothing that hasn't been talked about for years, really.

- Patch submission workflow without email
- Code review tool with threaded at-code conversations
- Code formatter that I can make work for vim (i.e. guix style for non-packages)
- Useful commit messages instead of GNU ChangeLog

My previous attempt at contribution (https://issues.guix.gnu.org/66557)was quite unpleasant.
I don't know how to phrase my critique of the reviewers in a constructive manner, given that I respect we're all human beings volunteering time for this hobby.
Toggle quote (2 lines)
> I'm going to give a talk in August at the Guix London meetup on patch review, the mumi CLI tool, and my current personal workflow.

I will be watching the recording, but I don't see how it would address my wishlist :)
woshilapin wrote 8 months ago
(name . 71870@debbugs.gnu.org)(address . 71870@debbugs.gnu.org)
0ywYMXpaeVXncJ4ceEEQU0GJ9EcrgQytIK2atgICiAkTnNn6ZN8TU9HqsD4T3doVZUJUmO_rSAUBwgWbDdfxLBoy-o1-P8t1T4yIFEmPE3w=@tuziwo.info
Hi Nils, hi jgart,

Toggle quote (7 lines)
> Building the new Podman package fails because building a depdency
> (gvisor-tap-vsock) fails:
> <...>
> It looks to me like 0df957eecc536e1d0a5722b47dda1563439bbe04 removed
> remove-go-references, but it is still used by podman,
> gvisor-tap-vsock, and buildah.

You might be interested in this other issue that links to some
interesting content related to the removal of `remove-go-references`,
especially the following comment.


Sincerely,
--
Jean SIMARD aka woshilapin
jgart wrote 8 months ago
(address . nils@landt.email)
84ba6a7e0e26dcc3bc2e9ac992658305cfae4443@dismail.de
Thanks for the link. I'll take a look

all best,

jgart
Jean-Pierre De Jesus Diaz wrote 8 months ago
(address . 71870@debbugs.gnu.org)
CAG1gdUqCpVsGRMytjUSAO=8tm4LOcxxvAVjQE94hjd_rJhZhVA@mail.gmail.com
Hello,

I've sent a few patches in https://issues.guix.gnu.org/71923 to fix
the build of these
packages and also updates podman to latest version.

Cheers,
Nils Landt wrote 8 months ago
251706119.341838.1720075892004@office.mailbox.org
Toggle quote (11 lines)
> Jean-Pierre De Jesus Diaz <jean@foundation.xyz> hat am 03.07.2024 18:40 CEST geschrieben:
>
>
> Hello,
>
> I've sent a few patches in <https://issues.guix.gnu.org/71923> to fix
> the build of these
> packages and also updates podman to latest version.
>
> Cheers,

Thank you very much Jean-Pierre.
Sharlatan Hellseher wrote 8 months ago
Some broken Go packages (including Podman)
(address . 71870-done@debbugs.gnu.org)
875xtapqsf.fsf@gmail.com
Hi,

Closing as resovled in other mentioned issues.

Thanks,
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmaRTSAACgkQdtcnv/Ys
0rW43BAAkyhFhXq9PEMUd52ynP4lYx8IcPgIbGHSS7+JUnnVN77K9277v/+69Ju7
dlzumEMnNIKWizuGmGaDoFMQb4BDT2Xoxt7yU6SaZBMkhappd8ZT4j0gOzPp03aT
vq84afWJd2MOkS4qn1gv91KKGayIRmnKBL2veeWaCdt/VD/izqGk++LvhogrVnND
FQZ9Wn8RRCA2VyrAgBCxuVKBP0djwVfXndtJ97jLFArb7oyAWSdCkXatf8rbZfBr
iRPqnCQwfvfGKKsGUg3uTs8Q2VZHEoOHsvCf3Ijs5rIhp+k763jSPe/6bp1g+0sO
SvkmR40HQj3KJDnkUjJ05dWjA0yDvwyh1iqdXtx6ZJJcHEVnMOsludZodRqHC8c0
lxI5yMaYBdymYURokXhy0CTYo6apl1IW3npnHMJAmfoRyp1oUY7nIh52x3oGiBYL
DtvvpjuvAI/t8vjJYcRHsTxOwSsc9INvpEQOJZXsudHtKfat8mcszoYJyOizQI9k
2ALKd9oZp8lvwE1mxm7TqODg48+33oI4G+e+Bp6QLq4Xm3atwuaIvFEmko7O01Fx
FKQqtJoriJeFS7aZqmfFxs38YyZoc84jb3Ut0KSH8ScAkbp2W632mHBr7GSBmfkv
uKUzl+lwWweGMfLtVf+tV0D/6HrY6BKCZKaWtL42r7QRobiaGUE=
=4TWt
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 71870@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 71870
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help