[PATCH] doc: Add message for common error about make check-system

  • Done
  • quality assurance status badge
Details
3 participants
  • Maxim Cournoyer
  • pelzflorian
  • Richard Sent
Owner
unassigned
Submitted by
Richard Sent
Severity
normal
Merged with
R
R
Richard Sent wrote on 15 Jun 23:42 +0200
(address . guix-patches@gnu.org)(name . Richard Sent)(address . richard@freakingpenguin.com)
80b83bce10be06052a916580fc171098aa42fb5b.1718487758.git.richard@freakingpenguin.com
* doc/contributing.texi (Running the Test Suite): Mention that make clean-go
may need to be run before running make check-system when previous builds were
run with different work trees. See https://issues.guix.gnu.org/47573.

Change-Id: I4b68d3a05f1425505816db969284487d725840d6
---
Sending a followup rebased on current master.

doc/contributing.texi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

Toggle diff (29 lines)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..c9591dc9bf 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -411,6 +411,20 @@ Running the Test Suite
substitutes are available for their dependencies (@pxref{Substitutes}).
Some of them require a lot of storage space to hold VM images.
+If you encounter an error like:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistency in the work tree from previous builds. To
+resolve this, try running @command{make clean-go} followed by
+@command{make}.
+
Again in case of test failures, please send @email{bug-guix@@gnu.org}
all the details.

base-commit: 612e4dd98f7d1d015e405af9d029bede3fe3c280
--
2.45.1
R
R
Richard Sent wrote on 15 Jun 23:44 +0200
control message for bug #71580
(address . control@debbugs.gnu.org)
87wmmpanji.fsf@freakingpenguin.com
merge 71580 70202
quit
M
M
Maxim Cournoyer wrote on 17 Jun 23:07 +0200
Re: [bug#71580] [PATCH] doc: Add message for common error about make check-system
(name . Richard Sent)(address . richard@freakingpenguin.com)
87jzinffbv.fsf@gmail.com
Hi Richard,

Richard Sent <richard@freakingpenguin.com> writes:

Toggle quote (31 lines)
> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
> may need to be run before running make check-system when previous builds were
> run with different work trees. See https://issues.guix.gnu.org/47573.
>
> Change-Id: I4b68d3a05f1425505816db969284487d725840d6
> ---
> Sending a followup rebased on current master.
>
> doc/contributing.texi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index 938c8bfdb1..c9591dc9bf 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -411,6 +411,20 @@ Running the Test Suite
> substitutes are available for their dependencies (@pxref{Substitutes}).
> Some of them require a lot of storage space to hold VM images.
>
> +If you encounter an error like:
> +
> +@example
> +Compiling Scheme modules...
> +ice-9/eval.scm:142:16: In procedure compile-top-call:
> +error: all-system-tests: unbound variable
> +hint: Did you forget `(use-modules (gnu tests))'?
> +@end example
> +
> +@noindent
> +there may be inconsistency in the work tree from previous builds. To

perhaps ^ an inconsistency? alternatively, 'inconsistencies'.

Toggle quote (6 lines)
> +resolve this, try running @command{make clean-go} followed by
> +@command{make}.
> +
> Again in case of test failures, please send @email{bug-guix@@gnu.org}
> all the details.

I guess the fact that there is an open issue from a different perhaps
about this problem on the tracker means it's bit enough people that it
merits to be mentioned in the doc.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

--
Thanks,
Maxim
R
R
Richard Sent wrote on 18 Jun 03:02 +0200
[PATCH v2] doc: Add message for common error about make check-system
(address . 71580@debbugs.gnu.org)(name . Richard Sent)(address . richard@freakingpenguin.com)
3e0cb737e55694fee8d7e3c515845e4c4cc20c76.1718672549.git.richard@freakingpenguin.com
* doc/contributing.texi (Running the Test Suite): Mention that make clean-go
may need to be run before running make check-system when previous builds were
run with different work trees. See https://issues.guix.gnu.org/47573.

Change-Id: I4b68d3a05f1425505816db969284487d725840d6
---
Adjusted the phrasing. If we think it's best to hold on merging this
until we determine how common of an occurrence this is or (better yet)
resolve the issue entirely, there's no complaints by me. I'll leave
that decision up to you all. :)

doc/contributing.texi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

Toggle diff (29 lines)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..6f0acc8c1f 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -411,6 +411,20 @@ Running the Test Suite
substitutes are available for their dependencies (@pxref{Substitutes}).
Some of them require a lot of storage space to hold VM images.
+If you encounter an error like:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistencies in the work tree from previous builds. To
+resolve this, try running @command{make clean-go} followed by
+@command{make}.
+
Again in case of test failures, please send @email{bug-guix@@gnu.org}
all the details.

base-commit: b993f4735d41e690dbafb8ee2e17fce996a8cf20
--
2.45.1
M
M
Maxim Cournoyer wrote on 18 Jun 14:13 +0200
(name . Richard Sent)(address . richard@freakingpenguin.com)
87h6dqe9f4.fsf@gmail.com
Richard Sent <richard@freakingpenguin.com> writes:

Toggle quote (6 lines)
> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
> may need to be run before running make check-system when previous builds were
> run with different work trees. See https://issues.guix.gnu.org/47573.
>
> Change-Id: I4b68d3a05f1425505816db969284487d725840d6

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

--
Thanks,
Maxim
P
P
pelzflorian wrote on 19 Jun 10:48 +0200
Re: [bug#71580] [PATCH v2] doc: Add message for common error about make check-system
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
47ea-66729b80-51-4b04d800@254991457
I cannot push; my computer broke; but this patch should not be stuck because of me.  However, it is not clear why `make clean-go' helps.  I tried to switch branches, but cannot reproduce the issue and do not get this kind of error message.

Regards,
Florian
 
Attachment: file
M
M
Maxim Cournoyer wrote on 24 Jun 06:09 +0200
Re: [bug#71580] [PATCH v2] doc: Add message for common error about make check-system
(name . Richard Sent)(address . richard@freakingpenguin.com)
87msnb0yoq.fsf@gmail.com
Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

Toggle quote (10 lines)
> Richard Sent <richard@freakingpenguin.com> writes:
>
>> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
>> may need to be run before running make check-system when previous builds were
>> run with different work trees. See https://issues.guix.gnu.org/47573.
>>
>> Change-Id: I4b68d3a05f1425505816db969284487d725840d6
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

Applied locally. Will push shortly.

--
Thanks,
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 71580@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 71580
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch