Several packages have dbus service files with broken file paths

  • Done
  • quality assurance status badge
Details
3 participants
  • iyzsong
  • Maxim Cournoyer
  • Nathan Dehnel
Owner
unassigned
Submitted by
Nathan Dehnel
Severity
normal
N
N
Nathan Dehnel wrote on 23 Apr 11:18 +0200
(name . bug-guix)(address . bug-guix@gnu.org)
CAEEhgEvvgBdUHDcsTFrN5b9w-4LOChH7VjR1Gq4efdAptt49Yg@mail.gmail.com
I was investigating powerdevil and snapper being broken and I
discovered packages with incorrect file paths in the Exec line of
their dbus services

$ ls -d /gnu/store/**/share/dbus-1/services/** | grep -v
profile/share/dbus-1 | while read line; do grep Exec $line 2>
/dev/null | grep -v /gnu/store && echo $line >>/dev/stderr; done
Exec=libexec/fontinst
/gnu/store/6hz6j922gs1861h49id3ddjsg02cwkl1-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service
Exec=libexec/fontinst
/gnu/store/nv8ccgy6jzfjkik5c5vy6id7dplnbb1y-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service



$ ls -d /gnu/store/**/share/dbus-1/system-services/** | grep -v
profile/share/dbus-1 | while read line; do grep Exec $line 2>
/dev/null | grep -v /gnu/store && echo $line >>/dev/stderr; done
Exec=/usr/sbin/snapperd
/gnu/store/07dlq92dnm85k7rmgl9q5ma8r6jsy79n-snapper-0.10.7/share/dbus-1/system-services/org.opensuse.Snapper.service
# who have MM installed but turned off. Thus the Exec path available to
# D-Bus is /bin/false, but systemd knows the real Exec path due to the MM
/gnu/store/16j7szl8lgjzb3fhm4b0mrs2dhd18pzr-modem-manager-1.18.12/share/dbus-1/system-services/org.freedesktop.ModemManager1.service
Exec=libexec/kde_ufw_plugin_helper
/gnu/store/2pr3flqh8yjkyl5zdk6ymw7azhdsd5qn-plasma-firewall-5.27.7/share/dbus-1/system-services/org.kde.ufw.service
Exec=/usr/sbin/snapperd
/gnu/store/2vlrhf10dxx5zl6pqzkk0hd06f7g1bqq-snapper-0.10.7/share/dbus-1/system-services/org.opensuse.Snapper.service
# who have MM installed but turned off. Thus the Exec path available to
# D-Bus is /bin/false, but systemd knows the real Exec path due to the MM
/gnu/store/5ca8f1gcc5ahn9kh2994mxnkwhny7csw-modem-manager-1.18.12/share/dbus-1/system-services/org.freedesktop.ModemManager1.service
Exec=libexec/fontinst_helper
/gnu/store/6hz6j922gs1861h49id3ddjsg02cwkl1-plasma-workspace-5.27.7/share/dbus-1/system-services/org.kde.fontinst.service
Exec=libexec/backlighthelper
/gnu/store/7m8l38wvi92bdar6li8amjaxhnvs6ffi-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service
Exec=libexec/chargethresholdhelper
/gnu/store/7m8l38wvi92bdar6li8amjaxhnvs6ffi-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.chargethresholdhelper.service
Exec=libexec/discretegpuhelper
/gnu/store/7m8l38wvi92bdar6li8amjaxhnvs6ffi-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.discretegpuhelper.service
Exec=libexec/kauth_ktexteditor_helper
/gnu/store/7xjgrp07s6vni8nr9j6kg43my94x4kr4-ktexteditor-5.114.0/share/dbus-1/system-services/org.kde.ktexteditor.katetextbuffer.service
Exec=libexec/kauth_ktexteditor_helper
/gnu/store/8bwwmnm1vsf16950cdm70c1vd8a1rhg4-ktexteditor-5.114.0/share/dbus-1/system-services/org.kde.ktexteditor.katetextbuffer.service
Exec=libexec/kde_ufw_plugin_helper
/gnu/store/d5vwa7vdcnf4vmarb9dz2690jgylxblp-plasma-firewall-5.27.7/share/dbus-1/system-services/org.kde.ufw.service
Exec=/usr/sbin/snapperd
/gnu/store/gc335dlb1y368fhv8625lmgp6bj1g3in-snapper-0.10.7/share/dbus-1/system-services/org.opensuse.Snapper.service
Exec=libexec/ksysguardprocesslist_helper
/gnu/store/i1n66kjkc1yd4ni1wpsgd40w1wvf3sji-libksysguard-5.27.7/share/dbus-1/system-services/org.kde.ksysguard.processlisthelper.service
Exec=libexec/kcmdatetimehelper
/gnu/store/l8f8fnv5ni0frawqh45yds1as494n26h-plasma-desktop-5.27.7/share/dbus-1/system-services/org.kde.kcontrol.kcmclock.service
Exec=libexec/kded-smart-helper
/gnu/store/llvacn6ibdrigxhg1bhqgsvad3ivpyqd-plasma-disks-5.27.7/share/dbus-1/system-services/org.kde.kded.smart.service
Exec=libexec/kinfocenter-dmidecode-helper
/gnu/store/mwlcz9f2dl650mvrhzll6c9msc4ppkhb-kinfocenter-5.27.7/share/dbus-1/system-services/org.kde.kinfocenter.dmidecode.service
Exec=libexec/fontinst_helper
/gnu/store/nv8ccgy6jzfjkik5c5vy6id7dplnbb1y-plasma-workspace-5.27.7/share/dbus-1/system-services/org.kde.fontinst.service
Exec=libexec/kded-smart-helper
/gnu/store/qw745xy5hz8viq4y6csrdw89nwyj0qxs-plasma-disks-5.27.7/share/dbus-1/system-services/org.kde.kded.smart.service
Exec=libexec/kinfocenter-dmidecode-helper
/gnu/store/srb98cwh801f5hr80vwv4mlnmspjsy0d-kinfocenter-5.27.7/share/dbus-1/system-services/org.kde.kinfocenter.dmidecode.service
Exec=libexec/ksysguardprocesslist_helper
/gnu/store/vhzhsdn13q1q8qfns23kb2l7w066ig7j-libksysguard-5.27.7/share/dbus-1/system-services/org.kde.ksysguard.processlisthelper.service
Exec=libexec/kcmdatetimehelper
/gnu/store/wcc6skf3p74s0mmhhs32hrzk3p9srid6-plasma-desktop-5.27.7/share/dbus-1/system-services/org.kde.kcontrol.kcmclock.service
Exec=libexec/backlighthelper
/gnu/store/zsszwz0q0h2vj4vbzw0lwj2vxvqjavn9-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service
Exec=libexec/chargethresholdhelper
/gnu/store/zsszwz0q0h2vj4vbzw0lwj2vxvqjavn9-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.chargethresholdhelper.service
Exec=libexec/discretegpuhelper
/gnu/store/zsszwz0q0h2vj4vbzw0lwj2vxvqjavn9-powerdevil-5.27.7/share/dbus-1/system-services/org.kde.powerdevil.discretegpuhelper.service
I
I
iyzsong wrote on 25 Apr 12:32 +0200
[PATCH] gnu: kauth: Fix KAUTH_HELPER_INSTALL_ABSOLUTE_DIR.
(address . guix-patches@gnu.org)
a51f1697f0fc5244ae83d8bfbbf250b7b33801d4.1714041115.git.iyzsong@member.fsf.org
From: ??? <iyzsong@member.fsf.org>

KAuth helpers use KAUTH_HELPER_INSTALL_ABSOLUTE_DIR as the prefix for "Exec="
in their dbus service files, which should really be an absolute directory.


* gnu/packages/kde-frameworks.scm (kauth)[arguments]<#:phases>: In
fix-cmake-install-directories phase, replace KAUTH_HELPER_INSTALL_DIR
with '${KDE_INSTALL_LIBEXECDIR}/kauth' and KAUTH_HELPER_INSTALL_ABSOLUTE_DIR
with '${KDE_INSTALL_FULL_LIBEXECDIR}/kauth'.

Change-Id: I57920c59dca503fd4bc8727cb35e1b0fb6016e56
---
gnu/packages/kde-frameworks.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 95c0f95e8c..8991c36f89 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1645,9 +1645,9 @@ (define-public kauth
(("@KAUTH_POLICY_FILES_INSTALL_DIR@")
"${KDE_INSTALL_DATADIR}/polkit-1/actions")
(("@KAUTH_HELPER_INSTALL_DIR@")
- "${KDE_INSTALL_LIBEXECDIR}")
+ "${KDE_INSTALL_LIBEXECDIR}/kauth")
(("@KAUTH_HELPER_INSTALL_ABSOLUTE_DIR@")
- "${KDE_INSTALL_LIBEXECDIR}"))))
+ "${KDE_INSTALL_FULL_LIBEXECDIR}/kauth"))))
(replace 'check
(lambda* (#:key tests? #:allow-other-keys)
(when tests?

base-commit: 4514239971895fc7ad47c7752e30d98a0c44a154
--
2.41.0
?
?
??? wrote on 25 Apr 12:34 +0200
Re: bug#70529: Several packages have dbus service files with broken file paths
(name . Nathan Dehnel)(address . ncdehnel@gmail.com)(address . 70529@debbugs.gnu.org)
87bk5xrar1.fsf@envs.net
Nathan Dehnel <ncdehnel@gmail.com> writes:

Toggle quote (13 lines)
> I was investigating powerdevil and snapper being broken and I
> discovered packages with incorrect file paths in the Exec line of
> their dbus services
>
> $ ls -d /gnu/store/**/share/dbus-1/services/** | grep -v
> profile/share/dbus-1 | while read line; do grep Exec $line 2>
> /dev/null | grep -v /gnu/store && echo $line >>/dev/stderr; done
> Exec=libexec/fontinst
> /gnu/store/6hz6j922gs1861h49id3ddjsg02cwkl1-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service
> Exec=libexec/fontinst
> /gnu/store/nv8ccgy6jzfjkik5c5vy6id7dplnbb1y-plasma-workspace-5.27.7/share/dbus-1/services/org.kde.fontinst.service
> [...]

Hello, thank you the report, I have send a patch to fix this (tested
fine with ktexteditor and plasma-disks).
M
M
Maxim Cournoyer wrote on 28 Apr 16:48 +0200
Re: [bug#70566] [PATCH] gnu: kauth: Fix KAUTH_HELPER_INSTALL_ABSOLUTE_DIR.
(address . iyzsong@envs.net)
87il01czmk.fsf@gmail.com
Hi,

iyzsong@envs.net writes:

Toggle quote (12 lines)
> From: ??? <iyzsong@member.fsf.org>
>
> KAuth helpers use KAUTH_HELPER_INSTALL_ABSOLUTE_DIR as the prefix for "Exec="
> in their dbus service files, which should really be an absolute directory.
>
> Fixes <https://issues.guix.gnu.org/70529>.
>
> * gnu/packages/kde-frameworks.scm (kauth)[arguments]<#:phases>: In
> fix-cmake-install-directories phase, replace KAUTH_HELPER_INSTALL_DIR
> with '${KDE_INSTALL_LIBEXECDIR}/kauth' and KAUTH_HELPER_INSTALL_ABSOLUTE_DIR
> with '${KDE_INSTALL_FULL_LIBEXECDIR}/kauth'.

Applied!

--
Thanks,
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70529@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70529
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch