dia: Fails to build (Meson: Function does not take positional arguments)

Hi! It looks like the Meson build of `dia` fails to complete in the version

of Guix shown below:

```

$ LANG=C guix describe

Generation 56 May 02 2023 11:25:26 (current)

guix 3f8c489

repository URL: https://git.savannah.gnu.org/git/guix.git

branch: master

commit: 3f8c4899a9a67bb509a603bd21dcfcfab88c0e8e

```

This is the final part of the build log:

```

starting phase `configure'

The Meson build system

Version: 1.1.0

Source dir: /tmp/guix-build-dia-0.97.3-3.0997887.drv-0/source

Build dir: /tmp/guix-build-dia-0.97.3-3.0997887.drv-0/build

Build type: native build

Project name: dia

Project version: 0.97.3

C compiler for the host machine: gcc (gcc 11.3.0 "gcc (GCC) 11.3.0")

C linker for the host machine: gcc ld.bfd 2.38

C++ compiler for the host machine: c++ (gcc 11.3.0 "c++ (GCC) 11.3.0")

C++ linker for the host machine: c++ ld.bfd 2.38

[…]

Message: wpg_filter

Message: xfig_filter

../source/sheets/meson.build:47:32: ERROR: Function does not take positional arguments.

A full log can be found at /tmp/guix-build-dia-0.97.3-3.0997887.drv-0/build/meson-logs/meson-log.txt

error: in phase 'configure': uncaught exception:

%exception #<&invoke-error program: "meson" arguments: ("setup" "--prefix=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887" "--buildtype=debugoptimized" "-Dc_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "-Dcpp_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "/tmp/guix-build-dia-0.97.3-3.0997887.drv-0/source") exit-status: 1 term-signal: #f stop-signal: #f>

phase `configure' failed after 3.0 seconds

command "meson" "setup" "--prefix=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887" "--buildtype=debugoptimized" "-Dc_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "-Dcpp_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "/tmp/guix-build-dia-0.97.3-3.0997887.drv-0/source" failed with status 1

```

I know nothing about Meson, but the error reminds me of

https://issues.guix.gnu.org/53182, and I see that its fix 3969dc45 added

`(arguments `(#:meson ,meson-0.59))`, which was removed later in f38d8e05.

Thanks and have a nice day!

--

Ivan Vilata i Balaguer -- https://elvil.net/

---

gnu/packages/gnome.scm | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

Hello,

gentle ping (and I forgot to Cc: the gnome team)

Thanks! Gio'

Giovanni Biscuolo <g@xelera.eu> writes:

[...]

--

Giovanni Biscuolo

Xelera IT Infrastructures

Ivan Vilata i Balaguer (2023-05-04 17:26:48 +0200) wrote:

The latest commit in Dia's Git repo (just 3 after the one use by Guix) states

"build: Fix deprecated positional argument for i18n.merge_file":

Building `--with-commit=dia=6ef461d8a04ffcd23df26fc4749cebc6322a5322` is successful.

I'll send a patch to fix this.

Cheers!

--

Ivan Vilata i Balaguer -- https://elvil.net/

Hello Ivan,

Ivan Vilata i Balaguer <ivan@selidor.net> writes:

I sent a patch on May 5th as #63274 [1] using commit

b903dd83aa5aab1b41c7864dd5027d1b6a0a190c, please send a V2 patch if you

think is better

Thanks! Gio'

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63274

--

Giovanni Biscuolo

Xelera IT Infrastructures

Fixes https://issues.guix.gnu.org/63274.

---

gnu/packages/gnome.scm | 7 ++++---

1 file changed, 4 insertions(+), 3 deletions(-)

Giovanni Biscuolo (2023-05-20 10:15:58 +0200) wrote:

Thanks Giovanni! Sorry that I didn't know about your patch, it looks like

Guix debbugs doesn't send copies of messages in the bug thread to involved

addresses (not even to the original poster??)… I kinda assumed it behaved

like Debian's. I'll remember to check the issue page and use "reply to all"

next time, just in case.

Yesterday I sent patch https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63592

(v2), not knowing about yours. I just checked your patch and it points to a

more recent commit than my patch, so I guess it fixes even more stuff, and I

see that Guix' version has anyway been quite ahead 1.9.5 for a while. So I

guess that your patch makes more sense. However, I see that you forgot to add

your copyright entry at the beginning of the file, and you may want to specify

that the patch fixes this issue too (you may want to adapt the commit message

from my v2 patch).

I sent a new version of your patch which just fixes that. I'll ask to close

my other patch issue.

Thanks again!

--

Ivan Vilata i Balaguer -- https://elvil.net/

Am Montag, dem 15.05.2023 um 16:52 +0200 schrieb Giovanni Biscuolo:

Pushed now.

Cheers

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Thanks, Liliana!

--

Thanks,

Maxim