[PATCH] gnu: Add guile-fibers-latest.

  • Done
  • quality assurance status badge
Details
3 participants
  • Ludovic Courtès
  • Christopher Baines
  • zimoun
Owner
unassigned
Submitted by
Christopher Baines
Severity
normal
C
C
Christopher Baines wrote on 25 Nov 2022 18:01
(address . guix-patches@gnu.org)
20221125170108.25413-1-mail@cbaines.net
* gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.
---
gnu/packages/guile-xyz.scm | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

Toggle diff (32 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b1620618eb..6505798f27 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -707,6 +707,25 @@ (define-public guile-fibers-1.1
(properties '((upstream-name . "fibers")))
(license license:lgpl3+)))
+(define-public guile-fibers-latest
+ (let ((commit "0fa712ecd85c65d7d11ce0c897f068fba4e6ef3f")
+ (revision "0"))
+ (package
+ (inherit guile-fibers-1.1)
+ (name "guile-fibers-latest")
+ (version (git-version (package-version guile-fibers-1.1)
+ revision
+ commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/wingo/fibers")
+ (commit commit)))
+ (file-name (git-file-name "guile-fibers" version))
+ (sha256
+ (base32
+ "0vfq4dkdq2szi5f99ywm856vll397c1x42a55rpxya61rrws8s9r")))))))
+
(define-public guile-fibers
(package
(inherit guile-fibers-1.1)
--
2.38.1
Z
Z
zimoun wrote on 25 Nov 2022 20:07
87edtqua2s.fsf@gmail.com
Hi Chris,

On Fri, 25 Nov 2022 at 17:01, Christopher Baines <mail@cbaines.net> wrote:
Toggle quote (2 lines)
> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.

From my understanding, the convention seems ’-next’ and not ’-latest’.

Toggle snippet (9 lines)
45 candidates:
./gnu/packages/freedesktop.scm:1210:(define-public wayland-protocols-next
./gnu/packages/bioconductor.scm:13526:(define-public r-cistopic-next

[...]

./gnu/packages/emacs-xyz.scm:25239:(define-public emacs-spaceline-next

Although, 6 packages are using ’-latest’. :-)

Toggle snippet (9 lines)
6 candidates:
./gnu/packages/guile-xyz.scm:1359:(define-public guile-email-latest
./gnu/packages/bioinformatics.scm:4161:(define-public java-htsjdk-latest
./gnu/packages/tls.scm:333:(define-public gnutls-latest
./gnu/packages/guile.scm:391:(define-public guile-3.0-latest
./gnu/packages/perl.scm:5493:(define-public perl-inc-latest
./gnu/packages/ruby.scm:5378:(define-public ruby-latest-ruby

Well, since this appears in the name, it appears to me better to have
the same convention; for discover-ability, for instance.


Cheers,
simon
L
L
Ludovic Courtès wrote on 28 Nov 2022 22:06
Re: bug#59578: [PATCH] gnu: Add guile-fibers-latest.
(name . Christopher Baines)(address . mail@cbaines.net)(address . 59578@debbugs.gnu.org)
87h6yiaivg.fsf@gnu.org
Hi Christopher,

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (2 lines)
> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.

I agree with zimoun that this should be “-next” but otherwise LGTM.

Thanks,
Ludo’.
C
C
Christopher Baines wrote on 6 Dec 2022 12:30
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 59578-done@debbugs.gnu.org)
871qpcn4ze.fsf@cbaines.net
Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (6 lines)
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.
>
> I agree with zimoun that this should be “-next” but otherwise LGTM.

Thanks both for looking at this, I've changed -next to -latest and
pushed this to master as ef2fba6fe3d020adfc95481fbd6958a62892aa45.

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOPKAVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xd0hw/9FcXgU23c1KNURWyUUWRJGGSp/Ug7yv1M
D+0Vsb6VuVgx3kn9KBVQ6/m+ctiNozwal6uWJAeK0XmrCImexy8CesZBtJ3FwoWN
tcGflfUuhz2GeRCSVEkqtj8QKpegV0gId3SMJBc6efFCwHd4KUC2zWFYkqS8DFUL
OHKqPgs4ppjQXPJcWQTC6sEbWc1XsPsI48DaUZcUzoPlUUjOMMYCo/JPGiEM7r0G
sfMTl54QkMxAV2AgLZ6uUJgudRbnMJKNBLsqv3lg+1kxisn4uBOckSwDNv3Q/BI4
Q1O7XzMutqz8aCDkBf6pNQJ7XpJRV1sDGL35OXAgrb+bomHhsd7PomQHQrKm0WaQ
5EgydG9h8q2xiHfCBvZwGZJbV87RLctiPF8FXfeJqumT75Ow+QCyJONQ7CwHepPK
TuDU1HQUTZxNoWB8/q87K8Gk0DjWAFlp13X81RSsWwRAZZhH6Ze45pGzj5yAUoOl
sIIst7spJ8k4uB4JK4BDIrkJTkPXuPsw23Awl+tFF2qamduELFXhKH19Ad9N2RVR
HS2z8596VhTDbT2kfCU2iPdWCSkNjT7slHNY8sxNK/310Jo/4q9GC8lpDL4snqzG
BXWthlHw1RMnbAxacYLlp83zwrZRb5ORhcd6O/ght2G2PRexselfMqkeEujcpNNQ
9OIbkMMhupk=
=lyT1
-----END PGP SIGNATURE-----

Closed
?