[PATCH] gnu: fortune-mod: Remove off database.

---

gnu/packages/games.scm | 5 ++++-

1 file changed, 4 insertions(+), 1 deletion(-)

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

[...]

(Perhaps also make “fortune-mod” a deprecated name for

“fortune-jkirchartz”.)

FWIW I’m fine with this change. Note that there’s also another patch

that removes the ‘off’ database of ‘fortune-mod’¹, though I don’t know

whether that would fully address the issues raised in this thread. It

will have to closed if/once this series is applied.

Thanks,

Ludo’.

¹ https://issues.guix.gnu.org/56599

Censorship is a tricky term, and it does not directly address why the

database is being removed. The phase should be more simply renamed to

remove-offensive-database, and include a comment on why the database is

being removed, referencing #54691.

Hi Ludo,

Am Mittwoch, dem 03.08.2022 um 15:43 +0200 schrieb Ludovic Courtès:

I'm getting mixed messages here. On the one hand, Maxime suggests not

propagating daikichi from fortune-jkirchartz (which makes it a plain

data package lacking a `fortune' command), on the other we want to mark

fortune-mod as deprecated. These are mutually exclusive options.

IIRC, I responded to such a patch already, though perhaps not that

thread in particular. To summarize, fortune-mod also propagates non-

nice things outside of ‘off’, so removing it is not enough.

Cheers

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

To me use of ‘deprecated-package’ in this case is just to ensure that

users who run ‘guix upgrade’ will transparently get

‘fortune-jkirchartz’. I don’t have a strong opinion though.

Alright, let’s remove ‘fortune-mod’ then.

Thanks for taking care of it!

Ludo’.

I believe what Liliana meant is that it's worse to 'transparently' upgrade to a data package that doesn't provide the 'fortune' command at all (or conversely, an implementation of the command that doesn't propagate the actual fortune data), than it is to signal to users through an error message that something's up and they need to stop and think.

(Er, that's a lot more words to put in someone's mouth than I intended to, sorry :-)

I'd suggest a news item but I really don't think this warrants it.

Kind regards,

T G-R

Sent on the go. Excuse or enjoy my brevity.

Am Donnerstag, dem 04.08.2022 um 15:37 +0000 schrieb Tobias Geerinckx-

Rice:

I'm not saying either option is worse than the other, just that we

can't pick both in a manner that provides a functioning package, and

that transparently upgrading to a package that does nothing is a pretty

bad option. We could transparently upgrade to daikichi, but that'd

just say "no fortunes found" because FORTUNE_PATH will be empty. Other

options would include a metapackage (also rejected by Maxime) or

providing a dummy fortune-mod package that fails at build with a

helpful message and is disabled in CI (came up as a shower thought).

Cheers

Hi Liliana,

Liliana Marie Prikler ???

I see; thanks for the clarification.

Then I *will* say that transparently upgrading to a package that

does nothing is worse than simple removal.

In fact, all of the proposed hacks are…

Kind regards,

T G-R

Hi,

On +2022-08-04 21:58:16 +0200, Tobias Geerinckx-Rice via Bug reports for GNU Guix wrote:

I hope the original is preserved somewhere for history's sake.

So where can I get a copy to see what all the fuss is about? :)

--

Regards,

Bengt Richter

It ain't what they call you, it's what you answer to.

-- W. C. Fields

Start every day off with a smile and get it over with.

-- W. C. Fields

On 07-08-2022 01:01, bokr@bokr.com wrote:

It's not merged yet IIUC, so you can just use the Guix package manager

to install the original.

For the history thing: we have "guix time-machine" and the SWH fallback.

Greetings,

Maxime.

Am Sonntag, dem 07.08.2022 um 01:05 +0200 schrieb Maxime Devos:

It is merged now, so take out your time machines if you want to have

offensive fortunes. Or build the datfiles with daikichi, I can't stop

you ;)