[PATCH 1/2] gnu: add python-librouteros

Open

Details

3 participants

Denis 'GNUtoo' Carikli
Ludovic Courtès
Maxime Devos

Owner: unassigned

Submitted by: Denis 'GNUtoo' Carikli

Severity: normal

Denis 'GNUtoo' Carikli wrote on 23 Apr 2022 18:44

Recipients:(address . guix-patches@gnu.org)(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)

Message-ID:20220423164428.28465-1-GNUtoo@cyberdimension.org

* gnu/packages/python-xyz.scm (python-librouteros): New variable

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>

---

gnu/packages/python-xyz.scm | 17 +++++++++++++++++

1 file changed, 17 insertions(+)

Toggle diff (37 lines)diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9a5d311680..8d6b91c8f7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -119,6 +119,7 @@
 ;;; Copyright © 2022 Evgeny Pisemsky <evgeny@pisemsky.com>
 ;;; Copyright © 2022 drozdov <drozdov@portalenergy.tech>
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -12347,6 +12348,22 @@ (define-public python-idna
 (define-public python2-idna
   (package-with-python2 python-idna))
 
+(define-public python-librouteros
+  (package
+    (name "python-librouteros")
+    (version "3.2.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "librouteros" version))
+              (sha256
+               (base32
+                "121z8w47sx9hczg0jhxwsy2ld1r52z9nnyxqzljb4vfphi0gkh78"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/luqasz/librouteros")
+    (synopsis "Python implementation of MikroTik RouterOS API")
+    (description "Python implementation of MikroTik RouterOS API")
+    (license license:gpl2)))
+
 (define-public python-libsass
   (package
     (name "python-libsass")
-- 
2.35.1

Denis 'GNUtoo' Carikli wrote on 23 Apr 2022 18:54

[PATCH 2/2] gnu: Add bundlewrap

Recipients:(address . 55083@debbugs.gnu.org)(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)

Message-ID:20220423165445.30956-1-GNUtoo@cyberdimension.org

* gnu/packages/configuration-management.scm (bundlewrap): New variable

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>

---

gnu/packages/configuration-management.scm | 41 +++++++++++++++++++++--

1 file changed, 38 insertions(+), 3 deletions(-)

Toggle diff (66 lines)diff --git a/gnu/packages/configuration-management.scm b/gnu/packages/configuration-management.scm
index c64b937fe5..cbbddf3cd1 100644
--- a/gnu/packages/configuration-management.scm
+++ b/gnu/packages/configuration-management.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust@gmail.com>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -18,11 +19,17 @@
 
 (define-module (gnu packages configuration-management)
   #:use-module (gnu packages)
-  #:use-module (guix build-system go)
-  #:use-module (guix git-download)
   #:use-module (gnu packages golang)
-  #:use-module (gnu packages version-control)
+  #:use-module (gnu packages python-crypto)
+  #:use-module (gnu packages python-web)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages ssh)
   #:use-module (gnu packages textutils)
+  #:use-module (gnu packages version-control)
+  #:use-module (guix build-system go)
+  #:use-module (guix build-system python)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils))
@@ -103,3 +110,31 @@ (define-public chezmoi
     (description "This package helps to manage personal configuration files
 across multiple machines.")
     (license license:expat)))
+
+(define-public bundlewrap
+  (package
+    (name "bundlewrap")
+    (version "4.13.6")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "bundlewrap" version))
+              (sha256
+               (base32
+                "1fsy5kjpacrca85ckxhwq1y4lci4ysls5raam75jpkzg5ra1fxj7"))))
+    (build-system python-build-system)
+    (inputs (list python-cryptography
+                  python-jinja2
+                  python-librouteros
+                  python-mako
+                  python-passlib
+                  python-pyaml
+                  python-requests
+                  python-tomlkit
+                  openssh))
+    (arguments
+     ;; Tests require network
+     `(#:tests? #f))
+    (synopsis "Agent-less configuration management")
+    (description "Agent-less configuration management with Python")
+    (home-page "https://bundlewrap.org/")
+    (license license:gpl3)))
-- 
2.35.1

Maxime Devos wrote on 23 Apr 2022 20:45

Re: [bug#55083] [PATCH 1/2] gnu: add python-librouteros

Recipients:

Message-ID:b82bfbcef16e06353571544d160f6b5b3efcc213.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:44 [+0200]:

Toggle quote (4 lines)

> * gnu/packages/python-xyz.scm (python-librouteros): New variable

> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>

While this is a thing for, say, the Linux kernel, Guix does not have a

DCO and this is not what Signed-off-by means in Guix. From the Guix

manual:

When pushing a commit on behalf of somebody else, please add a

‘Signed-off-by’ line at the end of the commit log message—e.g., with

‘git am --signoff’. This improves tracking of who did what.

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRJMhccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7upeAQDbz8bMf12YbSn6pedECLOtm6ZK

hN9eUsw2IJgOqwHF8wD/Ry8VmBXFjNmbH5NEJR5w8Vqlwt6pTvl0KaZY6kePbA8=

=3Ub6

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 20:45

Recipients:

Message-ID:74bd5814aee9776451fb20e0c157921aa7736956.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:44 [+0200]:

Toggle quote (3 lines)

> +�� (synopsis "Python implementation of MikroTik RouterOS API")

> +�� (description "Python implementation of MikroTik RouterOS API")

A description is missing here (it's identical to the synopsis)

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRJUxccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7joVAQCgNlAz5mopYKvq9+Kv8HiMSseq

/uVv9AcONOFDK0vutQEA7iLwcdOsLedG7cJfTrj51POpwboNhxrYFJdLiE57IQg=

=hvpm

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 20:48

Recipients:

Message-ID:8e74310feba017a21a008d1892cc927f5e0297e6.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:44 [+0200]:

Toggle quote (2 lines)

> +�� (license license:gpl2)))

GPL-2-only can easily cause compatibility issues, would upstream be
amenable to making it GPL-2-or-later, or (alternatively) just GPL-2-or-
3-at-your-choice?

Greetings,
Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRJ9RccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pfnAQCXnCpK36BWPtLbpoNUWHZcXuyB

1WWzAA5kQdinsQw/mQD+J5Lg3N4IylyPVgTG8iwABv8khMPX2CFQZDf9NAFs7Qs=

=hQDL

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 20:49

Re: [bug#55083] [PATCH 2/2] gnu: Add bundlewrap

Recipients:

Message-ID:82e750be4d7b9730b48f395fd96a1c5ee1a35188.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:54 [+0200]:

Toggle quote (2 lines)

> +�� (license license:gpl3)))

Isn't this incompatible with librouteros' license?

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRKHBccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tvqAP0b9iCoXJGaCLO3/evTATCKvze3

e/NzDtzI0DJfBNc5ZwEA6IgTGG4J5D9h6Q4DW+AP8GpOL0SYuFkOkVQYcMeRfQY=

=YpC9

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 20:52

Recipients:

Message-ID:df6b72d277b78000f61bdf74497cf03b91a32da0.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:54 [+0200]:

Toggle quote (3 lines)

> +�� (synopsis "Agent-less configuration management")

> +�� (description "Agent-less configuration management with Python")

What does this mean?  E.g., could I consider the text editor 'nano' to
be an ‘agent-less configuration management’ tool, because it allows me
the modify configuration files (‘managing’) and it doesn't have a
daemon (‘agent’)?

Greetings,
Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRK0hccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lW2APwMjJXn9/XmC3YGqY7wGsBBj+h2

g+qDl1MZ19npH1HoQgD+PoSSdPZr0WmkJU7r5tfIDs9k3SyIK/zkLhL+JCcnZA0=

=PWo6

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 20:55

Recipients:

Message-ID:88d22f3a4a0787153e3a54524372d7415932c203.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:54 [+0200]:

Toggle quote (2 lines)

> +�� python-requests

Is python-requests used for contacting https://URLs?  If so,
'bundlewrap' probably needs a SSL_CERT_FILE or SSL_CERT_DIR search path
(see, e.g., https://github.com/psf/requests/pull/2903).

Greeetings,
Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRLoRccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7m38AP9SdzfWo98Ydr1Lcy0+esoBwBih

8JZznosqEy8tJvbBvAEAoW4VsAfA3Mj1DldcNVB7HUVdT8iKFdDeUNuEpb73aQY=

=6hPr

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 21:00

Recipients:

Message-ID:270dce1ebc7434840fa404e6cf61d3d881ea638e.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:54 [+0200]:

Toggle quote (6 lines)

> +�� (method url-fetch)

> +�� (uri (pypi-uri "bundlewrap" version))

> +�� (sha256

> +�� (base32

> +��

It uses /usr/bin/less

https://github.com/bundlewrap/bundlewrap/blob/567b5f055067b1e23ea8081b24f1bebfdc44c541/bundlewrap/utils/ui.py#L122,

which does not exist in Guix.

It also uses git, bzr and hg:

https://github.com/bundlewrap/bundlewrap/blob/567b5f055067b1e23ea8081b24f1bebfdc44c541/bundlewrap/utils/scm.py#L10

these theoretically should be absolutised though there might be closure

size concerns.

There's also a use of 'stat':

https://github.com/bundlewrap/bundlewrap/blob/567b5f055067b1e23ea8081b24f1bebfdc44c541/bundlewrap/utils/remote.py#L8

Possibly there are more things to absolutise.

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRMuBccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tIwAQCydwFm6kbVQgyoUjzktsev7nMW

I7pw2RxOUEUXsG87iAEAtIONE0+3hGofA5tYbhsr1HivB8rg+wxOhpotdVqdNQc=

=B83p

-----END PGP SIGNATURE-----

Maxime Devos wrote on 23 Apr 2022 21:03

Recipients:

Message-ID:1ea13b25b658a664f32f0a54753d19704b4d980a.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:54 [+0200]:

Toggle quote (11 lines)> +(define-public bundlewrap
> +� (package
> +��� (name "bundlewrap")
> +��� (version "4.13.6")
> +��� (source (origin
> +������������� (method url-fetch)
> +������������� (uri (pypi-uri "bundlewrap" version))
> +������������� (sha256
> +�������������� (base32
> +��������������� "1fsy5kjpacrca85ckxhwq1y4lci4ysls5raam75jpkzg5ra1fxj7"))))

There appears to be some code that is broken in non-English locales:

"stat -c '%U:%G:%a:%s:%F' -- {}".format(quote(path)),

@property

def is_directory(self):

return self.stat['type'] == "directory"

@property

def is_file(self):

return self.stat['type'] in ("regular file", "regular empty

file")

@property

def is_symlink(self):

return self.stat['type'] == "symbolic link"

In my locale, it's 'map', not 'directory'.

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmRNjxccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7g/1AQCkY+oE4UVv0ZO7wf0mrBRp3iN4

X0dMfyVUi6XdV7uShwD8Cn9Y9qAneYR89NIb9bHRalKP9QRkw4ssjQ+kGA8J2gg=

=Sy55

-----END PGP SIGNATURE-----

Denis 'GNUtoo' Carikli wrote on 26 Apr 2022 17:32

Recipients:(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 55083@debbugs.gnu.org)

Message-ID:20220426173241.2ba56ef7@primarylaptop.localdomain

On Sat, 23 Apr 2022 20:49:00 +0200

Maxime Devos <maximedevos@telenet.be> wrote:

Toggle quote (4 lines)

> Denis 'GNUtoo' Carikli schreef op za 23-04-2022 om 18:54 [+0200]:

> > +�� (license license:gpl3)))

> Isn't this incompatible with librouteros' license?

Yes it is.

I've deduced both licenses from the setup.py file which as I understand

constitutes a statement of the project license (according to the GPL

FAQ you need statements to be sure of the license, not just a COPYING

file), but the issue is that they don't tell if it's GPLv2-only or

GPLv2-or-later (or GPLv3-only or GPLv3-or-later for bundlewrap's).

At first I've asked librouteros to clarify the situation[1] and

if that doesn't work I can still ask bundlewrap to add an exception for

linking against GPLv2-only code.

The later is also possible because there is some copyright assignment

process when sending patches to bundlewrap[2].

References:

-----------

[1]https://github.com/luqasz/librouteros/issues/129

[2]https://github.com/bundlewrap/bundlewrap/blob/main/CAA.md

Denis.

Ludovic Courtès wrote on 23 May 2022 15:19

Re: bug#55083: [PATCH 1/2] gnu: add python-librouteros

Recipients:(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)

Message-ID:87pmk475ez.fsf_-_@gnu.org

Hi Denis,

Did you have a chance to address Maxime’s comments?

Seems like little is missing to get those patches applied.

Thanks,

Ludo’.

Denis 'GNUtoo' Carikli wrote on 23 May 2022 18:08

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:20220523180849.02eda788@primarylaptop.localdomain

On Mon, 23 May 2022 15:19:16 +0200

Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (1 lines)

> Hi Denis,

Hi,

Toggle quote (3 lines)

> Did you have a chance to address Maxime’s comments?

> Seems like little is missing to get those patches applied.

I could do that but we can only merge python-librouteros.

python-librouteros doesn't want to change license so only bundlewrap

can fix that licensing issue.

I've reported the bug upstream[1], and as there is a CLA, a single

entity (here a company) owns all the copyright, and they don't want to

re-license as GPLv2 or GPLv2-or-later, so as I understand the only

options left are:

- to somehow remove the python-librouteros dependency completely

- to add an exception to link it to GPLv2 code

As for the later the project expressed some doubts on if it's really

possible or not:

Toggle quote (4 lines)

> Hm. Are you sure it's possible for me to "allow" BundleWrap to be

> linked against GPLv2 libs? Wouldn't that require the permission of

> the lib, rather than BundleWrap?

And so far I found the following information on the topic but nothing
really conclusive yet:
- https://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility
- https://www.gnu.org/licenses/gpl-faq.html#GPLIncompatibleLibs

And here the issue mentioned in the first link is the GPLv2 section 6
which has:

Toggle quote (5 lines)

> [...]

> You may not impose any further restrictions on the recipients'

> exercise of the rights granted herein.

> [...]

So here I'm not sure anymore if there is a way to somehow satisfy

the GPLv2 of the library just with an exception in bundlewrap.

I'm also very interested in understanding that issue better as I've

written software (were I still own all the copyright) that has somewhat

similar requirements (I want to release it under GPLv2 or later (to

be able to be merged upstream) with an exception for linking against

Apache libraries).

References:

-----------

[1]https://github.com/bundlewrap/bundlewrap/issues/709

Denis.

Maxime Devos wrote on 23 May 2022 18:37

Recipients:(address . 55083@debbugs.gnu.org)

Message-ID:eb7b8580688a3040620ba96abea021bfcd4ed992.camel@telenet.be

Denis 'GNUtoo' Carikli schreef op ma 23-05-2022 om 18:08 [+0200]:

Toggle quote (4 lines)

> I could do that but we can only merge python-librouteros.

> python-librouteros doesn't want to change license

Upstream clarified it's GPLv2-only, but AFAICT hasn't explicitly

expressed any opinion on whether they would mind relicensing. �I asked

for clarification [1]

[1]: https://github.com/luqasz/librouteros/issues/129#issuecomment-1134892145

Greetings,

Maxime.

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYou4XhccbWF4aW1lZGV2

b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qfQAP0YVs7fnUwbLEdo1OmgtGD6yQXR

VL/mgWHni67caHeVXwEA0qWRhFmW69D68WIQ9RU1RtIa3zZaZiWwuIBRSE1HYQk=

=wmKa

-----END PGP SIGNATURE-----

Denis 'GNUtoo' Carikli wrote on 29 Oct 2022 13:30

Re: gnu: add python-librouteros

Recipients:(address . 55083@debbugs.gnu.org)

Message-ID:20221029133029.7108fa0e@primary_laptop

Hi,

In the bug report about licensing it was unclear if

python-librouteros was GPLv2 only[1] or GPLv2 or later[2].

The comments were by the same person (the project owner in github) and

the one stating that it is GPLv2 or later came after the one stating

that it is GPLv2 only.

Bundlewrap considered it as GPLv2 of that later comment[3].

So to get a definitive clarification I send a patch to librouteros

for the license clarification[4] and it was accepted.

So I can now cleanup the code, update the packages to the latest

versions if necessary and get all that merged.

Do I need to use the exact commit with the license clarification or can

I use the latest release? Or do I backport that commit?

Since it's a license clarification and not a license change, I guess

that it works retrospectively too.

References:

-----------

[1]https://github.com/luqasz/librouteros/issues/129#issuecomment-1111537090

[2]https://github.com/luqasz/librouteros/issues/129#issuecomment-1136123888

[3]https://github.com/bundlewrap/bundlewrap/issues/709#issuecomment-1249674037

[4]https://github.com/luqasz/librouteros/commit/bbf0e580ac03b818190d2a3839046dc7e1a06a90

Denis.

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 55083@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 55083

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date