icedove clears user data on upgrade

  • Open
  • quality assurance status badge
Details
5 participants
  • Jonathan Brielmaier
  • Ludovic Courtès
  • Maxim Cournoyer
  • Maxime Devos
  • Nicholas von Klitzing
Owner
unassigned
Submitted by
Nicholas von Klitzing
Severity
normal
Merged with
N
N
Nicholas von Klitzing wrote on 14 Jan 2022 12:47
Download
(name . bug-guix@gnu.org)(address . bug-guix@gnu.org)
UshpRMynqqGYksf3DB_EDMyfDmE2zP4VU5FKrNzv8-ADlAffhoAh57_jlOmUyx4J_iY6fM9zWhlEdTzIiowFXnlRip8_J_yl8GsRAZB5vD8=@nvk.pm
Download
Hello Guix,

Every time I upgrade icedove (via guix pull && guix system reconfigure), all of my user data is cleared from icedove.

All of my mail settings, accounts, etc. are just gone and I need to manually set them all up again.

When I check ~/.icedove, my profile and settings are still there after the upgrades, but they're not loaded by icedove.

```
nicholas@guix14 ~$ ls .icedove/
dz83arz0.default/ profiles.ini
nicholas@guix14 ~$ cat .icedove/profiles.ini
[Profile0]
Name=default
IsRelative=1
Path=dz83arz0.default
Default=1

[General]
StartWithLastProfile=1
Version=2
```

Kind regards,
Nicholas
N
N
Nicholas von Klitzing wrote on 14 Jan 2022 13:02
Download
icedove clears data
(name . 53250@debbugs.gnu.org)(address . 53250@debbugs.gnu.org)
Yc13eyhNGiOWYjGvwKnR68azXgFVp6POj5cKmdsoHZ1YHiNTL-s2AmJiL9AG9ciUhczDTH8uL81rgoe55yJo2H9u2ZwHYoUQw_n0RW8bUQI=@nvk.pm
Download
A brief follow up:

It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).

Now looking into ~./thunderbird instead I see several more profiles.

```
nicholas@guix14 ~/.thunderbird$ ls
bv7r86h9.default/ installs.ini profiles.ini
gdmykixq.default-default-1/ k6sjw3jm.default-default/
nicholas@guix14 ~/.thunderbird$ cat profiles.ini
[Profile2]
Name=default-default-1
IsRelative=1
Path=gdmykixq.default-default-1

[Profile1]
Name=default
IsRelative=1
Path=bv7r86h9.default
Default=1

[Profile0]
Name=default-default
IsRelative=1
Path=k6sjw3jm.default-default

[Install281FC43567D8867D]
Default=gdmykixq.default-default-1
Locked=1

[General]
StartWithLastProfile=1
Version=2

[Install3F4F07DFB18472B1]
Default=k6sjw3jm.default-default
Locked=1
```

Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.

I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.

Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.

Kind regards,
Nicholas
M
M
Maxime Devos wrote on 14 Jan 2022 15:52
Download
a832628fb96cd0dbe8d23889d3eda94a1ad78d58.camel@telenet.be
Download
Nicholas von Klitzing via Bug reports for GNU Guix schreef op vr 14-01-
2022 om 12:02 [+0000]:
Toggle quote (30 lines)
> A brief follow up:
>
> It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
>
> Now looking into ~./thunderbird instead I see several more profiles.
>
> ```
> nicholas@guix14 ~/.thunderbird$ ls
> bv7r86h9.default/ installs.ini profiles.ini
> gdmykixq.default-default-1/ k6sjw3jm.default-default/
> nicholas@guix14 ~/.thunderbird$ cat profiles.ini
> [Profile2]
> [...]
> [Profile1]
> [...]
> [Profile0]
> [...]
> [Install281FC43567D8867D]
> [General]
> [...]
> [Install3F4F07DFB18472B1]
> [...]
> ```
>
> Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.
>
> I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.
>
> Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.

Maybe take a look at the following code in 'icedove':

;; Fixes issue where each installation directory generates its
own profile.
;; See e.g.
(add-after 'patch-source-shebangs 'fix-profile-setting
(lambda _
(substitute* "comm/mail/moz.configure"
(("MOZ_DEDICATED_PROFILES, True")
"MOZ_DEDICATED_PROFILES, False"))
#t))

Seems like this was fixed at some point but the fix broke?

Greetings,
Maxime.
Download
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeGOPRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gW/AQCUQbDpp4BTpv9woWNfbCGR/Wq7
OZeVlnkHjDNLZIepkAEAxlGwLpVU317NbJ1Zfc5i6+phPF4EmqiPeFxYDulM7g0=
=WlmX
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 14 Jan 2022 16:25
Download
Re: bug#53250: icedove clears user data on upgrade
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)(name . 53250@debbugs.gnu.org)(address . 53250@debbugs.gnu.org)
87ilum49vd.fsf_-_@gnu.org
Download
Hi,

Nicholas von Klitzing <nicholas@nvk.pm> skribis:

Toggle quote (4 lines)
> It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
>
> Now looking into ~./thunderbird instead I see several more profiles.

Indeed; when running ‘guix pull’, you might have seen this entry:

Icedove 91: profile folder moved to @file{~/.thunderbird}

Icedove 91 expects your profile folder under @file{~/.thunderbird}.
You need to manually copy your Icedove profiles from @file{~/.icedove} to
@file{~./thunderbird}. It may be required to start Icedove with
@option{--ProfileManager} for the first time after the migration.

HTH,
Ludo’.
N
N
Nicholas von Klitzing wrote on 17 Jan 2022 10:44
Download
Re: bug#53250: icedove clears data
(name . Maxime Devos)(address . maximedevos@telenet.be)(name . 53250@debbugs.gnu.org)(address . 53250@debbugs.gnu.org)
JPgtGUpjv1mcAeMCaDd2-1SmEJF7i7pz64aYVxDbDA5G-pEjbxoXUBZRIZnMif3mepCIX9Pd7G6dCIiwS3g4hNgQOvpUOfNs-_8yEx-lGhk=@nvk.pm
Download
Hi Maxime,

It seems that this issue is describing the new fix that is needed:

Only a simple patch would be necessary:

Kind regards,
Nicholas

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Friday, January 14th, 2022 at 2:52 PM, Maxime Devos <maximedevos@telenet.be> wrote:

Toggle quote (60 lines)
> Nicholas von Klitzing via Bug reports for GNU Guix schreef op vr 14-01-
>
> 2022 om 12:02 [+0000]:
>
> > A brief follow up:
> >
> > It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
> >
> > Now looking into ~./thunderbird instead I see several more profiles.
> >
> > nicholas@guix14 ~/.thunderbird$ ls
> > bv7r86h9.default/ installs.ini profiles.ini
> > gdmykixq.default-default-1/ k6sjw3jm.default-default/
> > nicholas@guix14 ~/.thunderbird$ cat profiles.ini
> > [Profile2]
> > [...]
> > [Profile1]
> > [...]
> > [Profile0]
> > [...]
> > [Install281FC43567D8867D]
> > [General]
> > [...]
> > [Install3F4F07DFB18472B1]
> > [...]
> >
> >
> > Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.
> >
> > I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.
> >
> > Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.
>
> Maybe take a look at the following code in 'icedove':
>
> ;; Fixes issue where each installation directory generates its
>
> own profile.
>
> ;; See e.g.
>
> https://trac.torproject.org/projects/tor/ticket/31457
>
> (add-after 'patch-source-shebangs 'fix-profile-setting
>
> (lambda _
>
> (substitute* "comm/mail/moz.configure"
>
> (("MOZ_DEDICATED_PROFILES, True")
>
> "MOZ_DEDICATED_PROFILES, False"))
>
> #t))
>
> Seems like this was fixed at some point but the fix broke?
>
> Greetings,
>
> Maxime.
N
N
Nicholas von Klitzing wrote on 17 Jan 2022 10:50
Download
(name . Maxime Devos)(address . maximedevos@telenet.be)(name . 53250@debbugs.gnu.org)(address . 53250@debbugs.gnu.org)
9XY6iMgv2chFVxLkl6tE7yYnC6e6W7p23cMZLTyzkjIKi8xoA7HbPh5T4iKIokiVgF61qqT-zFzBvuT7Dd_CSWJwiFrqvT6rHIYXm7MIYZY=@nvk.pm
Download
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, January 17th, 2022 at 9:44 AM, Nicholas von Klitzing <nicholas@nvk.pm> wrote:

Toggle quote (78 lines)
> Hi Maxime,
>
> It seems that this issue is describing the new fix that is needed:
>
> https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33734
>
> Only a simple patch would be necessary:
>
> https://gitlab.torproject.org/acat/tor-browser/-/commit/92f480c30178c0847e6866a4115a9393f1d49a28
>
> Kind regards,
>
> Nicholas
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Friday, January 14th, 2022 at 2:52 PM, Maxime Devos maximedevos@telenet.be wrote:
>
> > Nicholas von Klitzing via Bug reports for GNU Guix schreef op vr 14-01-
> >
> > 2022 om 12:02 [+0000]:
> >
> > > A brief follow up:
> > >
> > > It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
> > >
> > > Now looking into ~./thunderbird instead I see several more profiles.
> > >
> > > nicholas@guix14 ~/.thunderbird$ ls
> > > bv7r86h9.default/ installs.ini profiles.ini
> > > gdmykixq.default-default-1/ k6sjw3jm.default-default/
> > > nicholas@guix14 ~/.thunderbird$ cat profiles.ini
> > > [Profile2]
> > > [...]
> > > [Profile1]
> > > [...]
> > > [Profile0]
> > > [...]
> > > [Install281FC43567D8867D]
> > > [General]
> > > [...]
> > > [Install3F4F07DFB18472B1]
> > > [...]
> > >
> > >
> > > Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.
> > >
> > > I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.
> > >
> > > Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.
> >
> > Maybe take a look at the following code in 'icedove':
> >
> > ;; Fixes issue where each installation directory generates its
> >
> > own profile.
> >
> > ;; See e.g.
> >
> > https://trac.torproject.org/projects/tor/ticket/31457
> >
> > (add-after 'patch-source-shebangs 'fix-profile-setting
> >
> > (lambda _
> >
> > (substitute* "comm/mail/moz.configure"
> >
> > (("MOZ_DEDICATED_PROFILES, True")
> >
> > "MOZ_DEDICATED_PROFILES, False"))
> >
> > #t))
> >
> > Seems like this was fixed at some point but the fix broke?
> >
> > Greetings,
> >
> > Maxime.
Download
From 300eb9cc705f4529672f900bd107ba1dc7b69ad5 Mon Sep 17 00:00:00 2001
From: Nicholas von Klitzing <nicholas@nvk.pm>
Date: Mon, 17 Jan 2022 10:46:36 +0100
Subject: [PATCH] gnu: icedove: stop per-install profile generation.

* gnu/packages/gnuzilla.scm (): New variable.
---
gnu/packages/gnuzilla.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 27a9d099ce..bc7f32131b 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1371,8 +1371,8 @@ (define-public icedove
(add-after 'patch-source-shebangs 'fix-profile-setting
(lambda _
(substitute* "comm/mail/moz.configure"
- (("MOZ_DEDICATED_PROFILES, True")
- "MOZ_DEDICATED_PROFILES, False"))
+ (("MOZ_NORMANDY, True")
+ "MOZ_NORMANDY, False"))
#t))
(add-after 'prepare-thunderbird-sources 'rename-to-icedove
(lambda _
--
2.34.0
M
M
Maxime Devos wrote on 17 Jan 2022 11:36
Download
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)(name . 53250@debbugs.gnu.org)(address . 53250@debbugs.gnu.org)
06e0cb28e3647be193ceeda8211a811d918940c1.camel@telenet.be
Download
Nicholas von Klitzing schreef op ma 17-01-2022 om 09:44 [+0000]:
Toggle quote (7 lines)
> It seems that this issue is describing the new fix that is needed:
> https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33734
>
> Only a simple patch would be necessary:
> https://gitlab.torproject.org/acat/tor-browser/-/commit/92f480c30178c0847e6866a4115a9393f1d49a28
>

Seems reasonable to me (untested).

Greetings
Maxime (not a committer)
Download
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeVGxRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vy8AQDbFN318OW9G+f81BttzZvVU/ML
hHMb0tlSpFicUcw6HgD9E/68qiJNPACUuLx6SnbOQ2dDqPgBI8via9ZP0cNN0Ak=
=lOS0
-----END PGP SIGNATURE-----


J
J
Jonathan Brielmaier wrote on 17 Jan 2022 21:49
Download
icedove clears user data on upgrade
(address . 53250@debbugs.gnu.org)
3a6a5c1b-7045-eca6-4a52-a7644ad5e23b@web.de
Download
Hello Nicholas,

thanks for the patch, I test it right now :)

~Jonathan
J
J
Jonathan Brielmaier wrote on 19 Jan 2022 21:29
Download
[PATCH] gnu: icedove: Stop per-install profile generation.
(address . 53250@debbugs.gnu.org)
20220119202928.29726-1-jonathan.brielmaier@web.de
Download
From: Nicholas von Klitzing <nicholas@nvk.pm>


* gnu/packages/gnuzilla.scm (icedove)[arguments]: Disable MOZ_NORMANDY.

Signed-off-by: Jonathan Brielmaier <jonathan.brielmaier@web.de>
---
gnu/packages/gnuzilla.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index a9b5ed9fe9..929e43d71d 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1372,7 +1372,9 @@ (define-public icedove
(lambda _
(substitute* "comm/mail/moz.configure"
(("MOZ_DEDICATED_PROFILES, True")
- "MOZ_DEDICATED_PROFILES, False"))
+ "MOZ_DEDICATED_PROFILES, False")
+ (("MOZ_NORMANDY, True")
+ "MOZ_NORMANDY, False"))
#t))
(add-after 'prepare-thunderbird-sources 'rename-to-icedove
(lambda _
--
2.34.0
J
J
Jonathan Brielmaier wrote on 19 Jan 2022 21:33
Download
icedove clears user data on upgrade
(address . 53250@debbugs.gnu.org)
eb947030-c822-c983-9f8f-1206d4e26298@web.de
Download
I tested your patch, Nicholas, and the one I sent in. But sadly non of
them resolved the problem for me :(

Maybe we should add a service or something to start icedove always with
`icedove -P YOUR-PROFILE-NAME`. As a "dirty" hack...
N
N
Nicholas von Klitzing wrote on 19 Jan 2022 23:40
Download
(No Subject)
0w9x-LGg6YzFoqEpkVsaox-Cd4gUKiT2YIfMXS7tRCV43ZpZn-5_KX5EDkHxdMaoEu18OIT15xOJdgWIFwLPNZNiwc8jhUh1VmwNJUJSdQw=@nvk.pm
Download
Hi Jonathan,

Thanks for testing the patch. What exactly doesn't work?

Is icedove still generating new profiles upon install?

Even if it stops generating profiles, you still need to use `icedove -p` to select the correct default.

Kind regards,

Nicholas
Attachment: file
M
M
Maxim Cournoyer wrote on 20 Feb 18:05 +0100
Download
control message for bug #58763
(address . control@debbugs.gnu.org)
87ilfwl135.fsf@gmail.com
Download
merge 58763 53250
quit
M
M
Maxim Cournoyer wrote on 20 Feb 19:46 +0100
Download
Re: bug#53250: icedove clears user data on upgrade
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)
873570kwe1.fsf_-_@gmail.com
Download
Hi,

Nicholas von Klitzing <nicholas@nvk.pm> writes:

Toggle quote (8 lines)
> Hi Jonathan,
>
> Thanks for testing the patch. What exactly doesn't work?
>
> Is icedove still generating new profiles upon install?
>
> Even if it stops generating profiles, you still need to use `icedove -p` to select the correct default.

I believe the reason it wasn't working was because the substitution of
the MOZ_DEDICATED_PROFILES value to False was not effective:

I believe this should fix it:

Toggle snippet (14 lines)
modified gnu/packages/gnuzilla.scm
@@ -1335,8 +1335,8 @@ (define-public icedove-minimal
(add-after 'patch-source-shebangs 'fix-profile-setting
(lambda _
(substitute* "comm/mail/moz.configure"
- (("MOZ_DEDICATED_PROFILES, True")
- "MOZ_DEDICATED_PROFILES, False"))))
+ (("\"MOZ_DEDICATED_PROFILES\", True")
+ "\"MOZ_DEDICATED_PROFILES\", False"))))
(add-after 'build 'neutralize-store-references
(lambda _
;; Mangle the store references to compilers & other build tools in

Pushed to master as c81d2d448c, after testing resolution on an affected
machine.

Closing!

--
Thanks,
Maxim
?