[PATCH] Shell2Batch: New Package

DoneSubmitted by Jacob Hrbek.
Details
3 participants
  • david larsson
  • Julien Lepiller
  • Jacob Hrbek
Owner
unassigned
Severity
normal
J
J
Jacob Hrbek wrote on 18 Nov 2021 12:41
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
iyVc_WDzB13C41YwMkf71ROss-4R5ko_1Drb_6-zhkWa8PIpZ4sbIHiFEl2byDm_zeqg1dmy9pBvf6dM2ZMBoCBHMnbbTnoohPMGxUsZdf8=@rixotstudio.cz
DISCLAIMER: First time packaging things for guix, i have no idea what am i doing aAaAAaAAaAA

WARNING: Fails reproduction, no idea why, help me

-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
Attachment: file
Attachment: signature.asc
J
J
Jacob Hrbek wrote on 18 Nov 2021 12:48
Build log
(name . 51944@debbugs.gnu.org)(address . 51944@debbugs.gnu.org)
jErY_rH30oLaKHtCI4UnDgKTUFW9uXJ0fO9RIrvZJUh5jVWWy7MIO3EXl7ucns4Ulbl9gv6n7W2DtquAUOAS4lNKBvxgsdQsSr0TuuNWgW8=@rixotstudio.cz
-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
Attachment: file
Attachment: signature.asc
J
J
Jacob Hrbek wrote on 18 Nov 2021 20:04
New patch on roptat's request
(name . 51944@debbugs.gnu.org)(address . 51944@debbugs.gnu.org)
95dFbGnz_skwEogtl4EAFNSfF96XaFRKs5nnB-bq0X-ngqipGJJy74yn4zSrtDZJdCHFFpVFhwFSrWWNkoo_6AOttMTvIodbywLJlKyyHzo=@rixotstudio.cz
-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
Attachment: file
Attachment: signature.asc
D
D
david larsson wrote on 18 Nov 2021 20:32
Re: [bug#51944] [PATCH] Shell2Batch: New Package
(name . Jacob Hrbek)(address . kreyren@rixotstudio.cz)
4123b093aa23d4d5e4724e61b902bb48@selfhosted.xyz
On 2021-11-18 12:41, Jacob Hrbek wrote:
Toggle quote (14 lines)
> DISCLAIMER: First time packaging things for guix, i have no idea what
> am i doing aAaAAaAAaAA
> WARNING: Fails reproduction, no idea why, help me
>
> -- Jacob "Kreyren" Hrbek
>
> Sent with ProtonMail [1] Secure Email.
>
>
>
> Links:
> ------
> [1] https://protonmail.com/

Imn the synopsis you repeat the error "coverts", which should be
"converts". Secondly, in the description you may want to expand on the
synopsis. I found the following somewhere in the source repo, which you
could use as the description:

"While it is not really possible to take every shell script and
automatically convert it to a windows batch file, this library provides
a way to convert simple basic shell commands to windows batch commands."

Best regards,
David
J
J
Jacob Hrbek wrote on 18 Nov 2021 20:34
Added skip-build as requested by rekado_
(name . 51944@debbugs.gnu.org)(address . 51944@debbugs.gnu.org)
SGCRRa3Qi2WGss-8sFd7jAIf5OwBZfd8rI63omR-faEyXbxAGNLEwYN95fQnJQkt5ynT0EHgjvU-bYzP3LBtKEtTIGe95-NbDqVcx2F2y9Y=@rixotstudio.cz
-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
Attachment: file
Attachment: signature.asc
J
J
Jacob Hrbek wrote on 18 Nov 2021 20:39
Re: [bug#51944] [PATCH] Shell2Batch: New Package
(name . david larsson)(address . david.larsson@selfhosted.xyz)
G9TtnnyFxHpsqvTXbN1a7GABV3jBM4RCM4UysImjeyyyOzFLpLx03aLS4E7CnkJ6OO8WsTwVL3TmyLC2yedkJDdrOoJJcIzFtLqoHR3_TOY=@rixotstudio.cz


-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, November 18th, 2021 at 7:32 PM, david larsson <david.larsson@selfhosted.xyz> wrote:

Toggle quote (50 lines)
> On 2021-11-18 12:41, Jacob Hrbek wrote:
>

> > DISCLAIMER: First time packaging things for guix, i have no idea what
> >

> > am i doing aAaAAaAAaAA
> >

> > WARNING: Fails reproduction, no idea why, help me
> >

> > -- Jacob "Kreyren" Hrbek
> >

> > Sent with ProtonMail [1] Secure Email.
> >

> > Links:
> > ------
> >

> > [1] https://protonmail.com/
>

> Imn the synopsis you repeat the error "coverts", which should be
>

> "converts". Secondly, in the description you may want to expand on the
>

> synopsis. I found the following somewhere in the source repo, which you
>

> could use as the description:
>

> "While it is not really possible to take every shell script and
>

> automatically convert it to a windows batch file, this library provides
>

> a way to convert simple basic shell commands to windows batch commands."
>

> Best regards,
>

> David
Attachment: signature.asc
D
D
david larsson wrote on 18 Nov 2021 22:51
(name . Jacob Hrbek)(address . kreyren@rixotstudio.cz)
12e4fed645fb7a01775260ee657f89d8@selfhosted.xyz
I should have also mentioned this part (my apologies):

"Synopses must start with a capital letter and must not end with a
period." -

your patch ends with a period in the synopsis. That needs fixed.

(I do not have commit access. Im just reviewing your patch to prepare it
for being committed)

Best regards,
David
J
J
Julien Lepiller wrote on 18 Nov 2021 23:46
(name . Jacob Hrbek)(address . kreyren@rixotstudio.cz)
20211118234635.7842e026@tachikoma.lepiller.eu
Thanks for the patch! Pushed to master as
92d6f17dfd449208a657a1a54e3a287ae22d1da8.

I took the liberty to fix some parts of it that didn't correspond to
our standards. Have a look at the packaging guidelines in the manual to
better understand:

First, I renamed the patch file to rust-shell2batch-lint-fix.patch, so
it starts with the name of the package. I also modified a little bit
your message in the patch, to reference the issue there too, format at
80 lines and simplify the wording. I also added the patch file to
dist_patch_DATA, in gnu/local.mk. Whenever you add a patch file, please
make sure to add a reference in gnu/local.mk. This is necessary for
correctly generating the release tarballs.

Then, I fixed a few things in the package itself: I replaced tabs with
spaces and removed the empty line at the end of the file. I changed the
synopsis a bit so it better aligns with the rest of guix and removed
the period at the end. I also changed the description, mostly to wrap
it at 80 characters.

Finally, I fixed the commit message so it respects our conventions.
You'll find more info in the link above, and a lot of examples in the
git log history.

Some of these issues would have been caught by "guix lint
rust-shell2batch", I encourage you to run it on your next submissions :)

Have fun with guix :D
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 51944@debbugs.gnu.org