Hi On Sunday, August 8th, 2021 at 12:10 PM, pelzflorian (Florian Pelz) <email@example.com> wrote:
Toggle quote (8 lines)> On Sat, Aug 07, 2021 at 09:58:55PM +0000, phodina via Guix-patches via wrote:>> > - (home-page "https://github.com/wfeldt/libx86emu")>> FYI this is the same package as http://issues.guix.gnu.org/45744.>> I don’t know what became of it.
Thanks. I didn't know there's a patch already. The aim of this one is to get the hwinfo and hw-prober to get the hardware details. I've not encountered this situation. So what do you think is the best approach? Use the patch from Vincent Legoll and refactor the other two? So that both issues are closed? Kind regardsPetr
On Mon, Aug 09, 2021 at 12:00:00PM +0000, phodina wrote:
Toggle quote (2 lines)> Thanks. I didn't know there's a patch already. The aim of this one is to get the hwinfo and hw-prober to get the hardware details.
I think it is good to get your patch into shape and merged. While Ihaven’t been involved in package review (shame on me), I’ll give it atry. You should, after applying each of your patches, cd to the guix repoand run `./etc/indent-code.el gnu/packages/hardware.scm` as describedin `info '(guix)Formatting Code'`. `./pre-inst-env guix lint libx86emu` warns that your custom checkphase does not consider #:tests? (i.e. it does not work with the--without-tests transform option). As for the package libx86emu proper:
I am not sure, would it be better to delete this git2log in an originsnippet? I have not checked.
Toggle quote (14 lines)> (let* ((file (open-file "VERSION" "a")))> (display ,version file)> (close-port file))> (substitute* "Makefile"> (("/usr") "/"))))> (replace 'check> (lambda* _> (invoke "make" "test"))))))> (native-inputs `(("git" ,git) ("perl" ,perl) ("nasm" ,nasm)))> (synopsis "Library for x86 emulation")> (description "Small library to emulate x86 instructions. The focus here> is not a complete emulation (go for qemu for this) but to cover enough for> typical firmware blobs.
The start of the sentence is missing before @enumerate. “You can”?
Toggle quote (6 lines)> @enumerate> @item intercept any memory access or directly map real memory ranges> @item intercept any i/o access, map real i/o ports, or block any real i/o> @item intercept any interrupt> @item provides hook to run after each instruction
Either “provides a hook” or “provides hooks”.
Toggle quote (2 lines)> @item recognizes a special x86 instruction that can trigger logging
Toggle quote (2 lines)> @item has integrated logging
Hi, I have sent a patch for hw-probe (https://issues.guix.gnu.org/49934#9),which requires some refinements.  Some programs in the script are not patched, hence doesn't work in pure environment. Synopsis and description has to be revised. Finding a way to avoid propagation of hw-info. @phodina, Would you be able to hack on the above. Regards,RG.