[PATCH v3] gnu: icecat: Add WebAuthn support.

  • Done
  • quality assurance status badge
Details
One participant
  • Brice Waegeneire
Owner
unassigned
Submitted by
Brice Waegeneire
Severity
normal
Merged with
B
B
Brice Waegeneire wrote on 3 Jul 2021 22:15
(address . guix-patches@gnu.org)
20210703201552.28769-1-brice@waegenei.re
* gnu/packages/gnuzilla.scm (icecat)[inputs]: Add eudev.
[phases]: Add eudev to the wrapper.
---
gnu/packages/gnuzilla.scm | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)

I remember having testing one version of this patch successfully, in
retrospect it probably wasn't the one sent. I have tested this version
specificly with success in regards to WebAuth, trough the Yubico test website.

Toggle diff (56 lines)
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 6ec920141a..d118ae48e4 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -15,6 +15,7 @@
;;; Copyright © 2019, 2020 Adrian Malacoda <malacoda@monarch-pass.net>
;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier@web.de>
;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
+;;; Copyright © 2021 Brice Waegeneire <brice@waegenei.re>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -910,6 +911,7 @@ from forcing GEXP-PROMISE."
;; UNBUNDLE-ME! ("nss" ,nss)
("shared-mime-info" ,shared-mime-info)
;; UNBUNDLE-ME! ("sqlite" ,sqlite)
+ ("eudev" ,eudev)
("unzip" ,unzip)
("zip" ,zip)
;; UNBUNDLE-ME! ("zlib" ,zlib)
@@ -1271,24 +1273,21 @@ from forcing GEXP-PROMISE."
(lib (string-append out "/lib"))
(gtk (assoc-ref inputs "gtk+"))
(gtk-share (string-append gtk "/share"))
- (mesa (assoc-ref inputs "mesa"))
- (mesa-lib (string-append mesa "/lib"))
- (pulseaudio (assoc-ref inputs "pulseaudio"))
- (pulseaudio-lib (string-append pulseaudio "/lib"))
- (libxscrnsaver (assoc-ref inputs "libxscrnsaver"))
- (libxscrnsaver-lib (string-append libxscrnsaver "/lib"))
- (mit-krb5 (assoc-ref inputs "mit-krb5"))
- (mit-krb5-lib (string-append mit-krb5 "/lib")))
+ (ld-libs (map (lambda (lib)
+ (string-append (assoc-ref inputs lib)
+ "/lib"))
+ '("libxscrnsaver"
+ "mesa"
+ "mit-krb5"
+ "eudev"
+ "pulseaudio"))))
(wrap-program (car (find-files lib "^icecat$"))
`("XDG_DATA_DIRS" prefix (,gtk-share))
;; The following line is commented out because the icecat
;; package on guix has been observed to be unstable when
;; using wayland, and the bundled extensions stop working.
;; `("MOZ_ENABLE_WAYLAND" = ("1"))
- `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib
- ,mesa-lib
- ,libxscrnsaver-lib
- ,mit-krb5-lib)))
+ `("LD_LIBRARY_PATH" prefix ,ld-libs))
#t))))))
(home-page "https://www.gnu.org/software/gnuzilla/")
(synopsis "Entirely free browser derived from Mozilla Firefox")
--
2.31.1
B
B
Brice Waegeneire wrote on 6 Jul 2021 06:23
control message for bug #49362
(address . control@debbugs.gnu.org)
E1m0ccY-0006w0-FL@debbugs.gnu.org
merge 49362 48980
quit
B
B
Brice Waegeneire wrote on 4 Sep 2021 09:39
Re: bug#49362: [PATCH v3] gnu: icecat: Add WebAuthn support.
(address . 49362-done@debbugs.gnu.org)
877dfwhjs3.fsf_-_@waegenei.re
Brice Waegeneire <brice@waegenei.re> writes:

Toggle quote (3 lines)
> * gnu/packages/gnuzilla.scm (icecat)[inputs]: Add eudev.
> [phases]: Add eudev to the wrapper.

I pushed this a month or so ago as commit
bccfcef473da6d91f2c2cd444227721013570918.
Closed
?