[PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems.

OpenSubmitted by Leo Famulari.
Details
3 participants
  • Leo Famulari
  • Ludovic Courtès
  • Mathieu Othacehe
Owner
unassigned
Severity
important
L
L
Leo Famulari wrote on 23 Apr 20:53 +0200
(address . guix-patches@gnu.org)
b0a1ebc01ab84f43d5bddff5f54cea44dc04e513.1619203994.git.leo@famulari.name
We had several bug reports with a root cause of "the clock wasincorrect" from users who used the installer to install a non-graphicalGuix System.
* gnu/installer/services.scm (%system-services): Add the ntp-service-type.--- gnu/installer/services.scm | 6 ++++++ 1 file changed, 6 insertions(+)
Toggle diff (26 lines)diff --git a/gnu/installer/services.scm b/gnu/installer/services.scmindex ec5ea30594..440b8c67db 100644--- a/gnu/installer/services.scm+++ b/gnu/installer/services.scm@@ -2,6 +2,7 @@ ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -103,6 +104,11 @@ (type 'networking) (packages '((specification->package "nss-certs"))) (recommended? #t))+ (system-service+ (name (G_ "Network time service, to set the clock automatically"))+ (type 'network-management)+ (snippet '((service ntp-service-type)))+ (recommended? #t)) ;; Network connectivity management. (system-service-- 2.31.1
L
L
Leo Famulari wrote on 23 Apr 20:56 +0200
(address . 47979@debbugs.gnu.org)
YIMYaG4+hTJj5/s9@jasmine.lan
Hey everyone, please disregard this patch.
It doesn't do what I meant. Sorry for being hasty and sending the wrongthing.
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDGGgACgkQJkb6MLrKfwgzhBAA0Ii0++wXRQ0v0mbjyDVWkP4dU/+eEEuiuYeBlByM+7o0VI/K/T+VBPmrrOGnyA9Wt+t8Q3HeJnatDP81pkHbDoN4alj7CAgit+c4ZqJG2P607Q2RlcqxaFsIW9SRRa1/AjtFL/K3acABPJGBlYMEBqbNf4x5qLFuEzJVE91MBDZtrsqOo1HLgyiy8be8+KgVYBhrSbqKzyaMJBxBn61X8lanvNZ4MsIPHS7KbLKgA4IXrYFYk0XMEDxGZ2JUBeLAVT0PRFdOEzsMi4836gPh8lzSDzCFGbjvkNYEFYrVNoetNcWz3U6jfrhM1EHNIQgEYW5RzmYCMzbZQLnWh44IUSLNRoiz503ibB3lyWMOw+5Nh/yCwsfrYv82og/ndo1skIpe3NnXdiX5ySYxpJyf9eTM3IepXIUgt0Ht1K7/FuERHUWzUwFcCdVsHCl4ju/dqm6lXGBaJ9zEFB2NS5qj/YhuDJeYmF1dbbUjYtzqvDVcZe1SmxiWVm5Of59jRlQdi6jEiJnvrylO6r4m/KVfIrxzHKq2lSvRIJ23lLytwJ15sSoMpyPOkFn3OPoRWxtRk22Mu5JvCs1zyWTviNOeebYMV8HeR4z9MXxq2sDUV5OOY2ZeCOR9XO1fYkFm696HhYnkfHaAs97DvCEKQ3YVpovCLy+RmeYDy+rwgZTpxeE==u6bC-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 24 Apr 00:45 +0200
(address . 47979@debbugs.gnu.org)
YINOJ3HMdKFFKASf@jasmine.lan
Okay, here is a patch that does what I want.
That is, when the user does not select any desktop environments, itprompts them about enabling NTP, with the checkbox already checked.
However, with this patch, the installer crashes after partitioning, likethis:
------In ./gnu/installer/services.scm: 38:0 19 (%system-service-snippet-procedure (#<<system-service> name: "Network time service, to set the clock automatically" type: administration recommended?: #t snippet: ((service ntp-servi…>))In ice-9/boot-9.scm: 1669:16 18 (raise-exception _ #:continuable? _) 1667:16 17 (raise-exception _ #:continuable? _) 1667:16 16 (raise-exception _ #:continuable? _) 1667:16 15 (raise-exception _ #:continuable? _) 1667:16 14 (raise-exception _ #:continuable? _) 1667:16 13 (raise-exception _ #:continuable? _) 1667:16 12 (raise-exception _ #:continuable? _) 1667:16 11 (raise-exception _ #:continuable? _) 1667:16 10 (raise-exception _ #:continuable? _) 1667:16 9 (raise-exception _ #:continuable? _) 1667:16 8 (raise-exception _ #:continuable? _) 1667:16 7 (raise-exception _ #:continuable? _) 1764:13 6 (_ #<&compound-exception components: (#<&assertion-failure> #<&origin origin: "struct-vtable"> #<&message message: "Wrong type argument in position 1 (expecting struct): ~S"> #<&irrit…>)In ice-9/eval.scm: 619:8 5 (_ #(#(#<directory (guile-user) 7f8be12f4c80> #<<installer> name: newt init: #<procedure init ()> exit: #<procedure exit ()> exit-error: #<procedure exit-error (file key args)> f…>) …)) 619:8 4 (_ #(#(#(#<directory (guile-user) 7f8be12f4c80> #<<installer> name: newt init: #<procedure init ()> exit: #<procedure exit ()> exit-error: #<procedure exit-error (file key arg…>) …) #))In ice-9/ports.scm: 463:17 3 (call-with-output-file _ _ #:binary _ #:encoding _)In ice-9/eval.scm: 619:8 2 (_ #(#(#<directory (guile-user) 7f8be12f4c80> wrong-type-arg ("struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" ((#<<system-service> name: "Network …>)) …)) #)) 159:9 1 (_ #(#(#<directory (guile-user) 7f8be12f4c80> wrong-type-arg ("struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" ((#<<system-service> name: "Network …>)) …)) #))In unknown file: 0 (make-stack #t)ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in position 1 (expecting struct): (#<<system-service> name: "Network time service, to set the clock automatically" type: administration recommended?: #t snippet: ((service ntp-service-type)) packages: ()>)------
So, I've done something wrong. But I don't know what :)
I'm going to keep trying but hopefully somebody can help me.
From c70ed1b6ed621a56ab258cf5cfce45c50cb1831f Mon Sep 17 00:00:00 2001From: Leo Famulari <leo@famulari.name>Date: Fri, 23 Apr 2021 14:50:15 -0400Subject: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems.
We had several bug reports with a root cause of "the clock wasincorrect" from users who used the installer to install a non-graphicalGuix System.
* gnu/installer/services.scm (%system-services): Add the ntp-service-type.* gnu/installer/newt/services.scm (run-system-administration-cbt-page): Newvariable.(run-services-page): Use run-system-administration-cbt-page when notinstalling a desktop.--- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ 2 files changed, 30 insertions(+), 1 deletion(-)
Toggle diff (74 lines)diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scmindex 74f28e41ba..60c62a52b1 100644--- a/gnu/installer/newt/services.scm+++ b/gnu/installer/newt/services.scm@@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org> ;;; Copyright © 2021 Tobias Geerinckx-Rice <me@tobias.gr>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) +(define (run-system-administration-cbt-page)+ "Run a page to select various system adminstrative services."+ (let ((items (filter (lambda (service)+ (eq? 'administration+ (system-service-type service)))+ %system-services)))+ (run-checkbox-tree-page+ #:title (G_ "Miscellaneous services")+ #:info-text (G_ "Select miscellaneous system services to run on your system.")+ #:items items+ #:selection (map system-service-recommended? items)+ #:item->text (compose G_ system-service-name)+ #:checkbox-tree-height 5+ #:exit-button-callback-procedure+ (lambda ()+ (raise+ (condition+ (&installer-step-abort)))))))+ (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management")))@@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop)- (list (run-network-management-page))+ (list (run-network-management-page)+ (run-system-administration-cbt-page)) '()))))diff --git a/gnu/installer/services.scm b/gnu/installer/services.scmindex ec5ea30594..17ff31d2ec 100644--- a/gnu/installer/services.scm+++ b/gnu/installer/services.scm@@ -2,6 +2,7 @@ ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; System administration+ (system-service+ (name (G_ "Network time service, to set the clock automatically"))+ (type 'administration)+ (snippet '((service ntp-service-type)))+ (recommended? #t))+ ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager"))-- 2.31.1
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDTicACgkQJkb6MLrKfwjlRw/+MK0M4CWE8ia/QcGVtvBR4OBUVF+TE+cvTrpL+mmSKY+OND00IHOngicImhh7qUZcwlIIYFseox+IPO4Yw29SxYGOctyE+k2DqTkYJ8QFUKVetO9WKIqYdQF9LTEaG8wZQLakSPCvfZpw3FtD7D+//gwH9ncu42Z+4OXcGCugT2STurfzbTWioHnO4q+ASbbqAqO2rRxTaJg4jhEeUOTV2hDwGmCegtvHYJfukbLiuZyq6MU/bB1tWaDlBN2Yb5Kn9Apn8Nere1xGA/+3cUonrP/v85+eZ4VnwCpSEJb/8jlhLQEqTWSTbZ631sODXTIJWrXwbl8LaKStV4NmhSOYje7HwHRnksWzBLa5Ht+Kg6pb+zEEBubs0E06LFFT9akSestWqIngxDXCOUn9I3Cd3lXlpzvd4yT05zpbvJdzcOUtZbxb9R1hAdQ2lYUpfP7LK9S2kbPLtTugqoppIGs6dlezhONbwym8nDXZup/btgv0xObp2UcPu2FYKCk/O/oD50gK7Gbnk8cXUoMNZhlhgngXYCc+JW1XE/FhLN6o32C2d5yQuavdFo56DZ6JC2hVD+KfdmNcrwMRvlGb/euzu3R6AAJ27EAdrwGc8KD/Ba1v1fXhDWcHpg1l/KtCLKUrR7I1c21VopBjL4B9wvsu+Ti44rfXpMzxECNNK6FXGt0==gQrc-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 24 Apr 01:20 +0200
(address . 47979@debbugs.gnu.org)
YINWQz00YwrQP2l1@jasmine.lan
On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote:
Toggle quote (3 lines)> However, with this patch, the installer crashes after partitioning, like> this:
By the way, I'm testing this by building the installer in the same wayas our Makefile:
$ guix environment guix -- ./pre-inst-env guix system image -t iso9660 --label="GUIX_x86_64-linux-leo" --system=x86_64-linux gnu/system/install.scm
I create a QEMU disk:
$ qemu-img create -f qcow2 guix-system.img 50G
And then I use the ISO I built, after copying it out of the store:
$ qemu-system-x86_64 -m 1024 -smp 1 -enable-kvm -nic user,model=virtio-net-pci -boot menu=on,order=d -drive file=guix-system.img -drive media=cdrom,file=image.iso
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDVkMACgkQJkb6MLrKfwhBEA//e+eWdYCUeYAmyNXyaqocDSnOEd98VVhskGHjql4YChsow2JlIODHRWW0fghagCxtQrgrHs/YRnDbGTTuvKVTXckox3T+uAAIwWNGXNOaN3B46nPQp2dZX6SoFzyYelO7MmIlxh+p22GPT3cwaaIP1PsqcEMHNX1zi9Nz6+eGqbO4VbHnY2G/t9VyJSS8v001cOwpNsbFfh2kIUz3+5SQp8K6MSvpIC5v/JdvcaS9zODy7wTH1UjKz/kzhdj2YrMJEMwxz57mN8mlEKp2wa1c+5wyZktwIjL5qeYiEm4zVdXN+k38kT3ttZeFoNzqlDVNFcXWmYxDaniU05erbdvx06CNzpvHb6FZmvj0VHFrpV3/P3rUfEAgbPkkV4dwRGwbRd5WMp4NBnmWAo9n6X1nAAHyHsUtxKbm/Y5P12N37hx+pnvmoxYuOPwaEwfBcAz0r7656ZGYvKyDBfe3PTTJg9XUPDV423+doH5k1gyx8h0zL23FWUl4JI9isAcAFwRdaS5WwSsWe9fJ3IuJOzCXxz06Vl4tuD9J0FyzKSfId/y3WrtSD8lNqGqtXUd/C9/1sUSQJbGyZ0aebGpGL+nBG/blpAXcY9x+7IfxO5b335v3ExP8djb9Bxseu2XfQ4NoZt2pB5gEzwPb3wywasLUVWrGW0Usfcw8UXz7/bEmYSw==Vbie-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 24 Apr 02:56 +0200
Re: [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems.
(address . 47979@debbugs.gnu.org)
YINsy8LNhQd4NYmq@jasmine.lan
On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote:
Toggle quote (2 lines)> ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in position 1 (expecting struct): (#<<system-service> name: "Network time service, to set the clock automatically" type: administration recommended?: #t snippet: ((service ntp-service-type)) packages: ()>)
With Leo Prikler's help on #guix [0], I got it to work :)
I've attached the working patch, as well as a patch to offer the GPM"console mouse" service on non-graphical systems.
[0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921
From 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001From: Leo Famulari <leo@famulari.name>Date: Fri, 23 Apr 2021 14:50:15 -0400Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems.
We had several bug reports with a root cause of "the clock wasincorrect" from users who used the installer to install a non-graphicalGuix System.
* gnu/installer/services.scm (%system-services): Add the ntp-service-type.* gnu/installer/newt/services.scm (run-system-administration-cbt-page): Newvariable.(run-services-page): Use run-system-administration-cbt-page when notinstalling a desktop.--- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ 2 files changed, 30 insertions(+), 1 deletion(-)
Toggle diff (74 lines)diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scmindex 74f28e41ba..ee003b24b1 100644--- a/gnu/installer/newt/services.scm+++ b/gnu/installer/newt/services.scm@@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org> ;;; Copyright © 2021 Tobias Geerinckx-Rice <me@tobias.gr>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) +(define (run-system-administration-cbt-page)+ "Run a page to select various system adminstration services."+ (let ((items (filter (lambda (service)+ (eq? 'administration+ (system-service-type service)))+ %system-services)))+ (run-checkbox-tree-page+ #:title (G_ "Miscellaneous services")+ #:info-text (G_ "Select miscellaneous services to run on your system.")+ #:items items+ #:selection (map system-service-recommended? items)+ #:item->text (compose G_ system-service-name)+ #:checkbox-tree-height 5+ #:exit-button-callback-procedure+ (lambda ()+ (raise+ (condition+ (&installer-step-abort)))))))+ (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management")))@@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop)- (list (run-network-management-page))+ (cons (run-network-management-page)+ (run-system-administration-cbt-page)) '()))))diff --git a/gnu/installer/services.scm b/gnu/installer/services.scmindex ec5ea30594..b50bd3e412 100644--- a/gnu/installer/services.scm+++ b/gnu/installer/services.scm@@ -2,6 +2,7 @@ ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; Miscellaneous system administration services.+ (system-service+ (name (G_ "Network time service, to set the clock automatically"))+ (type 'administration)+ (recommended? #t)+ (snippet '((service ntp-service-type))))+ ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager"))-- 2.31.1
From a00274e70d700b9325ad9ab7cd1804d444a5dc37 Mon Sep 17 00:00:00 2001From: Leo Famulari <leo@famulari.name>Date: Fri, 23 Apr 2021 20:42:28 -0400Subject: [PATCH 2/2] installer: Offer 'gpm-service-type' for non-graphical systems.
* gnu/installer/services.scm (%system-services): Add the gpm-service-type.--- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+)
Toggle diff (17 lines)diff --git a/gnu/installer/services.scm b/gnu/installer/services.scmindex b50bd3e412..27beb5da66 100644--- a/gnu/installer/services.scm+++ b/gnu/installer/services.scm@@ -111,6 +111,10 @@ (type 'administration) (recommended? #t) (snippet '((service ntp-service-type))))+ (system-service+ (name (G_ "GPM mouse daemon, to use the mouse in the console"))+ (type 'administration)+ (snippet '((service gpm-service-type)))) ;; Network connectivity management. (system-service-- 2.31.1
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDbMgACgkQJkb6MLrKfwhyVQ/+I4Z9bPvlS/m9+XhUARgOepoymiLl3ykv4fdS6os5LSqdxDQp5LcaGyrL1FM1AOUrQZ0rd2ZO0XGpYh/eyvE+edaBP1Bpnd0/LTjzZqCn4z8fQo6xn1O6rDyOMuurlXYMlGivSZtngH0UeEcOi85JQaF6eBVIk9+yH4OCzS/e2HiFQhzmpE032vx8MLaJ5HycJFrmKmPCB53Zp+rkvjqwRL9S8b51afYp5hABxoGfSX2JkGARRSSfZxRDARtqvwqCgU3DzB6X7BmWBEa9MU5WWRGSc7wOX2CCPag6A6RbXcTO3rQV8P+xi8SDSkQB7WAlvHTx7ueLsn3SK/OBqKTVgtf98kFTtzBQiNfN4p+NFDPSQ/MpowNAO6NIWhZAQNNE/jMoZBVmOxKBbdDxCJk41K86Vvv4QV/IvXJC03s1eyraM/91cXgTG8+oIVr/q6Vbs3QErrsoZg2E/NVeS6rQaa/8vmiSkzM1+gel66NLBGVZBcOVKQayfc+AITKcr2fo6tPM3LxnHA/tKn44kFmGNeutGrcjeijHThYGHR1An/d51y1M5vVLaLEI/O/wNigTWVgAhHcmH64Y9zk1SSxJsFS4OzTpBs4CV3xZq8rTL8GXx+g8wux3sgLw/wMBlIJPgHd2KJdeFAUgIpAsHTflmXSa/H0kAbstw5QiV5bCCfI==U8RK-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 2 May 06:36 +0200
(address . 47979@debbugs.gnu.org)
YI4sPu8mD8UKwG9d@jasmine.lan
On Fri, Apr 23, 2021 at 08:56:43PM -0400, Leo Famulari wrote:
Toggle quote (23 lines)> With Leo Prikler's help on #guix [0], I got it to work :)> > I've attached the working patch, as well as a patch to offer the GPM> "console mouse" service on non-graphical systems.> > [0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921
> From 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001> From: Leo Famulari <leo@famulari.name>> Date: Fri, 23 Apr 2021 14:50:15 -0400> Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphical> systems.> > We had several bug reports with a root cause of "the clock was> incorrect" from users who used the installer to install a non-graphical> Guix System.> > * gnu/installer/services.scm (%system-services): Add the ntp-service-type.> * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New> variable.> (run-services-page): Use run-system-administration-cbt-page when not> installing a desktop.
Ping!
I suppose it's too late for 1.3.0, due to the string freeze.
But I am asking for review anyways.
M
M
Mathieu Othacehe wrote on 2 May 11:25 +0200
Re: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type' for non-graphical systems.
(name . Leo Famulari)(address . leo@famulari.name)(address . 47979@debbugs.gnu.org)
87sg351o9a.fsf@gnu.org
Hey Leo,
Toggle quote (2 lines)> I suppose it's too late for 1.3.0, due to the string freeze.
It looks rather nice, but I'll test it more thoroughly after therelease. Did you make sure that the installer tests are passing with:
make check-system TESTS="gui-installed-os gui-uefi-installed-osgui-installed-os-encrypted gui-installed-desktop-os-encrypted"
Thanks,
Mathieu
L
L
Leo Famulari wrote on 2 May 17:22 +0200
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 47979@debbugs.gnu.org)
YI7Do9YQ7+gAsuh2@jasmine.lan
On Sun, May 02, 2021 at 11:25:05AM +0200, Mathieu Othacehe wrote:
Toggle quote (11 lines)> > Hey Leo,> > > I suppose it's too late for 1.3.0, due to the string freeze.> > It looks rather nice, but I'll test it more thoroughly after the> release. Did you make sure that the installer tests are passing with:> > make check-system TESTS="gui-installed-os gui-uefi-installed-os> gui-installed-os-encrypted gui-installed-desktop-os-encrypted"
I tested it on "bare metal", but I will run the systems tests, too.
M
M
Mathieu Othacehe wrote on 21 May 14:58 +0200
Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems.
(name . Leo Famulari)(address . leo@famulari.name)(address . 47979@debbugs.gnu.org)
87lf88qm47.fsf_-_@gnu.org
Hey Leo,
Toggle quote (19 lines)> +(define (run-system-administration-cbt-page)> + "Run a page to select various system adminstration services."> + (let ((items (filter (lambda (service)> + (eq? 'administration> + (system-service-type service)))> + %system-services)))> + (run-checkbox-tree-page> + #:title (G_ "Miscellaneous services")> + #:info-text (G_ "Select miscellaneous services to run on your system.")> + #:items items> + #:selection (map system-service-recommended? items)> + #:item->text (compose G_ system-service-name)> + #:checkbox-tree-height 5> + #:exit-button-callback-procedure> + (lambda ()> + (raise> + (condition> + (&installer-step-abort)))))))
Indentation is off here,
Toggle quote (8 lines)> + ;; Miscellaneous system administration services.> + (system-service> + (name (G_ "Network time service, to set the clock automatically"))> + (type 'administration)> + (recommended? #t)> + (snippet '((service ntp-service-type))))> +
here,
Toggle quote (5 lines)> + (system-service> + (name (G_ "GPM mouse daemon, to use the mouse in the console"))> + (type 'administration)> + (snippet '((service gpm-service-type))))
and here. Those patches are breaking the installer tests because theyintroduce a new dialog. You need to add something like:
Toggle snippet (5 lines) ((checkbox-list (title "Miscellaneous services") (text _) (items ,services)) (filter choose-misc-service? services))
in the (gnu installer tests) module, to fix this error:
Toggle snippet (13 lines)conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))/gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) sexp: (checkbox-list (title "Miscellaneous services") (text "Select miscellaneous services to run on your system.") (items ("Network time service, to set the clock automatically" "GPM mouse daemon, to use the mouse in the console")))May 21 14:53:11 localhost instaBacktrace:ller[180]: running form #<newt-form 79dc20> ("Miscellaneous services") with 1 clients 2 (primitive-load "/gnu/store/9vzfy688gawwn2p06nn75kiqqz3?")In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(#<directory (guile-user) 7ffff3bb3f00> #<variabl?>))
Otherwise, it looks fine :)
Thanks,
Mathieu
L
L
Leo Famulari wrote on 21 May 15:37 +0200
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 47979@debbugs.gnu.org)
YKe3hmapmNSvhemn@jasmine.lan
Thanks for the review.
On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
Toggle quote (38 lines)> > +(define (run-system-administration-cbt-page)> > + "Run a page to select various system adminstration services."> > + (let ((items (filter (lambda (service)> > + (eq? 'administration> > + (system-service-type service)))> > + %system-services)))> > + (run-checkbox-tree-page> > + #:title (G_ "Miscellaneous services")> > + #:info-text (G_ "Select miscellaneous services to run on your system.")> > + #:items items> > + #:selection (map system-service-recommended? items)> > + #:item->text (compose G_ system-service-name)> > + #:checkbox-tree-height 5> > + #:exit-button-callback-procedure> > + (lambda ()> > + (raise> > + (condition> > + (&installer-step-abort)))))))> > Indentation is off here, > > > + ;; Miscellaneous system administration services.> > + (system-service> > + (name (G_ "Network time service, to set the clock automatically"))> > + (type 'administration)> > + (recommended? #t)> > + (snippet '((service ntp-service-type))))> > +> > here, > > > + (system-service> > + (name (G_ "GPM mouse daemon, to use the mouse in the console"))> > + (type 'administration)> > + (snippet '((service gpm-service-type))))> > and here.
I don't see the problems. I copied from existing pieces of similar codeand I don't really have a sense of what's right and wrong for indentingthis kind of thing.
Toggle quote (11 lines)> Those patches are breaking the installer tests because they> introduce a new dialog. You need to add something like:> > --8<---------------cut here---------------start------------->8---> ((checkbox-list (title "Miscellaneous services") (text _)> (items ,services))> (filter choose-misc-service? services))> --8<---------------cut here---------------end--------------->8---> > in the (gnu installer tests) module, to fix this error:
Okay, I'll work on that.
L
L
Leo Famulari wrote on 21 May 16:21 +0200
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 47979@debbugs.gnu.org)
YKfB/hBQUwLPrWci@jasmine.lan
On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
Toggle quote (11 lines)> Those patches are breaking the installer tests because they> introduce a new dialog. You need to add something like:> > --8<---------------cut here---------------start------------->8---> ((checkbox-list (title "Miscellaneous services") (text _)> (items ,services))> (filter choose-misc-service? services))> --8<---------------cut here---------------end--------------->8---> > in the (gnu installer tests) module, to fix this error:
How do I run this test? I can never figure out the names of the testsused by `make check-system`...
L
L
Leo Famulari wrote on 21 May 16:26 +0200
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 47979@debbugs.gnu.org)
YKfC+mRQMycoW/4d@jasmine.lan
On Fri, May 21, 2021 at 10:21:50AM -0400, Leo Famulari wrote:
Toggle quote (15 lines)> On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:> > Those patches are breaking the installer tests because they> > introduce a new dialog. You need to add something like:> > > > --8<---------------cut here---------------start------------->8---> > ((checkbox-list (title "Miscellaneous services") (text _)> > (items ,services))> > (filter choose-misc-service? services))> > --8<---------------cut here---------------end--------------->8---> > > > in the (gnu installer tests) module, to fix this error:> > How do I run this test? I can never figure out the names of the tests> used by `make check-system`...
With informed use of grep I found it:
`make check-system TESTS=iso-image-installer`.
M
M
Mathieu Othacehe wrote on 21 May 16:39 +0200
(name . Leo Famulari)(address . leo@famulari.name)(address . 47979@debbugs.gnu.org)
875yzcqhg4.fsf@gnu.org
Toggle quote (3 lines)> How do I run this test? I can never figure out the names of the tests> used by `make check-system`...
The installer tests are defined in the (gnu tests install) module. Youcan then search for "%test-gui" for all the graphical installationtests.
You can run all of them by typing:
Toggle snippet (4 lines)make check-system TESTS="gui-installed-os gui-uefi-installed-osgui-installed-os-encrypted gui-installed-desktop-os-encrypted"
Fixing the "gui-installed-os" test should be enough to fix all of themthough.
Thanks,
Mathieu
L
L
Leo Famulari wrote on 21 May 23:01 +0200
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 47979@debbugs.gnu.org)
YKgfsIih02iFbR6o@jasmine.lan
On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
Toggle quote (11 lines)> Those patches are breaking the installer tests because they> introduce a new dialog. You need to add something like:> > --8<---------------cut here---------------start------------->8---> ((checkbox-list (title "Miscellaneous services") (text _)> (items ,services))> (filter choose-misc-service? services))> --8<---------------cut here---------------end--------------->8---> > in the (gnu installer tests) module, to fix this error:
I started implementing this, in the attached v4 patch series.
I tried copying existing code, e.g. the choose-network-service?part of the tests.
However, it now crashes in a different way when I do `guix environmentguix -- make check-system TESTS=gui-installed-os -j1`:
------[...]building /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv...-builder for `/gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv' failed to produce output path `/gnu/store/f99fblkzb6ip268sg096shhs7wzjyp55-Python-3.5.9.tar.xz'build of /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv failedView build log at '/var/log/guix/drvs/fr/1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv.bz2'.cannot build derivation `/gnu/store/s7q1xs3mkld23v8541bvrzmq5j5xw5ad-Python-3.5.9.tar.xz.drv': 1 dependencies couldn't be built building /gnu/store/1nnawddi9gw8k71figgphhrpn86dzsxl-activate-service.scm.drv...cannot build derivation `/gnu/store/l2f280iinh1hfp19k49r9vlhnbmbbss8-python-minimal-3.5.9.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/k43m6gi372wzwz0xir1axms8vp2jyv1c-glibc-2.31.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/b1py4d1j3ym2k69zbzi0r3hh08afxkn9-shepherd-ntpd.scm.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/mf7gj4cn0cb9ml3c4v1n1kg1293jjp57-shepherd-ntpd.go.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/gs4kgf2x2syj64zf6s2r02sclffmf48n-shepherd.conf.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/dy6w4vsvrxzsq9hg8pj7731k6p0z90cg-boot.drv': 1 dependencies couldn't be builtbuilding /gnu/store/15j31c7b2kc4hf03yxpqjsibgkyi40rv-module-import-compiled.drv...cannot build derivation `/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-system.drv': 1 dependencies couldn't be built guix system: error: build of `/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-system.drv' failedconversation expecting pCommand failed with exit code 1. Press Enter to continue. attern ((quote installation-complete)) May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been stopped. May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been started. May 21 22:47:27 localhost installer[219]: command ("guix" "system" "init" "--fallback" "--no-grafts" "--no-substitutes" "/mnt/etc/config.scm" "/mnt") failed with exit code 1 May 21 22:47:27 localhost installer[183]: unmounting "/mnt/" /gnu/store/5fwnbmlfq6bp37n94j36jdcfapm0mhbz-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote installation-complete)) sexp: (installation-failure) Backtrace: 2 (primitive-load "/gnu/store/gpxpcz96pdckj3a69q5cjzxaxq5?") In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(#<directory (guile-user) 7fffefbabf00> #<variabl?>))
ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote (complete-installation installer-socket)))'.note: keeping build directory `/tmp/guix-build-installation.drv-8'builder for `/gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv' failed with exit code 1build of /gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv failedView build log at '/var/log/guix/drvs/np/hpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv.gz'.cannot build derivation `/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gui-installed-os.drv': 1 dependencies couldn't be builtguix build: error: build of `/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gui-installed-os.drv' failedmake: *** [Makefile:6859: check-system] Error 1------
I'm a little lost...
From ef1dfe36130fa276ce1b2a4213cde14d649bfbf8 Mon Sep 17 00:00:00 2001From: Leo Famulari <leo@famulari.name>Date: Fri, 23 Apr 2021 14:50:15 -0400Subject: [PATCH v4 1/2] installer: Recommend 'ntp-service-type' for non-graphical systems.
We had several bug reports with a root cause of "the clock wasincorrect" from users who used the installer to install a non-graphicalGuix System.
* gnu/installer/services.scm (%system-services): Add the ntp-service-type.* gnu/installer/newt/services.scm (run-system-administration-cbt-page): Newvariable.(run-services-page): Use run-system-administration-cbt-page when notinstalling a desktop.* gnu/installer/tests.scm (choose-services): Add and use achoose-misc-service? procedure.--- gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++- gnu/installer/services.scm | 8 ++++++++ gnu/installer/tests.scm | 11 +++++++++-- 3 files changed, 39 insertions(+), 3 deletions(-)
Toggle diff (133 lines)diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scmindex 74f28e41ba..ee003b24b1 100644--- a/gnu/installer/newt/services.scm+++ b/gnu/installer/newt/services.scm@@ -3,6 +3,7 @@ ;;; Copyright © 2019, 2020 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org> ;;; Copyright © 2021 Tobias Geerinckx-Rice <me@tobias.gr>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -68,6 +69,25 @@ system.") (condition (&installer-step-abort))))))) +(define (run-system-administration-cbt-page)+ "Run a page to select various system adminstration services."+ (let ((items (filter (lambda (service)+ (eq? 'administration+ (system-service-type service)))+ %system-services)))+ (run-checkbox-tree-page+ #:title (G_ "Miscellaneous services")+ #:info-text (G_ "Select miscellaneous services to run on your system.")+ #:items items+ #:selection (map system-service-recommended? items)+ #:item->text (compose G_ system-service-name)+ #:checkbox-tree-height 5+ #:exit-button-callback-procedure+ (lambda ()+ (raise+ (condition+ (&installer-step-abort)))))))+ (define (run-network-management-page) "Run a page to select among several network management methods." (let ((title (G_ "Network management")))@@ -99,5 +119,6 @@ client may be enough for a server.") (append desktop (run-networking-cbt-page) (if (null? desktop)- (list (run-network-management-page))+ (cons (run-network-management-page)+ (run-system-administration-cbt-page)) '()))))diff --git a/gnu/installer/services.scm b/gnu/installer/services.scmindex ec5ea30594..1dae40daec 100644--- a/gnu/installer/services.scm+++ b/gnu/installer/services.scm@@ -2,6 +2,7 @@ ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>+;;; Copyright © 2021 Leo Famulari <leo@famulari.name> ;;; ;;; This file is part of GNU Guix. ;;;@@ -104,6 +105,13 @@ (packages '((specification->package "nss-certs"))) (recommended? #t)) + ;; Miscellaneous system administration services.+ (system-service+ (name (G_ "Network time service (NTP), to set the clock automatically"))+ (type 'administration)+ (recommended? #t)+ (snippet '((service ntp-service-type))))+ ;; Network connectivity management. (system-service (name (G_ "NetworkManager network connection manager"))diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scmindex 8ccd327a7c..7a4989ef88 100644--- a/gnu/installer/tests.scm+++ b/gnu/installer/tests.scm@@ -220,7 +220,11 @@ ROOT-PASSWORD, and USERS." (string-contains service "NSS")))) (choose-network-management-tool? (lambda (service)- (string-contains service "DHCP"))))+ (string-contains service "DHCP")))+ (choose-misc-service?+ (lambda (service)+ (string-contains service "NTP"))))+ "Converse over PORT to choose networking services." (define desktop-environments '()) @@ -240,7 +244,10 @@ ROOT-PASSWORD, and USERS." (multiple-choices? #f) (items ,services)) (null? desktop-environments)- (find choose-network-management-tool? services))))+ (find choose-network-management-tool? services))+ ((checkbox-list (title "Miscellaneous services") (text _)+ (items ,services))+ (filter choose-misc-service? services)))) (define (edit-configuration-file file) "Edit FILE, an operating system configuration file generated by the-- 2.31.1

From 8fa2cd50e36835358c0533ded36674d5499b76fe Mon Sep 17 00:00:00 2001From: Leo Famulari <leo@famulari.name>Date: Fri, 23 Apr 2021 20:42:28 -0400Subject: [PATCH v4 2/2] installer: Offer 'gpm-service-type' for non-graphical systems.
* gnu/installer/services.scm (%system-services): Add the gpm-service-type.--- gnu/installer/services.scm | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/gnu/installer/services.scm b/gnu/installer/services.scmindex 1dae40daec..91b22c6f19 100644--- a/gnu/installer/services.scm+++ b/gnu/installer/services.scm@@ -111,6 +111,10 @@ (type 'administration) (recommended? #t) (snippet '((service ntp-service-type))))+ (system-service+ (name (G_ "GPM mouse daemon, to use the mouse in the console"))+ (type 'administration)+ (snippet '((service gpm-service-type)))) ;; Network connectivity management. (system-service-- 2.31.1
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCoH6kACgkQJkb6MLrKfwhtUA//SbL8Bvwk6597+T4davhVCnn2B3aGGdEog14jLZAKJaD7bvOcaj/S2yYoQX1eQdaiYPJZbxYGx3DsgpqU4urlGb10XQGAhU6GGZs0yTYD8Ez0VLoNfMxL/1OhD8mNmE+EN/1e7mgl+n7QubQWvb0p2k9VVKly3WGwLITc9ZNCPlD947zu8GC1ILp26KLqtDF9mQs0Aa6tkcPtr13dxg5sad5i9AeQzCIB9CpN96XCZgP0/xrSYMmKkCIyVk5PC3yQ/gkf2SMx/kd+hEq5dvP/2MapAA5Fot3DaLGqQbi4AD1IbobJXPc6VfDQDsxoxjBkfRJ7FNf+BdPanMR7zkV/SgNf/r4dY4+t5U8hhVcN9qdXbYDJaOyt+k3hT6gb3ETRTgUILPzb3VUS5AS6DKwTO0kvHgvB5lauSf7c/WLdJ74DVY4JNd62DjBrKLB6ukoQ/JzeB6htlGgJZp7o8YxyibfjtX8aEsbtZ5lKzDs8S5kIPUB0QytcPeOKrV3qDhrzOpgEbe85YVimvtbsTGoQzjLDfyXVAEXCCJqx1nlSepIglDQBSHdwylfLDKRVOUukFTtEuu1LJ1FEhzSEpZxNrJFnxhy8f6NgIqgib0gBlWEDJoABQWqN8CjXM9Wt8CTqvkssAzEasnciuG3MKkirpEQDjA/h+6dWDPW/4ilQyog==ZZo3-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 21 May 23:44 +0200
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 47979@debbugs.gnu.org)
YKgpxUpoZcU1IvPs@jasmine.lan
On Fri, May 21, 2021 at 05:01:36PM -0400, Leo Famulari wrote:
Toggle quote (3 lines)> I tried copying existing code, e.g. the choose-network-service?> part of the tests.
The tests succeed when I amend the v4 patch to do "(choose-misc-service?(const #f))" in (gnu installer tests).
I'm not really sure what it means :/
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCoKcUACgkQJkb6MLrKfwgfvw/+IKIrxmjP/nRSn9pwy0XzRa7znPfm37IJXmuv5LfCvG05p2fkCsL4rN97bBZJgY0Q5k1/T1PLRC8PmmRvEgkzmibwYn42HPkWsXng+DDnhptipUvvRvF74vqAxnhV+R4D81oaox1bpwQd9aFJW0gOhXsMzz47t77RDSL1jxnYJK9LM7fBqKfIc3MUKkaUofqZPs+8Xg5IkiHx2RZraqlhHeyijj+jtELoOQd6/3UCfcdY4Plqw29hYDNHgmvdvufVIhBNFWvUJ96mFg7pgiJUSqL0M8AaKtUn6IdReQjreaPYPi+KwltPVoPgscWRN6OlAxq8JItI8ghBM0V1RpNk5Ur/VlzDnxXtFdnU/ftlaTajAAtEIFjHAQdH7UVCqbzTEfitzEXbmH1im93tv65Pce7Aouv9nqOq7QCvkd3WdfuhcYFsiEoSw42TIeR9xtQDxdlqJe28lEowAUn1e/0KidhmhtL8mlndjbrMU+2R7iaVlZHfKloBKpi4mTJBZDdiT3qzbrOWy1al6RREBD750W0BI5HzzRKnFj+JiVmv+ZFk7PvxnKwaukBa6sku5SxO4y3nCANg72iI1snk0eUgbLurauNayFymsP+yXAfdGPr0M1G935V7EhBz05b+KVw2UXnjUKAl9AOvdfORDf3c7vwfX/jsBW24QA14E9Sk1hM==2QD0-----END PGP SIGNATURE-----

M
M
Mathieu Othacehe wrote on 1 Jun 11:49 +0200
(name . Leo Famulari)(address . leo@famulari.name)(address . 47979@debbugs.gnu.org)
87tumh6hj0.fsf@gnu.org
Hey Leo,
Toggle quote (2 lines)> cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies couldn't be built
The installation tests are run in a network isolated environment. Thismeans that we need to make sure that every single derivation that willbe needed during the installation is made available.
It is for sure a tricky business. If you have a look to the error line Ipasted above, you will see that the installer tries to build the ntppackage because the ntp-service-type is now included.
The following patch fixes the "gui-installed-os" test by making surethat the ntp package is available in the installation environment. I didnot check for the other installation tests.
Toggle snippet (18 lines)diff --git a/gnu/tests/install.scm b/gnu/tests/install.scmindex b5263f5f0d..e9ebc63b64 100644--- a/gnu/tests/install.scm+++ b/gnu/tests/install.scm@@ -1608,8 +1608,9 @@ build (current-guix) and then store a couple of full system images.") (swap-devices (if encrypted? '() (list (uuid "11111111-2222-3333-4444-123456789abc"))))- (services (cons (service dhcp-client-service-type)- (operating-system-user-services %minimal-os-on-vda)))))+ (services (cons* (service dhcp-client-service-type)+ (service ntp-service-type)+ (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f))
Thanks,
Mathieu
L
L
Ludovic Courtès wrote on 10 Jun 10:29 +0200
control message for bug #47979
(address . control@debbugs.gnu.org)
8735tqazrf.fsf@gnu.org
severity 47979 importantquit
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 47979@debbugs.gnu.org