Thanks for the review. On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote: > > +(define (run-system-administration-cbt-page) > > + "Run a page to select various system adminstration services." > > + (let ((items (filter (lambda (service) > > + (eq? 'administration > > + (system-service-type service))) > > + %system-services))) > > + (run-checkbox-tree-page > > + #:title (G_ "Miscellaneous services") > > + #:info-text (G_ "Select miscellaneous services to run on your system.") > > + #:items items > > + #:selection (map system-service-recommended? items) > > + #:item->text (compose G_ system-service-name) > > + #:checkbox-tree-height 5 > > + #:exit-button-callback-procedure > > + (lambda () > > + (raise > > + (condition > > + (&installer-step-abort))))))) > > Indentation is off here, > > > + ;; Miscellaneous system administration services. > > + (system-service > > + (name (G_ "Network time service, to set the clock automatically")) > > + (type 'administration) > > + (recommended? #t) > > + (snippet '((service ntp-service-type)))) > > + > > here, > > > + (system-service > > + (name (G_ "GPM mouse daemon, to use the mouse in the console")) > > + (type 'administration) > > + (snippet '((service gpm-service-type)))) > > and here. I don't see the problems. I copied from existing pieces of similar code and I don't really have a sense of what's right and wrong for indenting this kind of thing. > Those patches are breaking the installer tests because they > introduce a new dialog. You need to add something like: > > --8<---------------cut here---------------start------------->8--- > ((checkbox-list (title "Miscellaneous services") (text _) > (items ,services)) > (filter choose-misc-service? services)) > --8<---------------cut here---------------end--------------->8--- > > in the (gnu installer tests) module, to fix this error: Okay, I'll work on that.