[PATCH] gnu: fiano-fmap: turn off tests to build program.

  • Done
  • quality assurance status badge
Details
3 participants
  • Jack Hill
  • Adam Kandur
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Adam Kandur
Severity
normal
Merged with
A
A
Adam Kandur wrote on 31 Mar 2021 00:50
(name . Guix Patches)(address . guix-patches@gnu.org)
MX4K52s--3-2@tuta.io
From b5a149a0ae68eb2692463f0d77f3da686ff23864 Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd@tuta.io>
Date: Wed, 31 Mar 2021 01:46:49 +0300
Subject: [PATCH] gnu: fiano-fmap: turn off tests to build program.

* gnu/packages/admin.scm (fiano-fmap): turn off tests to build program.
---
 gnu/packages/admin.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 292a4bc..14f7864 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -4431,7 +4431,9 @@ disk utilization, priority, username, state, and exit code.")
     (name "fiano-fmap")
     (arguments
      `(#:import-path "github.com/linuxboot/fiano/cmds/fmap"
-       #:unpack-path "github.com/linuxboot/fiano"))))
+       #:unpack-path "github.com/linuxboot/fiano"
+       ;; tests dont work
+       #:tests? #f))))
 
 (define-public novena-eeprom
   (package
--
2.30.1
J
J
Jack Hill wrote on 31 Mar 2021 08:28
(name . Adam Kandur)(address . rndd@tuta.io)(address . 47506@debbugs.gnu.org)
alpine.DEB.2.21.2103310223520.8138@marsh.hcoop.net
Hi,

Thanks for your interest in fiano-fmap!

On Wed, 31 Mar 2021, Adam Kandur via Guix-patches via wrote:

Toggle quote (28 lines)
>
> From b5a149a0ae68eb2692463f0d77f3da686ff23864 Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd@tuta.io>
> Date: Wed, 31 Mar 2021 01:46:49 +0300
> Subject: [PATCH] gnu: fiano-fmap: turn off tests to build program.
>
> * gnu/packages/admin.scm (fiano-fmap): turn off tests to build program.
> ---
>  gnu/packages/admin.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 292a4bc..14f7864 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4431,7 +4431,9 @@ disk utilization, priority, username, state, and exit code.")
>      (name "fiano-fmap")
>      (arguments
>       `(#:import-path "github.com/linuxboot/fiano/cmds/fmap"
> -       #:unpack-path "github.com/linuxboot/fiano"))))
> +       #:unpack-path "github.com/linuxboot/fiano"
> +       ;; tests dont work
> +       #:tests? #f))))
>  
>  (define-public novena-eeprom
>    (package
>

When I first noticed the test failure in #45172 [0] it wasn't clear to me
that the test failure was harmless rather than exhibiting an actual problem
in our fiano-fmap package. Can you confirm that the package works as
expected? I also wonder if we could make a smaller change and just disable
the problematic test rather than the whole suite.

I've also noticed that fiano-fmap has a release candidate for version
6.0.0. I wonder if that version fixes the problem (I may have to give it a
try, although this one may come back to needing improvements in the
go-build-system).


Best,
Jack
J
J
Jack Hill wrote on 31 Mar 2021 16:42
fiano-fmap test failure
(address . control@debbugs.gnu.org)
alpine.DEB.2.21.2103311042000.8138@marsh.hcoop.net
reassign 47506 guix
merge 47506 45172
thanks
S
S
Sharlatan Hellseher wrote on 4 Apr 18:46 +0200
[PATCH] gnu: fiano-fmap: turn off tests to build program.
(address . 47506-done@debbugs.gnu.org)
871q7lqdo4.fsf@gmail.com
Hi,

Closing this issue as resolved in https://issues.guix.gnu.org/70123.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmYO2UsACgkQdtcnv/Ys
0rU8Xg//dzHk51LuG1ZtqQ2AB2w+G3BNlNLPpMavU6+7jCwRT7arq2aMlvhfDh9B
minnjfgCsqRlbyYGe5SNCiRgAwEgi6Ku+hJTgRgtrAbMtLC1dbi49Qw+O1caEkGq
viB+YzHSCXD0h0Qt7NxV/gUGA/elIbFnMGSe+nlFs/WPCF9HIAkquH8yBLbHnrPy
1MA4fsQnRgxm77CPkFuA02D7vlc5IfCI+R626Rp8duMm2+HfcUIM4CAAeEWLuQEY
86p9S3cnxseHYfja9Z91079dqBip1Ox9ZN5cFqHzzYgmd++Jxw/Cpeldgx2d3SwZ
clhNEbxj83Bi+dfFdfecNV1XIPdpFD95VMZ705fs4XyCTWP9XNnAVhFqJR6KeKVH
/sST1UnojlTnzMgzL7z8vfSoQeVjomCAXKQ3mBXcoQKj7+HBUVcvBDh3WllSdAne
/dQgrMmoAE+Ls6mB0GpIABSY4hgdtO0xUd0b/cvHjHyCIQQuhEZ2xlPocGKdkQHJ
ctp6ZNX+0rzNdggK7mu13ETilHvfQ0hiHFYH8OlqV1xJPYSj8gdd/8iOVF/HoWW3
5Xh4La0ULMa/qcTUOGRKm/pfgRVUSaPb04VKjeXh3jgcapqFIwj/PBLregBdhroA
GJNp52QTsJFfPI7OhU/9Db0PeptwRgYO98F9Wu9SwR34RXzxE6M=
=TXbj
-----END PGP SIGNATURE-----

Closed
?