[PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

OpenSubmitted by John Doe.
Details
One participant
  • John Doe
Owner
unassigned
Severity
normal
J
J
John Doe wrote on 22 Dec 2020 23:21
(address . guix-patches@gnu.org)(name . John Doe)(address . dftxbs3e@free.fr)
20201222222127.2659-1-dftxbs3e@free.fr
* gnu/packages/freedesktop.scm (udisks):
[inputs]: Add dosfstools.
[arguments]: Modify 'wrap-udisksd phase to add dosfstools in PATH with
wrapper.
---
gnu/packages/freedesktop.scm | 4 ++++
1 file changed, 4 insertions(+)

Toggle diff (31 lines)
diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 3c4ad57a15..1104a07955 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1112,6 +1112,7 @@ Analysis and Reporting Technology) functionality.")
     (inputs
      `(("acl" ,acl)
        ("cryptsetup" ,cryptsetup)
+       ("dosfstools" ,dosfstools)
        ("libatasmart" ,libatasmart)
        ("libblockdev" ,libblockdev)
        ("libgudev" ,libgudev)
@@ -1163,6 +1164,7 @@ Analysis and Reporting Technology) functionality.")
              (let ((out   (assoc-ref outputs "out"))
                    (utils (assoc-ref inputs "util-linux"))
                    (cryptsetup (assoc-ref inputs "cryptsetup"))
+                   (dosfstools (assoc-ref inputs "dosfstools"))
                    (parted (assoc-ref inputs "parted")))
                (wrap-program (string-append out "/libexec/udisks2/udisksd")
                  `("PATH" ":" prefix
@@ -1170,6 +1172,8 @@ Analysis and Reporting Technology) functionality.")
                     ;; cryptsetup is required for setting encrypted
                     ;; partitions, e.g. in gnome-disks
                     ,(string-append cryptsetup "/sbin")
+                    ;; Required to format FAT file systems in gnome-disks
+                    ,(string-append dosfstools "/sbin")
                     "/run/current-system/profile/bin"
                     "/run/current-system/profile/sbin")))
                #t))))))
-- 
2.29.2
D
D
dftxbs3e wrote on 22 Dec 2020 23:44
(address . 45374@debbugs.gnu.org)
a275d3e7369e3129ec0524cb69b7b9aea3d35499.camel@free.fr
Looks like there has already been some discussion about this:

So what do we do?

Patch libblockdev to use full paths or give it to udisksd's
environment?
-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQozTys6hLca3Ekt8u3HhLxn6GoewUCX+J2zQAKCRC3HhLxn6Go
e2uZAP9dSOoNdS9P9gy52hIYBsvYxGKeaHzHC9mw+0TpjwxQ5wEAzmLnComUE1vj
wD0z34HjAVxN0VCOq9gG2utCPoKO1w4=
=LdpI
-----END PGP SIGNATURE-----


?