[PATCH] gnu: Add gmic.

DoneSubmitted by Vinicius Monego.
Details
3 participants
  • Ludovic Courtès
  • Marius Bakke
  • Vinicius Monego
Owner
unassigned
Severity
normal
V
V
Vinicius Monego wrote on 19 Jun 2020 22:26
Download
(address . guix-patches@gnu.org)(name . Vinicius Monego)(address . monego@posteo.net)
20200619202625.35415-1-monego@posteo.net
Download
* gnu/packages/image-processing.scm (gmic): New variable.--- gnu/packages/image-processing.scm | 39 +++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
Toggle diff (59 lines)diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scmindex 801dc70149..efafcbacf0 100644--- a/gnu/packages/image-processing.scm+++ b/gnu/packages/image-processing.scm@@ -9,6 +9,7 @@ ;;; Copyright © 2018 Lprndn <guix@lprndn.info> ;;; Copyright © 2019 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>+;;; Copyright © 2020 Vinicius Monego <monego@posteo.net> ;;; ;;; This file is part of GNU Guix. ;;;@@ -487,6 +488,44 @@ quickly, especially on machines with more than one CPU core. This is primarily due to its architecture which automatically parallelises the image workflows.") (license license:lgpl2.1+))) +(define-public gmic+ (package+ (name "gmic")+ (version "2.9.1")+ (source+ (origin+ (method url-fetch)+ (uri (string-append+ "https://gmic.eu/files/source/gmic_"+ version ".tar.gz"))+ (sha256+ (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))+ (build-system cmake-build-system)+ (arguments+ `(#:tests? #f))+ (native-inputs+ `(("pkg-config" ,pkg-config)))+ (inputs+ `(("curl" ,curl)+ ("fftw" ,fftw)+ ("graphicsmagick" ,graphicsmagick)+ ("libjpeg-turbo" ,libjpeg-turbo)+ ("libpng" ,libpng)+ ("libtiff" ,libtiff)+ ("libx11" ,libx11)+ ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI+ ("openexr" ,openexr)+ ("zlib" ,zlib)))+ (home-page "https://gmic.eu/")+ (synopsis "Full-featured framework for digital image processing")+ (description "G'MIC is a full-featured framework for digital image+processing. It provides several user interfaces to convert / manipulate+/ filter / visualize generic image datasets, ranging from 1D scalar+signals to 3D+t sequences of multi-spectral volumetric images, hence+including 2D color images.")+ (license (list license:cecill ;; G'MIC is dual-licensed.+ license:cecill-c))))+ (define-public nip2 (package (name "nip2")-- 2.20.1
M
M
Marius Bakke wrote on 22 Jun 2020 23:13
Download
(name . Vinicius Monego)(address . monego@posteo.net)
87366mby84.fsf@gnu.org
Download
Vinicius Monego <monego@posteo.net> writes:
Toggle quote (2 lines)> * gnu/packages/image-processing.scm (gmic): New variable.
[...]
Toggle quote (16 lines)> +(define-public gmic> + (package> + (name "gmic")> + (version "2.9.1")> + (source> + (origin> + (method url-fetch)> + (uri (string-append> + "https://gmic.eu/files/source/gmic_"> + version ".tar.gz"))> + (sha256> + (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))> + (build-system cmake-build-system)> + (arguments> + `(#:tests? #f))
Can you add a comment about why tests are disabled?
Toggle quote (12 lines)> + (native-inputs> + `(("pkg-config" ,pkg-config)))> + (inputs> + `(("curl" ,curl)> + ("fftw" ,fftw)> + ("graphicsmagick" ,graphicsmagick)> + ("libjpeg-turbo" ,libjpeg-turbo)> + ("libpng" ,libpng)> + ("libtiff" ,libtiff)> + ("libx11" ,libx11)> + ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI
:-(
Toggle quote (12 lines)> + ("openexr" ,openexr)> + ("zlib" ,zlib)))> + (home-page "https://gmic.eu/")> + (synopsis "Full-featured framework for digital image processing")> + (description "G'MIC is a full-featured framework for digital image> +processing. It provides several user interfaces to convert / manipulate> +/ filter / visualize generic image datasets, ranging from 1D scalar> +signals to 3D+t sequences of multi-spectral volumetric images, hence> +including 2D color images.")> + (license (list license:cecill ;; G'MIC is dual-licensed.> + license:cecill-c))))
Can you expand on the license comment a bit? Can the user choose whichlicense, or do both apply somehow?
Otherwise LGTM, thanks!
Download
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7xHvsACgkQoqBt8qM6VPoN9Qf/SBHJoKX0VBftez4iUrrr7u0FYsDXwHxJrNRn/bkACxFdSE7U32KCty5/c1vYWWjQ6SKMLYQOi1e+U/gZjrj0ha4YZPsLweHUK/IjtyTZA3zh/8fJ+H3pc1aOadZDmf+auxngDaefazRGJw3Yfqva/hG4ofr9hcba52WhZwgkgW6pzXjBx52mJbYtZPZe15MymO7JBY/DEyE5Kw757EexK6sb3howEaGTPqxN6wmtiCwLLyqv77kTeRFR6v/Q+Kknrmz8Fv5WYhqIMFMh4igdKX4fXGZbid//VD+jN3qpbMCWRtyCupmHNbuCSy8Mm3gJO55WbnE3EvUbMHX6oifggg===S0x8-----END PGP SIGNATURE-----
V
V
Vinicius Monego wrote on 23 Jun 2020 00:01
Download
56c2220a8ca0246e3d13857b11376becbb79cd8a.camel@posteo.net
Download
Em seg, 2020-06-22 às 23:13 +0200, Marius Bakke escreveu:
Toggle quote (25 lines)> Vinicius Monego <monego@posteo.net> writes:> > > * gnu/packages/image-processing.scm (gmic): New variable.> > [...]> > > +(define-public gmic> > + (package> > + (name "gmic")> > + (version "2.9.1")> > + (source> > + (origin> > + (method url-fetch)> > + (uri (string-append> > + "https://gmic.eu/files/source/gmic_"> > + version ".tar.gz"))> > + (sha256> > + (base32> > "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))> > + (build-system cmake-build-system)> > + (arguments> > + `(#:tests? #f))> > Can you add a comment about why tests are disabled?
Yes, there are no tests.
Toggle quote (35 lines)> > + (native-inputs> > + `(("pkg-config" ,pkg-config)))> > + (inputs> > + `(("curl" ,curl)> > + ("fftw" ,fftw)> > + ("graphicsmagick" ,graphicsmagick)> > + ("libjpeg-turbo" ,libjpeg-turbo)> > + ("libpng" ,libpng)> > + ("libtiff" ,libtiff)> > + ("libx11" ,libx11)> > + ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI> > :-(> > > + ("openexr" ,openexr)> > + ("zlib" ,zlib)))> > + (home-page "https://gmic.eu/")> > + (synopsis "Full-featured framework for digital image> > processing")> > + (description "G'MIC is a full-featured framework for digital> > image> > +processing. It provides several user interfaces to convert /> > manipulate> > +/ filter / visualize generic image datasets, ranging from 1D> > scalar> > +signals to 3D+t sequences of multi-spectral volumetric images,> > hence> > +including 2D color images.")> > + (license (list license:cecill ;; G'MIC is dual-licensed.> > + license:cecill-c))))> > Can you expand on the license comment a bit? Can the user choose> which> license, or do both apply somehow?
This is an excerpt from the copyright header in one of the files:
# This software is governed either by the CeCILL or the CeCILL-Clicense # under French law and abiding by the rules of distribution of freesoftware.
From my limited understanding, the user can choose either.
I will send a v2 with the proposed changes.
Toggle quote (1 lines)> Otherwise LGTM, thanks!
L
L
Ludovic Courtès wrote on 3 Jul 2020 23:47
Download
control message for bug #41954
(address . control@debbugs.gnu.org)
87k0zkmfty.fsf@gnu.org
Download
tags 41954 fixedclose 41954 quit
?
Your may also send email to 41954@debbugs.gnu.org to comment.