From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 18:01:55 2020 Received: (at 41954) by debbugs.gnu.org; 22 Jun 2020 22:01:55 +0000 Received: from localhost ([127.0.0.1]:34823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnUVm-0003lh-Q7 for submit@debbugs.gnu.org; Mon, 22 Jun 2020 18:01:55 -0400 Received: from mout02.posteo.de ([185.67.36.66]:47507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnUVj-0003lQ-9N for 41954@debbugs.gnu.org; Mon, 22 Jun 2020 18:01:53 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C5AB72400FC for <41954@debbugs.gnu.org>; Tue, 23 Jun 2020 00:01:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1592863304; bh=aWbNmbhbL5YWdqOma0oKnTurxZsm8jVWBJmqwgiVIe4=; h=Subject:From:To:Date:From; b=Cq8+mcu6yePDt74kNNtHT0UgeXCABcAx+zBMNR90gO6J7vM+x1b1Hp2Fo5dpS22aB B/BHZYmEluNrYA43vJCQneqhMqS7TDduiqoZKS9/7XAYM0bQOCJ2LPrk5RXYvDfZ5b z1Z6h67DiNt1H/epVQaf11k8vqm81Re4zQqzVs9Gl83LYtiMtEf5gEc07Bv4ZHeq3T 1p2hwZP+Q+SALVOhhEbUZoutKS1wIqc7FpFCfOpk5LqBv0Mhm4GZlKQGEbiWYMjkeu ZEwkvYjiLI66xGlwVBjzj1UFJGYcYMKMUpaYdb79dgzYfkmXOJcCY1TxB1+NhK+y/i xLHzrfUoABfSg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49rNfb0cXrz6tmN; Tue, 23 Jun 2020 00:01:42 +0200 (CEST) Message-ID: <56c2220a8ca0246e3d13857b11376becbb79cd8a.camel@posteo.net> Subject: Re: [bug#41954] [PATCH] gnu: Add gmic. From: Vinicius Monego To: Marius Bakke , 41954@debbugs.gnu.org Date: Mon, 22 Jun 2020 19:01:38 -0300 In-Reply-To: <87366mby84.fsf@gnu.org> References: <20200619202625.35415-1-monego@posteo.net> <87366mby84.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: 41954 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Em seg, 2020-06-22 às 23:13 +0200, Marius Bakke escreveu: > Vinicius Monego writes: > > > * gnu/packages/image-processing.scm (gmic): New variable. > > [...] > > > +(define-public gmic > > + (package > > + (name "gmic") > > + (version "2.9.1") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + "https://gmic.eu/files/source/gmic_" > > + version ".tar.gz")) > > + (sha256 > > + (base32 > > "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah")))) > > + (build-system cmake-build-system) > > + (arguments > > + `(#:tests? #f)) > > Can you add a comment about why tests are disabled? Yes, there are no tests. > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (inputs > > + `(("curl" ,curl) > > + ("fftw" ,fftw) > > + ("graphicsmagick" ,graphicsmagick) > > + ("libjpeg-turbo" ,libjpeg-turbo) > > + ("libpng" ,libpng) > > + ("libtiff" ,libtiff) > > + ("libx11" ,libx11) > > + ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI > > :-( > > > + ("openexr" ,openexr) > > + ("zlib" ,zlib))) > > + (home-page "https://gmic.eu/") > > + (synopsis "Full-featured framework for digital image > > processing") > > + (description "G'MIC is a full-featured framework for digital > > image > > +processing. It provides several user interfaces to convert / > > manipulate > > +/ filter / visualize generic image datasets, ranging from 1D > > scalar > > +signals to 3D+t sequences of multi-spectral volumetric images, > > hence > > +including 2D color images.") > > + (license (list license:cecill ;; G'MIC is dual-licensed. > > + license:cecill-c)))) > > Can you expand on the license comment a bit? Can the user choose > which > license, or do both apply somehow? This is an excerpt from the copyright header in one of the files: # This software is governed either by the CeCILL or the CeCILL-C license # under French law and abiding by the rules of distribution of free software. From my limited understanding, the user can choose either. I will send a v2 with the proposed changes. > Otherwise LGTM, thanks!