[PATCH] gnu: Update protonvpn-cli to 2.2.4

DoneSubmitted by Ryan Prior.
Details
3 participants
  • Brice Waegeneire
  • Ludovic Courtès
  • Ryan Prior
Owner
unassigned
Severity
normal
R
R
Ryan Prior wrote on 3 Jun 2020 01:43
(address . guix-patches@gnu.org)
20200602234337.11487-1-rprior@protonmail.com
* gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4--- gnu/packages/vpn.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Toggle diff (42 lines)diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scmindex 0f0157806c..cdfddc1e54 100644--- a/gnu/packages/vpn.scm+++ b/gnu/packages/vpn.scm@@ -51,6 +51,7 @@ #:use-module (gnu packages guile) #:use-module (gnu packages libevent) #:use-module (gnu packages linux)+ #:use-module (gnu packages ncurses) #:use-module (gnu packages nss) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config)@@ -316,7 +317,7 @@ traversing network address translators (@dfn{NAT}s) and firewalls.") (define-public protonvpn-cli (package (name "protonvpn-cli")- (version "2.2.2")+ (version "2.2.4") (source (origin ;; PyPI has a ".whl" file but not a proper source release.@@ -328,7 +329,7 @@ traversing network address translators (@dfn{NAT}s) and firewalls.") (file-name (git-file-name name version)) (sha256 (base32- "0ixjb02kj4z79whm1izd8mrn2h0rp9cmw4im1qvp93rahqxdd4n8"))))+ "08yca0a0prrnrc7ir7ajd56yxvxpcs4m1k8f5kf273f5whgr7wzw")))) (build-system python-build-system) (arguments '(#:tests? #f)) ; no tests in repo (native-inputs@@ -337,7 +338,8 @@ traversing network address translators (@dfn{NAT}s) and firewalls.") `(("pythondialog" ,python-pythondialog) ("requests" ,python-requests))) (propagated-inputs- `(("openvpn" ,openvpn)))+ `(("openvpn" ,openvpn)+ ("dialog" ,dialog))) (synopsis "Command-line client for ProtonVPN") (description "This is the official command-line interface for ProtonVPN, a secure-- 2.26.2
B
B
Brice Waegeneire wrote on 7 Jun 2020 23:18
(name . Ryan Prior)(address . rprior@protonmail.com)(address . 41679@debbugs.gnu.org)
877dwilgma.fsf@waegenei.re
Hello Ryan,
Thank you for the patch!
Ryan Prior <rprior@protonmail.com> writes:
Toggle quote (5 lines)> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4> ---> gnu/packages/vpn.scm | 8 +++++---> 1 file changed, 5 insertions(+), 3 deletions(-)
The update is fine, but that package is missing several dependencies, atleast: python-jinja2, coreutils and iproute. Try running it in a pureenvironment and it will crash “guix environment --pure --container--ad-hoc protonvpn-cli -- protonvpn -h”.
Searching the source for “subprocess.run” I find call to other binarieswhich aren't listed as dependencies. Could you wrap the “protonvpn”binary with the “PATH” of all the binaries it uses to avoid propagatinga whole lot of packages. Probably only “python-jinja2” should bepropagated.
- Brice
L
L
Ludovic Courtès wrote on 9 Sep 2020 23:08
(name . Ryan Prior)(address . rprior@protonmail.com)
87ft7qlktu.fsf@gnu.org
Hi Ryan,
Ryan Prior <rprior@protonmail.com> skribis:
Toggle quote (2 lines)> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4
Applied!
Brice Waegeneire <brice@waegenei.re> skribis:
Toggle quote (11 lines)> The update is fine, but that package is missing several dependencies, at> least: python-jinja2, coreutils and iproute. Try running it in a pure> environment and it will crash “guix environment --pure --container> --ad-hoc protonvpn-cli -- protonvpn -h”.>> Searching the source for “subprocess.run” I find call to other binaries> which aren't listed as dependencies. Could you wrap the “protonvpn”> binary with the “PATH” of all the binaries it uses to avoid propagating> a whole lot of packages. Probably only “python-jinja2” should be> propagated.
Alternatively, we can substitute file names (of jinja2, coreutils, andiproute programs) with absolute file names.
That can be addressed separately, though.
Thanks,Ludo’.
L
L
Ludovic Courtès wrote on 14 Sep 2020 10:59
control message for bug #41679
(address . control@debbugs.gnu.org)
874ko0pwdn.fsf@gnu.org
tags 41679 fixedclose 41679 quit
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 41679@debbugs.gnu.org