From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 17:08:43 2020 Received: (at 41679) by debbugs.gnu.org; 9 Sep 2020 21:08:43 +0000 Received: from localhost ([127.0.0.1]:34933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG7Kd-0008Ta-E2 for submit@debbugs.gnu.org; Wed, 09 Sep 2020 17:08:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG7Kc-0008TL-2l for 41679@debbugs.gnu.org; Wed, 09 Sep 2020 17:08:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43940) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG7KW-00011s-1n; Wed, 09 Sep 2020 17:08:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55730 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kG7KV-0005kV-J2; Wed, 09 Sep 2020 17:08:35 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ryan Prior Subject: Re: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4 References: <20200602234337.11487-1-rprior@protonmail.com> Date: Wed, 09 Sep 2020 23:08:29 +0200 In-Reply-To: <20200602234337.11487-1-rprior@protonmail.com> (Ryan Prior's message of "Tue, 02 Jun 2020 23:43:48 +0000") Message-ID: <87ft7qlktu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41679 Cc: 41679@debbugs.gnu.org, Brice Waegeneire X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ryan, Ryan Prior skribis: > * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4 Applied! Brice Waegeneire skribis: > The update is fine, but that package is missing several dependencies, at > least: python-jinja2, coreutils and iproute. Try running it in a pure > environment and it will crash =E2=80=9Cguix environment --pure --container > --ad-hoc protonvpn-cli -- protonvpn -h=E2=80=9D. > > Searching the source for =E2=80=9Csubprocess.run=E2=80=9D I find call to = other binaries > which aren't listed as dependencies. Could you wrap the =E2=80=9Cprotonvp= n=E2=80=9D > binary with the =E2=80=9CPATH=E2=80=9D of all the binaries it uses to avo= id propagating > a whole lot of packages. Probably only =E2=80=9Cpython-jinja2=E2=80=9D sh= ould be > propagated. Alternatively, we can substitute file names (of jinja2, coreutils, and iproute programs) with absolute file names. That can be addressed separately, though. Thanks, Ludo=E2=80=99.