gnu: claws-mail: Fix fhs directories.

OpenSubmitted by Raghav Gururajan.
Details
4 participants
  • Danny Milosavljevic
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
  • Raghav Gururajan
Owner
unassigned
Severity
normal
R
R
Raghav Gururajan wrote on 6 May 15:06 +0200
(address . guix-patches@gnu.org)
20200506090638.36eb28eb.raghavgururajan@disroot.org
D
D
Danny Milosavljevic wrote on 8 May 19:29 +0200
claws-mail
(address . 41111@debbugs.gnu.org)
20200508192929.07cad57b@scratchpost.org
Hi,
I think that this patch does a lot more than "Fix fhs directories".
Could you split it into multiple patches, each with a high-level subject thatallows the reviewer to find out the reason for it?
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl61lvoACgkQ5xo1VCwwuqV74Af+PB0CSohcqkB0qaJnPyBgP7BmKSFIEmo7hp8QMLNqgO+5oZnxFBGd1SEa/JZH3CMxEaxegSmsQVnuUlhXznS9y2FGC5PUCToJVAkJyt5392HoUKWwE8yGs06gdpDs026KJ22JzdK6RiujFQC6567hPBbLer+6FahhhwN2jSq84jdJnv5OSIf5YOk9UCs5GE3N0RwLr6zVhJrK4x0Tj6L9OXREuT16QPB2D14Gojy3BURxijDoG3boOgxgj3ILMDmH+35IVf9Mc4+ThLRF0N+ZPUTNwJ1qms/p7X8auEC9c69995j+l5DUrlJM1w4acvXEWL6lwxNwGQ/vp8Q5SoVD5A===WmQz-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 2 Sep 16:50 +0200
(address . 41111@debbugs.gnu.org)
87ft805j27.fsf@gnu.org
Hi!
Raghav, could you take a look at Danny’s suggestions below?
https://issues.guix.gnu.org/41111
Ludo’.
Danny Milosavljevic <dannym@scratchpost.org> skribis:
Toggle quote (6 lines)> Hi,>> I think that this patch does a lot more than "Fix fhs directories".>> Could you split it into multiple patches, each with a high-level subject that> allows the reviewer to find out the reason for it?
R
R
Raghav Gururajan wrote on 30 Sep 12:17 +0200
Claws-Mail
(address . 41111@debbugs.gnu.org)(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
d95e34dc-cc97-1033-de64-b31b9071115e@disroot.org
Hi Danny!
Based on your feedback, I have split the changes. Please find the attached patches.
Regards,RG.
From d6888dfabb15f4485d13de09e58c487e22ed3038 Mon Sep 17 00:00:00 2001From: Raghav Gururajan <raghavgururajan@disroot.org>Date: Wed, 30 Sep 2020 05:31:43 -0400Subject: [PATCH 1/5] gnu: claws-mail: Make some cosmetic changes.
* gnu/packages/mail.scm (claws-mail): Make some cosmetic changes.--- gnu/packages/mail.scm | 105 ++++++++++++++++++++++-------------------- 1 file changed, 56 insertions(+), 49 deletions(-)
Toggle diff (121 lines)diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scmindex 70e2fcd76b..9da842bc1d 100644--- a/gnu/packages/mail.scm+++ b/gnu/packages/mail.scm@@ -1317,58 +1317,65 @@ compresses it.") (package (name "claws-mail") (version "3.17.6")- (source (origin- (method url-fetch)- (uri (string-append- "https://www.claws-mail.org/releases/claws-mail-" version- ".tar.xz"))- (sha256- (base32- "1s05qw0r0gqwvvkxvrrwbjkbi61dvilixiwrpgcq21qc9csc9r0m"))))+ (source+ (origin+ (method url-fetch)+ (uri+ (string-append+ "https://www.claws-mail.org/releases/claws-mail-"+ version ".tar.xz"))+ (sha256+ (base32 "1s05qw0r0gqwvvkxvrrwbjkbi61dvilixiwrpgcq21qc9csc9r0m")))) (build-system gnu-build-system)- (native-inputs `(("pkg-config" ,pkg-config)))- (inputs `(("bogofilter" ,bogofilter)- ("curl" ,curl)- ("dbus-glib" ,dbus-glib)- ("enchant" ,enchant)- ("expat" ,expat)- ("ghostscript" ,ghostscript)- ("hicolor-icon-theme" ,hicolor-icon-theme)- ("gnupg" ,gnupg)- ("gnutls" ,gnutls)- ("gpgme" ,gpgme)- ("gtk" ,gtk+-2)- ("libarchive" ,libarchive)- ("libcanberra" ,libcanberra)- ("libetpan" ,libetpan)- ("libical" ,libical)- ("libnotify" ,libnotify)- ("libsm" ,libsm)- ("libxml2" ,libxml2)- ("perl" ,perl)- ("python-2" ,python-2)- ("mime-info" ,shared-mime-info)- ("startup-notification" ,startup-notification))) (arguments- '(#:configure-flags- '("--enable-gnutls" "--enable-pgpmime-plugin" "--enable-enchant"- "--enable-ldap")- #:make-flags- ;; Disable updating icon cache since it's done by the profile hook.- ;; Conflict with other packages in the profile would be inevitable- ;; otherwise.- '("gtk_update_icon_cache=true")- #:phases (modify-phases %standard-phases- (add-before 'build 'patch-mime- (lambda* (#:key inputs #:allow-other-keys)- (substitute* "src/procmime.c"- (("/usr/share/mime/globs")- (string-append (assoc-ref inputs "mime-info")- "/share/mime/globs"))))))))+ `(#:configure-flags+ (list+ "--enable-gnutls"+ "--enable-pgpmime-plugin"+ "--enable-enchant"+ "--enable-ldap")+ #:make-flags+ ;; Disable updating icon cache since it's done by the profile hook.+ ;; Conflict with other packages in the profile would be inevitable+ ;; otherwise.+ (list+ "gtk_update_icon_cache=true")+ #:phases+ (modify-phases %standard-phases+ (add-before 'build 'patch-mime+ (lambda* (#:key inputs #:allow-other-keys)+ (substitute* "src/procmime.c"+ (("/usr/share/mime/globs")+ (string-append (assoc-ref inputs "mime-info")+ "/share/mime/globs"))))))))+ (native-inputs+ `(("pkg-config" ,pkg-config)))+ (inputs+ `(("bogofilter" ,bogofilter)+ ("curl" ,curl)+ ("dbus-glib" ,dbus-glib)+ ("enchant" ,enchant)+ ("expat" ,expat)+ ("ghostscript" ,ghostscript)+ ("hicolor-icon-theme" ,hicolor-icon-theme)+ ("gnupg" ,gnupg)+ ("gnutls" ,gnutls)+ ("gpgme" ,gpgme)+ ("gtk" ,gtk+-2)+ ("libarchive" ,libarchive)+ ("libcanberra" ,libcanberra)+ ("libetpan" ,libetpan)+ ("libical" ,libical)+ ("libnotify" ,libnotify)+ ("libsm" ,libsm)+ ("libxml2" ,libxml2)+ ("perl" ,perl)+ ("python-2" ,python-2)+ ("mime-info" ,shared-mime-info)+ ("startup-notification" ,startup-notification))) (synopsis "GTK-based Email client")- (description- "Claws-Mail is an email client (and news reader) based on GTK+. The-appearance and interface are designed to be familiar to new users coming from+ (description "Claws-Mail is an email client (and news reader) based on GTK+.+The appearance and interface are designed to be familiar to new users coming from other popular email clients, as well as experienced users. Almost all commands are accessible with the keyboard. Plus, Claws-Mail is extensible via addons which can add many functionalities to the base client.")-- 2.28.0
From 6a4fa215f4313f020fb1c98bcb5a679ade685e79 Mon Sep 17 00:00:00 2001From: Raghav Gururajan <raghavgururajan@disroot.org>Date: Wed, 30 Sep 2020 05:34:21 -0400Subject: [PATCH 2/5] gnu: claws-mail: Change build-system.
* gnu/packages/mail.scm (claws-mail) [build-system]: Change fromgnu to glib-or-gtk.--- gnu/packages/mail.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Toggle diff (23 lines)diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scmindex 9da842bc1d..d0ad0e41d3 100644--- a/gnu/packages/mail.scm+++ b/gnu/packages/mail.scm@@ -141,6 +141,7 @@ #:use-module (guix git-download) #:use-module (guix svn-download) #:use-module (guix utils)+ #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system guile) #:use-module (guix build-system perl)@@ -1326,7 +1327,7 @@ compresses it.") version ".tar.xz")) (sha256 (base32 "1s05qw0r0gqwvvkxvrrwbjkbi61dvilixiwrpgcq21qc9csc9r0m"))))- (build-system gnu-build-system)+ (build-system glib-or-gtk-build-system) (arguments `(#:configure-flags (list-- 2.28.0
From 5e1c842fd4b4537cd83b4abf96f45a850ead8aa7 Mon Sep 17 00:00:00 2001From: Raghav Gururajan <raghavgururajan@disroot.org>Date: Wed, 30 Sep 2020 05:52:34 -0400Subject: [PATCH 3/5] gnu: claws-mail: Update to 3.17.7.
* gnu/packages/mail.scm (claws-mail) [version]: Update to 3.17.7.[source]<origin>[sha256]: Modify base32.[arguments]<#:configure-flags>: Remove all configure flags.[arguments]<#:phases>['patch-mime]: Remove phase.['patch-fhs-dirs]: New phase.[inputs]: Add bash, cairo, compface, dbus, fontconfig, gdk-pibuf,glib, gobject-introspection, gumbo-parser, libgdata, librsvg,libsoup, mailutils, nettle, openldap, poppler, python,python2-pygtk and webkitgtk. Remove hicolor-icon-theme, libsm andlibxml2.--- gnu/packages/mail.scm | 64 +++++++++++++++++++++++++++++-------------- 1 file changed, 44 insertions(+), 20 deletions(-)
Toggle diff (132 lines)diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scmindex d0ad0e41d3..febf207710 100644--- a/gnu/packages/mail.scm+++ b/gnu/packages/mail.scm@@ -75,6 +75,7 @@ #:use-module (gnu packages documentation) #:use-module (gnu packages emacs) #:use-module (gnu packages enchant)+ #:use-module (gnu packages fontutils) #:use-module (gnu packages gdb) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript)@@ -102,10 +103,12 @@ #:use-module (gnu packages m4) #:use-module (gnu packages man) #:use-module (gnu packages ncurses)+ #:use-module (gnu packages nettle) #:use-module (gnu packages networking) #:use-module (gnu packages openldap) #:use-module (gnu packages onc-rpc) #:use-module (gnu packages pcre)+ #:use-module (gnu packages pdf) #:use-module (gnu packages perl) #:use-module (gnu packages perl-check) #:use-module (gnu packages perl-web)@@ -1317,25 +1320,19 @@ compresses it.") (define-public claws-mail (package (name "claws-mail")- (version "3.17.6")+ (version "3.17.7") (source (origin (method url-fetch) (uri (string-append "https://www.claws-mail.org/releases/claws-mail-"- version ".tar.xz"))+ version ".tar.gz")) (sha256- (base32 "1s05qw0r0gqwvvkxvrrwbjkbi61dvilixiwrpgcq21qc9csc9r0m"))))+ (base32 "0zqjfjy8qj6j6a6r0xs97si7hkcsb7jvxx4k2kkdxypqmdkwrn2q")))) (build-system glib-or-gtk-build-system) (arguments- `(#:configure-flags- (list- "--enable-gnutls"- "--enable-pgpmime-plugin"- "--enable-enchant"- "--enable-ldap")- #:make-flags+ `(#:make-flags ;; Disable updating icon cache since it's done by the profile hook. ;; Conflict with other packages in the profile would be inevitable ;; otherwise.@@ -1343,37 +1340,64 @@ compresses it.") "gtk_update_icon_cache=true") #:phases (modify-phases %standard-phases- (add-before 'build 'patch-mime+ (add-after 'unpack 'patch-fhs-dirs (lambda* (#:key inputs #:allow-other-keys)- (substitute* "src/procmime.c"- (("/usr/share/mime/globs")- (string-append (assoc-ref inputs "mime-info")- "/share/mime/globs"))))))))+ (let*+ ((sh (string-append (assoc-ref inputs "bash")+ "/bin/sh"))+ (inc (string-append (assoc-ref inputs "mailutils")+ "/bin/mu-mh/inc"))+ (send (string-append (assoc-ref inputs "mailutils")+ "/bin/mu-mh/send"))+ (globs (string-append (assoc-ref inputs "shared-mime-info")+ "/share/mime/globs")))+ (with-directory-excursion "src"+ (substitute* '("action.c" "common/defs.h" "etpan/imap-thread.c")+ (("/bin/sh") sh)+ (("/usr/bin/mh/inc") inc)+ (("/usr/sbin/sendmail") send)+ (("/usr/share/mime/globs") globs)))+ #t)))))) (native-inputs `(("pkg-config" ,pkg-config))) (inputs- `(("bogofilter" ,bogofilter)+ `(("bash" ,bash)+ ("bogofilter" ,bogofilter)+ ("cairo" ,cairo) ("curl" ,curl) ("dbus-glib" ,dbus-glib)+ ("dbus" ,dbus) ("enchant" ,enchant) ("expat" ,expat)+ ("fontconfig" ,fontconfig)+ ("gdk-pxbuf" ,gdk-pixbuf+svg) ("ghostscript" ,ghostscript)- ("hicolor-icon-theme" ,hicolor-icon-theme)+ ("glib" ,glib) ("gnupg" ,gnupg) ("gnutls" ,gnutls)+ ("gobject-introspection" ,gobject-introspection) ("gpgme" ,gpgme) ("gtk" ,gtk+-2)+ ("gumbo-parser" ,gumbo-parser) ("libarchive" ,libarchive) ("libcanberra" ,libcanberra) ("libetpan" ,libetpan)+ ("libgdata" ,libgdata) ("libical" ,libical) ("libnotify" ,libnotify)- ("libsm" ,libsm)- ("libxml2" ,libxml2)+ ("librsvg" ,librsvg)+ ("libsoup" ,libsoup)+ ("mailutils" ,mailutils)+ ("nettle" ,nettle)+ ("openldap" ,openldap) ("perl" ,perl)+ ("poppler" ,poppler)+ ("python" ,python) ("python-2" ,python-2)+ ("python2-pygtk" ,python2-pygtk) ("mime-info" ,shared-mime-info)- ("startup-notification" ,startup-notification)))+ ("startup-notification" ,startup-notification)+ ("webkitgtk" ,webkitgtk))) (synopsis "GTK-based Email client") (description "Claws-Mail is an email client (and news reader) based on GTK+. The appearance and interface are designed to be familiar to new users coming from-- 2.28.0
From 13b08ee79c56eb39a044fe8492217a822053418b Mon Sep 17 00:00:00 2001From: Raghav Gururajan <raghavgururajan@disroot.org>Date: Wed, 30 Sep 2020 06:04:01 -0400Subject: [PATCH 4/5] gnu: claws-mail: Update license.
* gnu/packages/mail.scm (claws-mail) [license]: Remove comment.--- gnu/packages/mail.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Toggle diff (15 lines)diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scmindex febf207710..4a185235b1 100644--- a/gnu/packages/mail.scm+++ b/gnu/packages/mail.scm@@ -1405,7 +1405,7 @@ other popular email clients, as well as experienced users. Almost all commands are accessible with the keyboard. Plus, Claws-Mail is extensible via addons which can add many functionalities to the base client.") (home-page "https://www.claws-mail.org/")- (license license:gpl3+))) ; most files are actually public domain or x11+ (license license:gpl3+))) (define-public msmtp (package-- 2.28.0
From 6c74dfc8d76d9ae447698c98eef4dbed7cee290e Mon Sep 17 00:00:00 2001From: Raghav Gururajan <raghavgururajan@disroot.org>Date: Wed, 30 Sep 2020 06:10:56 -0400Subject: [PATCH 5/5] gnu: claws-mail: Update synopsis and description.
* gnu/packages/mail.scm (claws-mail) [synopsis]: Modify.[description]: Modify.--- gnu/packages/mail.scm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
Toggle diff (23 lines)diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scmindex 4a185235b1..ca0ec9d8de 100644--- a/gnu/packages/mail.scm+++ b/gnu/packages/mail.scm@@ -1398,12 +1398,10 @@ compresses it.") ("mime-info" ,shared-mime-info) ("startup-notification" ,startup-notification) ("webkitgtk" ,webkitgtk)))- (synopsis "GTK-based Email client")- (description "Claws-Mail is an email client (and news reader) based on GTK+.-The appearance and interface are designed to be familiar to new users coming from-other popular email clients, as well as experienced users. Almost all commands-are accessible with the keyboard. Plus, Claws-Mail is extensible via addons-which can add many functionalities to the base client.")+ (synopsis "A GTK+ lightweight and fast e-mail client")+ (description "Claws-Mail is a lightweight and highly configurable email+client and news reader based on the GTK+ GUI toolkit. It runs on the X Window+System.") (home-page "https://www.claws-mail.org/") (license license:gpl3+))) -- 2.28.0
T
T
Tobias Geerinckx-Rice wrote on 30 Sep 12:52 +0200
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
87v9fvzgdn.fsf@nckx
Raghav,
Raghav Gururajan 写道:
Toggle quote (4 lines)> Based on your feedback, I have split the changes. Please find > the > attached patches.
I haven't been following this thread, but have updated claws-mail to .7 on master in the meantime.
Your 0003-gnu-claws-mail-Update-to-3.17.7.patch does unrelated things and deserves a different commit message.
Toggle quote (2 lines)> [source]<origin>[sha256]: Modify base32.
This isn't needed; <version> and <origin> changes are implicitly covered by ‘Update to x.y’ to reduce noise in the common case.
Kind regards,
T G-R
-----BEGIN PGP SIGNATURE-----
iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3RjVA0cbWVAdG9iaWFzLmdyAAoJEA2w/4hPVW15Xa0BAN3eiH0hE08xHTDXs1Zj/11MSo1KtcOg2Nio/ywV6lYYAPsERCixnHc/4C1J6vGzth1v0jfCaURpdOhb+YjzqI+7Dw===lV86-----END PGP SIGNATURE-----
R
R
Raghav Gururajan wrote on 15 Oct 05:05 +0200
(address . 41111@debbugs.gnu.org)
c2a17c5ec91c05c8134604eb5322b269@disroot.org
D
D
Danny Milosavljevic wrote on 15 Oct 11:14 +0200
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
20201015111402.2b205ce7@scratchpost.org
Hi RG,
pushed to master as commits b168f2ba53b938e1b322c79e5bfa47fcc506b803 and 7269a591361138ac6fc122d465e45e2b8c4944be.
Thanks!
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+IEtoACgkQ5xo1VCwwuqUv9wf/aRqfEHTOSvQScSjkBUkTwBrl0C6PTELsevPVpEYQG1wXhL5LzCXiSeD/x+dkNr2OW7qrp/3nYPcLNJIWe9soIvFpofVnJ/yhxVBh5oogQjkrxhKOyxwQ8Ifi8e1wQfuu9wXBtZYPL7Xmdj5hJnERLO6z6djfisQMH0WSCy/Cw7vh/R0ulZO9dlF/3MidIv+NnOmxH/IRHJ+s76ZzD49GzQe9p09xBwjsiXi64TE2B3Drzof0JJ3K8Oe7t0Are5gifX6jE9NTbf2M0D0CQg/CaOr2a9cnXA4rh4HM2k6ebCbnPfiX71KW3nTxP6QItP29blLJS0T3sgLbcNepyZHjdw===8Jgi-----END PGP SIGNATURE-----

Closed
R
R
Raghav Gururajan wrote on 15 Oct 18:40 +0200
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
cbc4a86742d8c608d9cd6895a89d6e86@disroot.org
Hi Danny!
Toggle quote (3 lines)> pushed to master as commits b168f2ba53b938e1b322c79e5bfa47fcc506b803 and> 7269a591361138ac6fc122d465e45e2b8c4944be.
Thanks!
The patch-set had 6 patches, but only 2 were pushed?
Regards,RG.
Closed
D
D
Danny Milosavljevic wrote on 15 Oct 22:07 +0200
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
20201015220717.50c1ddf9@scratchpost.org
Toggle quote (2 lines)> The patch-set had 6 patches, but only 2 were pushed?
Whoops, yes. I only saw and pushed the first two.
Reopened the bug report.
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+Iq/UACgkQ5xo1VCwwuqWf2Qf9FtKdN55SRA153G3EYqpyKLlhOzvN3TcZRrLjB9ZxKgNsgjtK9poO1AXXf9+OoHTwPvEIebNuGGRV6s2Aysooh5njDBiZcVM7gKfNh98xd9kk4wSkosYGQ6zkJBJTffeW6VwFU0m8Xas03NZoQD/8FaJSe9zkPr1rBtl1HF3g1N60j7MKF0fJURAZKBGl/Jo/TUivknf6RmoE6je+3KZlogICha91EiHlwBzX3b3JnvCOTRsRiQXdOAXoSewlBEvujRYMUT14NdK3efa+C7WsvQJ4zXuoO+laZT4KPtp3AKV1muVLfKn1k6rrvEx7yR8swQ2BLi8306A0wRyxU//SFg===81Xg-----END PGP SIGNATURE-----

R
R
Raghav Gururajan wrote on 15 Oct 22:08 +0200
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
4b9c66981d11a90ed297b2213b74fd35@disroot.org
Hi Danny!
Toggle quote (4 lines)> Whoops, yes. I only saw and pushed the first two.> > Reopened the bug report.
Cool!
Regards,RG.
D
D
Danny Milosavljevic wrote on 16 Oct 00:42 +0200
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
20201016004243.66186743@scratchpost.org
This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB.
That's a definition of "lightweight" (see revised synopsis and description) I was not aware of.
I'm not necessarily opposed--but for example does it really need webkitgtk ?What does it do with it ?
(There were really bad security problems in Microsoft Outlook because theywere using a more-capable-than-necessary web browser to render HTML mail,back in the day?)
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+I0GMACgkQ5xo1VCwwuqUonwgAiCymiTPfhT03jCUrEWu8FZZkFT51UBJ9XX8jbQ1UWZPI7J23dJay85TghyZMDWx4j2+gzGRQBG8x5sXKCzD7fmw1fgybFeQDe/OBKKwF5P4uzFAPOxiV95sqfPPb+XQ8fJrnlQcmWQXq1agSalFCoJuR2fc2Zhz6aMzgfyFfHf6zK3TyzhkiWpYaZI1KaWCuDfSIMjRmXxnzAiR9JBq2QeQhf0Yxb1SZtF2xSxJANhMZd0IpqLrsteivPpgH5yjfFV807VlADWtsN827KmahA958IvdaDmcuQPhE/ySoU6GMI2aDm9txI5kiBCGI5doInNM25XjeU4Lt3CjTd0Avmg===1KqT-----END PGP SIGNATURE-----

R
R
Raghav Gururajan wrote on 16 Oct 00:48 +0200
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
fb8455f79f97cb40a9bfed806bef1392@disroot.org
Hi Danny!
Toggle quote (4 lines)> This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB.> > That's a definition of "lightweight" (see revised synopsis and description) I was not aware of.
I know :/
Toggle quote (3 lines)> I'm not necessarily opposed--but for example does it really need webkitgtk ?> What does it do with it ?
Yeah, it enables a feature called "Fancy" (HTML stuff).
Toggle quote (4 lines)> (There were really bad security problems in Microsoft Outlook because they> were using a more-capable-than-necessary web browser to render HTML mail,> back in the day?)
The fancy is disabled my default. So, user should enable it only if required.
Regards,RG.
R
R
Raghav Gururajan wrote on 16 Oct 00:52 +0200
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
de75c29a60924f5c13a222528cd41b6e@disroot.org
Hi Danny!
Toggle quote (17 lines)>> This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB.>> >> That's a definition of "lightweight" (see revised synopsis and description) I was not aware of.> > I know :/> >> I'm not necessarily opposed--but for example does it really need webkitgtk ?>> What does it do with it ?> > Yeah, it enables a feature called "Fancy" (HTML stuff).> >> (There were really bad security problems in Microsoft Outlook because they>> were using a more-capable-than-necessary web browser to render HTML mail,>> back in the day?)> > The fancy is disabled my default. So, user should enable it only if required.
Hmm. Would you be able to comment-out the webkitgtk input while pushing? In future, if someone really needs it, then we can include it.
Regards,RG.
D
D
Danny Milosavljevic wrote on 16 Oct 11:48 +0200
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
20201016114822.2153a45f@scratchpost.org
Hi RG,
On Thu, 15 Oct 2020 22:52:13 +0000"Raghav Gururajan" <raghavgururajan@disroot.org> wrote:
Toggle quote (2 lines)> Hmm. Would you be able to comment-out the webkitgtk input while pushing? In future, if someone really needs it, then we can include it.
With your patchset I get:
$ guix gc --references /gnu/store/1lz5ax9j3wysl83qfzyh2c8212mh2dch-claws-mail-3.17.7 |grep -i webkit$
So it's not using webkitgtk in the first place.
Still huge...
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+JbG0ACgkQ5xo1VCwwuqWNRwf5AQ7/f5IV7KkGVmV0COEtUK1dTKtz/Ll9+cE/dbe1hwxGVMZNHobGL8k/mc4fMc8LNkQ5TtzDNOfdDFmKaWVQuTmcWYD1h8Q/lyMQfmayifMRJdHmG0leFdJ6sWYvEWEKxy7uoCyjuv8il2DYhQ8WQ7Ou1zRhv68iZUJyX+Kf6jyxYYQZsKu7MB8pb2Kw+E4xG2j8ouuaaykC1PjNyxfc918y7+D54PSZ/Ud7RreF5Wou81PQwAyy8AYVo4XFV8IYWF4QSiIbx4svWYc5/PaJBd884+06bmDW+DUrU4TxhQ7OCraypJDulTVbhGQnZnjl2gDwUrhhBEtOMInF2J131w===9B+3-----END PGP SIGNATURE-----

R
R
Raghav Gururajan wrote on 16 Oct 21:54 +0200
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
8d403b4a20b29d305e4d10807e918f43@disroot.org
Hi Danny!
Toggle quote (10 lines)> With your patchset I get:> > $ guix gc --references /gnu/store/1lz5ax9j3wysl83qfzyh2c8212mh2dch-claws-mail-3.17.7 |grep -i> webkit> $> > So it's not using webkitgtk in the first place.> > Still huge...
Thanks for catching that. The claws-mail wants WebKit-1.0 (older version of webkitgtk).
So I removed it.
Please find the revised patch attached.
Regards,RG.
D
D
Danny Milosavljevic wrote on 17 Oct 12:08 +0200
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
20201017120805.7529a031@scratchpost.org
How come gobject-introspection is in the regular inputs, not in native-inputs?
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+KwoUACgkQ5xo1VCwwuqUW6ggAlzQ9mlqsCbUQaIw9N+Jizj0Hi1RvOzgbXfCdraDdpn0l4hKqmHzljalL1mla8HMLPk4AWKtBUs/owRRj6KPX8jtwc8lBvfnwE2v6ssnH7KgZCxzuS/zVgQ7JttN2J5P16RwJKHrJaZ2qZsXMIxcpIxMj6yiS9ve+leONSx2pYoBNcH9SjKewnmbDdFkhPYxQLu01c0KQXqeMbdTgG1VRjmYcPkVTCnpVJnpQHn2+4BriMhTZ2Gk9f6JGZdKOd34ezdfMapnkSrXMwSo5GHVUDWA0MirPmVsFL+ykOsGCs4y/Je2SxpFLRq2l4iZY0e1uQkpzO6eEP5cyerHb2H/H6w===SHLO-----END PGP SIGNATURE-----

R
R
Raghav Gururajan wrote on 17 Oct 13:26 +0200
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
bb52a6e06aaf7b89bdff0df8413ed87c@disroot.org
Hi Danny!
Toggle quote (2 lines)> How come gobject-introspection is in the regular inputs, not in native-inputs?
Oops! Performed lint on wrong branch. Fixed now.
Regards,RG.
?