(address . guix-patches@gnu.org)
093ccf01caa8595305c0d22f03193aae@disroot.org
Hello Guix!
Please find the attached patch to make the "antlr3-3.3" variable public.
Regards,
RG.
gnu: packages: java: antlr3: Make antlr3-3.3 public
- Done
Details
- 2 participants
- Maxim Cournoyer
- Raghav Gururajan
- Owner
- unassigned
- Submitted by
- Raghav Gururajan
- Severity
- normal
- Blocked by
R
M
control message for bug #40285
(address . control@debbugs.gnu.org)
87d08tz3jm.fsf@gmail.com
block 40285 by 40307
quit
M
Re: [bug#40285] gnu: packages: java: antlr3: Make antlr3-3.3 public
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40285-done@debbugs.gnu.org)
871rp9z0zz.fsf@gmail.com
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
Toggle quote (31 lines)
> Hello Guix!
>
> Please find the attached patch to make the "antlr3-3.3" variable public.
>
> Regards,
> RG.
>
> From be47a8520cddcee72ba9be531bbe922118f027d2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Sun, 29 Mar 2020 21:45:10 -0400
> Subject: [PATCH 15/15] gnu: packages: java: antlr3: Make antlr3-3.3 public
>
> * gnu/packages/java.scm (antlr3): Make antlr3-3.3 public.
> ---
> gnu/packages/java.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 400ef8795e..37108f56c0 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -7162,7 +7162,7 @@ tree walking, and translation.")
> (inputs
> `(("junit" ,java-junit)))))
>
> -(define antlr3-3.3
> +(define-public antlr3-3.3
> (package
> (inherit antlr3)
> (name "antlr3")
I added a bit more context to the commit message, fixed the gnu: antlr3:
prefix and pushed as commit 011f941279.
Thank you!
Maxim
Closed
M
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40285@debbugs.gnu.org)
87tv25xm1n.fsf@gmail.com
Hello Raghav!
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
Toggle quote (7 lines)
> Hello Guix!
>
> Please find the attached patch to make the "antlr3-3.3" variable public.
>
> Regards,
> RG.
(I thought I had sent this already but it seems not -- sending it just
for the record, even though I've already merged this change to master).
It would have been easier for us reviewers to add the changes related to
the packaging of Linphone in the same patch series (appearing before the
packages that need this), so as to have the context and understand the
rational of making this change.
I've marked those as blocking 40307 (linphone), so OK for this time, but
keep in mind for next time :-).
Maxim
R
control message for bug #40264
(address . control@debbugs.gnu.org)
eedf882e4495e7e0f8820925ff63bbac@disroot.org
block 40264 by 40285
?