(address . guix-patches@gnu.org)
f684e597826a57564ddbbcc16cb3d480@disroot.org
Hello Guix!
Please find the attached patch to add "spandsp" package.
Regards,
RG.
gnu: packages: telephony: Add spandsp
- Done
Details
- 2 participants
- Maxim Cournoyer
- Raghav Gururajan
- Owner
- unassigned
- Submitted by
- Raghav Gururajan
- Severity
- normal
R
M
control message for bug #40264
(address . control@debbugs.gnu.org)
87ftdpz3rw.fsf@gmail.com
block 40264 by 40307
quit
M
control message for bug #40291
(address . control@debbugs.gnu.org)
87eet9z3jt.fsf@gmail.com
block 40291 by 40307
quit
M
control message for bug #40285
(address . control@debbugs.gnu.org)
87d08tz3jm.fsf@gmail.com
block 40285 by 40307
quit
M
Re: [bug#40307] gnu: packages: telephony: Add spandsp
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40307@debbugs.gnu.org)
87eet9xfpc.fsf@gmail.com
Hello again :-)
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
Toggle quote (12 lines)
> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.
>
> From 68e093007f2c5678895a5cbe29f2b1ac2c357ba2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Sat, 28 Mar 2020 23:32:57 -0400
> Subject: [PATCH 13/13] gnu: packages: telephony: Add spandsp
This prefix also need to be adjusted to just "gnu: Add ...".
Toggle quote (35 lines)
> * gnu/packages/telephony.scm (spandsp): New variable.
> ---
> gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index fe6c230693..c68f80669c 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -52,6 +52,7 @@
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages image)
> #:use-module (gnu packages libcanberra)
> #:use-module (gnu packages linux)
> #:use-module (gnu packages multiprecision)
> @@ -84,6 +85,35 @@
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system qt))
>
> +(define-public spandsp
> + (package
> + (name "spandsp")
> + (version "0.0.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + (string-append "https://www.soft-switch.org/downloads/" name "/"
> + name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0rclrkyspzk575v8fslzjpgp4y2s4x7xk3r55ycvpi4agv33l1fc"))))
> + (build-system gnu-build-system)
The check phase doesn't seem to run anything; it just passes. Perhaps
we don't start it the correct way?
Toggle quote (10 lines)
> + (native-inputs
> + `(("libtiff" ,libtiff)
> + ("zlib" ,zlib)))
> + (synopsis "DSP library for telephony")
> + (description "SpanDSP is a library of DSP functions for telephony, in the 8000 sample
> +per second world of E1s, T1s, and higher order PCM channels. It contains low level
> +functions, such as basic filters. It also contains higher level functions, such as
> +cadenced supervisory tone detection, and a complete software FAX
> machine.")
This body of text is a bit too wide. We limit our column width at 80
characters. You can use M-q in Emacs to automatically re-flow the
paragraph. I kind of like the concise description from Debian, because
it gives me a better idea of what the package can be used for: "SpanDSP
is a low-level signal processing library that modulate and demodulate
signals commonly used in telephony, such as the "noise" generated by a
fax modem or DTMF touchpad."
Toggle quote (9 lines)
> + (home-page "https://www.soft-switch.org/index.html")
> + (license
> + (list
> + ;; For Library
> + license:lgpl2.1+
> + ;; For Test Suites and Support Programs
> + license:gpl2+))))
> +
My preferred style for formatting the license list would be:
(license (list license:lgpl2.1+ ;for the library
license:gpl2+)))) ;for the test suites and support programs
The indentation of the package is off. Please use Emacs or the
indent-code.el script :-).
Maxim
M
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40307@debbugs.gnu.org)
87a73xxfia.fsf@gmail.com
Hi again,
I forgot to add; Debian adds the --enable-doc --enable-tests flags. I
think it'd be nice to have a manpage, and perhaps the check phase would
actually run something with the above?
Maxim
R
Alternative Source for TarBall
(address . 40307@debbugs.gnu.org)
3fb3576b22a6eeba5c7dded2abcc74db@disroot.org
R
(address . 40307@debbugs.gnu.org)
a840d68675786239ba3ca30972e679a4@disroot.org
M
Re: [bug#40307] gnu: packages: telephony: Add spandsp
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40307-done@debbugs.gnu.org)
871rp8xmm8.fsf@gmail.com
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
Toggle quote (7 lines)
> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.
Hi Raghav!
I've modified the package to add the doc + tests and pushed as
d82539d35f.
Thank you!
Closing.
Closed
R
gnu: Add spandsp (v2)
(address . 40307@debbugs.gnu.org)
4104cdb4612020b03f9f366e173b6fce@disroot.org
?