[WIP] LightDM service

Done

Details

7 participants

Nicolò Balzarotti
Brice Waegeneire
Efraim Flashner
L p R n d n
Jonathan Brielmaier
Maxim Cournoyer
Ricardo Wurmus

Owner: unassigned

Submitted by: L p R n d n

Severity: normal

Debbugs page

L p R n d n wrote 6 years ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:87zhooso9g.fsf@lprndn.info

Hello,

Wanted to work on Guix's website but fate led me to try my way on a

lightdm service...

So, here is what I got for now.

It fails to start a window manager but I don't think I'll be able to

debug the last mile with my sole knowledge.

Beside that, here is a list of possible improvements before merging:

* lightdm-greeter-gtk configuration is a part of lightdm's service.

It might be a good idea to give it its own service but it would

mean we need to write a service for each lightdm greeter.

* lightdm complains about the lack of

org.freedesktop.DisplayManager.AccountsService interface.

The lightdm package provides the relevent files but it seems

accountsservice doesn't find them. I think it searches them in

$XDG_DATA_DIRS/accountservices . See

https://github.com/NixOS/nixpkgs/issues/45059

* lightdm-gtk-greeter's wrapper is handmade and ugly.

* General refining.

A thorough review would also be welcome as I'm not really sure I know

what I'm doing.

Thanks!

L p R n d n

From 826ca620f71f5b219f1402fe4ea582de621b061a Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm): Update to 1.28.0.

---

gnu/packages/display-managers.scm | 11 +++++------

1 file changed, 5 insertions(+), 6 deletions(-)

Toggle diff (28 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index afe5cc2b7b..243baebb3d 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -208,16 +208,15 @@ create smooth, animated user interfaces.")
 (define-public lightdm
   (package
     (name "lightdm")
-    (version "1.24.0")
+    (version "1.28.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://launchpad.net/lightdm/"
-                                  (version-major+minor version) "/"
-                                  version "/+download/lightdm-"
-                                  version ".tar.xz"))
+              (uri (string-append
+                    "https://github.com/CanonicalLtd/lightdm/releases/download/"
+                    version "/lightdm-" version ".tar.xz"))
               (sha256
                (base32
-                "18j33bm54i8k7ncxcs69zqi4105s62n58jrydqn3ikrb71s9nl6d"))))
+                "01zsxim662n2w66j46rv291w9aqmwvlwccyzl9vhpybwinfmj3zj"))))
     (build-system gnu-build-system)
     (arguments
      '(#:parallel-tests? #f ; fails when run in parallel
-- 
2.21.0

From c2ead5265c209315fa57cb07b84ead557e191175 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm) [native-inputs]: Add vala.

---

gnu/packages/display-managers.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 243baebb3d..d1eb3f146e 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -263,6 +263,7 @@ create smooth, animated user interfaces.")
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
+       ("vala" ,vala)                   ;For vala bindings
        ;; For tests
        ("dbus" ,dbus)
        ("python" ,python-2)
-- 
2.21.0

From 6e0bf56cd21964c868b6eaf2867dfbd412c4d279 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm)[arguments]: Remove disable-broken-phase.

---

gnu/packages/display-managers.scm | 6 ------

1 file changed, 6 deletions(-)

Toggle diff (19 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index d1eb3f146e..7f5678f459 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -235,12 +235,6 @@ create smooth, animated user interfaces.")
              (substitute* "src/seat.c"
                (("/bin/sh") (which "sh")))
              #t))
-         (add-after 'unpack 'disable-broken-tests
-           (lambda _
-             (substitute* "tests/Makefile.in"
-               (("test-sessions-gobject ") "")
-               ((" test-sessions-python ") " "))
-             #t))
          (add-before 'check 'pre-check
            ;; Run test-suite under a dbus session.
            (lambda* (#:key inputs #:allow-other-keys)
-- 
2.21.0

From c31f542d6c551ef2b7bef4d576ff7c2ad1e4a01a Mon Sep 17 00:00:00 2001

* gnu/packages/display-manager.scm (lightdm-gtk-greeter): Update to 2.0.6.

---

gnu/packages/display-managers.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 7f5678f459..be365df6a2 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -276,7 +276,7 @@ display manager which supports different greeters.")
 (define-public lightdm-gtk-greeter
   (package
     (name "lightdm-gtk-greeter")
-    (version "2.0.2")
+    (version "2.0.6")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -285,7 +285,7 @@ display manager which supports different greeters.")
                     "/+download/lightdm-gtk-greeter-" version ".tar.gz"))
               (sha256
                (base32
-                "1436sdm83xqhxyr1rzqxhsl8if2xmidlvb341xcv6dv83lyxkrlf"))))
+                "1pis5qyg95pg31dvnfqq34bzgj00hg4vs547r8h60lxjk81z8p15"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("exo" ,exo)
-- 
2.21.0

From 8b4354bd30dc44c47509f0bc0da9fe95e6b4db8d Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Tue, 16 Apr 2019 13:50:58 +0200
Subject: [PATCH 05/10] gnu: lightdm-gtk-greeter: Fix at-spi runtime
 dependency.

* gnu/packages/display-manager.scm (lightdm): Fix at-spi runtime dependency.
[inputs]: Add at-spi2-core.
[arguments]: Add '--enable-at-spi-command' configure flag.
---
 gnu/packages/display-managers.scm | 7 +++++++
 1 file changed, 7 insertions(+)

Toggle diff (21 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index be365df6a2..352ad19efa 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -293,7 +293,14 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
+    (arguments
+     `(#:configure-flags
+       (list "--localstatedir=/var"
+             (string-append "--enable-at-spi-command="
+                            (assoc-ref %build-inputs "at-spi2-core")
+                            "/libexec/at-spi-bus-launcher"))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.21.0

From ef95fd1a611d24cb5a2f77f758a0495ab231a444 Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Tue, 16 Apr 2019 13:58:26 +0200
Subject: [PATCH 06/10] gnu: lightdm-gtk-greeter: Fix .desktop file.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix .desktop file
  path.
[arguments]: Add fix-.desktop-path phase.
---
 gnu/packages/display-managers.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (25 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 352ad19efa..4d22d28f02 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -300,7 +300,17 @@ display manager which supports different greeters.")
        (list "--localstatedir=/var"
              (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
-                            "/libexec/at-spi-bus-launcher"))))
+                            "/libexec/at-spi-bus-launcher"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'fix-.desktop-path
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* (string-append
+                             out "/share/xgreeters/lightdm-gtk-greeter.desktop")
+                 (("Exec=lightdm-gtk-greeter")
+                  (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
+               #t))))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.21.0

From 8ed5177d5a188f8722e4cfdede4967b3e73968f8 Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Tue, 16 Apr 2019 14:17:18 +0200
Subject: [PATCH 07/10] gnu: lightdm-gtk-greeter: Wrap binary.

* gnu/package/display-managers.scm (lightdm-gtk-greeter): Wrap binary.
[inputs]: Add hicolor-icon-theme.
[arguments]: Add wrap-program phase.
---
 gnu/packages/display-managers.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

Toggle diff (43 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 4d22d28f02..de2b45d4d6 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -294,6 +294,7 @@ display manager which supports different greeters.")
     (inputs
      `(("lightdm" ,lightdm)
        ("at-spi2-core" ,at-spi2-core)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
        ("gtk+" ,gtk+)))
     (arguments
      `(#:configure-flags
@@ -310,7 +311,27 @@ display manager which supports different greeters.")
                              out "/share/xgreeters/lightdm-gtk-greeter.desktop")
                  (("Exec=lightdm-gtk-greeter")
                   (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
-               #t))))))
+               #t)))
+         (add-after 'fix-.desktop-path 'wrap-program
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (wrap-program (string-append (assoc-ref outputs "out")
+                                          "/sbin/lightdm-gtk-greeter")
+               `("XDG_DATA_DIRS" ":" prefix (,(string-append (assoc-ref inputs "hicolor-icon-theme")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "glib")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "shared-mime-info")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "gtk+")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "exo")
+                                                             "/share")
+                                             ,(string-append (assoc-ref outputs "out")
+                                                             "/share")
+                                             "/run/current-system/profile/share"))
+               `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+             #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.21.0

From 56c962ccc54f3c7f83ea288c9ac26524af19b5a0 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm)[native-inputs]: Add accountsservice.

---

gnu/packages/display-managers.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index de2b45d4d6..a829e74604 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -253,7 +253,8 @@ create smooth, animated user interfaces.")
        ("libgcrypt" ,libgcrypt)
        ("libxcb" ,libxcb)))
     (native-inputs
-     `(("gobject-introspection" ,gobject-introspection)
+     `(("accountsservice" ,accountsservice)
+       ("gobject-introspection" ,gobject-introspection)
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
-- 
2.21.0

From 0d2fa80019cd9d95a0008576fc768fac8ac49c6c Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Wed, 17 Apr 2019 12:44:07 +0200
Subject: [PATCH 09/10] gnu: lightdm-gtk-greeter: Fix some warnings.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix some warnings.
[arguments]: Add '--disable-indicator-services-command' configure flags.
---
 gnu/packages/display-managers.scm | 1 +
 1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index a829e74604..67d6d9e5c6 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -300,6 +300,7 @@ display manager which supports different greeters.")
     (arguments
      `(#:configure-flags
        (list "--localstatedir=/var"
+             "--disable-indicator-services-command"
              (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
                             "/libexec/at-spi-bus-launcher"))
-- 
2.21.0

Attachment: 0010-services-Add-lightDM-service.patch

Jonathan Brielmaier wrote 6 years ago

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:98e6b5db-084d-57ad-8bcf-d65a3b7b8b37@web.de

Please add gnu/services/lightdm.scm to gnu/local.mk

L p R n d n wrote 6 years ago

Re: bug#35305: Acknowledgement ([WIP] LightDM service)

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:87r29zwiu8.fsf@lprndn.info

Hello,

After some work, here is a new patch replacing the last one from

previous mail. It now seems to work as it successfully starts a window

manager.

Have a nice day,

L p R n d n

Attachment: 0010-services-Add-lightdm-service.patch

L p R n d n wrote 6 years ago

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:87imvbwbb7.fsf@lprndn.info

New patch for addinf lightdm service replacing previous one.

Now with local.mk changes.

Have a nice day,

L p R n d n

Attachment: 0010-services-Add-lightdm-service-type.patch

L p R n d n wrote 6 years ago

[PATCH] LightDM service

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:877eahwhwz.fsf@lprndn.info

Hello,

New patch for adding the lightDM service replacing the previous one.

Added some doc, simplified lightdm-configuration to look a little bit

more like other display manager's services and use xorg-configuration.

We can always add more options later if needed.

I also made an attempt at factoring out the lightdm-gtk-greeter

configuration. It should be easier to add configuration of other greeter

but there might be better ways.

I'm open to suggestions but otherwise it should be mergeable.

Thanks,

Have a nice day,

L p R n d n

Attachment: 0010-services-Add-lightdm-service-type.patch

L p R n d n wrote 6 years ago

Re: bug#35305: Acknowledgement ([WIP] LightDM service)

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:878srf9ava.fsf@lprndn.info

ping

Nicolò Balzarotti wrote 5 years ago

Re: [bug#35305] Acknowledgement ([WIP] LightDM service)

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:878sk1e19s.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me

Cool, I was wondering why the lightdm package was available but no

service was provided for it. Anything blocking this patch?

Thanks, Nicolò

L p R n d n <guix@lprndn.info> writes:

Toggle quote (1 lines)

> ping

Efraim Flashner wrote 5 years ago

Recipients:(name . Nicolò Balzarotti)(address . anothersms@gmail.com)(address . 35305@debbugs.gnu.org)(name . L p R n d n)(address . guix@lprndn.info)

Message-ID:20200316073450.GH927@E5400

On Sun, Mar 15, 2020 at 10:50:07PM +0100, Nicolò Balzarotti wrote:

Toggle quote (9 lines)

> Cool, I was wondering why the lightdm package was available but no

> service was provided for it. Anything blocking this patch?

> Thanks, Nicolò

> L p R n d n <guix@lprndn.info> writes:

> > ping

I don't think anyone got around to reviewing it :/

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

L p R n d n wrote 5 years ago

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 35305@debbugs.gnu.org)(name . Nicolò Balzarotti)(address . anothersms@gmail.com)

Message-ID:87pndcvgpt.fsf@lprndn.info

Hello,

Also a rebase on latest master might be necessary. I was waiting for

staging to be merged so if I got time, I'll probably take care of this

during the week. ;)

Have a nice day,

L p R n d n

L p R n d n wrote 5 years ago

Re: [bug#35305] LightDM service

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:874kukh85l.fsf_-_@lprndn.info

Hello,

Here is the new set of reworked patches. I tested it quickly in a

vm with xfce and gnome (login, logout, switch user) and it seems ok.

I also attach a little scm file with a simple system definition with

lightdm and xfce for those willing to test it.

(also the password is "q" without quotes).

Have a nice day,

L p R n d n

From 461b4c27816d4340a37209ca5389d7ec9f373581 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm): Update to 1.30.0.

---

gnu/packages/display-managers.scm | 11 +++++------

1 file changed, 5 insertions(+), 6 deletions(-)

Toggle diff (28 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index bfe1a8f6dd..2f81f10140 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -125,16 +125,15 @@ create smooth, animated user interfaces.")
 (define-public lightdm
   (package
     (name "lightdm")
-    (version "1.24.0")
+    (version "1.30.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://launchpad.net/lightdm/"
-                                  (version-major+minor version) "/"
-                                  version "/+download/lightdm-"
-                                  version ".tar.xz"))
+              (uri (string-append
+                    "https://github.com/CanonicalLtd/lightdm/releases/download/"
+                    version "/lightdm-" version ".tar.xz"))
               (sha256
                (base32
-                "18j33bm54i8k7ncxcs69zqi4105s62n58jrydqn3ikrb71s9nl6d"))))
+                "158zb2d0v1309a8v19hh32y4yj3v6yg4yg6m0l7v59d3a2b7f651"))))
     (build-system gnu-build-system)
     (arguments
      '(#:parallel-tests? #f ; fails when run in parallel
-- 
2.25.1

From a2d8e9027e12dabb0acebd3c32aff555727c4129 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm) [native-inputs]: Add vala.

---

gnu/packages/display-managers.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 2f81f10140..1f4842bff3 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -180,6 +180,7 @@ create smooth, animated user interfaces.")
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
+       ("vala" ,vala)                   ;For vala bindings
        ;; For tests
        ("dbus" ,dbus)
        ("python" ,python-2)
-- 
2.25.1

Attachment: 0003-gnu-lightdm-Disable-python-tests-only.patch

From b7026a6b9cfb43ae3f7a2105b1681cc73281854d Mon Sep 17 00:00:00 2001

* gnu/packages/display-manager.scm (lightdm-gtk-greeter): Update to 2.0.7.

---

gnu/packages/display-managers.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 56725f8302..9e02eaed33 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -187,7 +187,7 @@ display manager which supports different greeters.")
 (define-public lightdm-gtk-greeter
   (package
     (name "lightdm-gtk-greeter")
-    (version "2.0.2")
+    (version "2.0.7")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -196,7 +196,7 @@ display manager which supports different greeters.")
                     "/+download/lightdm-gtk-greeter-" version ".tar.gz"))
               (sha256
                (base32
-                "1436sdm83xqhxyr1rzqxhsl8if2xmidlvb341xcv6dv83lyxkrlf"))))
+                "1g7wc3d3vqfa7mrdhx1w9ywydgjbffla6rbrxq9k3sc62br97qms"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("exo" ,exo)
-- 
2.25.1

From 172167821db646e82c1fceef5dced9f2dcf49fd8 Mon Sep 17 00:00:00 2001
From: Lprndn <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:50:58 +0200
Subject: [PATCH 05/10] gnu: lightdm-gtk-greeter: Fix at-spi runtime
 dependency.

* gnu/packages/display-manager.scm (lightdm): Fix at-spi runtime dependency.
[inputs]: Add at-spi2-core.
[arguments]: Add '--enable-at-spi-command' configure flag.
---
 gnu/packages/display-managers.scm | 6 ++++++
 1 file changed, 6 insertions(+)

Toggle diff (20 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 9e02eaed33..29f91ad1fc 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -204,7 +204,13 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--enable-at-spi-command="
+                            (assoc-ref %build-inputs "at-spi2-core")
+                            "/libexec/at-spi-bus-launcher"))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.25.1

From 5e77afbfeb70892c7065927ac3223941679e5f59 Mon Sep 17 00:00:00 2001
From: Lprndn <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:58:26 +0200
Subject: [PATCH 06/10] gnu: lightdm-gtk-greeter: Fix .desktop file.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix .desktop file
  path.
[arguments]: Add fix-.desktop-path phase.
---
 gnu/packages/display-managers.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (25 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 29f91ad1fc..ec0f685063 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,7 +210,17 @@ display manager which supports different greeters.")
      `(#:configure-flags
        (list (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
-                            "/libexec/at-spi-bus-launcher"))))
+                            "/libexec/at-spi-bus-launcher"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'fix-.desktop-path
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* (string-append
+                             out "/share/xgreeters/lightdm-gtk-greeter.desktop")
+                 (("Exec=lightdm-gtk-greeter")
+                  (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
+               #t))))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.25.1

From 11ab812bca3d9c2a1a53355d4ea2710861377275 Mon Sep 17 00:00:00 2001
From: Lprndn <guix@lprndn.info>
Date: Tue, 16 Apr 2019 14:17:18 +0200
Subject: [PATCH 07/10] gnu: lightdm-gtk-greeter: Wrap binary.

* gnu/package/display-managers.scm (lightdm-gtk-greeter): Wrap binary.
[inputs]: Add hicolor-icon-theme.
[arguments]: Add wrap-program phase.
---
 gnu/packages/display-managers.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

Toggle diff (43 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index ec0f685063..4c2391951b 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -205,6 +205,7 @@ display manager which supports different greeters.")
     (inputs
      `(("lightdm" ,lightdm)
        ("at-spi2-core" ,at-spi2-core)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
        ("gtk+" ,gtk+)))
     (arguments
      `(#:configure-flags
@@ -220,7 +221,27 @@ display manager which supports different greeters.")
                              out "/share/xgreeters/lightdm-gtk-greeter.desktop")
                  (("Exec=lightdm-gtk-greeter")
                   (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
-               #t))))))
+               #t)))
+         (add-after 'fix-.desktop-path 'wrap-program
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (wrap-program (string-append (assoc-ref outputs "out")
+                                          "/sbin/lightdm-gtk-greeter")
+               `("XDG_DATA_DIRS" ":" prefix (,(string-append (assoc-ref inputs "hicolor-icon-theme")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "glib")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "shared-mime-info")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "gtk+")
+                                                             "/share")
+                                             ,(string-append (assoc-ref inputs "exo")
+                                                             "/share")
+                                             ,(string-append (assoc-ref outputs "out")
+                                                             "/share")
+                                             "/run/current-system/profile/share"))
+               `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+             #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.25.1

From d83b7241279cf8d672241cb28bd7f719619e6a61 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm)[native-inputs]: Add accountsservice.

---

gnu/packages/display-managers.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 4c2391951b..50a43c125f 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -166,7 +166,8 @@ create smooth, animated user interfaces.")
        ("libgcrypt" ,libgcrypt)
        ("libxcb" ,libxcb)))
     (native-inputs
-     `(("gobject-introspection" ,gobject-introspection)
+     `(("accountsservice" ,accountsservice)
+       ("gobject-introspection" ,gobject-introspection)
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
-- 
2.25.1

From 1d3f159d3b3205c118325266f1867f439d0d9a46 Mon Sep 17 00:00:00 2001
From: Lprndn <guix@lprndn.info>
Date: Wed, 17 Apr 2019 12:44:07 +0200
Subject: [PATCH 09/10] gnu: lightdm-gtk-greeter: Fix some warnings.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix some warnings.
[arguments]: Add '--disable-indicator-services-command' configure flags.
---
 gnu/packages/display-managers.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 50a43c125f..62387b14a5 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,7 +210,8 @@ display manager which supports different greeters.")
        ("gtk+" ,gtk+)))
     (arguments
      `(#:configure-flags
-       (list (string-append "--enable-at-spi-command="
+       (list "--disable-indicator-services-command"
+             (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
                             "/libexec/at-spi-bus-launcher"))
        #:phases
-- 
2.25.1

Attachment: 0010-services-Add-lightdm-service-type.patch

;; This is an operating system configuration template ;; for a "desktop" setup without full-blown desktop ;; environments. (use-modules (gnu) (gnu system nss) (srfi srfi-1)) (use-service-modules desktop lightdm xorg) (use-package-modules bootloaders certs) (operating-system (host-name "antelope") (timezone "Europe/Paris") (locale "en_US.utf8") ;; Use the UEFI variant of GRUB with the EFI System ;; Partition mounted on /boot/efi. (bootloader (bootloader-configuration (bootloader grub-efi-bootloader) (target "/boot/efi"))) ;; Assume the target root file system is labelled "my-root", ;; and the EFI System Partition has UUID 1234-ABCD. (file-systems (append (list (file-system (device (file-system-label "my-root")) (mount-point "/") (type "ext4")) (file-system (device (uuid "1234-ABCD" 'fat)) (mount-point "/boot/efi") (type "vfat"))) %base-file-systems)) (users (cons (user-account (name "alice") (comment "Bob's sister") ;; Password is "q" (without quotes) (password "a2l/LaE8AKHIY") (group "users") (supplementary-groups '("wheel" "netdev" "audio" "video"))) %base-user-accounts)) ;; Add a bunch of window managers; we can choose one at ;; the log-in screen with F1. (packages (append (list ;; for HTTPS access nss-certs) %base-packages)) ;; Use the "desktop" services, which include the X11 ;; log-in service, networking with NetworkManager, and more. (services (cons* (service lightdm-service-type) (service xfce-desktop-service-type) (modify-services (remove (lambda (service) (eq? (service-kind service) gdm-service-type)) %desktop-services)))) ;; Allow resolution of '.local' host names with mDNS. (name-service-switch %mdns-host-lookup-nss))

Brice Waegeneire wrote 5 years ago

Recipients:(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:e0dd6ca666986ea18597f95873e3b1c1@waegenei.re

Hello L p R n d n,

I never did a review before but I would like to see this patch merged,

bear with me.

The indentation of lightdm's origin should probably be done in the

commit

01 not 03.

Toggle quote (15 lines)> `("XDG_DATA_DIRS" ":" prefix (,(string-append (assoc-ref inputs 
> "hicolor-icon-theme")
>                                               "/share")
>                               ,(string-append (assoc-ref inputs "glib")
>                                               "/share")
>                               ,(string-append (assoc-ref inputs 
> "shared-mime-info")
>                                               "/share")
>                               ,(string-append (assoc-ref inputs "gtk+")
>                                               "/share")
>                               ,(string-append (assoc-ref inputs "exo")
>                                               "/share")
>                               ,(string-append (assoc-ref outputs "out")
>                                               "/share")
>                               "/run/current-system/profile/share"))

This part can use a map procedure.

It would be nice if “lightdm-service-type” support

“set-xorg-configuration”

like the other login manager now does by using

“handle-xorg-configuration”

see 50be0da7bfd5c108697679effeb2a893d2f37598 for how it's done in GDM,

SLIM

and co.

Toggle quote (1 lines)

> + (comment "LighDM user")

^ a “t” is missing here

Toggle quote (6 lines)> +(define (lightdm-shepherd-service config)
> +  "Return a <lightdm-service> for LightDM with CONFIG."
> +
> +  (define lightdm-command
> +    #~(list (string-append #$(lightdm-configuration-lightdm config) 
> "/sbin/lightdm")))

[…]

Toggle quote (5 lines)

> + (fork+exec-command

> + (list #$(file-append

> + (lightdm-configuration-lightdm config)

> + "/sbin/lightdm"))

“lightdm-command” isn't used, I get the hint it ought to be the argument

“fork+exec-command.”

Toggle quote (9 lines)

> +(define (lightdm-etc-service config)

> + (list `("xdg/lightdm/lightdm.conf.d/lightdm.conf"

> + ,(lightdm-configuration-file config))

> + `(,(string-append "xdg/lightdm/"

> + (computed-file-name

> +

> (lightdm-configuration-greeter-configuration config)))

> + ,(lightdm-configuration-greeter-configuration config))))

I've been told, in Guix, it's better to avoid putting configuration in
“/etc” since it cause edge case during rollback and such, specifying the
configuration by passing the “--config” argument to “lightdm” would be 
more
appropriate.

Toggle quote (6 lines)

> + (define %user

> + (getpw "lightdm"))

> + (let ((directory "/var/lib/lightdm-data"))

> + (mkdir-p directory)

> + (chown directory (passwd:uid %user) (passwd:gid %user))))))

“%user” could go in the “let”. BTW can't lightdm use its user home

directory instead of “/var/lib/lightdm-data” or the reverse; IOW does it

need to have to own two directories in “/var/lib”?

Several lines in “gnu/services/lightdm.scm” exceed the maximal line

length.

Thank you very much for this patch series. I'm impatient seeing it in

Guix

proper.

- Brice

L p R n d n wrote 5 years ago

Recipients:(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:87sghcir5k.fsf@lprndn.info

Hello,

Brice Waegeneire <brice@waegenei.re> writes:

Toggle quote (5 lines)

> Hello L p R n d n,

> I never did a review before but I would like to see this patch merged, so

> bear with me.

Thank you for the review! It's my first service for guix so we're

probably even here. ;)

Toggle quote (3 lines)

> The indentation of lightdm's origin should probably be done in the commit

> 01 not 03.

Done.

Toggle quote (17 lines)>> `("XDG_DATA_DIRS" ":" prefix (,(string-append (assoc-ref inputs
>> "hicolor-icon-theme")
>>                                               "/share")
>>                               ,(string-append (assoc-ref inputs "glib")
>>                                               "/share")
>>                               ,(string-append (assoc-ref inputs
>> "shared-mime-info")
>>                                               "/share")
>>                               ,(string-append (assoc-ref inputs "gtk+")
>>                                               "/share")
>>                               ,(string-append (assoc-ref inputs "exo")
>>                                               "/share")
>>                               ,(string-append (assoc-ref outputs "out")
>>                                               "/share")
>>                               "/run/current-system/profile/share"))
> This part can use a map procedure.

Done. + cleaned some things that weren't necessary.

Toggle quote (8 lines)

> It would be nice if “lightdm-service-type” support “set-xorg-configuration”

> like the other login manager now does by using “handle-xorg-configuration”

> see 50be0da7bfd5c108697679effeb2a893d2f37598 for how it's done in GDM, SLIM

> and co.

>> + (comment "LighDM user")

> ^ a “t” is missing here

Huh.. Done (I think...) and done!

Toggle quote (15 lines)>> +(define (lightdm-shepherd-service config)
>> +  "Return a <lightdm-service> for LightDM with CONFIG."
>> +
>> +  (define lightdm-command
>> +    #~(list (string-append #$(lightdm-configuration-lightdm config)
>> "/sbin/lightdm")))
> […]
>> + (fork+exec-command
>> + (list #$(file-append
>> + (lightdm-configuration-lightdm config)
>> + "/sbin/lightdm"))
>
> “lightdm-command” isn't used, I get the hint it ought to be the argument of
> “fork+exec-command.”

Done.

Toggle quote (15 lines)>
>> +(define (lightdm-etc-service config)
>> +  (list `("xdg/lightdm/lightdm.conf.d/lightdm.conf"
>> +          ,(lightdm-configuration-file config))
>> +        `(,(string-append "xdg/lightdm/"
>> +                          (computed-file-name
>> +                           (lightdm-configuration-greeter-configuration
>> config)))
>> +          ,(lightdm-configuration-greeter-configuration config))))
>
> I've been told, in Guix, it's better to avoid putting configuration in
> “/etc” since it cause edge case during rollback and such, specifying the
> configuration by passing the “--config” argument to “lightdm” would be more
> appropriate.

Need some advices here as even if "--config" works for LightDM, greeters
also search their config in /etc. They're all different so they might or
might not provide a convenient way to do it... :/
In the meantime, kept the etc-service-extension + prevented errors in
case a file wasn't provided.

Toggle quote (10 lines)>> +        (define %user
>> +          (getpw "lightdm"))
>> +        (let ((directory "/var/lib/lightdm-data"))
>> +          (mkdir-p directory)
>> +          (chown directory (passwd:uid %user) (passwd:gid %user))))))
>
> “%user” could go in the “let”. BTW can't lightdm use its user home
> directory instead of “/var/lib/lightdm-data” or the reverse; IOW does it
> need to have to own two directories in “/var/lib”?

Reworked everything a little bit to match what is done for gdm.
I think we can use a CFLAG to change "/var/lib/lightdm-data" to
"/var/lib/lightdm/lightdm-data" for example. However, I think lightdm
sometime cleans or delete stuff in "/var/lib/lightdm" so it might
explain why there are two directories. I don't know what
"/var/lib/lightdm-data" is used for but LightDM does complain if it
doesn't exist. Advices needed here too.

Toggle quote (3 lines)

> Several lines in “gnu/services/lightdm.scm” exceed the maximal line length.

Tried to keep them below 80. Is it ok?

Toggle quote (7 lines)

> Thank you very much for this patch series. I'm impatient seeing it in Guix

> proper.

> - Brice

+ Corrected some typos in the documentation and added an extra-config

field to lightd and lightdm-gtk-greeter's configuration.

Hope it's better now, new patches are attached below.

Have a nice day,

L p R n d n

From 461b4c27816d4340a37209ca5389d7ec9f373581 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm): Update to 1.30.0.

---

gnu/packages/display-managers.scm | 11 +++++------

1 file changed, 5 insertions(+), 6 deletions(-)

Toggle diff (28 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index bfe1a8f6dd..2f81f10140 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -125,16 +125,15 @@ create smooth, animated user interfaces.")
 (define-public lightdm
   (package
     (name "lightdm")
-    (version "1.24.0")
+    (version "1.30.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://launchpad.net/lightdm/"
-                                  (version-major+minor version) "/"
-                                  version "/+download/lightdm-"
-                                  version ".tar.xz"))
+              (uri (string-append
+                    "https://github.com/CanonicalLtd/lightdm/releases/download/"
+                    version "/lightdm-" version ".tar.xz"))
               (sha256
                (base32
-                "18j33bm54i8k7ncxcs69zqi4105s62n58jrydqn3ikrb71s9nl6d"))))
+                "158zb2d0v1309a8v19hh32y4yj3v6yg4yg6m0l7v59d3a2b7f651"))))
     (build-system gnu-build-system)
     (arguments
      '(#:parallel-tests? #f ; fails when run in parallel
-- 
2.25.1

From a2d8e9027e12dabb0acebd3c32aff555727c4129 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm) [native-inputs]: Add vala.

---

gnu/packages/display-managers.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 2f81f10140..1f4842bff3 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -180,6 +180,7 @@ create smooth, animated user interfaces.")
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
+       ("vala" ,vala)                   ;For vala bindings
        ;; For tests
        ("dbus" ,dbus)
        ("python" ,python-2)
-- 
2.25.1

Attachment: 0003-gnu-lightdm-Disable-python-tests-only.patch

From 0f3bc9f7b17b4a099a9622c92b7b2fdb4076ba24 Mon Sep 17 00:00:00 2001

* gnu/packages/display-manager.scm (lightdm-gtk-greeter): Update to 2.0.7.

---

gnu/packages/display-managers.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index eee7c6d841..49739a0064 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -187,7 +187,7 @@ display manager which supports different greeters.")
 (define-public lightdm-gtk-greeter
   (package
     (name "lightdm-gtk-greeter")
-    (version "2.0.2")
+    (version "2.0.7")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -196,7 +196,7 @@ display manager which supports different greeters.")
                     "/+download/lightdm-gtk-greeter-" version ".tar.gz"))
               (sha256
                (base32
-                "1436sdm83xqhxyr1rzqxhsl8if2xmidlvb341xcv6dv83lyxkrlf"))))
+                "1g7wc3d3vqfa7mrdhx1w9ywydgjbffla6rbrxq9k3sc62br97qms"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("exo" ,exo)
-- 
2.25.1

From b394a0e2019c9780b669a3258fe8e9afb5dfb76d Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Tue, 16 Apr 2019 13:50:58 +0200
Subject: [PATCH 05/10] gnu: lightdm-gtk-greeter: Fix at-spi runtime
 dependency.

* gnu/packages/display-manager.scm (lightdm): Fix at-spi runtime dependency.
[inputs]: Add at-spi2-core.
[arguments]: Add '--enable-at-spi-command' configure flag.
---
 gnu/packages/display-managers.scm | 6 ++++++
 1 file changed, 6 insertions(+)

Toggle diff (20 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 49739a0064..7b280fee6b 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -204,7 +204,13 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--enable-at-spi-command="
+                            (assoc-ref %build-inputs "at-spi2-core")
+                            "/libexec/at-spi-bus-launcher"))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.25.1

From f695692a52e5768e9d40a485140c148e88c51593 Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Tue, 16 Apr 2019 13:58:26 +0200
Subject: [PATCH 06/10] gnu: lightdm-gtk-greeter: Fix .desktop file.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix .desktop file
  path.
[arguments]: Add fix-.desktop-path phase.
---
 gnu/packages/display-managers.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (25 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 7b280fee6b..a97730ab1a 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,7 +210,17 @@ display manager which supports different greeters.")
      `(#:configure-flags
        (list (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
-                            "/libexec/at-spi-bus-launcher"))))
+                            "/libexec/at-spi-bus-launcher"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'fix-.desktop-path
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* (string-append
+                             out "/share/xgreeters/lightdm-gtk-greeter.desktop")
+                 (("Exec=lightdm-gtk-greeter")
+                  (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
+               #t))))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.25.1

From eaa49a238ab60f6a905506a750914ad3269c6e15 Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Tue, 16 Apr 2019 14:17:18 +0200
Subject: [PATCH 07/10] gnu: lightdm-gtk-greeter: Wrap binary.

* gnu/package/display-managers.scm (lightdm-gtk-greeter): Wrap binary.
[inputs]: Add shared-mime-info.
[arguments]: Add wrap-program phase.
---
 gnu/packages/display-managers.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Toggle diff (37 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index a97730ab1a..8636d713b0 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -204,6 +204,7 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("shared-mime-info" ,shared-mime-info)
        ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
     (arguments
@@ -220,7 +221,21 @@ display manager which supports different greeters.")
                              out "/share/xgreeters/lightdm-gtk-greeter.desktop")
                  (("Exec=lightdm-gtk-greeter")
                   (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
-               #t))))))
+               #t)))
+         (add-after 'fix-.desktop-path 'wrap-program
+           ;; try to mimic glib-or-gtk build system
+           ;; which doesn't wrap files in /sbin
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (wrap-program (string-append (assoc-ref outputs "out")
+                                          "/sbin/lightdm-gtk-greeter")
+               `("XDG_DATA_DIRS" ":" prefix
+                 ,(cons "/run/current-system/profile/share"
+                   (map (lambda (pkg)
+                          (string-append (assoc-ref inputs pkg) "/share"))
+                        '("gtk+" "shared-mime-info" "glib"))))
+               `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+             #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.25.1

From 967da134843193aaaded8a681d44734a9702e247 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm)[native-inputs]: Add accountsservice.

---

gnu/packages/display-managers.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 8636d713b0..fe45165b90 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -166,7 +166,8 @@ create smooth, animated user interfaces.")
        ("libgcrypt" ,libgcrypt)
        ("libxcb" ,libxcb)))
     (native-inputs
-     `(("gobject-introspection" ,gobject-introspection)
+     `(("accountsservice" ,accountsservice)
+       ("gobject-introspection" ,gobject-introspection)
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
-- 
2.25.1

From f5f2da7c91530ca4ad7aae38aa083cff81c1e9bc Mon Sep 17 00:00:00 2001
From: Lprndn <lprndn@gmail.com>
Date: Wed, 17 Apr 2019 12:44:07 +0200
Subject: [PATCH 09/10] gnu: lightdm-gtk-greeter: Fix some warnings.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix some warnings.
[arguments]: Add '--disable-indicator-services-command' configure flags.
---
 gnu/packages/display-managers.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index fe45165b90..e13266ed03 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,7 +210,8 @@ display manager which supports different greeters.")
        ("gtk+" ,gtk+)))
     (arguments
      `(#:configure-flags
-       (list (string-append "--enable-at-spi-command="
+       (list "--disable-indicator-services-command"
+             (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
                             "/libexec/at-spi-bus-launcher"))
        #:phases
-- 
2.25.1

Attachment: 0010-services-Add-lightdm-service-type.patch

Brice Waegeneire wrote 5 years ago

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:2d2d720d1fd6a6357a171e13953a593b@waegenei.re

Hello L p R n d n,

Using `set-xorg-configuration` with `lightdm-service-type` seems to be

working.

There is an error on vt1 at startup about some dbus stuff related to

“accountservice”. The cursor theme isn't set as well as the icon theme,

seems; it may come from some missing environment variable as NixOS set a

few of them in their service[0].

After digging in the new service file I keep wondering if it's the right

way to go about implementing it. I tried to set a simple setting

for `lightdm-gtk-greeter` and I ended up with the following which

doesn't

look intuitive:

Toggle snippet (8 lines)

(service lightdm-service-type

(lightdm-configuration

(greeter-configuration-file

(lightdm-gtk-greeter-configuration-file

(lightdm-gtk-greeter-configuration

(extra-config "hide-user-image=true"))))))

Furthermore `lightdm-service-type` only set a single seat while lightdm 
can
have many of them. So maybe there should be a lightdm-seat` record used 
as
a list of seats in `lightdm-service-type`. Each greater will be able to
expand `lightdm-service-type` by appending a seat to it. Then the
configuration could look like this:

Toggle snippet (8 lines)

(service lightdm-service-type)

(service lightdm-gtk-greeter-service-type

(lightdm-gtk-greeter-configuration

(assets (list guix-artwork))

(theme-name "Guix")

(extra-config "hide-user-image=true")))

Using this approch would also avoid populating “/etc”, at least for
`lightdm-grk-greeter`, since each greeter would be defined as a service 
and
could expand “/etc” if it really needs it. For `lightdm-gtk-greeter`
specifically avoiding putting config in “/etc/” can be done by compiling 
it
with `-DCONFIG_FILE` pointing to `/run/current-system` And `lightdm` can 
be
started with `--config`.

Here is an example in how to make a conjuration file procedure more
readable while keeping under the line length limit by using 
`match-record`:

Toggle snippet (15 lines)(define (lightdm-gtk-greeter-configuration-file config)
   (match-record config <lightdm-gtk-greeter-configuration>
     (theme-name icon-theme-name cursor-theme-name cursor-size background
                 extra-config)
    (mixed-text-file "lightdm-gtk-greeter.conf" "
[greeter]
theme-name = "           theme-name                   "
icon-theme-name = "      icon-theme-name              "
cursor-theme-name = "    cursor-theme-name            "
cursor-theme-size = "    (number->string cursor-size) "
background = "           background                   "
" extra-config                                        "
")))

BTW the default background could use one from Guix artwork repo like

“(file-append %artwork-repository "/grub/GuixSD-fully-black-16-9.svg")”.

WDYT? I may be completely off on the `lightdm-seat` part.

[0]:

https://github.com/NixOS/nixpkgs/blob/release-19.09/nixos/modules/services/x11/display-managers/lightdm-greeters/gtk.nix#L18

Cheers,

- Brice

L p R n d n wrote 5 years ago

Recipients:(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:874ktmjtkl.fsf@lprndn.info

Hello,

Thanks again for the feedbacks.

Brice Waegeneire <brice@waegenei.re> writes:

[...]

Toggle quote (6 lines)

> There is an error on vt1 at startup about some dbus stuff related to

> “accountservice”. The cursor theme isn't set as well as the icon theme,

> it

> seems; it may come from some missing environment variable as NixOS set a

> few of them in their service[0].

For the cursor, setting "XCURSOR_PATH" seems to solve the problem.

Preparing a patch.

As for dbus, from what I found at NixOS[0][1], it's a accountsservice

bug. I'll send a bug report. In the meantime, it doesn't appear to

affect LightDM too much so it might be ok...?

Toggle quote (13 lines)> After digging in the new service file I keep wondering if it's the right
> way to go about implementing it. I tried to set a simple setting
> for `lightdm-gtk-greeter` and I ended up with the following which 
> doesn't
> look intuitive:
>
> (service lightdm-service-type
>           (lightdm-configuration
>            (greeter-configuration-file
>             (lightdm-gtk-greeter-configuration-file
>              (lightdm-gtk-greeter-configuration
>               (extra-config "hide-user-image=true"))))))

Yeah, far from elegant. Did it that way in case someone wanted to

provide its own file but dropping

lightdm-gtk-greeter-configuration-file gives one level less of nesting.

Toggle quote (15 lines)> Furthermore `lightdm-service-type` only set a single seat while lightdm 
> can
> have many of them. So maybe there should be a lightdm-seat` record used 
> as
> a list of seats in `lightdm-service-type`. Each greater will be able to
> expand `lightdm-service-type` by appending a seat to it. Then the
> configuration could look like this:
>
> (service lightdm-service-type)
> (service lightdm-gtk-greeter-service-type
>           (lightdm-gtk-greeter-configuration
>            (assets (list guix-artwork))
>            (theme-name "Guix")
>            (extra-config "hide-user-image=true")))

I didn't know one could use a different greeter for each seat. Indeed,

it would be nice to have that feature!

The only thing that bothers me is that you don't get a working

default LightDM service by default. I feel that just adding (service

lightdm-service-type) to your configuration should get you a fully

working LightDM, specially for newcomers. Here one would lack a greeter.

I believe there is a solution that would give us the best of both

worlds. If someone has a clue, an idea or even a patch, please share it!

Also, merging as is and improving the service later is possible too.

Toggle quote (11 lines)>
> Using this approch would also avoid populating “/etc”, at least for
> `lightdm-grk-greeter`, since each greeter would be defined as a service 
> and
> could expand “/etc” if it really needs it. For `lightdm-gtk-greeter`
> specifically avoiding putting config in “/etc/” can be done by compiling 
> it
> with `-DCONFIG_FILE` pointing to `/run/current-system` And `lightdm` can 
> be
> started with `--config`.

I will make a patch to use --config for lightdm.

For lightdm-gtk-greeter, how would one put the config file in

"/run/current-system"? Do we need to make a package out of it?

Toggle quote (18 lines)> Here is an example in how to make a conjuration file procedure more
> readable while keeping under the line length limit by using 
> `match-record`:
>
> (define (lightdm-gtk-greeter-configuration-file config)
>    (match-record config <lightdm-gtk-greeter-configuration>
>      (theme-name icon-theme-name cursor-theme-name cursor-size background
>                  extra-config)
>     (mixed-text-file "lightdm-gtk-greeter.conf" "
> [greeter]
> theme-name = "           theme-name                   "
> icon-theme-name = "      icon-theme-name              "
> cursor-theme-name = "    cursor-theme-name            "
> cursor-theme-size = "    (number->string cursor-size) "
> background = "           background                   "
> " extra-config                                        "
> ")))

Way better! Preparing a patch for that.

Toggle quote (3 lines)

> BTW the default background could use one from Guix artwork repo like

> “(file-append %artwork-repository "/grub/GuixSD-fully-black-16-9.svg")”.

Yeap!

Toggle quote (8 lines)

> WDYT? I may be completely off on the `lightdm-seat` part.

> [0]:

> https://github.com/NixOS/nixpkgs/blob/release-19.09/nixos/modules/services/x11/display-managers/lightdm-greeters/gtk.nix#L18

> Cheers,

> - Brice

Have a nice day!

L p R n d n

L p R n d n wrote 5 years ago

Recipients:(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:02e8c94b36eb45519413033812a57680@posteo.net

Hey!

Le 14.04.2020 11:38, L p R n d n a écrit :

Toggle quote (22 lines)> Hello,
> 
> Thanks again for the feedbacks.
> 
> Brice Waegeneire <brice@waegenei.re> writes:
> 
> [...]
>> There is an error on vt1 at startup about some dbus stuff related to
>> “accountservice”. The cursor theme isn't set as well as the icon 
>> theme,
>> it
>> seems; it may come from some missing environment variable as NixOS set 
>> a
>> few of them in their service[0].
> 
> For the cursor, setting "XCURSOR_PATH" seems to solve the problem.
> Preparing a patch.
> 
> As for dbus, from what I found at NixOS[0][1], it's a accountsservice
> bug. I'll send a bug report. In the meantime, it doesn't appear to
> affect LightDM too much so it might be ok...?

Better with actual links:

[0]: https://github.com/NixOS/nixpkgs/pull/45107

[1]: https://github.com/NixOS/nixpkgs/issues/72396

Have a nice day,

L p R n d n

L p R n d n wrote 5 years ago

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:87tv1bmtir.fsf@lprndn.info

Hello,

Here is the new set of patches with quite a few modifications for the

service, everything rebased on 1.1.0.

After a discussion with bricewge on irc, a new design has been adopted

allowing use of multiple seats.

To use the service, you can instantiate a lightdm-service-type, a

lightdm-gtk-greeter-service-type or both. The service should always find

a way to start a working instance of LightDM. :)

A non exhaustive list of changes that might need further review:

* lightdm-gtk-greeter has its own service extending lightdm-service and

others.

* Seats configuration use now the lightdm-seat-record-type and can be

defined both in the lightdm-service and lightdm-gtk-greeter-service.

The greeter now extends the LightDM's service by providing a list of

seats.

* The `compose` and `extend` field of the lightdm-service-type have seen

work for this purpose while keeping compatibility with

`set-xorg-configuration`.

* extra-config fields are list of strings to avoid weird indentation in

the user's config.

* Fixed customization of lightdm-gtk-greeter's cursor.

* Added some fields to deal with accessibility for

lightdm-gtk-greeter-configuration.

* Takes default background from guix-artwork.

Also a review of PAM services might be nice as I'm not versed in security.

However, I didn't get rid of etc-service-type's extension as LightDM's

seems to ignore `sessions-directory` when configuration is passed

through `--config`. Patches to fix that are welcome but can wait a

future patch submission, I think.

Otherwise, tested in a WM: default configurations, autologin, sway,

changing greeter appearance and everything worked fine. For passwordless

I don't know if it's expected.

Have a nice day and good review :)

L p R n d n

From fc80fd5c5a4e3ffa1de0f96d2e157e230a6d7afd Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm): Update to 1.30.0.

---

gnu/packages/display-managers.scm | 11 +++++------

1 file changed, 5 insertions(+), 6 deletions(-)

Toggle diff (28 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 51605e09aa..f23dc7f573 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -125,16 +125,15 @@ create smooth, animated user interfaces.")
 (define-public lightdm
   (package
     (name "lightdm")
-    (version "1.24.0")
+    (version "1.30.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://launchpad.net/lightdm/"
-                                  (version-major+minor version) "/"
-                                  version "/+download/lightdm-"
-                                  version ".tar.xz"))
+              (uri (string-append
+                    "https://github.com/CanonicalLtd/lightdm/releases/download/"
+                    version "/lightdm-" version ".tar.xz"))
               (sha256
                (base32
-                "18j33bm54i8k7ncxcs69zqi4105s62n58jrydqn3ikrb71s9nl6d"))))
+                "158zb2d0v1309a8v19hh32y4yj3v6yg4yg6m0l7v59d3a2b7f651"))))
     (build-system gnu-build-system)
     (arguments
      '(#:parallel-tests? #f ; fails when run in parallel
-- 
2.26.1

From 79e893dd86ff913bb840ba36fe2d9aa36a4e82f0 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm) [native-inputs]: Add vala.

---

gnu/packages/display-managers.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index f23dc7f573..065b1c0000 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -180,6 +180,7 @@ create smooth, animated user interfaces.")
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
+       ("vala" ,vala)                   ;For vala bindings
        ;; For tests
        ("dbus" ,dbus)
        ("python" ,python-2)
-- 
2.26.1

Attachment: 0003-gnu-lightdm-Disable-python-tests-only.patch

From 3474c4025451a3554ef33ab0712bb40f5626ef6e Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:50:58 +0200
Subject: [PATCH 04/10] gnu: lightdm-gtk-greeter: Fix at-spi runtime
 dependency.

* gnu/packages/display-manager.scm (lightdm): Fix at-spi runtime dependency.
[inputs]: Add at-spi2-core.
[arguments]: Add '--enable-at-spi-command' configure flag.
---
 gnu/packages/display-managers.scm | 6 ++++++
 1 file changed, 6 insertions(+)

Toggle diff (20 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index e8fae583f1..65f7d6ed79 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -204,7 +204,13 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--enable-at-spi-command="
+                            (assoc-ref %build-inputs "at-spi2-core")
+                            "/libexec/at-spi-bus-launcher"))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.26.1

From 86af8348bd21d24856ba48aa067322e08f791551 Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:58:26 +0200
Subject: [PATCH 05/10] gnu: lightdm-gtk-greeter: Fix .desktop file.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix .desktop file
  path.
[arguments]: Add fix-.desktop-path phase.
---
 gnu/packages/display-managers.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (25 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 65f7d6ed79..fa9b47e2f2 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,7 +210,17 @@ display manager which supports different greeters.")
      `(#:configure-flags
        (list (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
-                            "/libexec/at-spi-bus-launcher"))))
+                            "/libexec/at-spi-bus-launcher"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'fix-.desktop-path
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* (string-append
+                             out "/share/xgreeters/lightdm-gtk-greeter.desktop")
+                 (("Exec=lightdm-gtk-greeter")
+                  (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
+               #t))))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.26.1

From d007dad08e28a613ff787a8cd2f2461d965605ba Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 14:17:18 +0200
Subject: [PATCH 06/10] gnu: lightdm-gtk-greeter: Wrap binary.

* gnu/package/display-managers.scm (lightdm-gtk-greeter): Wrap binary.
[inputs]: Add shared-mime-info.
[arguments]: Add wrap-program phase.
---
 gnu/packages/display-managers.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Toggle diff (37 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index fa9b47e2f2..ecc006ae3c 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -204,6 +204,7 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("shared-mime-info" ,shared-mime-info)
        ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
     (arguments
@@ -220,7 +221,21 @@ display manager which supports different greeters.")
                              out "/share/xgreeters/lightdm-gtk-greeter.desktop")
                  (("Exec=lightdm-gtk-greeter")
                   (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
-               #t))))))
+               #t)))
+         (add-after 'fix-.desktop-path 'wrap-program
+           ;; try to mimic glib-or-gtk build system
+           ;; which doesn't wrap files in /sbin
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (wrap-program (string-append (assoc-ref outputs "out")
+                                          "/sbin/lightdm-gtk-greeter")
+               `("XDG_DATA_DIRS" ":" prefix
+                 ,(cons "/run/current-system/profile/share"
+                   (map (lambda (pkg)
+                          (string-append (assoc-ref inputs pkg) "/share"))
+                        '("gtk+" "shared-mime-info" "glib"))))
+               `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+             #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using
-- 
2.26.1

From c2ed7ecd53808284386bbaea8dff9f4450653612 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm)[native-inputs]: Add accountsservice.

---

gnu/packages/display-managers.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index ecc006ae3c..f855b17e3f 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -166,7 +166,8 @@ create smooth, animated user interfaces.")
        ("libgcrypt" ,libgcrypt)
        ("libxcb" ,libxcb)))
     (native-inputs
-     `(("gobject-introspection" ,gobject-introspection)
+     `(("accountsservice" ,accountsservice)
+       ("gobject-introspection" ,gobject-introspection)
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
-- 
2.26.1

From 396efb44d1976fd9d5b398782f999e4da8f58ecb Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Wed, 17 Apr 2019 12:44:07 +0200
Subject: [PATCH 08/10] gnu: lightdm-gtk-greeter: Fix some warnings.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix some warnings.
[arguments]: Add '--disable-indicator-services-command' configure flags.
---
 gnu/packages/display-managers.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index f855b17e3f..0a9ae8ee61 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,7 +210,8 @@ display manager which supports different greeters.")
        ("gtk+" ,gtk+)))
     (arguments
      `(#:configure-flags
-       (list (string-append "--enable-at-spi-command="
+       (list "--disable-indicator-services-command"
+             (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
                             "/libexec/at-spi-bus-launcher"))
        #:phases
-- 
2.26.1

Attachment: 0009-services-Add-lightdm-service-type.patch

From bbdb165bd0a0d91b0ef961fec81060a0f376c25f Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Fri, 17 Apr 2020 11:53:51 +0200
Subject: [PATCH 10/10] gnu: lightdm-gtk-greeter: Set XCURSOR_PATH in wrapper.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter)[arguments]:
Modify wrap-program phase to add XCURSOR_PATH.
---
 gnu/packages/display-managers.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Toggle diff (23 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 0a9ae8ee61..43ca05bee4 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -232,11 +232,12 @@ display manager which supports different greeters.")
                                           "/sbin/lightdm-gtk-greeter")
                `("XDG_DATA_DIRS" ":" prefix
                  ,(cons "/run/current-system/profile/share"
-                   (map (lambda (pkg)
-                          (string-append (assoc-ref inputs pkg) "/share"))
-                        '("gtk+" "shared-mime-info" "glib"))))
+                        (map (lambda (pkg)
+                               (string-append (assoc-ref inputs pkg) "/share"))
+                             '("gtk+" "shared-mime-info" "glib"))))
                `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
-               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("XCURSOR_PATH" ":" prefix ("/run/current-system/profile/share/icons")))
              #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
-- 
2.26.1

L p R n d n wrote 5 years ago

Recipients:(address . 35305@debbugs.gnu.org)

Message-ID:87imh9gnvy.fsf@lprndn.info

Hello,

New set of patches with some modifications according to the feedbacks

from rekado.

One notable change is that all tests are now enabled for LightDM's

package. The package builds but there might be some non deterministic

tests failures sometimes (not necessarily those that have been re-enabled).

Have a nice day,

L p R n d n

From d55481e2cfbe83567c1950531cd4780b46371255 Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:16:39 +0200
Subject: [PATCH 1/9] gnu: lightdm: Update 1.30.0.

* gnu/packages/display-managers.scm (lightdm): Update to 1.30.0.
[arguments]: Re-enable all tests by removing 'disable-broken-tests phase.
---
 gnu/packages/display-managers.scm | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

Toggle diff (39 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 51605e09aa..49e9264f8f 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -125,16 +125,15 @@ create smooth, animated user interfaces.")
 (define-public lightdm
   (package
     (name "lightdm")
-    (version "1.24.0")
+    (version "1.30.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://launchpad.net/lightdm/"
-                                  (version-major+minor version) "/"
-                                  version "/+download/lightdm-"
-                                  version ".tar.xz"))
+              (uri (string-append
+                    "https://github.com/CanonicalLtd/lightdm/releases/download/"
+                    version "/lightdm-" version ".tar.xz"))
               (sha256
                (base32
-                "18j33bm54i8k7ncxcs69zqi4105s62n58jrydqn3ikrb71s9nl6d"))))
+                "158zb2d0v1309a8v19hh32y4yj3v6yg4yg6m0l7v59d3a2b7f651"))))
     (build-system gnu-build-system)
     (arguments
      '(#:parallel-tests? #f ; fails when run in parallel
@@ -153,13 +152,6 @@ create smooth, animated user interfaces.")
              (substitute* "src/seat.c"
                (("/bin/sh") (which "sh")))
              #t))
-         (add-after 'unpack 'disable-broken-tests
-           (lambda _
-             (substitute* "tests/Makefile.in"
-               (("test-sessions-gobject ") "")
-               ((" test-sessions-python ") " "))
-             #t))
          (add-before 'check 'pre-check
            ;; Run test-suite under a dbus session.
            (lambda* (#:key inputs #:allow-other-keys)

2.26.1

From fd891d52cd184e197dcb07fb3855492c28911815 Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm) [native-inputs]: Add vala.

---

gnu/packages/display-managers.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (12 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 49e9264f8f..7f812d3b54 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -174,7 +174,7 @@ create smooth, animated user interfaces.")
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)
+       ("vala" ,vala)                   ;For vala bindings
        ;; For tests
        ("dbus" ,dbus)
        ("python" ,python-2)

2.26.1

From ef53a04c308fc8b00b77a833b4018d11247924cb Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:50:58 +0200
Subject: [PATCH 3/9] gnu: lightdm-gtk-greeter: Fix at-spi runtime dependency.

* gnu/packages/display-manager.scm (lightdm): Fix at-spi runtime dependency.
[inputs]: Add at-spi2-core.
[arguments]: Add '--enable-at-spi-command' configure flag.
---
 gnu/packages/display-managers.scm | 6 ++++++
 1 file changed, 6 insertions(+)

Toggle diff (18 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 7f812d3b54..ed12a4605b 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,8 +210,13 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--enable-at-spi-command="
+                            (assoc-ref %build-inputs "at-spi2-core")
+                            "/libexec/at-spi-bus-launcher"))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using

2.26.1

From d73ff1af07bc2bd9ec7029577877cfbf87b98d60 Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 13:58:26 +0200
Subject: [PATCH 4/9] gnu: lightdm-gtk-greeter: Fix .desktop file.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix .desktop file
  path.
[arguments]: Add fix-.desktop-path phase.
---
 gnu/packages/display-managers.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (23 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index ed12a4605b..18ec0f10d6 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -216,8 +216,17 @@ display manager which supports different greeters.")
      `(#:configure-flags
        (list (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
-                            "/libexec/at-spi-bus-launcher"))))
+                            "/libexec/at-spi-bus-launcher"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'fix-.desktop-path
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* (string-append
+                             out "/share/xgreeters/lightdm-gtk-greeter.desktop")
+                 (("Exec=lightdm-gtk-greeter")
+                  (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
+               #t))))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using

2.26.1

From 4a7ce94753e0d8180d5581387cc18a585a28eadc Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Tue, 16 Apr 2019 14:17:18 +0200
Subject: [PATCH 5/9] gnu: lightdm-gtk-greeter: Wrap binary.

* gnu/package/display-managers.scm (lightdm-gtk-greeter): Wrap binary.
[inputs]: Add shared-mime-info.
[arguments]: Add wrap-program phase.
---
 gnu/packages/display-managers.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Toggle diff (35 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 18ec0f10d6..be17f055d1 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -210,6 +210,7 @@ display manager which supports different greeters.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("lightdm" ,lightdm)
+       ("shared-mime-info" ,shared-mime-info)
        ("at-spi2-core" ,at-spi2-core)
        ("gtk+" ,gtk+)))
     (arguments
@@ -226,8 +227,21 @@ display manager which supports different greeters.")
                              out "/share/xgreeters/lightdm-gtk-greeter.desktop")
                  (("Exec=lightdm-gtk-greeter")
                   (string-append "Exec=" out "/sbin/lightdm-gtk-greeter")))
-               #t))))))
+               #t)))
+         (add-after 'fix-.desktop-path 'wrap-program
+           ;; try to mimic glib-or-gtk build system
+           ;; which doesn't wrap files in /sbin
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (wrap-program (string-append (assoc-ref outputs "out")
+                                          "/sbin/lightdm-gtk-greeter")
+               `("XDG_DATA_DIRS" ":" prefix
+                 ,(cons "/run/current-system/profile/share"
+                   (map (lambda (pkg)
+                          (string-append (assoc-ref inputs pkg) "/share"))
+                        '("gtk+" "shared-mime-info" "glib"))))
+               `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+             #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
     (description "This package provides a LightDM greeter implementation using

2.26.1

From 1250601cbad58a5d6cea588fdcc1258b2c8861db Mon Sep 17 00:00:00 2001

* gnu/packages/display-managers.scm (lightdm)[native-inputs]: Add accountsservice.

---

gnu/packages/display-managers.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index be17f055d1..42245f19e2 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -170,8 +170,8 @@ create smooth, animated user interfaces.")
        ("libgcrypt" ,libgcrypt)
        ("libxcb" ,libxcb)))
     (native-inputs
-     `(("gobject-introspection" ,gobject-introspection)
+     `(("accountsservice" ,accountsservice)
+       ("gobject-introspection" ,gobject-introspection)
        ("pkg-config" ,pkg-config)
        ("itstool" ,itstool)
        ("intltool" ,intltool)

2.26.1

From 18e22bf05def2c1102a66cce2b2bbb42d3faeded Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Wed, 17 Apr 2019 12:44:07 +0200
Subject: [PATCH 7/9] gnu: lightdm-gtk-greeter: Disable indicator services.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter): Fix some warnings.
[arguments]: Add '--disable-indicator-services-command' configure flags.
---
 gnu/packages/display-managers.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (15 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 42245f19e2..3d0a118e27 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -216,8 +216,9 @@ display manager which supports different greeters.")
        ("gtk+" ,gtk+)))
     (arguments
      `(#:configure-flags
-       (list (string-append "--enable-at-spi-command="
+       ;; indicator services use upstart
+       (list "--disable-indicator-services-command"
+             (string-append "--enable-at-spi-command="
                             (assoc-ref %build-inputs "at-spi2-core")
                             "/libexec/at-spi-bus-launcher"))
        #:phases

2.26.1

Attachment: 0008-services-Add-lightdm-service-type.patch

From 879cced7b0205035407dfa680966e5672e77da9c Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Fri, 17 Apr 2020 11:53:51 +0200
Subject: [PATCH 9/9] gnu: lightdm-gtk-greeter: Set XCURSOR_PATH in wrapper.

* gnu/packages/display-managers.scm (lightdm-gtk-greeter)[arguments]:
Modify wrap-program phase to add XCURSOR_PATH.
---
 gnu/packages/display-managers.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Toggle diff (23 lines)diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 3d0a118e27..1f82ccc065 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -239,11 +239,12 @@ display manager which supports different greeters.")
                                           "/sbin/lightdm-gtk-greeter")
                `("XDG_DATA_DIRS" ":" prefix
                  ,(cons "/run/current-system/profile/share"
-                   (map (lambda (pkg)
-                          (string-append (assoc-ref inputs pkg) "/share"))
-                        '("gtk+" "shared-mime-info" "glib"))))
+                        (map (lambda (pkg)
+                               (string-append (assoc-ref inputs pkg) "/share"))
+                             '("gtk+" "shared-mime-info" "glib"))))
                `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+")))
-               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))))
+               `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+")))
+               `("XCURSOR_PATH" ":" prefix ("/run/current-system/profile/share/icons")))
              #t)))))
     (synopsis "GTK+ greeter for LightDM")
     (home-page "https://launchpad.net/lightdm-gtk-greeter")
-- 
2.26.1

Ricardo Wurmus wrote 5 years ago

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:87k11m2hqx.fsf@elephly.net

I have applied all patches locally, pushed some of them to the master

branch already, and also made these local changes:

Attachment: lightdm.diff

What do you think about these changes? I felt that a list of

directories should be expressed as a list and not a colon-separated

string. I realize that this clashes with the lightdm configuration

file, which speaks of “directory” even though it accepts a

colon-separated list of directories.

If that’s fine I’ll fold them into your patch that adds the service.

I built a VM and noticed that all icons are missing. Should the service

arrange for a certain fallback icon theme to be installed?

I also haven’t actually been able to log in as root with an empty

password, which is what the VM generates by default. Can this be

supported with lightdm?

Ricardo

L p R n d n wrote 5 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . 35305@debbugs.gnu.org)

Message-ID:87zhahcfgh.fsf@lprndn.info

Hello,

Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (3 lines)

> I have applied all patches locally, pushed some of them to the master

> branch already, and also made these local changes:

Thanks for the review!

[...]

Toggle quote (10 lines)>  
>  @item @code{autologin-user} (default: "")
> -If @code{autologin-user} is set, LightDM logs in directly
> -as @code{autologin-user} to the session defined in
> -@code{default-user-session}. This user should be part of the
> +If @code{autologin-user} is set, LightDM logs in directly as
> +@code{autologin-user} to the session defined in
> +@code{default-user-session}.  This user should be part of the
>  @code{autologin} group.

My bad but here, the `autologin group thing is not applicable in
Guix at least for now. + adding a user to this group outputs an error
So I tried to make a quick fix of the documentation with this patch:

Toggle diff (18 lines)diff --git a/doc/guix.texi b/doc/guix.texi
index 54eba225d3..3dd5fe216a 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14792,10 +14792,9 @@ The name of the default @code{.desktop} file describing a session.
 Will be used for @code{user-session} and @code{autologin-session} if necessary.
 
 @item @code{autologin-user} (default: "")
-If @code{autologin-user} is set, LightDM logs in directly
-as @code{autologin-user} to the session defined in
-@code{default-user-session}. This user should be part of the
-@code{autologin} group.
+If @code{autologin-user} is set, LightDM logs in directly as
+@code{autologin-user} to the session defined in
+@code{default-user-session}.
 
 @item @code{extra-config} (default: @code{'()})
 A list of strings each describing a custom setting to append to the seat

However it might be interesting to set this up in Guix as it seems to be

used in other linux distribution and looks like a relatively good security

feature. I'm not versed in security but we would at least need to create

this group and modify the pam services. Should I open an issue for that?

[...]

Toggle quote (7 lines)

> What do you think about these changes? I felt that a list of

> directories should be expressed as a list and not a colon-separated

> string. I realize that this clashes with the lightdm configuration

> file, which speaks of “directory” even though it accepts a

> colon-separated list of directories.

Everything is looking fine! And the directories as lists is indeed way better.

Toggle quote (5 lines)

> If that’s fine I’ll fold them into your patch that adds the service.

> I built a VM and noticed that all icons are missing. Should the service

> arrange for a certain fallback icon theme to be installed?

If you only added (service-type lightdm-service-type) without any
greeter, it's expected.
LightDM without autologin needs a greeter. So in this case you just get
a "fallback" session to avoid unnecesseraly breaking the user's
system. I choose not to bring lightdm-gtk-greeter's assets to give the
user a little push toward adding a greeter service. It's very arguable
so if you think we should bring in assets too, let's do it. I can
prepare a patch if you want. The documentation might also be lacking
here. So adding a little comment in the lightdm-service description
might also be enough. What do you think?

Toggle quote (4 lines)

> I also haven’t actually been able to log in as root with an empty

> password, which is what the VM generates by default. Can this be

> supported with lightdm?

Didn't succeed either but it should be possible... :/

Looking on the web, on passwordless login, the lightdm-autologin pam is

often cited so this line:

(pam-entry (control "required") (module "pam_succeed_if.so")

(arguments (list "uid >= 1000")))

might be related. But I'm really not knowledgeable enough on this matter

to give a proper answer.

Toggle quote (3 lines)

> --

> Ricardo

Have a nice day,

L p R n d n

Ricardo Wurmus wrote 5 years ago

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:878shz38bf.fsf@elephly.net

L p R n d n <guix@lprndn.info> writes:

Toggle quote (10 lines)>> I built a VM and noticed that all icons are missing.  Should the service
>> arrange for a certain fallback icon theme to be installed?
>
> If you only added (service-type lightdm-service-type) without any
> greeter, it's expected.
> LightDM without autologin needs a greeter. So in this case you just get
> a "fallback" session to avoid unnecesseraly breaking the user's
> system. I choose not to bring lightdm-gtk-greeter's assets to give the
> user a little push toward adding a greeter service.

Ah, now I understand the comment in lightdm-profile-service.

I think the default configuration should take care of all this. It

seems problematic to me that users specify “greeter-session” as a mere

string, but the corresponding greeter may not even be installed. That’s

also what’s bothering me about the greeter search directories.

Would it make sense to let “greeter-session” be a *package* instead of a

string? Then we could specify the lightdm-gtk-greeter package as the

default and use its output directory as the lookup directory for

greeters — instead of the global system profile.

I think this would be more elegant and reduce potential for

misconfiguration. What do you think about this?

Toggle quote (4 lines)

> It's very arguable

> so if you think we should bring in assets too, let's do it. I can

> prepare a patch if you want.

What do you mean by assets? Which package provides them?

Toggle quote (14 lines)>> I also haven’t actually been able to log in as root with an empty
>> password, which is what the VM generates by default.  Can this be
>> supported with lightdm?
>
> Didn't succeed either but it should be possible... :/
> Looking on the web, on passwordless login, the lightdm-autologin pam is
> often cited so this line:
>
> (pam-entry (control "required") (module "pam_succeed_if.so")
>            (arguments (list "uid >= 1000")))
>
> might be related. But I'm really not knowledgeable enough on this matter
> to give a proper answer.

I can take a look at this and the other PAM questions you had.

Ricardo

L p R n d n wrote 5 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . 35305@debbugs.gnu.org)

Message-ID:87o8quu6bi.fsf@lprndn.info

Hello,

Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (14 lines)> L p R n d n <guix@lprndn.info> writes:
>
>>> I built a VM and noticed that all icons are missing.  Should the service
>>> arrange for a certain fallback icon theme to be installed?
>>
>> If you only added (service-type lightdm-service-type) without any
>> greeter, it's expected.
>> LightDM without autologin needs a greeter. So in this case you just get
>> a "fallback" session to avoid unnecesseraly breaking the user's
>> system. I choose not to bring lightdm-gtk-greeter's assets to give the
>> user a little push toward adding a greeter service.
>
> Ah, now I understand the comment in lightdm-profile-service.

Sorry, my comment was not clear :/

Toggle quote (5 lines)

> I think the default configuration should take care of all this. It

> seems problematic to me that users specify “greeter-session” as a mere

> string, but the corresponding greeter may not even be installed. That’s

> also what’s bothering me about the greeter search directories.

I agree but just to clarify the current behavior:
* A user can either define only a lightdm-service, only greeter-service.s
or both.
* There can be multiple greeter services defined hence allowing
different greeters, greeter configurations or assets for different seats
* Greeters' services extend the lightdm-service so the latter is really only needed
if you want to modify the default confiuration or do not define any
greeter.
* A seat defined in a greeter service have its `greeter-session
overwritten + get the greeter package for free. This is why defining
seats through the greeter is preferred.

Hope it's clear, I had some troubles with the possessive in those sentences...

Toggle quote (5 lines)

> Would it make sense to let “greeter-session” be a *package* instead of a

> string? Then we could specify the lightdm-gtk-greeter package as the

> default and use its output directory as the lookup directory for

> greeters — instead of the global system profile.

Yet, it's better, yes! So we remove the `greeters-directory field from the

`lightdm-configuration and use a package as input of the greeter-session

field of `lightdm-seat-configuration, right?

Toggle quote (9 lines)

> I think this would be more elegant and reduce potential for

> misconfiguration. What do you think about this?

>> It's very arguable

>> so if you think we should bring in assets too, let's do it. I can

>> prepare a patch if you want.

> What do you mean by assets? Which package provides them?

I meant the assets used by the greeter. They're defined in the
`lightdm-gtk-greeter-configuration-assets field of the
lightdm-gtk-greeter's configuration. It's really the only thing lacking
in the fallback session. A little patch that should be enough to fix the
missing icons.

Toggle diff (15 lines)diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm
index fa5330aade..0ef7f43215 100644
--- a/gnu/services/lightdm.scm
+++ b/gnu/services/lightdm.scm
@@ -291,7 +291,9 @@ remote-sessions-directory = " ,remote-sessions-directory "
   (let ((seats (lightdm-configuration-seats config))
         (lightdm (lightdm-configuration-lightdm config)))
     (if (null? seats)
-        (list lightdm lightdm-gtk-greeter)
+        (list lightdm lightdm-gtk-greeter
+              ;; assets
+              adwaita-icon-theme gnome-themes-standard)
         (list lightdm))))
 
 (define lightdm-service-type

Toggle quote (16 lines)>>> I also haven’t actually been able to log in as root with an empty
>>> password, which is what the VM generates by default.  Can this be
>>> supported with lightdm?
>>
>> Didn't succeed either but it should be possible... :/
>> Looking on the web, on passwordless login, the lightdm-autologin pam is
>> often cited so this line:
>>
>> (pam-entry (control "required") (module "pam_succeed_if.so")
>>            (arguments (list "uid >= 1000")))
>>
>> might be related. But I'm really not knowledgeable enough on this matter
>> to give a proper answer.
>
> I can take a look at this and the other PAM questions you had.

That would be nice! Beside this point, it's really checking that

there are no errors.

Toggle quote (3 lines)

> --

> Ricardo

Have a nice day,

L p R n d n

L p R n d n wrote 5 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . 35305@debbugs.gnu.org)

Message-ID:87o8qtzd71.fsf@lprndn.info

Hello,

Little from my side, I forgot to add the polkit extension of the lightdm

service so here is a patch.

Have a nice day,

L p R n d n

From e40317008723f27743f72f90008587ca2f779dde Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Mon, 11 May 2020 20:15:55 +0200
Subject: [PATCH 10/10] services: lightdm: Extend polkit service.

* gnu/services/lightdm.scm (lightdm-service-type): Add the LightDM package to
the polkit service.
---
 gnu/services/lightdm.scm | 2 ++
 1 file changed, 2 insertions(+)

Toggle diff (15 lines)diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm
index fa5330aade..5edeecd195 100644
--- a/gnu/services/lightdm.scm
+++ b/gnu/services/lightdm.scm
@@ -308,6 +308,8 @@ remote-sessions-directory = " ,remote-sessions-directory "
                   (service-extension dbus-root-service-type
                                      (compose list
                                               lightdm-configuration-lightdm))
+                  (service-extension polkit-service-type
+                                     (compose list lightdm-configuration-lightdm))
                   (service-extension account-service-type
                                      (const %lightdm-accounts))
                   (service-extension etc-service-type
-- 
2.26.1

Ricardo Wurmus wrote 5 years ago

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:87k116e3ee.fsf@elephly.net

Hey,

I’m very sorry for the delay.

What took me so long is that I’m conflicted about how to move forward.

On one hand I really don’t want to delay this. I think your patches are

a great and important addition to Guix. On the other hand I feel that

the relationship between these new components isn’t quite right.

It still doesn’t feel quite right to me that there’s a

lightdm-service-type and an independent

lightdm-gtk-greeter-service-type. I know that there can be any number

of greeters, but only one will be used with lightdm-service-type

dependent on the string value of greeter-session. This leads to

potential misconfiguration as we don’t (and can’t) validate this string.

It also feels wrong to me to have a global directory as the only

location for greeter desktop files, which means that all greeters must

be installed globally.

What I envision is something like this: we only have a single

lightdm-service-type and it has a field “greeters”, which by default is

a list of just one item: a <greeter> record containing the

lightdm-gtk-greeter and its configuration.

Other greeters could be added; they would all be record values of type

<greeter> and come with their own extensions of the

ligthdm-service-type.

The lightdm-service-type would go through each of the greeters in the

list and apply their specified extensions to itself.

The reason why I haven’t implemented this yet is because a) I don’t want

to break what already works with your patches and b) I don’t know if

that’s ultimately a clearer implementation.

I feel that this would be a more intuitive configuration and result in

clearer relationships between the display manager and its swappable

components. It would also allow for better defaults (so less

configuration needed) and avoid the problem of stringy types that are

easy to get wrong.

Maybe we are already really close to this solution, though: maybe the

proposed “greeter” field could simply accept service types like the

lightdm-gtk-greeter-service-type you already defined.

I’m going to play with this a little bit more, but if this doesn’t lead

anywhere I’ll merge the current version.

My apologies for delaying this!

Ricardo

L p R n d n wrote 5 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:87tv09zo70.fsf@lprndn.info

Hello,

Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (4 lines)

> Hey,

> I’m very sorry for the delay.

Again, there's no hurry. ;)

Toggle quote (12 lines)> What took me so long is that I’m conflicted about how to move forward.
> On one hand I really don’t want to delay this.  I think your patches are
> a great and important addition to Guix.  On the other hand I feel that
> the relationship between these new components isn’t quite right.
>
> It still doesn’t feel quite right to me that there’s a
> lightdm-service-type and an independent
> lightdm-gtk-greeter-service-type.  I know that there can be any number
> of greeters, but only one will be used with lightdm-service-type
> dependent on the string value of greeter-session.  This leads to
> potential misconfiguration as we don’t (and can’t) validate this string.

Just to clarify, as per my understanding, there can be multiple
`greeter-session fields defined. It's not a global value but a per seat
one. Each seat should be able to use a different greeter, I
think. Personally, I have a very standard use whith only one seat so
there are no questions in that case. However there might be use-cases
where it's needed. I CC bricewge, they might be more knowledgeable on
this issue.

Toggle quote (4 lines)

> It also feels wrong to me to have a global directory as the only

> location for greeter desktop files, which means that all greeters must

> be installed globally.

Isn't using packages as inputs of `greeter-session solving this issue?

We can collect them from seats and string-join them into the

`greeter-directory field.

Toggle quote (12 lines)> What I envision is something like this: we only have a single
> lightdm-service-type and it has a field “greeters”, which by default is
> a list of just one item: a <greeter> record containing the
> lightdm-gtk-greeter and its configuration.
>
> Other greeters could be added; they would all be record values of type
> <greeter> and come with their own extensions of the
> ligthdm-service-type.
>
> The lightdm-service-type would go through each of the greeters in the
> list and apply their specified extensions to itself.

If I understand correctly, the main difference would be that the
greeters would be defined from within the lightdm-service (as a list of records?), right?
The current implementation was chosen to avoid too much field nesting
but I don't mind.
Also, you can have a look at the previous implementation (see
mail from 19th of March). It lacks seats and some featurse but it looks a
little closer to what you're describing. It might give some ideas.

Toggle quote (14 lines)> The reason why I haven’t implemented this yet is because a) I don’t want
> to break what already works with your patches and b) I don’t know if
> that’s ultimately a clearer implementation.
>
> I feel that this would be a more intuitive configuration and result in
> clearer relationships between the display manager and its swappable
> components.  It would also allow for better defaults (so less
> configuration needed) and avoid the problem of stringy types that are
> easy to get wrong.
>
> Maybe we are already really close to this solution, though: maybe the
> proposed “greeter” field could simply accept service types like the
> lightdm-gtk-greeter-service-type you already defined.

We're close. :)
Just curious here, if we use a list of services (for example) as input of
the greeters field, how do we take care of it? Can we "merge" the
different services into the lightdm one? If it's possible, this might be
a good solution.

Toggle quote (5 lines)

> I’m going to play with this a little bit more, but if this doesn’t lead

> anywhere I’ll merge the current version.

> My apologies for delaying this!

Everything is going a lot faster than it was a few months ago so it's

already fine.

Have a nice day,

L p R n d n

Ricardo Wurmus wrote 5 years ago

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:87h7w9ej4w.fsf@elephly.net

L p R n d n <guix@lprndn.info> writes:

Toggle quote (30 lines)> Hello,
>
> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Hey,
>>
>> I’m very sorry for the delay.
>
> Again, there's no hurry. ;)
>
>> What took me so long is that I’m conflicted about how to move forward.
>> On one hand I really don’t want to delay this.  I think your patches are
>> a great and important addition to Guix.  On the other hand I feel that
>> the relationship between these new components isn’t quite right.
>>
>> It still doesn’t feel quite right to me that there’s a
>> lightdm-service-type and an independent
>> lightdm-gtk-greeter-service-type.  I know that there can be any number
>> of greeters, but only one will be used with lightdm-service-type
>> dependent on the string value of greeter-session.  This leads to
>> potential misconfiguration as we don’t (and can’t) validate this string.
>
> Just to clarify, as per my understanding, there can be multiple
> `greeter-session fields defined. It's not a global value but a per seat
> one. Each seat should be able to use a different greeter, I
> think. Personally, I have a very standard use whith only one seat so
> there are no questions in that case. However there might be use-cases
> where it's needed. I CC bricewge, they might be more knowledgeable on
> this issue.

Right, I realized this after composing my message.  However, currently
the lightdm-gtk-greeter-service-type inherits all the seats and then
overrides the greeter-session value for each of them, which seems rather
rude.  So maybe it is wrong to let greeters do that at all.

I wondered why there’s a service type for the greeter at all, so I
looked at the service extensions it provides:

* lightdm-service-type: only used to override greeter-session in all
  defined seats, which seems like an anti-feature.  If other greeters
  do the same, then effectively there can only be one greeter for all
  seats, and that would be wrong.  So seat configuration really should
  remain in lightdm-service-type and not be an extension.

* etc-service-type: that’s to provide the greeter’s global configuration
  file.  Ideally, we would not need to use a global configuration file.
  It looks like lightdm-gtk-greeter respects the XDG_CONFIG_DIRS
  variable, so we should be able to generate its configuration file in
  an arbitrary location and then add it to XDG_CONFIG_DIRS in the
  environment of lightdm itself.

* profile-service-type: that’s to install lightdm-gtk-greeter and its
  assets into the system profile.  Again, that’s something we should aim
  to avoid.  It seems that we can avoid it with the use of environment
  variables in the lightdm shepherd service.

If we can avoid all three extensions then we don’t need a
lightdm-gtk-greeter-service-type at all.  If we don’t need a service we
can specify greeters as record type values with a name and configuration
file generator.

-- 
Ricardo

L p R n d n wrote 5 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:871rmp4ll9.fsf@lprndn.info

Hello,

I spent some time thinking about the lightdm service and what are our

possibilities so here are my thoughts and conclusions.

(Here, I'll only describe relations between seats, greeters and the lightdm

service as it's our main source of problems)

So if we get rid of the greeter's services, we can have:

(service lightd-service-type

(lightdm-configuration

(greeters

(list

(lightdm-gtk-greeter-configuration

(seats

(list

(lightdm-seat-configuration ...))))))))

Here seats are defined by greeters. This way the user doesn't need to

fill `greeter-session field as we can do it automatically. But there's a lot of nesting

(and two lists.) + How do we define autologin?

(service lightd-service-type

(lightdm-configuration

(seats

(list

(lightdm-seat-configuration

(greeter-session

(lightdm-gtk-greeter-configuration ...)))))))

Defining greeters inside seats allows in the `greeter-session field make

it a little simpler. However, we would get errors or conflicts if a user

define two different configurations of the same greeter for two

different seats. The thing is that we can only have one configuration

per greeter as it will always look for a hardcoded file in /etc/ (worst

case) or a file we hardcoded at build time (best case). :/

(service lightd-service-type

(lightdm-configuration

(seats

(list

(lightdm-seat-configuration

(greeter-session 'lightdm-gtk-greeter))))

(greeters

(list

(lightdm-gtk-greeter-configuration

)))))

We can have separate fields for greeters and seats. The user will have

to define `greeter-session by himself. And what happen if they define

multiple occurences of one greeter's configuration?

So my conclusion is that the current implementation using a different service for lightdm and its

greeters is probably not so bad as it prevents most of these

issues. Unless someone has an even better idea, indeed. :D

Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (5 lines)> L p R n d n <guix@lprndn.info> writes:
>
>> Hello,
>>
>> Ricardo Wurmus <rekado@elephly.net> writes:

[...]

Toggle quote (14 lines)> Right, I realized this after composing my message.  However, currently
> the lightdm-gtk-greeter-service-type inherits all the seats and then
> overrides the greeter-session value for each of them, which seems rather
> rude.  So maybe it is wrong to let greeters do that at all.
>
> I wondered why there’s a service type for the greeter at all, so I
> looked at the service extensions it provides:
>
> * lightdm-service-type: only used to override greeter-session in all
>   defined seats, which seems like an anti-feature.  If other greeters
>   do the same, then effectively there can only be one greeter for all
>   seats, and that would be wrong.  So seat configuration really should
>   remain in lightdm-service-type and not be an extension.

As disussed on IRC, a greeter service only overwrites its own

`greeter-session field. But we could get rid of the `greeter-session

field altogether as it's probably not necessary if they're filled by the

greeters' service or record (depending of what we choose).

Toggle quote (7 lines)

> * etc-service-type: that’s to provide the greeter’s global configuration

> file. Ideally, we would not need to use a global configuration file.

> It looks like lightdm-gtk-greeter respects the XDG_CONFIG_DIRS

> variable, so we should be able to generate its configuration file in

> an arbitrary location and then add it to XDG_CONFIG_DIRS in the

> environment of lightdm itself.

I didn't find any informations about lightdm-gtk-greeter using

XDG_CONFIG_DIRS. Could you provide further explaination as it could

impact what I wrote earlier.

Toggle quote (5 lines)

> * profile-service-type: that’s to install lightdm-gtk-greeter and its

> assets into the system profile. Again, that’s something we should aim

> to avoid. It seems that we can avoid it with the use of environment

> variables in the lightdm shepherd service.

Yeah ;)

Toggle quote (5 lines)

> If we can avoid all three extensions then we don’t need a

> lightdm-gtk-greeter-service-type at all. If we don’t need a service we

> can specify greeters as record type values with a name and configuration

> file generator.

Hope it's clear, I'm really just dumping my thoughts... :)

Please tell me what you think.

Have a nice day,

L p R n d n

L p R n d n wrote 5 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:87v9jnqfiy.fsf@lprndn.info

Hello,

Here I come again with a new attempt for the LightDM service.

This one is a little too complex to my taste but it succeeds IMHO at

dealing with most cases nicely. Also I didn't find any other occurence

of this in Guix, so it might just not fit in. It's a draft and it's

ugly, it probably needs some refactoring/renaming, maybe using methods?

or just alists?

In the meantime, the chosen design is to have the lightdm-service and

greeter services to extend another, private service (lightdm-aggregate)

that deals with mergin everything all configuration and extending the

needed services accordingly. This way, data can be shared between

lightdm's and greeters' configurations (here, greeters' desktop file

directories and a list of greeters needed by the seats definition)

It features:

* A user can define only the a lightdm-service or only a greeter service

or both, he should always get a working LightDM. If a seats asks for a

greeter which is not defined in the user config, the lightdm-aggregate

service adds its service with default config.

* Seats are defined only in the lightdm service so, on one hand, the user needs to

manually set the `greeter-session field but, on the other hand, we get

a clear distinction between configurations.

* Too many (cond ...). There might be better solutions.

Please give me your opinion. I think I'll try one last design which will

be the complete opposite of this one. (lightdm-service deals with its

conf, greeters deal with theirs. The user deals with the rest. Also

(service lightdm-service-type) is not enough for a working

display-manager).

Have a nice day,

L p R n d n

Attachment: 0001-services-Add-lightdm-service-type.patch

Maxim Cournoyer wrote 3 years ago

Re: bug#35305: [WIP] LightDM service

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(address . 35305@debbugs.gnu.org)

Message-ID:874jysrbrt.fsf_-_@gmail.com

Hi,

Toggle quote (31 lines)

> Hello,

> New set of patches with some modifications according to the feedbacks

> from rekado.

> One notable change is that all tests are now enabled for LightDM's

> package. The package builds but there might be some non deterministic

> tests failures sometimes (not necessarily those that have been re-enabled).

> Have a nice day,

> L p R n d n

> [2. text/x-patch; 0001-gnu-lightdm-Update-1.30.0.patch]...

> [3. text/x-patch; 0002-gnu-lightdm-Add-vala-bindings.patch]...

> [4. text/x-patch; 0003-gnu-lightdm-gtk-greeter-Fix-at-spi-runtime-dependenc.patch]...

> [5. text/x-patch; 0004-gnu-lightdm-gtk-greeter-Fix-.desktop-file.patch]...

> [6. text/x-patch; 0005-gnu-lightdm-gtk-greeter-Wrap-binary.patch]...

> [7. text/x-patch; 0006-gnu-lightdm-Build-accountsservice-files.patch]...

> [8. text/x-patch; 0007-gnu-lightdm-gtk-greeter-Disable-indicator-services.patch]...

> [9. text/x-patch; 0008-services-Add-lightdm-service-type.patch]...

> [10. text/x-patch; 0009-gnu-lightdm-gtk-greeter-Set-XCURSOR_PATH-in-wrapper.patch]...

All the above changes except for the service have now been merged into

master. I'll now look at the service various versions.

Thank you!

Maxim

Maxim Cournoyer wrote 3 years ago

Recipients:(name . L p R n d n)(address . guix@lprndn.info)(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . brice@waegenei.re)(address . 35305@debbugs.gnu.org)

Message-ID:87zggkppbh.fsf_-_@gmail.com

Hi,

L p R n d n <guix@lprndn.info> writes:

Toggle quote (56 lines)> Hello,
>
> I spent some time thinking about the lightdm service and what are our
> possibilities so here are my thoughts and conclusions.
>
> (Here, I'll only describe relations between seats, greeters and the lightdm
> service as it's our main source of problems)
>
> So if we get rid of the greeter's services, we can have:
>
> 1:
> (service lightd-service-type
>     (lightdm-configuration
>         (greeters
>             (list
>                 (lightdm-gtk-greeter-configuration
>                   (seats
>                       (list
>                           (lightdm-seat-configuration ...))))))))
>
> Here seats are defined by greeters. This way the user doesn't need to
> fill `greeter-session field as we can do it automatically. But there's a lot of nesting
> (and two lists.) + How do we define autologin?
>
> 2:
> (service lightd-service-type
>     (lightdm-configuration
>         (seats
>             (list
>                 (lightdm-seat-configuration
>                     (greeter-session
>                         (lightdm-gtk-greeter-configuration ...)))))))
>
> Defining greeters inside seats allows in the `greeter-session field make
> it a little simpler. However, we would get errors or conflicts if a user
> define two different configurations of the same greeter for two
> different seats. The thing is that we can only have one configuration
> per greeter as it will always look for a hardcoded file in /etc/ (worst
> case) or a file we hardcoded at build time (best case). :/
>
> 3:
> (service lightd-service-type
>     (lightdm-configuration
>         (seats
>             (list
>                 (lightdm-seat-configuration
>                     (greeter-session 'lightdm-gtk-greeter))))
>         (greeters
>             (list
>                 (lightdm-gtk-greeter-configuration
>                   )))))
>
> We can have separate fields for greeters and seats. The user will have
> to define `greeter-session by himself. And what happen if they define
> multiple occurences of one greeter's configuration?

After reading more about lightdm (and there's not much to read about

it... [0]), I can better understand your points above, and I find #3

perhaps the most natural. The negative points (leaving place for user

errors) can be mitigated by a validating the configuration (e.g. that

all the configuration types listed in greeters are different).

I'll try to adjust your code to use the above layout when I get a

chance.

Thanks,

Maxim

[0] https://wiki.ubuntu.com/LightDM

Ricardo Wurmus wrote 3 years ago

[WIP] LightDM service

Recipients:(address . 35305-done@debbugs.gnu.org)

Message-ID:87zgfkrikq.fsf@elephly.net

A variation of this has been pushed to the master branch with commit

0ea62e84a787fe94cfeadf67ef27ea995a382b84.

Ricardo

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 35305@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 35305

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date