From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 06:14:36 2020 Received: (at 35305) by debbugs.gnu.org; 11 May 2020 10:14:36 +0000 Received: from localhost ([127.0.0.1]:51293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY5SF-0002RU-OE for submit@debbugs.gnu.org; Mon, 11 May 2020 06:14:36 -0400 Received: from mout02.posteo.de ([185.67.36.142]:50781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY5SD-0002RC-Nq for 35305@debbugs.gnu.org; Mon, 11 May 2020 06:14:34 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id F2F782400FC for <35305@debbugs.gnu.org>; Mon, 11 May 2020 12:14:27 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49LGxt5mQ7z9ry2; Mon, 11 May 2020 12:14:26 +0200 (CEST) From: L p R n d n To: Ricardo Wurmus Subject: Re: [bug#35305] LightDM service References: <87zhooso9g.fsf@lprndn.info> <87imh9gnvy.fsf@lprndn.info> <87k11m2hqx.fsf@elephly.net> <87zhahcfgh.fsf@lprndn.info> <878shz38bf.fsf@elephly.net> Date: Mon, 11 May 2020 12:14:25 +0200 In-Reply-To: <878shz38bf.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 10 May 2020 21:21:08 +0200") Message-ID: <87o8quu6bi.fsf@lprndn.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: 35305 Cc: 35305@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Ricardo Wurmus writes: > L p R n d n writes: > >>> I built a VM and noticed that all icons are missing. Should the service >>> arrange for a certain fallback icon theme to be installed? >> >> If you only added (service-type lightdm-service-type) without any >> greeter, it's expected. >> LightDM without autologin needs a greeter. So in this case you just get >> a "fallback" session to avoid unnecesseraly breaking the user's >> system. I choose not to bring lightdm-gtk-greeter's assets to give the >> user a little push toward adding a greeter service. > > Ah, now I understand the comment in lightdm-profile-service. Sorry, my comment was not clear :/ > I think the default configuration should take care of all this. It > seems problematic to me that users specify =E2=80=9Cgreeter-session=E2=80= =9D as a mere > string, but the corresponding greeter may not even be installed. That=E2= =80=99s > also what=E2=80=99s bothering me about the greeter search directories. I agree but just to clarify the current behavior: * A user can either define only a lightdm-service, only greeter-service.s or both. * There can be multiple greeter services defined hence allowing different greeters, greeter configurations or assets for different seats * Greeters' services extend the lightdm-service so the latter is really onl= y needed if you want to modify the default confiuration or do not define any greeter. * A seat defined in a greeter service have its `greeter-session overwritten + get the greeter package for free. This is why defining seats through the greeter is preferred. Hope it's clear, I had some troubles with the possessive in those sentences= ... > Would it make sense to let =E2=80=9Cgreeter-session=E2=80=9D be a *packag= e* instead of a > string? Then we could specify the lightdm-gtk-greeter package as the > default and use its output directory as the lookup directory for > greeters =E2=80=94 instead of the global system profile. Yet, it's better, yes! So we remove the `greeters-directory field from the `lightdm-configuration and use a package as input of the greeter-session field of `lightdm-seat-configuration, right? > I think this would be more elegant and reduce potential for > misconfiguration. What do you think about this? > >> It's very arguable >> so if you think we should bring in assets too, let's do it. I can >> prepare a patch if you want. > > What do you mean by assets? Which package provides them? I meant the assets used by the greeter. They're defined in the `lightdm-gtk-greeter-configuration-assets field of the lightdm-gtk-greeter's configuration. It's really the only thing lacking in the fallback session. A little patch that should be enough to fix the missing icons. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=add-default-assets.diff diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm index fa5330aade..0ef7f43215 100644 --- a/gnu/services/lightdm.scm +++ b/gnu/services/lightdm.scm @@ -291,7 +291,9 @@ remote-sessions-directory = " ,remote-sessions-directory " (let ((seats (lightdm-configuration-seats config)) (lightdm (lightdm-configuration-lightdm config))) (if (null? seats) - (list lightdm lightdm-gtk-greeter) + (list lightdm lightdm-gtk-greeter + ;; assets + adwaita-icon-theme gnome-themes-standard) (list lightdm)))) (define lightdm-service-type --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>> I also haven=E2=80=99t actually been able to log in as root with an emp= ty >>> password, which is what the VM generates by default. Can this be >>> supported with lightdm? >> >> Didn't succeed either but it should be possible... :/ >> Looking on the web, on passwordless login, the lightdm-autologin pam is >> often cited so this line: >> >> (pam-entry (control "required") (module "pam_succeed_if.so") >> (arguments (list "uid >=3D 1000"))) >> >> might be related. But I'm really not knowledgeable enough on this matter >> to give a proper answer. > > I can take a look at this and the other PAM questions you had. That would be nice! Beside this point, it's really checking that there are no errors. > -- > Ricardo Have a nice day, L p R n d n --=-=-=--