[PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates.

These are some of the patches working up to packaging Rails (a Ruby web

framework).

Christopher Baines (11):

gnu: Add ruby-cucumber-wire.

gnu: Add ruby-contracts.

gnu: Add ruby-ruby-progressbar.

gnu: Add ruby-fuubar.

gnu: Add ruby-cucumber-expressions.

gnu: Add ruby-mspec.

gnu: Add ruby-backports.

gnu: Add ruby-cucumber-tag-expressions.

gnu: ruby-cucumber-core: Update to 3.2.1.

gnu: ruby-gherkin: Update to 5.1.0.

gnu: Add ruby-cucumber and ruby-aruba.

gnu/packages/ruby.scm | 412 +++++++++++++++++++++++++++++++++++++++++-

1 file changed, 404 insertions(+), 8 deletions(-)

---

gnu/packages/ruby.scm | 34 ++++++++++++++++++++++++++++++++++

1 file changed, 34 insertions(+)

---

gnu/packages/ruby.scm | 48 +++++++++++++++++++++++++++++++++++++++++++

1 file changed, 48 insertions(+)

---

gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ruby.scm | 22 ++++++++++++++++++++++

1 file changed, 22 insertions(+)

---

gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

Package version 0.0.1 initially, as this is what's needed by Cucumber 3, and

Cucumber 4 hasn't been released yet.

---

gnu/packages/ruby.scm | 33 +++++++++++++++++++++++++++++++++

1 file changed, 33 insertions(+)

These packages are mutually dependant, so I've put them in one commit.

---

gnu/packages/ruby.scm | 136 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 136 insertions(+)

Don't upgrade all the way to version 6, as version 5 is needed for Cucumber 3.

[description]: Use @file{ }.

---

gnu/packages/ruby.scm | 10 +++++-----

1 file changed, 5 insertions(+), 5 deletions(-)

---

gnu/packages/ruby.scm | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

---

gnu/packages/ruby.scm | 43 +++++++++++++++++++++++++++++++++++++++++++

1 file changed, 43 insertions(+)

Just update to major version 3, as version 4 of Cucumber hasn't been released

yet.

[propagated-inputs]: Add ruby-backports, ruby-gherkin and

ruby-cucumber-tag-expressions.

---

gnu/packages/ruby.scm | 8 +++++---

1 file changed, 5 insertions(+), 3 deletions(-)

block 30689 by 34222 34217

Christopher Baines <mail@cbaines.net> skrev: (27 januari 2019 12:06:38 CET)

Nice ?

I'm interested in Rails because some of the OSM tools I would like to package depend on it.

--

Sent from my k-9 mail for Android.

On 2019-01-27 12:49, Christopher Baines wrote:

I investigated this and found:

Failed examples:

rspec ./spec/aruba/api_spec.rb:389 # Aruba::Api files #touch when

directory when exist and the mtim\

e should be set statically

rspec ./spec/aruba/api_spec.rb:388 # Aruba::Api files #touch when

directory when exist and the mtim\

e should be set statically behaves like an existing directory

rspec ./spec/aruba/api_spec.rb:362 # Aruba::Api files #touch when file

when does not exist and the \

mtime should be set statically

rspec ./spec/aruba/api_spec.rb:361 # Aruba::Api files #touch when file

when does not exist and the \

mtime should be set statically behaves like an existing file

rspec ./spec/aruba/matchers/command_spec.rb:165 # Command Matchers

#to_have_output_on_stderr when h\

ave output hello world on stderr

ave output hello world on stderr

rspec ./spec/aruba/matchers/command_spec.rb:128 # Command Matchers

#to_have_output_on_stdout when h\

ave output hello world on stderr

rspec ./spec/aruba/matchers/command_spec.rb:91 # Command Matchers

#to_have_output when have output \

hello world on stderr

The offending lines are in spec/aruba/api_spec.rb

beginning on line: 321, ending on 393

I tried creating a patch with diff for this file. I don't know if this

is the way others here usually create patches.

If not please enlighten me! :)

--

Cheers

Swedebugia

Hi swedebugia,

[…]

What does this mean?

We usually use “diff -u” to generate patches in unified diff format

(that’s the one with plus and minus prefixes).

Your patch only disables the test. I would rather like to know why it

fails and then fix the problem at the root. Have you figured out why

they fail and how the failure can be prevented?

--

Ricardo

On 2019-01-30 13:56, Ricardo Wurmus wrote:

No but I attached the full error message.

The relevant section is here:

Randomized with seed 46150

............................../tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

./tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

./tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

./tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

......................................................................................................................................F.....F.F......................................../tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

./tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

................................../tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

./tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/processes/basic_process.rb:100:

warning: instance variable @timed_out not initialized

................../tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/runtime.rb:84:

warning: instance variable @fixtures_directory not initialized

......../tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/lib/aruba/runtime.rb:84:

warning: instance variable @fixtures_directory not initialized

.......FF.....FF...............................................................

Failures:

1) Command Matchers #to_have_output_on_stdout when have output hello

world on stderr

Failure/Error: raise LaunchError, "It tried to start #{cmd}. " +

e.message

NameError:

undefined local variable or method `cmd' for

#<Aruba::Processes::SpawnProcess:0x0000555556f0bc10>

Did you mean? @cmd

# ./lib/aruba/processes/spawn_process.rb:89:in `rescue in start'

# ./lib/aruba/processes/spawn_process.rb:83:in `start'

# ./lib/aruba/command.rb:69:in `start'

# ./lib/aruba/api/command.rb:213:in `run'

# ./spec/aruba/matchers/command_spec.rb:126:in `block (4 levels)

in <top (required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

# ------------------

# --- Caused by: ---

# ChildProcess::LaunchError:

# No such file or directory -

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/tmp/aruba/cmd.sh

# ./lib/aruba/processes/spawn_process.rb:85:in `block in start'

2) Command Matchers #to_have_output when have output hello world on

stderr

Failure/Error: raise LaunchError, "It tried to start #{cmd}. " +

e.message

NameError:

undefined local variable or method `cmd' for

#<Aruba::Processes::SpawnProcess:0x00005555571159e8>

Did you mean? @cmd

# ./lib/aruba/processes/spawn_process.rb:89:in `rescue in start'

# ./lib/aruba/processes/spawn_process.rb:83:in `start'

# ./lib/aruba/command.rb:69:in `start'

# ./lib/aruba/api/command.rb:213:in `run'

# ./spec/aruba/matchers/command_spec.rb:89:in `block (4 levels) in

<top (required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

# ------------------

# --- Caused by: ---

# ChildProcess::LaunchError:

# No such file or directory -

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/tmp/aruba/cmd.sh

# ./lib/aruba/processes/spawn_process.rb:85:in `block in start'

3) Command Matchers #to_have_output_on_stderr when have output hello

world on stderr

Failure/Error: raise LaunchError, "It tried to start #{cmd}. " +

e.message

NameError:

undefined local variable or method `cmd' for

#<Aruba::Processes::SpawnProcess:0x0000555556efd4a8>

Did you mean? @cmd

# ./lib/aruba/processes/spawn_process.rb:89:in `rescue in start'

# ./lib/aruba/processes/spawn_process.rb:83:in `start'

# ./lib/aruba/command.rb:69:in `start'

# ./lib/aruba/api/command.rb:213:in `run'

# ./spec/aruba/matchers/command_spec.rb:163:in `block (4 levels)

in <top (required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

# ------------------

# --- Caused by: ---

# ChildProcess::LaunchError:

# No such file or directory -

/tmp/guix-build-ruby-aruba-0.14.7.drv-0/gem/tmp/aruba/cmd.sh

# ./lib/aruba/processes/spawn_process.rb:85:in `block in start'

4) Aruba::Api files #touch when directory when exist and the mtime

should be set statically

Failure/Error: let(:options) { { :mtime => Time.parse('2014-01-01

10:00:00') } }

NoMethodError:

undefined method `parse' for Time:Class

# ./spec/aruba/api_spec.rb:386:in `block (7 levels) in <top

(required)>'

# ./spec/aruba/api_spec.rb:381:in `block (6 levels) in <top

(required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

5) Aruba::Api files #touch when directory when exist and the mtime

should be set statically behaves like an existing directory

Failure/Error: let(:options) { { :mtime => Time.parse('2014-01-01

10:00:00') } }

NoMethodError:

undefined method `parse' for Time:Class

Shared Example Group: "an existing directory" called from

./spec/aruba/api_spec.rb:388

# ./spec/aruba/api_spec.rb:386:in `block (7 levels) in <top

(required)>'

# ./spec/aruba/api_spec.rb:381:in `block (6 levels) in <top

(required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

6) Aruba::Api files #touch when file when does not exist and the

mtime should be set statically

Failure/Error: let(:options) { { :mtime => Time.parse('2014-01-01

10:00:00') } }

NoMethodError:

undefined method `parse' for Time:Class

# ./spec/aruba/api_spec.rb:359:in `block (7 levels) in <top

(required)>'

# ./spec/aruba/api_spec.rb:333:in `block (5 levels) in <top

(required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

7) Aruba::Api files #touch when file when does not exist and the

mtime should be set statically behaves like an existing file

Failure/Error: let(:options) { { :mtime => Time.parse('2014-01-01

10:00:00') } }

NoMethodError:

undefined method `parse' for Time:Class

Shared Example Group: "an existing file" called from

./spec/aruba/api_spec.rb:361

# ./spec/aruba/api_spec.rb:359:in `block (7 levels) in <top

(required)>'

# ./spec/aruba/api_spec.rb:333:in `block (5 levels) in <top

(required)>'

# ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

I don't know ruby at all so I might not be the best qualified to

investigate this. :/

--

Cheers

Swedebugia

On 2019-01-30 17:11, swedebugia wrote:

I suspect a path-error.

I found this, but dunno if it is related:

I submitted this: https://github.com/cucumber/aruba/issues/589

--

Cheers

Swedebugia

On 2019-01-30 17:22, swedebugia wrote:

snip

I decided to try out latest master, worked a little on it and now it

builds without failure! :D

I'm unsure what revision number we usually start on, please correct if

necessary.

(define-public ruby-aruba

;; Take commit from latest master to avoid test failures

(let ((commit "688ad050f48990bfac127eaf529a828a0139d85f")

(revision "1"))

(package

(name "ruby-aruba")

(version

(string-append "0.14.7" "-" revision "." (string-take commit 7)))

(source

(origin

(method git-fetch)

(uri (git-reference

(url "https://github.com/cucumber/aruba.git")

(commit commit)))

(file-name (string-append name "-" version "-checkout"))

(sha256

(base32

"11c9w5rnra3xxzp1i4cazpf5gp6s25l4ymxsn022crk096nq475y"))))

(build-system ruby-build-system)

(arguments

'(#:test-target "spec"

#:phases

(modify-phases %standard-phases

(add-before 'check 'remove-unnecessary-dependencies

(lambda _

(substitute* "Gemfile"

((".*byebug.*") "\n")

((".*pry.*") "\n")

((".*yaml.*") "\n")

((".*bcat.*") "\n")

((".*kramdown.*") "\n")

((".*rubocop.*") "\n")

((".*cucumber-pro.*") "\n")

((".*cucumber.*") "\n")

((".*license_finder.*") "\n")

((".*rake.*") "gem 'rake'\n")

((".*simplecov.*") "\n")

((".*relish.*") "\n")

((".*json.*") "\n")

((".*yard-junk.*") "\n")

((".*yard.*") "\n"))

(substitute* "spec/spec_helper.rb"

((".*simplecov.*") "")

(("^SimpleCov.*") ""))

(substitute* "aruba.gemspec"

(("spec\\.add\\_runtime\\_dependency 'cucumber'.*")

"spec.add_runtime_dependency 'cucumber'\n"))

(substitute* "Rakefile"

;; Do not require docker stuff

((".*'aruba/.*")

"")

;; No linting

((":lint, :test")

":test"))

#t))

(add-before 'check 'set-home

(lambda _ (setenv "HOME" "/tmp") #t)))))

(native-inputs

`(("bundler" ,bundler)

("ruby-rspec" ,ruby-rspec)

("ruby-fuubar" ,ruby-fuubar)))

(propagated-inputs

`(("ruby-childprocess" ,ruby-childprocess)

("ruby-contracts" ,ruby-contracts)

("ruby-cucumber" ,ruby-cucumber)

("ruby-ffi" ,ruby-ffi)

("ruby-rspec-expectations" ,ruby-rspec-expectations)

("ruby-thor" ,ruby-thor)))

(synopsis "Test command-line applications with Cucumber, RSpec or

Minitest")

(description

"Aruba is an extension for Cucumber, RSpec and Minitest for

testing

command-line applications. It supports applications written in any

language.")

(home-page "https://github.com/cucumber/aruba")

(license license:expat))))

Could you update the patch Christopher?

--

Cheers

Swedebugia

On 2019-01-27 12:49, Christopher Baines wrote:

The failure is reported upstream, see

--

Cheers

Swedebugia

swedebugia <swedebugia@riseup.net> skrev: (31 januari 2019 09:53:17 CET)

From upstream:

Sorry the failure is quite obscure.

Backports wants to make sure it is defining the right methods only when necessary. The test is failing because the method alias_method_chainappears to have been added to all modules (Array, Binding, ...). Maybe the old backports/rails/module/alias_method_chain is somehow loaded, but I don't see how or why...

--

Sent from my k-9 mail for Android.

On Sun, 27 Jan 2019 11:49:46 +0000

Christopher Baines <mail@cbaines.net> wrote:

I would prefer to see this hint as a comment in the code, not in the

commit message: When I as a developer stumble upon the package

definition and see it is outdated, I would just update it and not

search all commit messages to find out it shouldn't. A comment near the

package definition or version would prevent that mistake.

Otherwise, LGTM.

Thanks,

Björn

On Sun, 27 Jan 2019 11:49:48 +0000

Christopher Baines <mail@cbaines.net> wrote:

Although we do not have a specific section about Ruby packages, I would

stick to the rules for Python packages:

"If a project already contains the word python, we drop this; for

instance, the module python-dateutil is packaged under the names python-dateutil"

Thus, rename the package to just "ruby-progressbar".

Otherwise, LGTM.

Thanks,

Björn

On Sun, 27 Jan 2019 11:49:56 +0000

Christopher Baines <mail@cbaines.net> wrote:

You missed to add the "...-without-tests" variables here.

[...]

There is another update since yesterday:

0.14.8 - February 02, 2019 (169 KB)

[..]

This is really nit-picking, I haven't tried it out myself and I haven't

used it much myself, but I think this could be written more elegant with

match-lambda [syntax errors might be included]:

(map (match-lambda

(("ruby-cucumber" . pkg)

`("ruby-cucumber" ,ruby-cucumber-without-tests))

(input input)

...)

Björn

On Sun, 27 Jan 2019 11:49:54 +0000

Christopher Baines <mail@cbaines.net> wrote:

Can u move this into a comment in the source, such that it sticks

directly to the package?

Otherwise LGTM.

Björn

On Sun, 27 Jan 2019 11:06:38 +0000

Christopher Baines <mail@cbaines.net> wrote:

Besides from small individual comments per package, this patchset looks

good for me.

Thank you,

Björn

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:

Or like this

`(("ruby-cucumber" ,ruby-cucumber-without-tests)

,@(alist-delete "ruby-cucumber"

(package-propagated-inputs ruby-aruba)))

--

Ricardo

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:

I wasn't quite sure whether to put only public things in the changelog,

or everything. I've included them in the changelog now.

Cool, I've updated to this new version.

I've changed this to use alist-delete which Ricardo suggested as I think

that's the most straight forward.

Thanks for the your comments,

Chris

Ricardo Wurmus <rekado@elephly.net> writes:

Yep, that looks good to me, thanks :)

swedebugia <swedebugia@riseup.net> writes:

...

Thanks for trying this out. Today I tried updating to 0.14.8, and

working around the test failures.

I've added the following phase, which works around the test failures.

(add-after 'unpack 'patch

(lambda _

(substitute* "spec/aruba/api_spec.rb"

;; This resolves some errors in the specs

;;

;; undefined method `parse' for Time:Class

(("require 'spec_helper'")

"require 'spec_helper'\nrequire 'time'"))

;; Avoid shebang issues in this spec file

(substitute* "spec/aruba/matchers/command_spec.rb"

(("/usr/bin/env bash")

(which "bash")))

#t))

The first change, adding require 'time' is present on the upstream

master branch [1], which explains why this helped.

1: https://github.com/cucumber/aruba/commit/7d11cad400bbbfd1ec039e39062f7f2576d970f6#diff-b014353d9f47f067ea8e078d34a1826b

As for the second set of test failures, the ones relating to "@cmd", I

think that's down to the spec's using "/usr/bin/env bash". I'm unsure

why using the master branch would have fixed this.

Even though sticking with 0.14.8 requires patching the tests, I'm

inclined to stick with patching this release, rather than using the

master branch as the source, as I think using upstream releases is

preferable.

Anyway, thanks for your help in looking in to this :)

Chris

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:

Sure, I've added the following comment to the patch.

;; Stick to major version 3, until version 4 of Cucumber is released.

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:

That makes sense, I've updated the name of the package and the

references.

Thanks,

Chris

On Fri, 08 Feb 2019 17:19:26 +0000

Christopher Baines <mail@cbaines.net> wrote:

Uh, I haven't seen that they are private, which of cause makes sense.

In that case I'm unsure what to do, but adding them doesn't hurt.

Björn

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:

Sure, I've added a comment to the package definition.

Thanks for taking a look,

Chris

swedebugia <swedebugia@riseup.net> writes:

Thanks for taking a look, I'll keep an eye on that upstream issue.

Chris

So, I've merged 66 patches now which were tracked across these 3 bugs so

the master branch now contains the ruby-rails gem!

I think I've even done this without breaking anything, I believe all the

packages I added or changed build, and all of there dependencies as

reported by guix lint build too.

If anyone still has any comments on the patches, I'd still love to hear

them.

Thanks for everyone who's reviewed these patches so far, and thanks to

Ben for kicking this work off many months ago.

Chris