From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 03 16:40:27 2019 Received: (at 34217) by debbugs.gnu.org; 3 Feb 2019 21:40:27 +0000 Received: from localhost ([127.0.0.1]:57830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqPV5-0005Wa-AS for submit@debbugs.gnu.org; Sun, 03 Feb 2019 16:40:27 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:33912 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqPV2-0005WP-Sf for 34217@debbugs.gnu.org; Sun, 03 Feb 2019 16:40:25 -0500 Received: from alma-ubu (unknown [10.9.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 986E83FE3F; Sun, 3 Feb 2019 22:40:22 +0100 (CET) Date: Sun, 3 Feb 2019 22:40:22 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Christopher Baines Subject: Re: [bug#34217] [PATCH 03/11] gnu: Add ruby-ruby-progressbar. Message-ID: <20190203224015.0cf8fd3d@alma-ubu> In-Reply-To: <20190127114956.26570-3-mail@cbaines.net> References: <87zhrmgy0x.fsf@cbaines.net> <20190127114956.26570-1-mail@cbaines.net> <20190127114956.26570-3-mail@cbaines.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 34217 Cc: 34217@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) On Sun, 27 Jan 2019 11:49:48 +0000 Christopher Baines wrote: > * gnu/packages/ruby.scm (ruby-ruby-progressbar): New variable. > --- > gnu/packages/ruby.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index 808b2d8686..15382de017 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -2507,6 +2507,28 @@ rate.") > (home-page "https://github.com/paul/progress_bar") > (license license:wtfpl2))) > =20 > +(define-public ruby-ruby-progressbar > + (package > + (name "ruby-ruby-progressbar") Although we do not have a specific section about Ruby packages, I would stick to the rules for Python packages: https://www.gnu.org/software/guix/manual/en/guix.html#Python-Modules "If a project already contains the word python, we drop this; for instance, the module python-dateutil is packaged under the names python-dat= eutil" Thus, rename the package to just "ruby-progressbar". Otherwise, LGTM. Thanks, Bj=C3=B6rn