[PATCH 1/2] gnu: python-hypercorn: Rename to hypercorn.

OpenSubmitted by Vinicius Monego.
Details
2 participants
  • Maxime Devos
  • Vinicius Monego
Owner
unassigned
Severity
normal
V
V
Vinicius Monego wrote on 6 May 21:17 +0200
(address . guix-patches@gnu.org)(name . Vinicius Monego)(address . monego@posteo.net)
20210506191726.103393-1-monego@posteo.net
* gnu/packages/python-web.scm (python-hypercorn): Rename to hypercorn.---This package provides the same use case for "gunicorn" that we have and both are used as binaries. I keep the inputs propagated because hypercorn also exposes some functionality over a module. See https://pgjones.gitlab.io/hypercorn/how_to_guides/api_usage.htmlfor reference.
gnu/packages/python-web.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Toggle diff (27 lines)diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scmindex 4f34502e86..223aca85a6 100644--- a/gnu/packages/python-web.scm+++ b/gnu/packages/python-web.scm@@ -37,7 +37,7 @@ ;;; Copyright © 2020 Holger Peters <holger.peters@posteo.de> ;;; Copyright © 2020 Noisytoot <noisytoot@gmail.com> ;;; Copyright © 2020 Edouard Klein <edk@beaver-labs.com>-;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>+;;; Copyright © 2020, 2021 Vinicius Monego <monego@posteo.net> ;;; Copyright © 2020 Konrad Hinsen <konrad.hinsen@fastmail.net> ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@autistici.org> ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech>@@ -1575,9 +1575,9 @@ choose to use, ensuring that you can communicate via WebSockets, as defined in RFC6455, regardless of your programming paradigm.") (license license:expat))) -(define-public python-hypercorn+(define-public hypercorn (package- (name "python-hypercorn")+ (name "hypercorn") (version "0.10.2") (source (origin-- 2.31.1
V
V
Vinicius Monego wrote on 6 May 21:20 +0200
[PATCH 2/2] gnu: hypercorn: Update to 0.11.2.
(address . 48263@debbugs.gnu.org)(name . Vinicius Monego)(address . monego@posteo.net)
20210506192039.103711-1-monego@posteo.net
* gnu/packages/python-web.scm (hypercorn): Update to 0.11.2.(python-h11): Update to 0.12.0.[arguments]: Add 'test-target' keyword. Do not replace check phase.[native-inputs]: Add python-pytest-runner.---Both packages have to updated at the same time or the hypercorn tests will fail (if either is updated first). I rebuilt the h11 dependents succesfully.
gnu/packages/python-web.scm | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
Toggle diff (50 lines)diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scmindex 223aca85a6..59702ac62e 100644--- a/gnu/packages/python-web.scm+++ b/gnu/packages/python-web.scm@@ -892,22 +892,19 @@ for use in Python programs that implement HTTP/2.") (define-public python-h11 (package (name "python-h11")- (version "0.9.0")+ (version "0.12.0") (source (origin (method url-fetch) (uri (pypi-uri "h11" version)) (sha256- (base32 "1qfad70h59hya21vrzz8dqyyaiqhac0anl2dx3s3k80gpskvrm1k"))))+ (base32 "0hk0nll6qazsambp3kl8cxxsbl4gv5y9252qadyk0jky0sv2q8j7")))) (build-system python-build-system) (arguments- `(#:phases- (modify-phases %standard-phases- (replace 'check- (lambda _- (invoke "pytest" "-vv"))))))+ `(#:test-target "pytest")) (native-inputs- `(("python-pytest" ,python-pytest)))+ `(("python-pytest" ,python-pytest)+ ("python-pytest-runner" ,python-pytest-runner))) (home-page "https://github.com/python-hyper/h11") (synopsis "Pure-Python, bring-your-own-I/O implementation of HTTP/1.1") (description@@ -1578,13 +1575,13 @@ RFC6455, regardless of your programming paradigm.") (define-public hypercorn (package (name "hypercorn")- (version "0.10.2")+ (version "0.11.2") (source (origin (method url-fetch) (uri (pypi-uri "Hypercorn" version)) (sha256- (base32 "15dgy47a18w2ls3hwykra1cyf7yzxmfjqnsqml482p12cxr2xwqr"))))+ (base32 "16kai5d12f05jr89mj611zslxqri4cd7ixcgd6yhl211qlcyg8av")))) (build-system python-build-system) (arguments `(#:phases-- 2.31.1
M
M
Maxime Devos wrote on 24 Jul 20:42 +0200
Re: [bug#49123] [PATCH 09/24] gnu: python-hyperframe: Update to 6.0.1.
7f7754df6714b6c925b452e6dbde4c5a80afa017.camel@telenet.be
Vinicius Monego schreef op za 24-07-2021 om 18:30 [+0000]:
Toggle quote (12 lines)> Em sáb, 2021-07-24 às 17:22 +0200, Maxime Devos escreveu:> > > The> > dependency 'python-hypercorn' now fails to compile (*). Aside from> > that, this> > patch LGTM. This build failure seems to be caused by the update of> > python-h11> > (and not python-hyperframe), however.> > That is true (see [1]). python-hypercorn will build again if updated to> the latest version.
Ok, we'll have to apply the '48263' patch before the '49123' patch seriesthen. FWIW, the '48263' patch looks good to me, but I only looked atthe patch itself and didn't do any other checks.
A comment about the commit message though:
Toggle quote (9 lines)> * gnu/packages/python-web.scm (hypercorn): Update to 0.11.2.> (python-h11): Update to 0.12.0.> [arguments]: Add 'test-target' keyword. Do not replace check phase.> [native-inputs]: Add python-pytest-runner.> ---> Both packages have to updated at the same time> or the hypercorn tests will fail (if either is updated first). I> rebuilt the h11 dependents succesfully.
Why not include this rationale in the commit message itself?
Toggle quote (2 lines)> [1] http://issues.guix.gnu.org/48263
Greetings,Maxime.
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYPxfJBccbWF4aW1lZGV2b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iSeAP0R3v9E2Zk396mR987Dv69RuiBI5Y5HU7grW6bMPuPl2AEA4Epztpe5RaglmJEOdyZaoR2m1UImkVDS2u4xFJAMdAQ==mk5s-----END PGP SIGNATURE-----

V
V
Vinicius Monego wrote on 12 Aug 02:04 +0200
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 48263@debbugs.gnu.org)
878s17cyv6.fsf@posteo.net
Maxime Devos <maximedevos@telenet.be> writes:
Toggle quote (14 lines)> A comment about the commit message though:>> * gnu/packages/python-web.scm (hypercorn): Update to 0.11.2.>> (python-h11): Update to 0.12.0.>> [arguments]: Add 'test-target' keyword. Do not replace check >> phase.>> [native-inputs]: Add python-pytest-runner.>> --->> Both packages have to updated at the same time>> or the hypercorn tests will fail (if either is updated >> first). I>> rebuilt the h11 dependents succesfully.>> Why not include this rationale in the commit message itself?
It would be an implicit fact for me, and it's uncommon to explainchanges in the commit message. But if it improves clarity, I'm OK withincluding it.
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 48263@debbugs.gnu.org