From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 14:42:55 2021 Received: (at 48263) by debbugs.gnu.org; 24 Jul 2021 18:42:55 +0000 Received: from localhost ([127.0.0.1]:46999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Mbv-0003Br-3e for submit@debbugs.gnu.org; Sat, 24 Jul 2021 14:42:55 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:42734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Mbr-0003Be-Vg for 48263@debbugs.gnu.org; Sat, 24 Jul 2021 14:42:54 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id Z6ip2500T0mfAB4066iqXi; Sat, 24 Jul 2021 20:42:50 +0200 Message-ID: <7f7754df6714b6c925b452e6dbde4c5a80afa017.camel@telenet.be> Subject: Re: [bug#49123] [PATCH 09/24] gnu: python-hyperframe: Update to 6.0.1. From: Maxime Devos To: Vinicius Monego , slg <0x2d@disroot.org>, 49123@debbugs.gnu.org, 48263@debbugs.gnu.org Date: Sat, 24 Jul 2021 20:42:44 +0200 In-Reply-To: References: <20210620010742.4259-1-0x2d@disroot.org> <20210620010742.4259-9-0x2d@disroot.org> <82f83ab33c4ae2b3892be9adc7f86730a121bcca.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-rYJFWQGp60kLLoCDSsFL" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1627152170; bh=AsZd7BDGtiuc/72yNuE4+5WVzPlljzznwbw19YBayQE=; h=Subject:From:To:Date:In-Reply-To:References; b=tnJS03wa3hGDz1fRrrPl4aMRQstv/KBB1gEtvlBhAs7U/pr91ARCuQJNsjBEZ3OPI ZWuCxcp7KwqsCjxVeWOpHfH8DStyVFEU62AaM6QZ8rscm1DBe1kCvUHzusoZK4DL8b GjsPrJKRxDME7kfv+BXP+FcI+mHMLw1VuUvfTS5+za28pYX0QK2g2inaYHTi6AoMf9 AG99kB3amsicuzzpqU2oP5hHbbuysjlTWIkLBU7ar6tBSEE2LXFEeZml5NHl7O1+sa hLsb8bDDRUiunwMXSbgiv/Tv24Dl8O6uNHojRreQkutBlGCd5YlVOc38pqcEXaRS51 Qs9vZFI0PDOBg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48263 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-rYJFWQGp60kLLoCDSsFL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Vinicius Monego schreef op za 24-07-2021 om 18:30 [+0000]: > Em s=C3=A1b, 2021-07-24 =C3=A0s 17:22 +0200, Maxime Devos escreveu: >=20 > > The > > dependency 'python-hypercorn' now fails to compile (*). Aside from > > that, this > > patch LGTM. This build failure seems to be caused by the update of > > python-h11 > > (and not python-hyperframe), however. >=20 > That is true (see [1]). python-hypercorn will build again if updated to > the latest version. Ok, we'll have to apply the '48263' patch before the '49123' patch series then. FWIW, the '48263' patch looks good to me, but I only looked at the patch itself and didn't do any other checks. A comment about the commit message though: > * gnu/packages/python-web.scm (hypercorn): Update to 0.11.2. > (python-h11): Update to 0.12.0. > [arguments]: Add 'test-target' keyword. Do not replace check phase. > [native-inputs]: Add python-pytest-runner. > --- > Both packages have to updated at the same time > or the hypercorn tests will fail (if either is updated first). I > rebuilt the h11 dependents succesfully. Why not include this rationale in the commit message itself? > [1] http://issues.guix.gnu.org/48263 Greetings, Maxime. --=-rYJFWQGp60kLLoCDSsFL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYPxfJBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iSeAP0R3v9E2Zk396mR987Dv69RuiBI 5Y5HU7grW6bMPuPl2AEA4Epztpe5RaglmJEOdyZaoR2m1UImkVDS2u4xFJAMdAQ= =mk5s -----END PGP SIGNATURE----- --=-rYJFWQGp60kLLoCDSsFL--