[PATCH] gnu: python-pygraphviz: Update to 1.10

  • Done
  • quality assurance status badge
Details
4 participants
  • Christopher Baines
  • Nicolas Goaziou
  • Philippe SWARTVAGHER
  • zimoun
Owner
unassigned
Submitted by
Philippe SWARTVAGHER
Severity
normal
P
P
Philippe SWARTVAGHER wrote on 13 Feb 2023 14:03
(address . guix-patches@gnu.org)(name . Philippe SWARTVAGHER)(address . swartvagher@par.tuwien.ac.at)
20230213130331.37045-1-swartvagher@par.tuwien.ac.at
* gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
---
gnu/packages/graphviz.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
index 7c2cb1eae0..1691658576 100644
--- a/gnu/packages/graphviz.scm
+++ b/gnu/packages/graphviz.scm
@@ -213,7 +213,7 @@ (define-public python-graphviz
(define-public python-pygraphviz
(package
(name "python-pygraphviz")
- (version "1.7")
+ (version "1.10")
(source
(origin
(method git-fetch)
@@ -223,7 +223,7 @@ (define-public python-pygraphviz
(file-name (string-append "pygraphviz-" version "-checkout"))
(sha256
(base32
- "0jqc3dzy9n0hn3b99zq8jp53901zpjzvvi5ns5mbaxg8kdrb1lfx"))))
+ "1yrzjp5n86ynlj32p5dj1aj67md6bzkk8hac74j5y3mbl94m259g"))))
(build-system python-build-system)
(inputs
(list graphviz))

base-commit: 5b1eab43f011983d9ee560d6935409b6b39706ff
--
2.30.2
Z
Z
zimoun wrote on 15 Feb 2023 12:50
(name . Philippe SWARTVAGHER)(address . swartvagher@par.tuwien.ac.at)
86y1ozcflj.fsf@gmail.com
Hi Philippe, Chris,

On Mon, 13 Feb 2023 at 14:03, Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> wrote:
Toggle quote (1 lines)
> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
--^
Missing dot

Missing two ending dot: one commit headline and one ChangeLog.

Well, QA says red:


but it appears to me unrelated. Chris, an idea?


Cheers,
simon
P
P
Philippe SWARTVAGHER wrote on 15 Feb 2023 17:19
[PATCH] gnu: python-pygraphviz: Update to 1.10
(address . 61477@debbugs.gnu.org)
20230215161951.37438-1-swartvagher@par.tuwien.ac.at
Toggle quote (1 lines)
> Missing two ending dot: one commit headline and one ChangeLog.
Fixed in attached revised patch (but it appears to me as a
nitpicking...).

Toggle quote (1 lines)
> Well, QA says red:
I don't really understand why the QA is complaining...

Philippe.
P
P
Philippe SWARTVAGHER wrote on 15 Feb 2023 17:19
[PATCH] gnu: python-pygraphviz: Update to 1.10.
(address . 61477@debbugs.gnu.org)(name . Philippe SWARTVAGHER)(address . swartvagher@par.tuwien.ac.at)
20230215161951.37438-2-swartvagher@par.tuwien.ac.at
* gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10.
---
gnu/packages/graphviz.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
index 7c2cb1eae0..1691658576 100644
--- a/gnu/packages/graphviz.scm
+++ b/gnu/packages/graphviz.scm
@@ -213,7 +213,7 @@ (define-public python-graphviz
(define-public python-pygraphviz
(package
(name "python-pygraphviz")
- (version "1.7")
+ (version "1.10")
(source
(origin
(method git-fetch)
@@ -223,7 +223,7 @@ (define-public python-pygraphviz
(file-name (string-append "pygraphviz-" version "-checkout"))
(sha256
(base32
- "0jqc3dzy9n0hn3b99zq8jp53901zpjzvvi5ns5mbaxg8kdrb1lfx"))))
+ "1yrzjp5n86ynlj32p5dj1aj67md6bzkk8hac74j5y3mbl94m259g"))))
(build-system python-build-system)
(inputs
(list graphviz))

base-commit: b4d2670771b8c2b9c4aedbef0371f1d23197d209
--
2.30.2
C
C
Christopher Baines wrote on 15 Feb 2023 17:24
Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
(name . zimoun)(address . zimon.toutoune@gmail.com)
874jrmopwm.fsf@cbaines.net
zimoun <zimon.toutoune@gmail.com> writes:

Toggle quote (13 lines)
> On Mon, 13 Feb 2023 at 14:03, Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> wrote:
>> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
> --^
> Missing dot
>
> Missing two ending dot: one commit headline and one ChangeLog.
>
> Well, QA says red:
>
> https://qa.guix.gnu.org/issue/61477
>
> but it appears to me unrelated. Chris, an idea?

Appears grey (unknown) to me currently, but it could have been red
previously.

I see one odd and unrelated thing here, the derivation for
openmv-openscenegraph is flapping around as there's a #<gexp in the
builder script. I've fixed that in
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPtB9lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XecTg/+L4nBN4Fwg4bPL20ts2gVHe6UAB1fM8a1
uY0+jv5PjGOqW222KNMU2esq+6zHA4t9ec6ciA27g+M1dH8lSN4Qv2h492bnCA91
TTcTVzyu1aCwSUy7GiM7D62B+/IrEzScuJYSKhYE0TGEirxSoiJbRaWXKgbk4XvL
mzzbBY4G9JoiEBjQdxJDpIL0SNRoJe+oJbPHoRMNgUXKIQMY0pi4ARiTx78EsBLh
Xvmq63AdO5DbhbsqJodMjC8coHW6gfMkRptYriwbs8EDoJe0n0kRyn4yB1JrEAyW
68mO4y9HQtE2BrZt7y23jyRXZZfLWmhQypPrxiufb31j+UGjvO3KOlq/aTCjPFwd
+zxj5JjoCTUvEc2bt9tNyLHJGqloWhwD9uCBUhr8SmWTu0AiWAHIYtujIXzLttPx
kw6LpwRjqPWu1lB5m7L3NESj7yZUChnXOgWn5dyPBtT2WTSy2dFBsa9iQMZfyWAq
LhY/FGIzd69QoluJ/0Yf+LQl9RQ9TRcGpKALXhoGzx7qXXhup0wqe6A9tbN1nrGA
LSDi+UktpCL2L7f7mv2wNdfSg8OrkcT7FvhY5lNMCjkHQQ7lAQ7ht6nWn+reEkdP
yjPYZ9iUCdQCRCFFBZvm/rcthTWqDMfGr9jpDNKMPcEbUKySek6aN8s8TrlV0ybA
SRXqq73pmY8=
=LJad
-----END PGP SIGNATURE-----

S
S
Simon Tournier wrote on 16 Feb 2023 10:49
864jrmc540.fsf@gmail.com
Hi Philippe,

On Wed, 15 Feb 2023 at 17:19, Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> wrote:

Toggle quote (3 lines)
> Fixed in attached revised patch (but it appears to me as a
> nitpicking...).

Yes, it is nitpicking! :-) I mentioned it in case committer would have
missed it – to fix it before pushing.

Cheers,
simon

PS: If I understand correctly, after Bordeaux you are now in
Vienna. Nice! :-)
Z
Z
zimoun wrote on 16 Feb 2023 12:31
(name . Christopher Baines)(address . mail@cbaines.net)
86ilg1c0cy.fsf@gmail.com
Hi Chris,

On Wed, 15 Feb 2023 at 16:24, Christopher Baines <mail@cbaines.net> wrote:

Toggle quote (7 lines)
>>
>> but it appears to me unrelated. Chris, an idea?
>
> Appears grey (unknown) to me currently, but it could have been red
> previously.

As a wish :-), would it be possible to report somewhere when the QA
pushes the issue in the queue?


Toggle quote (5 lines)
> I see one odd and unrelated thing here, the derivation for
> openmv-openscenegraph is flapping around as there's a #<gexp in the
> builder script. I've fixed that in
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=12127395dc55d9ea389a6dc619207c406725237e

Ah, thanks. Well, the ’inherit’ thing bites us at so many places now
that I am starting to be doubtful if it is a good pattern at scale.
Anyway. :-)

Cheers,
simon

PS: BTW, the new version [1] LGTM. ;-)

C
C
Christopher Baines wrote on 17 Feb 2023 17:47
(name . zimoun)(address . zimon.toutoune@gmail.com)(address . 61477@debbugs.gnu.org)
87h6vkkzko.fsf@cbaines.net
zimoun <zimon.toutoune@gmail.com> writes:

Toggle quote (12 lines)
> On Wed, 15 Feb 2023 at 16:24, Christopher Baines <mail@cbaines.net> wrote:
>
>>> https://qa.guix.gnu.org/issue/61477
>>>
>>> but it appears to me unrelated. Chris, an idea?
>>
>> Appears grey (unknown) to me currently, but it could have been red
>> previously.
>
> As a wish :-), would it be possible to report somewhere when the QA
> pushes the issue in the queue?

I don't follow what you mean, but I'd suggest filing a wishlist bug
against the guix package for qa-frontpage feature requests.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPvr+dfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XedVg/+IaLrLuR/5zy0QQlisei/9TQsTb39i43i
0U4L+C5tBv5otu1pyAgVtty82FYAU/3NBnP1SceRl6TCKnved363U378OwcXDnkF
3wHCvytUv0YspjDj3IbxNlJ6mVI9+f+3z6VmGu5sa3Yjxi9zovw+phlsgeGBDk21
TdFwxBapEGnQIuB5Blgz4QDSGdObFQl8owURudy9lAAkWTzkGByJWepWk70wFG5A
GBQREr5ulMT4NlD2vmTRTmy0YaDTuiPcf8UFusRLdR5KIGTwSTKUMhCNnv659wQ4
zByPs10ohfmM6/SMR+j/csmIqFcTD1QkI51Btn9mDkm9/SHL/3tJbB/UM0kwgl0y
xGKH0M8qlQBRjfFUS1VGl/DBnfqu5Jxv01t3G5pDsiRbpTGnHZSkXILI+VidhLZf
QfJFG4+QUZVygZRUaBmTk+iTYySIUegzLsF0lJOu93LCdAhJ+WdKizOTBQTr16Wx
HraNeFbSdeSpEROt8+BMGkuDk51CoH6wc8WNI3qPQgzZ+QY63PhOEn8vRl6jV1+z
qsDeee/fnXETrZWJWHeVYTn/1ZInXx5bvySo69nlLl+FCaiwsY0Uh0zxl5bLRE3h
ES/e45hn6iO9mQQcAaMUBAYIgyucZDQ1BnpaVMRmGBX72tZrgrMBoqJd7rvAxZBo
SODqR/UnslM=
=tC8r
-----END PGP SIGNATURE-----

S
S
Simon Tournier wrote on 17 Feb 2023 18:05
(name . Christopher Baines)(address . mail@cbaines.net)(address . 61477@debbugs.gnu.org)
CAJ3okZ3pquWUJxcV09LBeb+6Hk_oZgJX3ThpoMUHEjFixqycHA@mail.gmail.com
Hi,

On Fri, 17 Feb 2023 at 17:48, Christopher Baines <mail@cbaines.net> wrote:

Toggle quote (6 lines)
> > As a wish :-), would it be possible to report somewhere when the QA
> > pushes the issue in the queue?
>
> I don't follow what you mean, but I'd suggest filing a wishlist bug
> against the guix package for qa-frontpage feature requests.

Today, it is not possible to know the status: when the patch is
scheduled, I do not know when it was.

I will do my best for filling wishlist bug report.

Cheers,
simon
N
N
Nicolas Goaziou wrote on 20 Feb 2023 14:05
Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10.
(name . Philippe SWARTVAGHER)(address . swartvagher@par.tuwien.ac.at)(address . 61477-done@debbugs.gnu.org)
87sff0qygg.fsf@nicolasgoaziou.fr
Hello,

Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> writes:

Toggle quote (2 lines)
> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10.

Applied. Thank you.

Regards,
--
Nicolas Goaziou
Closed
?